72349 2011-11-14 20:19:58 -0800 VCSUtils.pm doesn't handle svn 1.7 correctly 2011-11-15 08:38:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting pkasting aroben hausmann webkit.review.bot oldest_to_newest 502604 0 pkasting 2011-11-14 20:19:58 -0800 $isSVNDirectory fails on svn 1.7 in non-root directories because svn 1.7 eliminates the .svn subdirectories everywhere but the root. I'm going to fix this by blindly copying the git code, which instead shells out to git to do the work, and adapt it to use "svn info". 502605 1 115089 pkasting 2011-11-14 20:22:21 -0800 Created attachment 115089 patch v1 This seems to work on my machine (tested both positively and negatively). Did not test on svn 1.6 or below. 502862 2 115089 aroben 2011-11-15 06:33:14 -0800 Comment on attachment 115089 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=115089&action=review > Tools/Scripts/VCSUtils.pm:252 > + return system("cd $dir && svn info > " . File::Spec->devnull() . " 2>&1") == 0; I wonder if this will cause problems for folks using native Win32 Perl? 502863 3 aroben 2011-11-15 06:33:43 -0800 Simon, any idea if this will be a problem for Qt/Win? 502889 4 hausmann 2011-11-15 07:12:24 -0800 (In reply to comment #3) > Simon, any idea if this will be a problem for Qt/Win? Don't think so :) 502931 5 115089 webkit.review.bot 2011-11-15 08:38:13 -0800 Comment on attachment 115089 patch v1 Clearing flags on attachment: 115089 Committed r100286: <http://trac.webkit.org/changeset/100286> 502932 6 webkit.review.bot 2011-11-15 08:38:19 -0800 All reviewed patches have been landed. Closing bug. 115089 2011-11-14 20:22:21 -0800 2011-11-15 08:38:13 -0800 patch v1 patch text/plain 1026 pkasting SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDIzNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTExLTE0ICBQZXRlciBLYXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNv bT4KKworICAgICAgICBIYW5kbGUgc3ZuIDEuNyB3aGVuIGRldGVjdGluZyB3aGV0aGVyIGEgZGly ZWN0b3J5IGlzIGluIGFuIHN2biBjaGVja291dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL1ZDU1V0aWxzLnBtOgorICAgICAgICAoaXNT Vk5EaXJlY3RvcnkpOgorCiAyMDExLTExLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIEltcHJvdmUgQ2hhbmdlTG9nRW50cnkncyByZXZpZXdlciBwYXJzaW5n IGFsZ29yaXRobSBwYXJ0IDIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkocmV2aXNpb24gMTAwMjM1KQorKysg VG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQkod29ya2luZyBjb3B5KQpAQCAtMjQ5LDggKzI0OSw3 IEBAIHN1YiBpc0dpdEJyYW5jaEJ1aWxkKCkKIHN1YiBpc1NWTkRpcmVjdG9yeSgkKQogewogICAg IG15ICgkZGlyKSA9IEBfOwotCi0gICAgcmV0dXJuIC1kIEZpbGU6OlNwZWMtPmNhdGRpcigkZGly LCAiLnN2biIpOworICAgIHJldHVybiBzeXN0ZW0oImNkICRkaXIgJiYgc3ZuIGluZm8gPiAiIC4g RmlsZTo6U3BlYy0+ZGV2bnVsbCgpIC4gIiAyPiYxIikgPT0gMDsKIH0KIAogc3ViIGlzU1ZOKCkK