72324 2011-11-14 16:03:55 -0800 DFG put_by_id transition optimizations test the wrong structures 2011-11-14 17:06:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 502426 0 fpizlo 2011-11-14 16:03:55 -0800 Patch forthcoming 502432 1 115053 fpizlo 2011-11-14 16:08:39 -0800 Created attachment 115053 the patch 502450 2 115053 barraclough 2011-11-14 16:36:27 -0800 Comment on attachment 115053 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=115053&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1825 > + if (previousStructure->storedPrototype().isCell()) I would prefer if the 'isCell' check check was a !isNull() check for consistency. 502488 3 fpizlo 2011-11-14 17:04:29 -0800 Landed in http://trac.webkit.org/changeset/100219 502491 4 fpizlo 2011-11-14 17:06:18 -0800 <rdar://problem/10445229> 115053 2011-11-14 16:08:39 -0800 2011-11-14 16:36:26 -0800 the patch fixputbyid_patch_1.diff text/plain 4187 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwMjA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHB1dF9ieV9pZCB0cmFuc2l0aW9uIG9wdGltaXphdGlvbnMgdGVzdCB0aGUgd3Jvbmcgc3Ry dWN0dXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzIzMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQ YXJzZXI6OnN0cnVjdHVyZUNoYWluSXNTdGlsbFZhbGlkKToKKyAgICAgICAgKEpTQzo6REZHOjpC eXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6CisgICAgICAgICogaml0L0pJVFByb3BlcnR5QWNj ZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZVB1dEJ5SWRUcmFuc2l0 aW9uKToKKwogMjAxMS0xMS0xNCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4K IAogICAgICAgICBUb3dhcmRzIDggYml0IHN0cmluZ3MgLSBBZGQgOCBiaXQgaGFuZGxpbmcgdG8g SlNTdHJpbmcgUm9wZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNv ZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Qnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lvbiAxMDAxOTgpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjg0LDYg KzY4NCwyMiBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gbm9kZUluZGV4OwogICAgIH0KICAg ICAKKyAgICBib29sIHN0cnVjdHVyZUNoYWluSXNTdGlsbFZhbGlkKGJvb2wgZGlyZWN0LCBTdHJ1 Y3R1cmUqIHByZXZpb3VzU3RydWN0dXJlLCBTdHJ1Y3R1cmVDaGFpbiogY2hhaW4pCisgICAgewor ICAgICAgICBpZiAoZGlyZWN0KQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIAor ICAgICAgICBpZiAoIXByZXZpb3VzU3RydWN0dXJlLT5zdG9yZWRQcm90b3R5cGUoKS5pc051bGwo KSAmJiBwcmV2aW91c1N0cnVjdHVyZS0+c3RvcmVkUHJvdG90eXBlKCkuYXNDZWxsKCktPnN0cnVj dHVyZSgpICE9IGNoYWluLT5oZWFkKCktPmdldCgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICAKKyAgICAgICAgZm9yIChXcml0ZUJhcnJpZXI8U3RydWN0dXJlPiogaXQgPSBj aGFpbi0+aGVhZCgpOyAqaXQ7ICsraXQpIHsKKyAgICAgICAgICAgIGlmICghKCppdCktPnN0b3Jl ZFByb3RvdHlwZSgpLmlzTnVsbCgpICYmICgqaXQpLT5zdG9yZWRQcm90b3R5cGUoKS5hc0NlbGwo KS0+c3RydWN0dXJlKCkgIT0gaXRbMV0uZ2V0KCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgICAgICB9CisgICAgICAgIAorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9Cisg ICAgCiAgICAgdm9pZCBidWlsZE9wZXJhbmRNYXBzSWZOZWNlc3NhcnkoKTsKICAgICAKICAgICBK U0dsb2JhbERhdGEqIG1fZ2xvYmFsRGF0YTsKQEAgLTE4MDMsOSArMTgxOSwxMiBAQCBib29sIEJ5 dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVuc2lnbmVkCiAgICAgICAgICAgICAgICAgICAgIElk ZW50aWZpZXIgaWRlbnRpZmllciA9IG1fY29kZUJsb2NrLT5pZGVudGlmaWVyKGlkZW50aWZpZXJO dW1iZXIpOwogICAgICAgICAgICAgICAgICAgICBzaXplX3Qgb2Zmc2V0ID0gbmV3U3RydWN0dXJl LT5nZXQoKm1fZ2xvYmFsRGF0YSwgaWRlbnRpZmllcik7CiAgICAgICAgICAgICAgICAgICAgIAot ICAgICAgICAgICAgICAgICAgICBpZiAob2Zmc2V0ICE9IG5vdEZvdW5kKSB7CisgICAgICAgICAg ICAgICAgICAgIGlmIChvZmZzZXQgIT0gbm90Rm91bmQgJiYgc3RydWN0dXJlQ2hhaW5Jc1N0aWxs VmFsaWQoZGlyZWN0LCBwcmV2aW91c1N0cnVjdHVyZSwgc3RydWN0dXJlQ2hhaW4pKSB7CiAgICAg ICAgICAgICAgICAgICAgICAgICBhZGRUb0dyYXBoKENoZWNrU3RydWN0dXJlLCBPcEluZm8obV9n cmFwaC5hZGRTdHJ1Y3R1cmVTZXQocHJldmlvdXNTdHJ1Y3R1cmUpKSwgYmFzZSk7CiAgICAgICAg ICAgICAgICAgICAgICAgICBpZiAoIWRpcmVjdCkgeworICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGlmIChwcmV2aW91c1N0cnVjdHVyZS0+c3RvcmVkUHJvdG90eXBlKCkuaXNDZWxsKCkpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFkZFRvR3JhcGgoQ2hlY2tTdHJ1Y3R1cmUs IE9wSW5mbyhtX2dyYXBoLmFkZFN0cnVjdHVyZVNldChwcmV2aW91c1N0cnVjdHVyZS0+c3RvcmVk UHJvdG90eXBlKCkuYXNDZWxsKCktPnN0cnVjdHVyZSgpKSksIGNlbGxDb25zdGFudChwcmV2aW91 c1N0cnVjdHVyZS0+c3RvcmVkUHJvdG90eXBlKCkuYXNDZWxsKCkpKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKFdyaXRlQmFy cmllcjxTdHJ1Y3R1cmU+KiBpdCA9IHN0cnVjdHVyZUNoYWluLT5oZWFkKCk7ICppdDsgKytpdCkg ewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBKU1ZhbHVlIHByb3RvdHlwZSA9ICgq aXQpLT5zdG9yZWRQcm90b3R5cGUoKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aWYgKHByb3RvdHlwZS5pc051bGwoKSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUUHJvcGVydHlBY2Nlc3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCShyZXZpc2lvbiAxMDAxOTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTIxLDEyICs1MjEsMTcgQEAgdm9pZCBKSVQ6OnByaXZhdGVDb21waWxlUHV0QnlJZFRyYW5z aXRpbwogICAgIC8vIENoZWNrIGVheCBpcyBhbiBvYmplY3Qgb2YgdGhlIHJpZ2h0IFN0cnVjdHVy ZS4KICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGVtaXRKdW1wSWZOb3RKU0NlbGwocmVnVDApKTsK ICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5jaFB0cihOb3RFcXVhbCwgQWRkcmVzcyhyZWdU MCwgSlNDZWxsOjpzdHJ1Y3R1cmVPZmZzZXQoKSksIFRydXN0ZWRJbW1QdHIob2xkU3RydWN0dXJl KSkpOworICAgIAogICAgIHRlc3RQcm90b3R5cGUob2xkU3RydWN0dXJlLT5zdG9yZWRQcm90b3R5 cGUoKSwgZmFpbHVyZUNhc2VzKTsKKyAgICAKKyAgICBBU1NFUlQob2xkU3RydWN0dXJlLT5zdG9y ZWRQcm90b3R5cGUoKS5pc051bGwoKSB8fCBvbGRTdHJ1Y3R1cmUtPnN0b3JlZFByb3RvdHlwZSgp LmFzQ2VsbCgpLT5zdHJ1Y3R1cmUoKSA9PSBjaGFpbi0+aGVhZCgpLT5nZXQoKSk7CiAKICAgICAv LyBlY3ggPSBiYXNlT2JqZWN0LT5tX3N0cnVjdHVyZQogICAgIGlmICghZGlyZWN0KSB7Ci0gICAg ICAgIGZvciAoV3JpdGVCYXJyaWVyPFN0cnVjdHVyZT4qIGl0ID0gY2hhaW4tPmhlYWQoKTsgKml0 OyArK2l0KQorICAgICAgICBmb3IgKFdyaXRlQmFycmllcjxTdHJ1Y3R1cmU+KiBpdCA9IGNoYWlu LT5oZWFkKCk7ICppdDsgKytpdCkgeworICAgICAgICAgICAgQVNTRVJUKCgqaXQpLT5zdG9yZWRQ cm90b3R5cGUoKS5pc051bGwoKSB8fCAoKml0KS0+c3RvcmVkUHJvdG90eXBlKCkuYXNDZWxsKCkt PnN0cnVjdHVyZSgpID09IGl0WzFdLmdldCgpKTsKICAgICAgICAgICAgIHRlc3RQcm90b3R5cGUo KCppdCktPnN0b3JlZFByb3RvdHlwZSgpLCBmYWlsdXJlQ2FzZXMpOworICAgICAgICB9CiAgICAg fQogCiAgICAgQ2FsbCBjYWxsVGFyZ2V0Owo=