72321 2011-11-14 15:39:46 -0800 Make ImageFrame member getAddr() public 2011-11-15 01:36:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59670 1 noel.gordon noel.gordon abarth webkit.review.bot oldest_to_newest 502393 0 noel.gordon 2011-11-14 15:39:46 -0800 Make ImageFrame member getAddr() public 502395 1 115046 noel.gordon 2011-11-14 15:41:58 -0800 Created attachment 115046 Patch 502520 2 115046 abarth 2011-11-14 17:24:00 -0800 Comment on attachment 115046 Patch The ChangeLog needs to explain why we're making this change. 502526 3 noel.gordon 2011-11-14 17:26:57 -0800 Would something like https://bugs.webkit.org/show_bug.cgi?id=59670#c8 be enough? 502532 4 abarth 2011-11-14 17:31:06 -0800 Not really. Sure, we could make the function public, but why would we want to? As a general rule, we prefer to limit the visibility of functions. Unless there's a reason to make it public, we'll probably leave it private. 502565 5 noel.gordon 2011-11-14 18:14:50 -0800 Ok, lemme better explain it then ... 502567 6 115079 noel.gordon 2011-11-14 18:15:46 -0800 Created attachment 115079 Patch 502569 7 115079 abarth 2011-11-14 18:16:55 -0800 Comment on attachment 115079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115079&action=review > Source/WebCore/ChangeLog:12 > + Make ImageFrame member getAddr() public to allow ImageFrame users access to the > + underlying frame pixels if needed. Image decoders, for example, could with care > + use this service to write decoded pixels direct to the ImageFrame pixel buffer, > + avoiding intermeadiate data copies from temporary decoded pixel row buffers and > + the decoding performance loss that that entails. Is there an example of an image decoder that would benefit from this API? 502570 8 noel.gordon 2011-11-14 18:18:49 -0800 > Is there an example of an image decoder that would benefit from this API? libturbo-jpeg would be one example. 502575 9 115079 abarth 2011-11-14 18:37:50 -0800 Comment on attachment 115079 Patch Ok 502731 10 115079 webkit.review.bot 2011-11-15 01:36:52 -0800 Comment on attachment 115079 Patch Clearing flags on attachment: 115079 Committed r100252: <http://trac.webkit.org/changeset/100252> 502732 11 webkit.review.bot 2011-11-15 01:36:57 -0800 All reviewed patches have been landed. Closing bug. 115046 2011-11-14 15:41:58 -0800 2011-11-14 18:15:38 -0800 Patch bug-72321-20111115104156.patch text/plain 2257 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1YTZkMWE3MmE0ZjVl NTZkNTFmMTQwMzNjZTg0MDlmYTBhMDNhMC4uNDY0MTMwY2NlNWI1MDFjYWFmZmIyYWNmZGY5YWQ2 YTYxOTU3M2E2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE0ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBNYWtlIEltYWdlRnJh bWUgbWVtYmVyIGdldEFkZHIoKSBwdWJsaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcyMzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZWZhY3RvcmluZyBvbmx5LgorCisgICAg ICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmg6CisgICAgICAgIChX ZWJDb3JlOjpJbWFnZUZyYW1lOjpnZXRBZGRyKToKKwogMjAxMS0xMS0xNCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFNlY3VyaXR5Q29udGV4dCBzaG91bGQgdHJh Y2sgd2hldGhlciB0aGUgU2VjdXJpdHlPcmlnaW4gaGFzIGJlZW4gaW5pdGlhbGl6ZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rl ci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVy LmgKaW5kZXggODY3ZDE1OGJjYjEwODYxOWZjMzBjZTViNzQxMTRlMmFkOTVhYTIyOC4uOTU2ODhl N2ExYzQ0ZDk5MjNiNzUzMGIzM2ZjNjJiYjRkMWMwY2VjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgKQEAgLTEzNyw2 ICsxMzcsMTkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgc2V0UkdCQShnZXRB ZGRyKHgsIHkpLCByLCBnLCBiLCBhKTsKICAgICAgICAgfQogCisgICAgICAgIGlubGluZSBQaXhl bERhdGEqIGdldEFkZHIoaW50IHgsIGludCB5KQorICAgICAgICB7CisjaWYgVVNFKFNLSUEpCisg ICAgICAgICAgICByZXR1cm4gbV9iaXRtYXAuYml0bWFwKCkuZ2V0QWRkcjMyKHgsIHkpOworI2Vs aWYgUExBVEZPUk0oUVQpCisgICAgICAgICAgICBtX2ltYWdlID0gbV9waXhtYXAudG9JbWFnZSgp OworICAgICAgICAgICAgbV9waXhtYXAgPSBRUGl4bWFwKCk7CisgICAgICAgICAgICByZXR1cm4g cmVpbnRlcnByZXRfY2FzdF9wdHI8UVJnYio+KG1faW1hZ2Uuc2NhbkxpbmUoeSkpICsgeDsKKyNl bHNlCisgICAgICAgICAgICByZXR1cm4gbV9ieXRlcyArICh5ICogd2lkdGgoKSkgKyB4OworI2Vu ZGlmCisgICAgICAgIH0KKwogI2lmIFBMQVRGT1JNKFFUKQogICAgICAgICB2b2lkIHNldFBpeG1h cChjb25zdCBRUGl4bWFwJiBwaXhtYXApOwogI2VuZGlmCkBAIC0xNTEsMTkgKzE2NCw2IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgaW50IHdpZHRoKCkgY29uc3Q7CiAgICAgICAgIGlu dCBoZWlnaHQoKSBjb25zdDsKIAotICAgICAgICBpbmxpbmUgUGl4ZWxEYXRhKiBnZXRBZGRyKGlu dCB4LCBpbnQgeSkKLSAgICAgICAgewotI2lmIFVTRShTS0lBKQotICAgICAgICAgICAgcmV0dXJu IG1fYml0bWFwLmJpdG1hcCgpLmdldEFkZHIzMih4LCB5KTsKLSNlbGlmIFBMQVRGT1JNKFFUKQot ICAgICAgICAgICAgbV9pbWFnZSA9IG1fcGl4bWFwLnRvSW1hZ2UoKTsKLSAgICAgICAgICAgIG1f cGl4bWFwID0gUVBpeG1hcCgpOwotICAgICAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Rf cHRyPFFSZ2IqPihtX2ltYWdlLnNjYW5MaW5lKHkpKSArIHg7Ci0jZWxzZQotICAgICAgICAgICAg cmV0dXJuIG1fYnl0ZXMgKyAoeSAqIHdpZHRoKCkpICsgeDsKLSNlbmRpZgotICAgICAgICB9Ci0K ICAgICAgICAgaW5saW5lIHZvaWQgc2V0UkdCQShQaXhlbERhdGEqIGRlc3QsIHVuc2lnbmVkIHIs IHVuc2lnbmVkIGcsIHVuc2lnbmVkIGIsIHVuc2lnbmVkIGEpCiAgICAgICAgIHsKICAgICAgICAg ICAgIGlmIChtX3ByZW11bHRpcGx5QWxwaGEgJiYgIWEpCg== 115079 2011-11-14 18:15:46 -0800 2011-11-15 01:36:52 -0800 Patch bug-72321-20111115131326.patch text/plain 2683 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY2NTA0ODg4MjhkZDJl ODE2YWUzYzE4NWNmMTMwZGNiMGExNDBlMy4uYTJhNmZiMjM4N2E3Njg4NjY5YTgyZTUwMWU1NmNi YjE5OTdjNjY2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTExLTE0ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBNYWtlIEltYWdlRnJh bWUgbWVtYmVyIGdldEFkZHIoKSBwdWJsaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcyMzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWFrZSBJbWFnZUZyYW1lIG1lbWJlciBnZXRBZGRyKCkgcHVibGlj IHRvIGFsbG93IEltYWdlRnJhbWUgdXNlcnMgYWNjZXNzIHRvIHRoZQorICAgICAgICB1bmRlcmx5 aW5nIGZyYW1lIHBpeGVscyBpZiBuZWVkZWQuIEltYWdlIGRlY29kZXJzLCBmb3IgZXhhbXBsZSwg Y291bGQgd2l0aCBjYXJlCisgICAgICAgIHVzZSB0aGlzIHNlcnZpY2UgdG8gd3JpdGUgZGVjb2Rl ZCBwaXhlbHMgZGlyZWN0IHRvIHRoZSBJbWFnZUZyYW1lIHBpeGVsIGJ1ZmZlciwKKyAgICAgICAg YXZvaWRpbmcgaW50ZXJtZWFkaWF0ZSBkYXRhIGNvcGllcyBmcm9tIHRlbXBvcmFyeSBkZWNvZGVk IHBpeGVsIHJvdyBidWZmZXJzIGFuZAorICAgICAgICB0aGUgZGVjb2RpbmcgcGVyZm9ybWFuY2Ug bG9zcyB0aGF0IHRoYXQgZW50YWlscy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJlZmFjdG9y aW5nIG9ubHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29k ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWU6OmdldEFkZHIpOgorCiAyMDExLTEx LTE0ICBSYWZhZWwgV2VpbnN0ZWluICA8cmFmYWVsd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W011dGF0aW9uT2JzZXJ2ZXJzXSBBZGQgaGlzdG9ncmFtIGNvbGxlY3Rpb24gZm9yIHVzYWdlIG9m IERPTSBNdXRhdGlvbiBFdmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmgKaW5kZXggODY3ZDE1OGJjYjEwODYxOWZjMzBj ZTViNzQxMTRlMmFkOTVhYTIyOC4uOTU2ODhlN2ExYzQ0ZDk5MjNiNzUzMGIzM2ZjNjJiYjRkMWMw Y2VjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv SW1hZ2VEZWNvZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2Rl cnMvSW1hZ2VEZWNvZGVyLmgKQEAgLTEzNyw2ICsxMzcsMTkgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICAgICAgc2V0UkdCQShnZXRBZGRyKHgsIHkpLCByLCBnLCBiLCBhKTsKICAgICAg ICAgfQogCisgICAgICAgIGlubGluZSBQaXhlbERhdGEqIGdldEFkZHIoaW50IHgsIGludCB5KQor ICAgICAgICB7CisjaWYgVVNFKFNLSUEpCisgICAgICAgICAgICByZXR1cm4gbV9iaXRtYXAuYml0 bWFwKCkuZ2V0QWRkcjMyKHgsIHkpOworI2VsaWYgUExBVEZPUk0oUVQpCisgICAgICAgICAgICBt X2ltYWdlID0gbV9waXhtYXAudG9JbWFnZSgpOworICAgICAgICAgICAgbV9waXhtYXAgPSBRUGl4 bWFwKCk7CisgICAgICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdF9wdHI8UVJnYio+KG1f aW1hZ2Uuc2NhbkxpbmUoeSkpICsgeDsKKyNlbHNlCisgICAgICAgICAgICByZXR1cm4gbV9ieXRl cyArICh5ICogd2lkdGgoKSkgKyB4OworI2VuZGlmCisgICAgICAgIH0KKwogI2lmIFBMQVRGT1JN KFFUKQogICAgICAgICB2b2lkIHNldFBpeG1hcChjb25zdCBRUGl4bWFwJiBwaXhtYXApOwogI2Vu ZGlmCkBAIC0xNTEsMTkgKzE2NCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgaW50 IHdpZHRoKCkgY29uc3Q7CiAgICAgICAgIGludCBoZWlnaHQoKSBjb25zdDsKIAotICAgICAgICBp bmxpbmUgUGl4ZWxEYXRhKiBnZXRBZGRyKGludCB4LCBpbnQgeSkKLSAgICAgICAgewotI2lmIFVT RShTS0lBKQotICAgICAgICAgICAgcmV0dXJuIG1fYml0bWFwLmJpdG1hcCgpLmdldEFkZHIzMih4 LCB5KTsKLSNlbGlmIFBMQVRGT1JNKFFUKQotICAgICAgICAgICAgbV9pbWFnZSA9IG1fcGl4bWFw LnRvSW1hZ2UoKTsKLSAgICAgICAgICAgIG1fcGl4bWFwID0gUVBpeG1hcCgpOwotICAgICAgICAg ICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3RfcHRyPFFSZ2IqPihtX2ltYWdlLnNjYW5MaW5lKHkp KSArIHg7Ci0jZWxzZQotICAgICAgICAgICAgcmV0dXJuIG1fYnl0ZXMgKyAoeSAqIHdpZHRoKCkp ICsgeDsKLSNlbmRpZgotICAgICAgICB9Ci0KICAgICAgICAgaW5saW5lIHZvaWQgc2V0UkdCQShQ aXhlbERhdGEqIGRlc3QsIHVuc2lnbmVkIHIsIHVuc2lnbmVkIGcsIHVuc2lnbmVkIGIsIHVuc2ln bmVkIGEpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChtX3ByZW11bHRpcGx5QWxwaGEgJiYg IWEpCg==