72318 2011-11-14 15:19:49 -0800 Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline 2011-11-14 16:20:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix ojan tony webkit.review.bot oldest_to_newest 502371 0 jchaffraix 2011-11-14 15:19:49 -0800 The fix for bug 72296 did not see that -wap-marquee did impact querying back the display property for -webkit-flexbox and -webkit-flexbox-inline. This is because of the current code is using: template<> inline CSSPrimitiveValue::operator EDisplay() const { if (m_value.ident == CSSValueNone) return NONE; return static_cast<EDisplay>(m_value.ident - CSSValueInline); } Because of -wap-marquee, m_value.ident would be one off for any display property after it! Patch forthcoming to add the missing testing. 502376 1 115044 jchaffraix 2011-11-14 15:21:54 -0800 Created attachment 115044 Proposed test. 502438 2 115044 webkit.review.bot 2011-11-14 16:20:31 -0800 Comment on attachment 115044 Proposed test. Clearing flags on attachment: 115044 Committed r100211: <http://trac.webkit.org/changeset/100211> 502439 3 webkit.review.bot 2011-11-14 16:20:36 -0800 All reviewed patches have been landed. Closing bug. 115044 2011-11-14 15:21:54 -0800 2011-11-14 16:20:31 -0800 Proposed test. bug-72318-20111114152153.patch text/plain 4478 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODQwZTgwNTE1OTUwMzg1NTdmODkz NjRlNWYxOThkYWM5NTg4N2RlYS4uYmRhYWE0NGU3M2I0Nzc4YjQyYTBjOGZlMTQ3Y2UzYjVjNzI4 NDc3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTE0ICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFRlc3QgZ2V0dGluZyAvIHNldHRp bmcgZGlzcGxheTogLXdlYmtpdC1mbGV4Ym94IGFuZCAtd2Via2l0LWZsZXhib3gtaW5saW5lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjMxOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgdGhhdCBj b3ZlcnMgdGhlIGNoYW5nZSBmb3IgYnVnIDcyMjk2IGFuZCBhbHNvIGluY3JlYXNlIG91ciBmbGV4 Ym94IGNvdmVyYWdlLgorCisgICAgICAgICogY3NzMy9mbGV4Ym94L2Rpc3BsYXktZmxleGJveC1z ZXQtZ2V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3NzMy9mbGV4Ym94L2Rpc3Bs YXktZmxleGJveC1zZXQtZ2V0Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNzczMvZmxleGJveC9y ZXNvdXJjZXMvZGlzcGxheS1mbGV4Ym94LXNldC1nZXQuanM6IEFkZGVkLgorCiAyMDExLTExLTE0 ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBD U1MzX0ZMRVhCT1ggY29tcGlsZSB0aW1lIGZsYWcgYW5kIGVuYWJsZSBvbiBhbGwgcG9ydHMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9kaXNwbGF5LWZsZXhib3gtc2V0LWdl dC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZGlzcGxheS1mbGV4Ym94 LXNldC1nZXQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg3NmJhMzUxZTgyNDc0MzQyMmMzNmIz NWM3YTlkZjJiZGIwYzZmOGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2Zs ZXhib3gvZGlzcGxheS1mbGV4Ym94LXNldC1nZXQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTgg QEAKK1Rlc3QgdGhhdCBzZXR0aW5nIGFuZCBnZXR0aW5nIGRpc3BsYXk6IC13ZWJraXQtZmxleGJv eCBhbmQgLXdlYmtpdC1pbmxpbmUtZmxleGJveCB3b3JrcyBhcyBleHBlY3RlZAorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworVGVzdCBnZXR0aW5nIHxkaXNwbGF5fCBzZXQgdGhyb3Vn aCBDU1MKK1BBU1MgZ2V0Q29tcHV0ZWRTdHlsZShmbGV4Ym94RWxlbWVudCwgJycpLmdldFByb3Bl cnR5VmFsdWUoJ2Rpc3BsYXknKSBpcyAnLXdlYmtpdC1mbGV4Ym94JworUEFTUyBnZXRDb21wdXRl ZFN0eWxlKGlubGluZUZsZXhib3hFbGVtZW50LCAnJykuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxh eScpIGlzICctd2Via2l0LWlubGluZS1mbGV4Ym94JworCitUZXN0IGdldHRpbmcgYW5kIHNldHRp bmcgZGlzcGxheSB0aHJvdWdoIEpTCitQQVNTIGdldENvbXB1dGVkU3R5bGUoZWxlbWVudCwgJycp LmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSBpcyAnYmxvY2snCitQQVNTIGdldENvbXB1dGVk U3R5bGUoZWxlbWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSBpcyAnLXdlYmtp dC1mbGV4Ym94JworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQsICcnKS5nZXRQcm9wZXJ0 eVZhbHVlKCdkaXNwbGF5JykgaXMgJ2Jsb2NrJworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1l bnQsICcnKS5nZXRQcm9wZXJ0eVZhbHVlKCdkaXNwbGF5JykgaXMgJy13ZWJraXQtaW5saW5lLWZs ZXhib3gnCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2Rpc3BsYXktZmxleGJveC1z ZXQtZ2V0Lmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZGlzcGxheS1mbGV4Ym94LXNl dC1nZXQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40NGI1NWE2ZjA0ZTlkNDU2NWNiZTVhODliMzUxY2VmYjAz NDhiMjFkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2Rpc3Bs YXktZmxleGJveC1zZXQtZ2V0Lmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIEhUTUwg UFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4K Ky5mbGV4Ym94IHsgZGlzcGxheTogLXdlYmtpdC1mbGV4Ym94OyB9CisuZmxleGJveElubGluZSB7 IGRpc3BsYXk6IC13ZWJraXQtaW5saW5lLWZsZXhib3g7IH0KKzwvc3R5bGU+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPSJmbGV4Ym94IiBpZD0iZmxleGJveCI+PC9kaXY+Cis8 ZGl2IGNsYXNzPSJmbGV4Ym94SW5saW5lIiBpZD0iZmxleGJveElubGluZSI+PC9kaXY+Cis8c2Ny aXB0IHNyYz0icmVzb3VyY2VzL2Rpc3BsYXktZmxleGJveC1zZXQtZ2V0LmpzIj48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9m bGV4Ym94L3Jlc291cmNlcy9kaXNwbGF5LWZsZXhib3gtc2V0LWdldC5qcyBiL0xheW91dFRlc3Rz L2NzczMvZmxleGJveC9yZXNvdXJjZXMvZGlzcGxheS1mbGV4Ym94LXNldC1nZXQuanMKbmV3IGZp bGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNTNmNDYwZjg3ZDAwMTI1ZTExMjg3M2QxNzUyODUzZWU3NzhhODAzYgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9yZXNvdXJjZXMvZGlzcGxheS1mbGV4 Ym94LXNldC1nZXQuanMKQEAgLTAsMCArMSwyMSBAQAorZGVzY3JpcHRpb24oJ1Rlc3QgdGhhdCBz ZXR0aW5nIGFuZCBnZXR0aW5nIGRpc3BsYXk6IC13ZWJraXQtZmxleGJveCBhbmQgLXdlYmtpdC1p bmxpbmUtZmxleGJveCB3b3JrcyBhcyBleHBlY3RlZCcpOworCitkZWJ1ZygiVGVzdCBnZXR0aW5n IHxkaXNwbGF5fCBzZXQgdGhyb3VnaCBDU1MiKTsKK3ZhciBmbGV4Ym94RWxlbWVudCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJmbGV4Ym94Iik7CitzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHls ZShmbGV4Ym94RWxlbWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSIsICInLXdl YmtpdC1mbGV4Ym94JyIpOwordmFyIGlubGluZUZsZXhib3hFbGVtZW50ID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImZsZXhib3hJbmxpbmUiKTsKK3Nob3VsZEJlKCJnZXRDb21wdXRlZFN0eWxl KGlubGluZUZsZXhib3hFbGVtZW50LCAnJykuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScpIiwg Iictd2Via2l0LWlubGluZS1mbGV4Ym94JyIpOworCitkZWJ1ZygiIik7CitkZWJ1ZygiVGVzdCBn ZXR0aW5nIGFuZCBzZXR0aW5nIGRpc3BsYXkgdGhyb3VnaCBKUyIpOwordmFyIGVsZW1lbnQgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQo ZWxlbWVudCk7CitzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50LCAnJykuZ2V0UHJv cGVydHlWYWx1ZSgnZGlzcGxheScpIiwgIidibG9jayciKTsKK2VsZW1lbnQuc3R5bGUuZGlzcGxh eSA9ICItd2Via2l0LWZsZXhib3giOworc2hvdWxkQmUoImdldENvbXB1dGVkU3R5bGUoZWxlbWVu dCwgJycpLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSIsICInLXdlYmtpdC1mbGV4Ym94JyIp OworCitlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Citkb2N1bWVudC5i b2R5LmFwcGVuZENoaWxkKGVsZW1lbnQpOworc2hvdWxkQmUoImdldENvbXB1dGVkU3R5bGUoZWxl bWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJ2Rpc3BsYXknKSIsICInYmxvY2snIik7CitlbGVt ZW50LnN0eWxlLmRpc3BsYXkgPSAiLXdlYmtpdC1pbmxpbmUtZmxleGJveCI7CitzaG91bGRCZSgi Z2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50LCAnJykuZ2V0UHJvcGVydHlWYWx1ZSgnZGlzcGxheScp IiwgIictd2Via2l0LWlubGluZS1mbGV4Ym94JyIpOwo=