72293 2011-11-14 11:29:58 -0800 [Chromium] build-webkit silently drops the features flags 2011-11-17 10:31:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified All RESOLVED DUPLICATE 72629 P2 Normal --- 1 jchaffraix jchaffraix abarth ojan tony webkit.review.bot oldest_to_newest 502130 0 jchaffraix 2011-11-14 11:29:58 -0800 Currently build-webkit on Chromium does nothing with the @features variable but does not notify anyone! For the casual developer, it looks like everything is working, until the feature is not compiled in. Per discussion, fixing that is difficult without slowing down everybody's workflow so let's add a warning about that. Patch forthcoming. 502134 1 114994 jchaffraix 2011-11-14 11:34:58 -0800 Created attachment 114994 Proposed fix: add a warning 502138 2 114994 tony 2011-11-14 11:40:21 -0800 Comment on attachment 114994 Proposed fix: add a warning Thanks! 502220 3 114994 jchaffraix 2011-11-14 12:53:09 -0800 Comment on attachment 114994 Proposed fix: add a warning Thanks for writing the wiki Tony! 502271 4 114994 webkit.review.bot 2011-11-14 13:46:09 -0800 Comment on attachment 114994 Proposed fix: add a warning Clearing flags on attachment: 114994 Committed r100184: <http://trac.webkit.org/changeset/100184> 502272 5 webkit.review.bot 2011-11-14 13:46:13 -0800 All reviewed patches have been landed. Closing bug. 504544 6 abarth 2011-11-16 21:43:26 -0800 I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong? 504926 7 tony 2011-11-17 09:46:30 -0800 (In reply to comment #6) > I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong? I saw it on the bots too. I think it might be confused by --chromium? I'll take a look. 504937 8 jchaffraix 2011-11-17 09:54:34 -0800 (In reply to comment #7) > (In reply to comment #6) > > I get this message every time I build. I don't think I have any non-default features. Any idea what's wrong? > > I saw it on the bots too. I think it might be confused by --chromium? I'll take a look. I don't think it is the --chromium as this should be the trigger for the behavior. I have seen the error for --debug but not for --release (or the other way around I can't recall) so I would look into those 2 first. I could investigate if you prefer! 504943 9 tony 2011-11-17 09:59:03 -0800 https://bugs.webkit.org/show_bug.cgi?id=72629 504974 10 abarth 2011-11-17 10:31:50 -0800 *** This bug has been marked as a duplicate of bug 72629 *** 114994 2011-11-14 11:34:58 -0800 2011-11-14 13:46:09 -0800 Proposed fix: add a warning bug-72293-20111114113457.patch text/plain 1948 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzRjZjAwMDQ2Mjk4YzJkZDMyMmFhYjA4MTQyZWNkMTYy M2E4NjM1My4uMjU3ZWU3OTU4MmIzMGMxMTQxMmFhY2ZlY2ExN2EyYzQ3NTY0MDQxMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTExLTE0ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3Jn PgorCisgICAgICAgIFtDaHJvbWl1bV0gYnVpbGQtd2Via2l0IHNpbGVudGx5IGRyb3BzIHRoZSBm ZWF0dXJlcyBmbGFncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzIyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaHJvbWl1bSBzdGlsbCBpZ25vcmVzIEBmZWF0dXJlcyBidXQgbm93IHdlIGdpdmUgYSB3 YXJuaW5nIQorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6IENoZWNrIGlmIG9uZSBv ZiB0aGUgZmVhdHVyZXMgaXMgZGlmZmVyZW50CisgICAgICAgIGZyb20gdGhlIGRlZmF1bHQgYW5k IHByaW50IGEgd2FybmluZyBpbiB0aGlzIGNhc2UuCisKIDIwMTEtMTEtMTQgIExlaSBaaGFuZyAg PHRoZXN0aWdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1pc3NpbmcgaW5jbHVkZSBpbiBUb29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50Lmg6CmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0CmluZGV4IGE1ZTkzYThmMmRlMjQwNzc5ZmY1OGQ0ZDRmNzJlNDZiNGQ1ZTRkOWYuLmQz MzMyOGVlNTE5MDE1MDY2NjVmYmJmZTNhMmE5ZWU4NzA1YTBiNWQgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBA IC01OTQsNiArNTk0LDIxIEBAIGlmIChpc1d4KCkpIHsKIH0KIAogaWYgKGlzQ2hyb21pdW0oKSkg eworICAgICMgQ3VycmVudGx5IGNocm9taXVtIGRvZXMgbm90IGhvbm91ciB0aGUgZmVhdHVyZXMg cGFzc2VkIHRvIGJ1aWxkLXdlYmtpdC4KKyAgICAjIFVudGlsIHRoaXMgaXMgc29sdmVkLCB3ZSBp c3N1ZSBhIHdhcm5pbmcgYWJvdXQgdGhhdC4KKyAgICBmb3JlYWNoIChAZmVhdHVyZXMpIHsKKyAg ICAgICAgaWYgKCR7JF8tPnt2YWx1ZX19IG5lICRfLT57ZGVmYXVsdH0pIHsKKyAgICAgICAgICAg IHByaW50ICJcbiI7CisgICAgICAgICAgICBwcmludCAiPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT1cbiI7CisgICAgICAgICAgICBwcmlu dCAiIENocm9taXVtIGRvZXMgbm90IGhvbm9yIHRoZSBmZWF0dXJlcyBwYXNzZWQgdG8gYnVpbGQt d2Via2l0LlxuIjsKKyAgICAgICAgICAgIHByaW50ICIgVGhlIHByZWZlcnJlZCB3YXkgaXMgdG8g c2V0IHVwIHlvdXIgb3ZlcnJpZGVzIGluIH4vLmd5cC9pbmNsdWRlLmd5cGkuXG4iOworICAgICAg ICAgICAgcHJpbnQgIiBTZWUgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvd2lraS9DaHJvbWl1bSNC dWlsZGluZ3dpdGhmZWF0dXJlZGVmaW5lc1xuIjsKKyAgICAgICAgICAgIHByaW50ICIgb24gaG93 IHRvIGRvIHRoYXQuXG4iOworICAgICAgICAgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOworICAgICAgICAgICAg bGFzdDsKKyAgICAgICAgfQorICAgIH0KKwogICAgIEBvcHRpb25zID0gQEFSR1Y7CiAgICAgIyBD aHJvbWl1bSBkb2Vzbid0IGJ1aWxkIGJ5IHByb2plY3QgZGlyZWN0b3JpZXMuCiAgICAgQHByb2pl Y3RzID0gKCk7Cg==