72288 2011-11-14 10:50:06 -0800 Towards 8 Bit Strings: Templatize YARR Parser 2011-11-14 11:25:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 71337 1 msaboff msaboff oldest_to_newest 502082 0 msaboff 2011-11-14 10:50:06 -0800 The current YARR parser calls StringImpl::characters(). Converting the parser to a template will allow the code to call characters8() or characters16() as appropriate. 502093 1 114987 msaboff 2011-11-14 11:01:08 -0800 Created attachment 114987 Patch 502096 2 114987 oliver 2011-11-14 11:04:13 -0800 Comment on attachment 114987 Patch r=me 502124 3 msaboff 2011-11-14 11:25:54 -0800 Committed r100167: <http://trac.webkit.org/changeset/100167> 114987 2011-11-14 11:01:08 -0800 2011-11-14 11:04:12 -0800 Patch 72288.patch text/plain 2325 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwMTYyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFRvd2FyZHMgOCBCaXQgU3RyaW5nczogVGVtcGxhdGl6ZSBZQVJSIFBhcnNlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIyODgKKworICAgICAg ICBDaGFuZ2VkIFlhcnI6OlBhcnNlciB0byBiZSBhIHRlbXBsYXRlIGJhc2VkIG9uIGNoYXJhY3Rl ciB0eXBlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogeWFyci9ZYXJyUGFyc2VyLmg6CisgICAgICAgIChKU0M6OllhcnI6OlBhcnNlcjo6UGFyc2Vy KToKKyAgICAgICAgKEpTQzo6WWFycjo6cGFyc2UpOgorCiAyMDExLTExLTExICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBNZWRpYUNvbnRyb2xs ZXIuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGFyc2VyLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyclBhcnNlci5oCShyZXZpc2lv biA5OTg2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJQYXJzZXIuaAkod29y a2luZyBjb3B5KQpAQCAtNDMsNyArNDMsNyBAQCBlbnVtIEJ1aWx0SW5DaGFyYWN0ZXJDbGFzc0lE IHsKIH07CiAKIC8vIFRoZSBQYXJzZXIgY2xhc3Mgc2hvdWxkIG5vdCBiZSB1c2VkIGRpcmVjdGx5 IC0gb25seSB2aWEgdGhlIFlhcnI6OnBhcnNlKCkgbWV0aG9kLgotdGVtcGxhdGU8Y2xhc3MgRGVs ZWdhdGU+Cit0ZW1wbGF0ZTxjbGFzcyBEZWxlZ2F0ZSwgdHlwZW5hbWUgQ2hhclR5cGU+CiBjbGFz cyBQYXJzZXIgewogcHJpdmF0ZToKICAgICB0ZW1wbGF0ZTxjbGFzcyBGcmllbmREZWxlZ2F0ZT4K QEAgLTIzMSwxMyArMjMxLDEzIEBAIHByaXZhdGU6CiAgICAgICAgIDogbV9kZWxlZ2F0ZShkZWxl Z2F0ZSkKICAgICAgICAgLCBtX2JhY2tSZWZlcmVuY2VMaW1pdChiYWNrUmVmZXJlbmNlTGltaXQp CiAgICAgICAgICwgbV9lcnIoTm9FcnJvcikKLSAgICAgICAgLCBtX2RhdGEocGF0dGVybi5jaGFy YWN0ZXJzMTYoKSkKKyAgICAgICAgLCBtX2RhdGEocGF0dGVybi5nZXRDaGFyYWN0ZXJzPENoYXJU eXBlPigpKQogICAgICAgICAsIG1fc2l6ZShwYXR0ZXJuLmxlbmd0aCgpKQogICAgICAgICAsIG1f aW5kZXgoMCkKICAgICAgICAgLCBtX3BhcmVudGhlc2VzTmVzdGluZ0RlcHRoKDApCiAgICAgewog ICAgIH0KLSAgICAKKwogICAgIC8qCiAgICAgICogcGFyc2VFc2NhcGUoKToKICAgICAgKgpAQCAt NzkzLDcgKzc5Myw3IEBAIHByaXZhdGU6CiAgICAgRGVsZWdhdGUmIG1fZGVsZWdhdGU7CiAgICAg dW5zaWduZWQgbV9iYWNrUmVmZXJlbmNlTGltaXQ7CiAgICAgRXJyb3JDb2RlIG1fZXJyOwotICAg IGNvbnN0IFVDaGFyKiBtX2RhdGE7CisgICAgY29uc3QgQ2hhclR5cGUqIG1fZGF0YTsKICAgICB1 bnNpZ25lZCBtX3NpemU7CiAgICAgdW5zaWduZWQgbV9pbmRleDsKICAgICB1bnNpZ25lZCBtX3Bh cmVudGhlc2VzTmVzdGluZ0RlcHRoOwpAQCAtODY0LDcgKzg2NCw5IEBAIHByaXZhdGU6CiB0ZW1w bGF0ZTxjbGFzcyBEZWxlZ2F0ZT4KIGNvbnN0IGNoYXIqIHBhcnNlKERlbGVnYXRlJiBkZWxlZ2F0 ZSwgY29uc3QgVVN0cmluZyYgcGF0dGVybiwgdW5zaWduZWQgYmFja1JlZmVyZW5jZUxpbWl0ID0g cXVhbnRpZnlJbmZpbml0ZSkKIHsKLSAgICByZXR1cm4gUGFyc2VyPERlbGVnYXRlPihkZWxlZ2F0 ZSwgcGF0dGVybiwgYmFja1JlZmVyZW5jZUxpbWl0KS5wYXJzZSgpOworICAgIGlmIChwYXR0ZXJu LmlzOEJpdCgpKQorICAgICAgICByZXR1cm4gUGFyc2VyPERlbGVnYXRlLCBMQ2hhcj4oZGVsZWdh dGUsIHBhdHRlcm4sIGJhY2tSZWZlcmVuY2VMaW1pdCkucGFyc2UoKTsKKyAgICByZXR1cm4gUGFy c2VyPERlbGVnYXRlLCBVQ2hhcj4oZGVsZWdhdGUsIHBhdHRlcm4sIGJhY2tSZWZlcmVuY2VMaW1p dCkucGFyc2UoKTsKIH0KIAogfSB9IC8vIG5hbWVzcGFjZSBKU0M6OllhcnIK