72287 2011-11-14 10:33:17 -0800 Remove the concept of an empty SecurityOrigin 2011-11-15 04:58:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72364 71745 1 abarth abarth dglazkov eric gustavo ossy pnormand webkit.review.bot xan.lopez oldest_to_newest 502070 0 abarth 2011-11-14 10:33:17 -0800 Remove the concept of an empty SecurityOrigin 502073 1 114981 abarth 2011-11-14 10:35:21 -0800 Created attachment 114981 Patch 502074 2 abarth 2011-11-14 10:35:42 -0800 This patch won't compile on the EWS because it depends on a couple patches that are in flight. 502101 3 114981 gustavo 2011-11-14 11:07:23 -0800 Comment on attachment 114981 Patch Attachment 114981 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10397299 502137 4 114981 gyuyoung.kim 2011-11-14 11:38:29 -0800 Comment on attachment 114981 Patch Attachment 114981 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10472326 502139 5 114981 webkit.review.bot 2011-11-14 11:43:34 -0800 Comment on attachment 114981 Patch Attachment 114981 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10476302 502153 6 114981 webkit-ews 2011-11-14 11:55:57 -0800 Comment on attachment 114981 Patch Attachment 114981 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10483005 502225 7 114981 abarth 2011-11-14 12:58:34 -0800 Comment on attachment 114981 Patch Clearing flags on attachment: 114981 Committed r100182: <http://trac.webkit.org/changeset/100182> 502226 8 abarth 2011-11-14 12:58:39 -0800 All reviewed patches have been landed. Closing bug. 502720 9 pnormand 2011-11-15 01:16:55 -0800 It seems this patch broke 3 tests on SL, GTK and Windows: fast/dom/Window/window-postmessage-arrays.html http/tests/security/cross-frame-access-enumeration.html http/tests/security/postMessage/invalid-origin-throws-exception.html 502822 10 ossy 2011-11-15 04:58:43 -0800 (In reply to comment #9) > It seems this patch broke 3 tests on SL, GTK and Windows: > > fast/dom/Window/window-postmessage-arrays.html > http/tests/security/cross-frame-access-enumeration.html > http/tests/security/postMessage/invalid-origin-throws-exception.html fast/dom/Window/window-postmessage-arrays.html introduced in http://trac.webkit.org/changeset/100239 (https://bugs.webkit.org/show_bug.cgi?id=72198) It is another bug. 114981 2011-11-14 10:35:21 -0800 2011-11-14 12:58:34 -0800 Patch bug-72287-20111114103520.patch text/plain 4995 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkzMGUyMDNkODc4MGYw OWVmM2YwMDk3MzJmYWRiODJlZDE3ZmY0Mi4uOGE3ZTRhNDg3ZGYwZjgxNzUyZDlkNDFhNGJkNjY5 MTU2YjdmNjQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDExLTExLTE0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmVtb3ZlIHRoZSBjb25jZXB0 IG9mIGFuIGVtcHR5IFNlY3VyaXR5T3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MjI4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgY29uY2VwdCBpcyBmcmFnaWxlIGFuZCBkb2Vzbid0IGV4 aXN0IGluIHRoZSBzcGVjcy4gIFByZXZpb3VzCisgICAgICAgIHBhdGNoZXMgaGF2ZSByZW1vdmVk IG1vc3Qgb2YgdGhlIGNvZGUgcmVseWluZyB1cG9uIHRoaXMgZnVuY3Rpb24uICBUaGlzCisgICAg ICAgIHBhdGNoIHJlbW92ZXMgYSBjb3VwbGUgc3RyYWdnbGVycy4KKworICAgICAgICAqIHBhZ2Uv RE9NV2luZG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cG9zdE1lc3NhZ2Up OgorICAgICAgICAgICAgLSBUaGlzIGNoZWNrIHNob3VsZCByZWFsbHkgYmUgYWJvdXQgdW5pcXVl IG9yaWdpbnMgYmVjYXVzZSBpdAorICAgICAgICAgICAgICBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8g dGFyZ2V0IHBvc3RNZXNzYWdlcyBhdCB1bmlxdWUgb3JpZ2lucywgYXMKKyAgICAgICAgICAgICAg ZXhwbGFpbmVkIGluIHRoZSBjb21tZW50LgorICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmlnaW4u Y3BwOgorICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmlnaW4uaDoKKworMjAxMS0xMS0xNCAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFNlY3VyaXR5T3JpZ2luIGlu aGVyaXRhbmNlIHNob3VsZCBkZXBlbmQgb24gZG9jdW1lbnQgVVJMLCBub3Qgb24gImVtcHRpbmVz cyIgb2YgdGhlIFNlY3VyaXR5T3JpZ2luCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MjI4MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDdi NDAwODZhYTQxOTY0NDk2ZjcwMjBjMWY0Mjc4YTc3MjExYzY2MGUuLmRmNTQwNGUzOTRlZGVmNTQ3 YTEzMDg2YWY2YjNjZmQ0MjJhNjI3NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTEtMTEtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K KworICAgICAgICBSZW1vdmUgdGhlIGNvbmNlcHQgb2YgYW4gZW1wdHkgU2VjdXJpdHlPcmlnaW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMjg3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSdsbCByZW5h bWUgdGhlIEFQSSBpbiBhIHN1YnNlcXVlbnQgcGF0Y2guCisKKyAgICAgICAgKiBzcmMvV2ViU2Vj dXJpdHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6aXNF bXB0eSk6CisKIDIwMTEtMTEtMTMgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtjaHJvbWl1bV0gTGF5ZXJSZW5kZXJlckNocm9taXVtOjppbml0aWFsaXplIHNob3Vs ZCBmYWlsIHdoZW4gR2FwaGljc0NvbnRleHQzRDo6bWFrZUN1cnJlbnQgZmFpbHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NV2luZG93LmNwcAppbmRleCA4ODE2MjQzZDZlNzBkMDE1OTg5OTAwMzIwYzBlZWEyMzc0 MTBkYTY4Li45NTk5ZThkNmJhM2JjNjQ2OTliOGM1YTc4YzQzNGUzYjc3MzVjMDU1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC04NzgsNyArODc4LDkgQEAgdm9pZCBET01XaW5kb3c6 OnBvc3RNZXNzYWdlKFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBtZXNzYWdlLCBj b25zdCBNZXMKICAgICBSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IHRhcmdldDsKICAgICBpZiAodGFy Z2V0T3JpZ2luICE9ICIqIikgewogICAgICAgICB0YXJnZXQgPSBTZWN1cml0eU9yaWdpbjo6Y3Jl YXRlRnJvbVN0cmluZyh0YXJnZXRPcmlnaW4pOwotICAgICAgICBpZiAodGFyZ2V0LT5pc0VtcHR5 KCkpIHsKKyAgICAgICAgLy8gSXQgZG9lc24ndCBtYWtlIHNlbnNlIHRhcmdldCBhIHBvc3RNZXNz YWdlIGF0IGEgdW5pcXVlIG9yaWdpbgorICAgICAgICAvLyBiZWNhdXNlIHRoZXJlJ3Mgbm8gd2F5 IHRvIHJlcHJlc2VudCBhIHVuaXF1ZSBvcmlnaW4gaW4gYSBzdHJpbmcuCisgICAgICAgIGlmICh0 YXJnZXQtPmlzVW5pcXVlKCkpIHsKICAgICAgICAgICAgIGVjID0gU1lOVEFYX0VSUjsKICAgICAg ICAgICAgIHJldHVybjsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9TZWN1cml0eU9yaWdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2lu LmNwcAppbmRleCA4Njc4ZDhkN2RhMWU0MmYwNGI4YWE2N2IzYTBiZDA4MmZmMGE5YzYwLi40ZmQ3 MzU0YjJlMGFhOWZjMjExZWQwNmY2OTYwNzljNTA5ZWE0NWUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1NlY3VyaXR5T3JpZ2luLmNwcApAQCAtMTM0LDEyICsxMzQsNiBAQCBTZWN1cml0eU9yaWdpbjo6 U2VjdXJpdHlPcmlnaW4oY29uc3QgU2VjdXJpdHlPcmlnaW4qIG90aGVyKQogewogfQogCi1ib29s IFNlY3VyaXR5T3JpZ2luOjppc0VtcHR5KCkgY29uc3QKLXsKLSAgICBBU1NFUlQoIW1fcHJvdG9j b2wuaXNFbXB0eSgpIHx8IG1faXNVbmlxdWUpOwotICAgIHJldHVybiBtX3Byb3RvY29sLmlzRW1w dHkoKTsKLX0KLQogUGFzc1JlZlB0cjxTZWN1cml0eU9yaWdpbj4gU2VjdXJpdHlPcmlnaW46OmNy ZWF0ZShjb25zdCBLVVJMJiB1cmwsIGJvb2wgZm9yY2VVbmlxdWUpCiB7CiAgICAgaWYgKCF1cmwu aXNWYWxpZCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdp bi5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5oCmluZGV4IGE1NmM1MGMw NzNkZWRiYjBmZDVmODM2ODAwZjgyNWMxY2UyOTgzNmYuLmNiNzgxMWE2ZWQ0N2JmZGJjZmY4Yzli ODEwZGE3YTM3MTQ3ZWY0YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJp dHlPcmlnaW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5T3JpZ2luLmgKQEAg LTEzNCwxMyArMTM0LDYgQEAgcHVibGljOgogICAgIC8vIGFkZGl0aW9uLCB0aGUgU2FuZGJveE9y aWdpbiBmbGFnIGlzIGluaGVyaXRlZCBieSBpZnJhbWVzLgogICAgIGJvb2wgaXNVbmlxdWUoKSBj b25zdCB7IHJldHVybiBtX2lzVW5pcXVlOyB9CiAKLSAgICAvLyBUaGUgZW1wdHkgU2VjdXJpdHlP cmlnaW4gaXMgYSB1bmlxdWUgc2VjdXJpdHkgb3JpZ24gKGluIHRoZSBzZW5zZSBvZgotICAgIC8v IGlzVW5pcXVlIGFib3ZlKSB0aGF0IHdhcyBjcmVhdGVkIGZvciBhICJibGFuayIgZG9jdW1lbnQs IHN1Y2ggYWJvdXQKLSAgICAvLyBhYm91dDpibGFuay4gRW1wdHkgb3JpZ2lucyBkaWZmZXIgZnJv bSB1bmlxdWUgb3JpZ2lucyBpbiB0aGF0IHRoZXkgY2FuCi0gICAgLy8gc29tZXRpbWVzIGJlIHJl cGxhY2VkIGJ5IG5vbi1lbXB0eSBvcmlnaW5zLCBmb3IgZXhhbXBsZSB3aGVuIGFuCi0gICAgLy8g YWJvdXQ6YmxhbmsgaWZyYW1lIGluaGVyaXRzIGl0cyBzZWN1cml0eSBvcmlnaW4gZnJvbSBpdHMg cGFyZW50IGZyYW1lLgotICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0OwotCiAgICAgLy8gTWFya3Mg YSBmaWxlOi8vIG9yaWdpbiBhcyBiZWluZyBpbiBhIGRvbWFpbiBkZWZpbmVkIGJ5IGl0cyBwYXRo LgogICAgIHZvaWQgZW5mb3JjZUZpbGVQYXRoU2VwYXJhdGlvbigpOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAKaW5kZXggZDIxYmRiODI5 ZjMyODlmNDU5NGVlOWM2NjQyOTEzNTBkN2E1ZjdiYS4uMmEyMzUwMDNhYTFiYjBkYWViNWZkZGVm ZWYxMmM3NWQxNDk0MTg0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU2VjdXJpdHlPcmlnaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlNlY3VyaXR5T3JpZ2luLmNwcApAQCAtOTAsMTAgKzkwLDExIEBAIHVuc2lnbmVkIHNob3J0IFdl YlNlY3VyaXR5T3JpZ2luOjpwb3J0KCkgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT5wb3J0 KCk7CiB9CiAKKy8vIEZJWE1FOiBSZW5hbWUgdGhpcyBBUEkgdG8gaXNVbmlxdWUuCiBib29sIFdl YlNlY3VyaXR5T3JpZ2luOjppc0VtcHR5KCkgY29uc3QKIHsKICAgICBBU1NFUlQobV9wcml2YXRl KTsKLSAgICByZXR1cm4gbV9wcml2YXRlLT5pc0VtcHR5KCk7CisgICAgcmV0dXJuIG1fcHJpdmF0 ZS0+aXNVbmlxdWUoKTsKIH0KIAogYm9vbCBXZWJTZWN1cml0eU9yaWdpbjo6Y2FuQWNjZXNzKGNv bnN0IFdlYlNlY3VyaXR5T3JpZ2luJiBvdGhlcikgY29uc3QK