72276 2011-11-14 08:31:10 -0800 Web Inspector: Command line $x fails for 3 of 4 types of XPath query 2011-11-15 00:09:16 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 501936 0 pfeldman 2011-11-14 08:31:10 -0800 (Upstream from http://code.google.com/p/chromium/issues/detail?id=97528). Although we don't have to do that by the spec, it is a handy improvement. 502038 1 114973 pfeldman 2011-11-14 10:03:05 -0800 Created attachment 114973 Patch 502270 2 114973 timothy 2011-11-14 13:45:02 -0800 Comment on attachment 114973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review r+ is you land it with the style fixed. > Source/WebCore/inspector/InjectedScriptSource.js:600 > + case XPathResult.NUMBER_TYPE: return result.numberValue; > + case XPathResult.STRING_TYPE: return result.stringValue; > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; The case and the return should be on seperate lines. 502688 3 pfeldman 2011-11-14 23:50:29 -0800 (In reply to comment #2) > (From update of attachment 114973 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114973&action=review > > r+ is you land it with the style fixed. > > > Source/WebCore/inspector/InjectedScriptSource.js:600 > > + case XPathResult.NUMBER_TYPE: return result.numberValue; > > + case XPathResult.STRING_TYPE: return result.stringValue; > > + case XPathResult.BOOLEAN_TYPE: return result.booleanValue; > > The case and the return should be on seperate lines. Welcome back :) 502689 4 pfeldman 2011-11-15 00:09:16 -0800 Committed r100246: <http://trac.webkit.org/changeset/100246> 114973 2011-11-14 10:03:05 -0800 2011-11-14 13:45:20 -0800 Patch bug-72276-20111114220303.patch text/plain 4754 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYzYzQ2MzQ1NjlmZmIx MWEyZjdlZDA1NmViZTNiYmI1YWVlODhiMC4uYWExM2FmN2EyMzc1MjA2OGQzYTQxNDg4Yjg3MTE4 M2FkYzk0MTMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTExLTE0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBDb21tYW5kIGxpbmUgJHggZmFpbHMgZm9yIDMgb2YgNCB0eXBlcyBvZiBYUGF0aCBxdWVyeQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIyNzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBpbnNw ZWN0b3IvY29uc29sZS9jb25zb2xlLXhwYXRoLmh0bWwKKworICAgICAgICAqIGluc3BlY3Rvci9J bmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgKC4pOgorCisyMDExLTExLTE0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBjb25zb2xlJ3MgcHJvdG9jb2wgcGF5bG9hZCBkb2VzIG5vdCBoYXZlIHVybCBhbmQgbGluZSBw cm9wZXJ0aWVzLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzIyNTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVk U2NyaXB0U291cmNlLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0 U291cmNlLmpzCmluZGV4IDliNDVlODRlNWI1MWU1NzU3NjVkM2NiMTgyZjExMTZjYzFhN2M5NzQu LmJjMmUzNDQ3OGZjMjhkY2Q0NjdhYzEyZGQzYTFiMDkwOTI1Y2QxZWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKQEAgLTU5MiwxNiAr NTkyLDE5IEBAIENvbW1hbmRMaW5lQVBJSW1wbC5wcm90b3R5cGUgPSB7CiAKICAgICAkeDogZnVu Y3Rpb24oeHBhdGgsIGNvbnRleHQpCiAgICAgewotICAgICAgICB2YXIgbm9kZXMgPSBbXTsKLSAg ICAgICAgdHJ5IHsKLSAgICAgICAgICAgIHZhciBkb2MgPSAoY29udGV4dCAmJiBjb250ZXh0Lm93 bmVyRG9jdW1lbnQpIHx8IGluc3BlY3RlZFdpbmRvdy5kb2N1bWVudDsKLSAgICAgICAgICAgIHZh ciByZXN1bHRzID0gZG9jLmV2YWx1YXRlKHhwYXRoLCBjb250ZXh0IHx8IGRvYywgbnVsbCwgWFBh dGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpOworICAgICAgICB2YXIgZG9jID0gKGNvbnRleHQgJiYg Y29udGV4dC5vd25lckRvY3VtZW50KSB8fCBpbnNwZWN0ZWRXaW5kb3cuZG9jdW1lbnQ7CisgICAg ICAgIHZhciByZXN1bHQgPSBkb2MuZXZhbHVhdGUoeHBhdGgsIGNvbnRleHQgfHwgZG9jLCBudWxs LCBYUGF0aFJlc3VsdC5BTllfVFlQRSwgbnVsbCk7CisgICAgICAgIHN3aXRjaCAocmVzdWx0LnJl c3VsdFR5cGUpIHsKKyAgICAgICAgY2FzZSBYUGF0aFJlc3VsdC5OVU1CRVJfVFlQRTogcmV0dXJu IHJlc3VsdC5udW1iZXJWYWx1ZTsKKyAgICAgICAgY2FzZSBYUGF0aFJlc3VsdC5TVFJJTkdfVFlQ RTogcmV0dXJuIHJlc3VsdC5zdHJpbmdWYWx1ZTsKKyAgICAgICAgY2FzZSBYUGF0aFJlc3VsdC5C T09MRUFOX1RZUEU6IHJldHVybiByZXN1bHQuYm9vbGVhblZhbHVlOworICAgICAgICBkZWZhdWx0 OgorICAgICAgICAgICAgdmFyIG5vZGVzID0gW107CiAgICAgICAgICAgICB2YXIgbm9kZTsKLSAg ICAgICAgICAgIHdoaWxlIChub2RlID0gcmVzdWx0cy5pdGVyYXRlTmV4dCgpKQorICAgICAgICAg ICAgd2hpbGUgKG5vZGUgPSByZXN1bHQuaXRlcmF0ZU5leHQoKSkKICAgICAgICAgICAgICAgICBu b2Rlcy5wdXNoKG5vZGUpOwotICAgICAgICB9IGNhdGNoIChlKSB7CisgICAgICAgICAgICByZXR1 cm4gbm9kZXM7CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIG5vZGVzOwogICAgIH0sCiAKICAg ICBkaXI6IGZ1bmN0aW9uKCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0MTdlMTMwODFlNThlMzk3MmU5MDMxYzQxMzUyMTgx OTBiNDFkZmY0Li43YmFlNTg0YjQ4NTZlNGNkNzgxZGQwNTUxN2FjMDRjNDFkMDcwZWM0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMTEtMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBn b29nbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1hbmQgbGluZSAkeCBmYWls cyBmb3IgMyBvZiA0IHR5cGVzIG9mIFhQYXRoIHF1ZXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjI3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS14cGF0 aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNv bGUteHBhdGguaHRtbDogQWRkZWQuCisKKzIwMTEtMTEtMTQgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBnb29nbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNvbnNvbGUncyBwcm90 b2NvbCBwYXlsb2FkIGRvZXMgbm90IGhhdmUgdXJsIGFuZCBsaW5lIHByb3BlcnRpZXMuCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjI1NgogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXhwYXRoLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUteHBhdGgtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk3NmU3OTEwMjczMjgzOWVmZGI3YjcxM2VmZmVjMjNjNzgw ZDQ4M2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9j b25zb2xlLXhwYXRoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEzIEBACitDT05TT0xFIE1FU1NB R0U6IGxpbmUgMTogY29tcGxldGUKK1Rlc3RzICR4IGZvciBpdGVyYXRvciBhbmQgbm9uLWl0ZXJh dG9yIHR5cGVzLgorCiskeCgnNDInKQorJHgoJ25hbWUoL2h0bWwpJykKKyR4KCdub3QoNDIpJykK KyR4KCcvaHRtbC9ib2R5L3AnKS5sZW5ndGgKKzQyCisiaHRtbCIKK2ZhbHNlCisxCitjb21wbGV0 ZQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXhw YXRoLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLXhwYXRoLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNzE3ODhlZTBjOGJmZjM2NTRjZjQ4N2JlZjc0ZjAzMGVjNzQ2NTM3NQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUt eHBhdGguaHRtbApAQCAtMCwwICsxLDM1IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3QuanMi Pjwvc2NyaXB0PgorPHNjcmlwdD4KKworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgSW5zcGVjdG9y VGVzdC5hZGRDb25zb2xlU25pZmZlcihhZGRNZXNzYWdlU25pZmZlciwgdHJ1ZSk7CisKKyAgICBJ bnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5Db25zb2xlKCIkeCgnNDInKSIpOyAvLyBudW1iZXIKKyAg ICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5Db25zb2xlKCIkeCgnbmFtZSgvaHRtbCknKSIpOyAv LyBzdHJpbmcKKyAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5Db25zb2xlKCIkeCgnbm90KDQy KScpIik7IC8vIGJvb2xlYW4KKyAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5Db25zb2xlKCIk eCgnL2h0bWwvYm9keS9wJykubGVuZ3RoIik7IC8vIG5vZGUgaXRlcmF0b3IKKyAgICBJbnNwZWN0 b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJjb25zb2xlLmxvZygnY29tcGxldGUnKSIpOyAvLyBub2Rl IGl0ZXJhdG9yCisKKyAgICBmdW5jdGlvbiBhZGRNZXNzYWdlU25pZmZlcihtZXNzYWdlKQorICAg IHsKKyAgICAgICAgaWYgKG1lc3NhZ2UudG9TdHJpbmcoKS5pbmRleE9mKCJjb21wbGV0ZSIpICE9 PSAtMSkgeworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wQ29uc29sZU1lc3NhZ2VzKCk7 CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgICAgICB9Cisg ICAgfQorfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJydW5UZXN0KCki PgorPHA+CitUZXN0cyAkeCBmb3IgaXRlcmF0b3IgYW5kIG5vbi1pdGVyYXRvciB0eXBlcy4KKzwv cD4KKworPC9ib2R5PgorPC9odG1sPgo=