72242 2011-11-13 23:23:40 -0800 SecurityPolicy should refer to isUnique rather than isEmpty 2011-11-13 23:53:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71745 1 abarth abarth eric webkit.review.bot oldest_to_newest 501652 0 abarth 2011-11-13 23:23:40 -0800 SecurityPolicy should refer to isUnique rather than isEmpty 501653 1 114884 abarth 2011-11-13 23:25:13 -0800 Created attachment 114884 Patch 501656 2 114884 eric 2011-11-13 23:26:44 -0800 Comment on attachment 114884 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114884&action=review LGTM. > Source/WebCore/ChangeLog:13 > + the difference, but we're eventually going to remove the isEmpty > + function. You might even say "Very shortly". :) 501676 3 114884 abarth 2011-11-13 23:53:31 -0800 Comment on attachment 114884 Patch Clearing flags on attachment: 114884 Committed r100101: <http://trac.webkit.org/changeset/100101> 501677 4 abarth 2011-11-13 23:53:35 -0800 All reviewed patches have been landed. Closing bug. 114884 2011-11-13 23:25:13 -0800 2011-11-13 23:53:31 -0800 Patch bug-72242-20111113232512.patch text/plain 2598 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NjOWYwY2I5NTc2OWEz YjMyOGJlYjA0YmJjODY5Y2U0N2JjNmU3Ny4uYzAzZTgyMzJmOWQ3OWYwNzU4MmQ4OGQ0OTY1OGE2 NjI4NTQwY2M1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDExLTExLTEzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgU2VjdXJpdHlQb2xpY3kgc2hv dWxkIHJlZmVyIHRvIGlzVW5pcXVlIHJhdGhlciB0aGFuIGlzRW1wdHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMjQyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgZG9lc24ndCBtYWtlIHNlbnNlIHRv IHR3ZWFrIHRoZSBzZWN1cml0eSBwb2xpY3kgZm9yIHVuaXF1ZSBvcmlnaW5zCisgICAgICAgIGJl Y2F1c2UgdGhleSdyZSBkaWZmZXJlbnQgZXZlcnkgdGltZS4gIFByZXZpb3VzbHksIHRoaXMgY29k ZSBjaGVja2VkCisgICAgICAgIGZvciBlbXB0eSBvcmlnaW5zLCB3aGljaCBhcmUgdGVjaG5pY2Fs bHkgYSBzdWJzZXQgb2YgdW5pcXVlIG9yaWdpbnMuICBJCisgICAgICAgIGRvbid0IHRoaW5rIGl0 J3MgcG9zc2libGUgdG8gY2FsbCB0aGlzIGNvZGUgaW4gYSB3YXkgdGhhdCBjYW4gZGV0ZWN0Cisg ICAgICAgIHRoZSBkaWZmZXJlbmNlLCBidXQgd2UncmUgZXZlbnR1YWxseSBnb2luZyB0byByZW1v dmUgdGhlIGlzRW1wdHkKKyAgICAgICAgZnVuY3Rpb24uCisKKyAgICAgICAgKiBwYWdlL1NlY3Vy aXR5UG9saWN5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlY3VyaXR5UG9saWN5OjphZGRPcmln aW5BY2Nlc3NXaGl0ZWxpc3RFbnRyeSk6CisgICAgICAgIChXZWJDb3JlOjpTZWN1cml0eVBvbGlj eTo6cmVtb3ZlT3JpZ2luQWNjZXNzV2hpdGVsaXN0RW50cnkpOgorCisyMDExLTExLTEzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgTW92ZSBpc1NlY3VyZVRyYW5z aXRpb25UbyBmcm9tIFNlY3VyaXR5T3JpZ2luIHRvIFNlY3VyaXR5Q29udGV4dAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIyNDEKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eVBvbGljeS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1NlY3VyaXR5UG9saWN5LmNwcAppbmRleCBjZDkyOTI5MjQyNmViYmI4MzI4MTRiZGZl NjFlOTA4Zjk2ZmM0ZjU1Li4zMWNhYzA2NWZlZWZlNjA4MTIyMDE3MjRlM2VjNzFlZGYwZDYxZDkw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5UG9saWN5LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NlY3VyaXR5UG9saWN5LmNwcApAQCAtOTksOCArOTksOCBA QCBib29sIFNlY3VyaXR5UG9saWN5Ojppc0FjY2Vzc1RvVVJMV2hpdGVMaXN0ZWQoY29uc3QgU2Vj dXJpdHlPcmlnaW4qIGFjdGl2ZU9yaWdpbgogdm9pZCBTZWN1cml0eVBvbGljeTo6YWRkT3JpZ2lu QWNjZXNzV2hpdGVsaXN0RW50cnkoY29uc3QgU2VjdXJpdHlPcmlnaW4mIHNvdXJjZU9yaWdpbiwg Y29uc3QgU3RyaW5nJiBkZXN0aW5hdGlvblByb3RvY29sLCBjb25zdCBTdHJpbmcmIGRlc3RpbmF0 aW9uRG9tYWluLCBib29sIGFsbG93RGVzdGluYXRpb25TdWJkb21haW5zKQogewogICAgIEFTU0VS VChpc01haW5UaHJlYWQoKSk7Ci0gICAgQVNTRVJUKCFzb3VyY2VPcmlnaW4uaXNFbXB0eSgpKTsK LSAgICBpZiAoc291cmNlT3JpZ2luLmlzRW1wdHkoKSkKKyAgICBBU1NFUlQoIXNvdXJjZU9yaWdp bi5pc1VuaXF1ZSgpKTsKKyAgICBpZiAoc291cmNlT3JpZ2luLmlzVW5pcXVlKCkpCiAgICAgICAg IHJldHVybjsKIAogICAgIFN0cmluZyBzb3VyY2VTdHJpbmcgPSBzb3VyY2VPcmlnaW4udG9TdHJp bmcoKTsKQEAgLTExNSw4ICsxMTUsOCBAQCB2b2lkIFNlY3VyaXR5UG9saWN5OjphZGRPcmlnaW5B Y2Nlc3NXaGl0ZWxpc3RFbnRyeShjb25zdCBTZWN1cml0eU9yaWdpbiYgc291cmNlTwogdm9pZCBT ZWN1cml0eVBvbGljeTo6cmVtb3ZlT3JpZ2luQWNjZXNzV2hpdGVsaXN0RW50cnkoY29uc3QgU2Vj dXJpdHlPcmlnaW4mIHNvdXJjZU9yaWdpbiwgY29uc3QgU3RyaW5nJiBkZXN0aW5hdGlvblByb3Rv Y29sLCBjb25zdCBTdHJpbmcmIGRlc3RpbmF0aW9uRG9tYWluLCBib29sIGFsbG93RGVzdGluYXRp b25TdWJkb21haW5zKQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAgQVNTRVJU KCFzb3VyY2VPcmlnaW4uaXNFbXB0eSgpKTsKLSAgICBpZiAoc291cmNlT3JpZ2luLmlzRW1wdHko KSkKKyAgICBBU1NFUlQoIXNvdXJjZU9yaWdpbi5pc1VuaXF1ZSgpKTsKKyAgICBpZiAoc291cmNl T3JpZ2luLmlzVW5pcXVlKCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIFN0cmluZyBzb3VyY2VT dHJpbmcgPSBzb3VyY2VPcmlnaW4udG9TdHJpbmcoKTsK