72234 2011-11-13 19:15:35 -0800 Test JPEG image decoding RGB pixel endianess 2011-11-14 17:13:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 59670 1 noel.gordon noel.gordon tkent webkit.review.bot oldest_to_newest 501579 0 noel.gordon 2011-11-13 19:15:35 -0800 Test JPEG image decoding RGB pixel endianess 501580 1 114872 noel.gordon 2011-11-13 19:16:32 -0800 Created attachment 114872 Patch 501715 2 114872 tkent 2011-11-14 01:23:15 -0800 Comment on attachment 114872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114872&action=review > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:9 > +<img src="resources/rgb-jpeg-red.jpg" onload="test(this, [255,0,0,255])"> > +<img src="resources/rgb-jpeg-green.jpg" onload="test(this, [0,255,0,255])"> > +<img src="resources/rgb-jpeg-blue.jpg" onload="test(this, [0,0,255,255])"> > + > +<pre id="log">PASS</pre> Because there are three tests, we had better show three 'PASS' in the test result. > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:13 > + layoutTestController.waitUntilDone(), layoutTestController.dumpAsText(); No reason to use a comma operator here. > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:24 > + r += data[i + 0], g += data[i + 1], b += data[i + 2], a += data[i + 3]; ditto. > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:26 > + return [ r / size, g / size, b / size, a / size ]; nit: spaces after ']' and before ']' are not needed. > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:36 > + if (tolerance = tolerance || 0, delta > tolerance) The tolerance argument is always specified. We don't need "tolerance = tolerance || 0". Also, there is no reason to use a comma operator here. > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:60 > + if (testImage(image, expect), ++loadedImages < 3) No reason to use a comma operator here. 501772 3 114910 noel.gordon 2011-11-14 03:35:45 -0800 Created attachment 114910 Patch 501773 4 noel.gordon 2011-11-14 03:38:23 -0800 (In reply to comment #2) > (From update of attachment 114872 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114872&action=review > > > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:9 > > +<img src="resources/rgb-jpeg-red.jpg" onload="test(this, [255,0,0,255])"> > > +<img src="resources/rgb-jpeg-green.jpg" onload="test(this, [0,255,0,255])"> > > +<img src="resources/rgb-jpeg-blue.jpg" onload="test(this, [0,0,255,255])"> > > + > > +<pre id="log">PASS</pre> > > Because there are three tests, we had better show three 'PASS' in the test result. We shown up to 3 failures should they happen, sufficient? > > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:13 > > + layoutTestController.waitUntilDone(), layoutTestController.dumpAsText(); > > No reason to use a comma operator here. One day layoutTestController will return its |this| context. Removed. > > LayoutTests/fast/images/rgb-jpeg-endian-pixels.html:24 > > + r += data[i + 0], g += data[i + 1], b += data[i + 2], a += data[i + 3]; > > ditto. All done, and the others you mentioned. 502477 5 114910 tkent 2011-11-14 16:54:37 -0800 Comment on attachment 114910 Patch ok 502483 6 noel.gordon 2011-11-14 16:55:51 -0800 Thankyou Tamura-san 502510 7 114910 webkit.review.bot 2011-11-14 17:13:41 -0800 Comment on attachment 114910 Patch Clearing flags on attachment: 114910 Committed r100220: <http://trac.webkit.org/changeset/100220> 502511 8 webkit.review.bot 2011-11-14 17:13:46 -0800 All reviewed patches have been landed. Closing bug. 114872 2011-11-13 19:16:32 -0800 2011-11-14 03:35:29 -0800 Patch bug-72234-20111114141413.patch text/plain 6620 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDk3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTkwMDNjYTdhOTNhMTJmOTljNmIx OTgyNTgzOTMwNzMwZGQ2OGQ5My4uMWZkMWU3NGQwMTU2MTQzODZhMWEzMGUyZDVkM2Q0MDEzMGI3 YzBjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTEzICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBUZXN0IEpQRUcgaW1hZ2UgZGVjb2Rpbmcg UkdCIHBpeGVsIGVuZGlhbmVzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzIyMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBKUEVHIGltYWdlIFJHQiBwaXhlbHMgc2hvdWxkIHJlbmRlciB3aXRob3V0IGNv bG9yIGNvcnJ1cHRpb24gYW5kIGluIHN0cmljdAorICAgICAgICBvcmRlciwgcmVnYXJkbGVzcyBv ZiB0aGUgdW5kZXJseWluZyBtYWNoaW5lIHBpeGVsIGJ1ZmZlciBlbmRpYW5lc3MuCisKKyAgICAg ICAgKiBmYXN0L2ltYWdlcy9yZXNvdXJjZXMvcmdiLWpwZWctYmx1ZS5qcGc6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ncmVlbi5qcGc6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1yZWQuanBnOiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2ltYWdlcy9yZ2ItanBlZy1lbmRpYW4tcGl4ZWxzLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy5o dG1sOiBBZGRlZC4KKwogMjAxMS0xMS0xMyAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKDk5ODQ5KTogTlVMTC1kZXJlZiBpbiB1 cGRhdGVMYXN0TWVkaWFMaW5lIHdoZW4gcGFyc2luZyBzb21lIG1lZGlhLXF1ZXJpZXMKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ibHVlLmpw ZyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ibHVlLmpwZwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4wNGI0NWQzZWJiNDZmYjY2Yjc3NjcwYzBlMGMxMDI0YjIwZDJjYmE0CkdJVCBi aW5hcnkgcGF0Y2gKbGl0ZXJhbCA2OTUKemNtZXg9PE5wSCYwV1VYQ0h3SCNWTXVyMytXY1l1WiFJ Xj1Ia3I5TlRmU0h2VTFsVSt1bXw1QWAqeDVtdGdPaSgrCnpnTSo4TW90PXg5aTtKNUYyLXJGS188 NEV3S3h+ajlBbmhQc0sqWW5yJkgrK0U4dSkqSkw2QyNOZngmXjlRSGc7YAp6a2RheENAJjZHOWM/ SmVYUi1rSl40dSUzb0NUMTJeSGxVTlp4UGMwYDNJTHRZJSorSUlFR3I4T1A8MVUob2BGUz4KelJZ PWoka3hlKS1rekpgISNIZXhOTEpubzhqUiFAOEVgQ3JrUEFZMlI8UHNCP2tkI3RZUWBnWWNHQkd0 WHgzSUt3CnpjNSF1Y193ZSl6NGhhbmxrQkUjKVBEeEVtJiZiUndFLTVXNXVjKWtRWmZSfDZAOTZC Qkc8bkxAWTEzIVNvVjk1Mgp6bEJMVSp1VU5UaSk4O0sod3s3M0NiSndCNk1+KXNsZSZYYipPUDgt KXk+fFZeJjA3eTJKJH59Xis0QzFLVXchPWEKemBPRFhELSslbzQxQGFkbzEyZT4xYUcjPDFPQXpR VUNTVit9dSFIPT8kVyN1KiV6YFllaWlUYExqKUNsbmd+Q2NrCnpqVHxDUTZCbGtnJGY7fWBeZyVT Sz1wdlZ4aXBmTE9rMDdzc2VNWCRlbiNsNFErK3pyVC1EMlFqVyZ9bmF2bWs+IwpZIT1LX3NVRHwq RCpsVGxYRU5VUForeUIxXzA3MylUKEV0RGQKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ncmVlbi5q cGcgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9yZXNvdXJjZXMvcmdiLWpwZWctZ3JlZW4uanBn Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjE5YTBkMjRlN2IzMjNlYzExYjkwNzk5MTg2ODc3NDA3MGM1ODg0NWUKR0lU IGJpbmFyeSBwYXRjaApsaXRlcmFsIDY5NQp6Y21leD08TnBIJjBXVVhDSHdII1ZNdXIzK1djWXVa IUlePUhrcjlOVGZTSHZVMWxVK3VtfDVBYCp4NW10Z09pKCsKemdNKjhNb3Q9eDlpO0o1RjItckZL Xzw0RXdLeH5qOUFuaFBzSypZbnImSCsrRTh1KSpKTDZDI05meCZeOVFIZztgCnprZGF4Q0AmNkc5 Yz9KZVhSLWtKXjR1JTNvQ1QxMl5IbFVOWnhQYzBgM0lMdFklKitJSUVHcjhPUDwxVShvYEZTPgp6 Ulk9aiRreGUpLWt6SmAhI0hleE5MSm5vOGpSIUA4RWBDcmtQQVkyUjxQc0I/a2QjdFlRYGdZY0dC R3RYeDNJS3cKemM1IXVjX3dlKXo0aGFubGtCRSMpUER4RW0mJmJSd0UtNVc1dWMpa1FaZlJ8NkA5 NkJCRzxuTEBZMTMhU29WOTUyCnpsQkxVKnVVTlRpKTg7Syh3ezczQ2JKd0I2TX4pc2xlJlhiKk9Q OC0peT58Vl4mMDd5Mkokfn1eKzRDMUtVdyE9YQp6YE9EWEQtKyVvNDFAYWRvMTJlPjFhRyM8MU9B elFVQ1NWK311IUg9PyRXI3UqJXpgWWVpaVRgTGopQ2xuZ35DY2sKempUfENRNkJsa2ckZjt9YF5n JVNLPXB2VnhpcGZMT2swN3NzZU1YJGVuI2w0USsrenJULUQyUWpXJn1uYXZtaz4jClkhYENqMk1m Kj5Fe3U5aWx2OGFKdVoyJGl6MERVVWh5WmBfSQoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL3JnYi1qcGVnLXJlZC5q cGcgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9yZXNvdXJjZXMvcmdiLWpwZWctcmVkLmpwZwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi45YTY5ZGJiZTU5Y2JlZmIzOGM1YzQ5Y2EwMmJjNjkxODExNWJmOTg4CkdJVCBi aW5hcnkgcGF0Y2gKbGl0ZXJhbCA2OTUKemNtZXg9PE5wSCYwV1VYQ0h3SCNWTXVyMytXY1l1WiFJ Xj1Ia3I5TlRmU0h2VTFsVSt1bXw1QWAqeDVtdGdPaSgrCnpnTSo4TW90PXg5aTtKNUYyLXJGS188 NEV3S3h+ajlBbmhQc0sqWW5yJkgrK0U4dSkqSkw2QyNOZngmXjlRSGc7YAp6a2RheENAJjZHOWM/ SmVYUi1rSl40dSUzb0NUMTJeSGxVTlp4UGMwYDNJTHRZJSorSUlFR3I4T1A8MVUob2BGUz4KelJZ PWoka3hlKS1rekpgISNIZXhOTEpubzhqUiFAOEVgQ3JrUEFZMlI8UHNCP2tkI3RZUWBnWWNHQkd0 WHgzSUt3CnpjNSF1Y193ZSl6NGhhbmxrQkUjKVBEeEVtJiZiUndFLTVXNXVjKWtRWmZSfDZAOTZC Qkc8bkxAWTEzIVNvVjk1Mgp6bEJMVSp1VU5UaSk4O0sod3s3M0NiSndCNk1+KXNsZSZYYipPUDgt KXk+fFZeJjA3eTJKJH59Xis0QzFLVXchPWEKemBPRFhELSslbzQxQGFkbzEyZT4xYUcjPDFPQXpR VUNTVit9dSFIPT8kVyN1KiV6YFllaWlUYExqKUNsbmd+Q2NrCnpqVHxDUTZCbGtnJGY7fWBeZyVT Sz1wdlZ4aXBmTE9rMDdzc2VNWCRlbiNsNFErK3pyVC1EMlFqVyZ9bmF2bWs+IwpZITtnSms4dGIx THxOWDxJdjhhSnVaMiRpejBEPnltJjtTNGMKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3JnYi1qcGVnLWVuZGlhbi1waXhlbHMtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVs cy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmY2MjRiYjMxMjg4ZTVhNjU2NzliMzE2Mjk0OTk1 ZGYwNDNlOGVkMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jn Yi1qcGVnLWVuZGlhbi1waXhlbHMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorSlBFRyBp bWFnZSBSR0IgcGl4ZWxzIHNob3VsZCByZW5kZXIgd2l0aG91dCBjb2xvciBjb3JydXB0aW9uIGFu ZCBpbiBzdHJpY3QKK29yZGVyLCByZWdhcmRsZXNzIG9mIHRoZSB1bmRlcmx5aW5nIG1hY2hpbmUg cGl4ZWwgYnVmZmVyIGVuZGlhbmVzcy4KKworICAKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvaW1hZ2VzL3JnYi1qcGVnLWVuZGlhbi1waXhlbHMuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvaW1hZ2VzL3JnYi1qcGVnLWVuZGlhbi1waXhlbHMuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNzkx MmY0MDJhNGY5M2FmOGZkOWE0OGUwYWMwZmZhZmNhMmZmYTM3Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy5odG1sCkBAIC0w LDAgKzEsNjkgQEAKKzwhRE9DVFlQRSBodG1sPgorSlBFRyBpbWFnZSBSR0IgcGl4ZWxzIHNob3Vs ZCByZW5kZXIgd2l0aG91dCBjb2xvciBjb3JydXB0aW9uIGFuZCBpbiBzdHJpY3Q8YnI+CitvcmRl ciwgcmVnYXJkbGVzcyBvZiB0aGUgdW5kZXJseWluZyBtYWNoaW5lIHBpeGVsIGJ1ZmZlciBlbmRp YW5lc3MuPGJyPjxicj4KKworPGltZyBzcmM9InJlc291cmNlcy9yZ2ItanBlZy1yZWQuanBnIiAg IG9ubG9hZD0idGVzdCh0aGlzLCBbMjU1LDAsMCwyNTVdKSI+Cis8aW1nIHNyYz0icmVzb3VyY2Vz L3JnYi1qcGVnLWdyZWVuLmpwZyIgb25sb2FkPSJ0ZXN0KHRoaXMsIFswLDI1NSwwLDI1NV0pIj4K KzxpbWcgc3JjPSJyZXNvdXJjZXMvcmdiLWpwZWctYmx1ZS5qcGciICBvbmxvYWQ9InRlc3QodGhp cywgWzAsMCwyNTUsMjU1XSkiPgorCis8cHJlIGlkPSJsb2ciPlBBU1M8L3ByZT4KKworPHNjcmlw dD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIud2FpdFVudGlsRG9uZSgpLCBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisKK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJsb2ciKS50ZXh0Q29udGVudCArPSAnXG4nICsgbWVzc2FnZTsKK30KKworZnVuY3Rpb24gYXZl cmFnZVBpeGVsQ29tcG9uZW50cyhkYXRhLCBzaXplKQoreworICAgIHZhciByID0gMCwgZyA9IDAs IGIgPSAwLCBhID0gMDsKKyAgICBmb3IgKHZhciBpID0gMCwgdG90YWwgPSBzaXplICogNDsgaSA8 IHRvdGFsOyBpICs9IDQpCisgICAgICAgIHIgKz0gZGF0YVtpICsgMF0sIGcgKz0gZGF0YVtpICsg MV0sIGIgKz0gZGF0YVtpICsgMl0sIGEgKz0gZGF0YVtpICsgM107CisKKyAgICByZXR1cm4gWyBy IC8gc2l6ZSwgZyAvIHNpemUsIGIgLyBzaXplLCBhIC8gc2l6ZSBdOworfQorCitmdW5jdGlvbiBh dmVyYWdlUGl4ZWxTaG91bGRCZShwaXhlbCwgZXhwZWN0LCB0b2xlcmFuY2UpCit7CisgICAgdmFy IGRlbHRhID0gMDsKKyAgICBwaXhlbC5mb3JFYWNoKGZ1bmN0aW9uKGNvbXBvbmVudCwgaSkgewor ICAgICAgICBkZWx0YSA9IE1hdGgubWF4KE1hdGguYWJzKHBpeGVsW2ldIC0gZXhwZWN0W2ldKSwg ZGVsdGEpOworICAgIH0pOworCisgICAgaWYgKHRvbGVyYW5jZSA9IHRvbGVyYW5jZSB8fCAwLCBk ZWx0YSA+IHRvbGVyYW5jZSkKKyAgICAgICBsb2coJ0ZBSUw6IFsnICsgcGl4ZWwgKyAnXSBleHBl Y3RlZCBbJyArIGV4cGVjdCArICddICsvLSAnICsgdG9sZXJhbmNlKTsKK30KKworZnVuY3Rpb24g dGVzdEltYWdlKGltYWdlLCBleHBlY3QpCit7CisgICAgLy8gQ3JlYXRlIGEgY2FudmFzLCBsb2Fk IHRoZSBnaXZlbiBpbWFnZSBpbiBpdC4KKyAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiY2FudmFzIik7CisgICAgY2FudmFzLndpZHRoID0gY2FudmFzLmhlaWdodCA9IDY0 OworICAgIHZhciBjb250ZXh0ID0gY2FudmFzLmdldENvbnRleHQoIjJkIik7CisgICAgY29udGV4 dC5kcmF3SW1hZ2UoaW1hZ2UsIDAsIDApOworCisgICAgLy8gQ29tcGFyZSB0aGUgY2FudmFzIHBp eGVsIGNvbXBvbmVudCBhdmVyYWdlcy4KKyAgICB2YXIgcGl4ZWxzID0gY29udGV4dC5nZXRJbWFn ZURhdGEoMCwgMCwgNjQsIDY0KS5kYXRhOworICAgIHZhciByZXN1bHQgPSBhdmVyYWdlUGl4ZWxD b21wb25lbnRzKHBpeGVscywgNjQgKiA2NCk7CisKKyAgICB2YXIgcGl4ZWxUb2xlcmFuY2UgPSAz OworICAgIGF2ZXJhZ2VQaXhlbFNob3VsZEJlKHJlc3VsdCwgZXhwZWN0LCBwaXhlbFRvbGVyYW5j ZSk7Cit9CisKK2Z1bmN0aW9uIHRlc3QoaW1hZ2UsIGV4cGVjdCkKK3sKKyAgICB0cnkgeworICAg ICAgICBsb2FkZWRJbWFnZXMgPSB3aW5kb3cubG9hZGVkSW1hZ2VzIHx8IDA7CisgICAgICAgIGlm ICh0ZXN0SW1hZ2UoaW1hZ2UsIGV4cGVjdCksICsrbG9hZGVkSW1hZ2VzIDwgMykKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIGxvZygnRkFJTDogJyArIGUu bWVzc2FnZSk7CisgICAgfQorCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICAgICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKzwv c2NyaXB0Pgo= 114910 2011-11-14 03:35:45 -0800 2011-11-14 17:13:41 -0800 Patch bug-72234-20111114223542.patch text/plain 6661 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWRkNDYzMTIyZjIyMDdiOWU3Yzli ODYzMmY4MmVkOWJmYWQ5Y2MyNS4uMTFkZDQ3NjgyYmI0OWJhM2UwOTZhNWIwY2VlNzJmM2E1OWNl NzU1NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTExLTE0ICBOb2VsIEdvcmRvbiAgPG5v ZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBUZXN0IEpQRUcgaW1hZ2UgZGVjb2Rpbmcg UkdCIHBpeGVsIGVuZGlhbmVzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzIyMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBKUEVHIGltYWdlIFJHQiBwaXhlbHMgc2hvdWxkIHJlbmRlciB3aXRob3V0IGNv bG9yIGNvcnJ1cHRpb24gYW5kIGluIHN0cmljdAorICAgICAgICBvcmRlciwgcmVnYXJkbGVzcyBv ZiB0aGUgdW5kZXJseWluZyBtYWNoaW5lIHBpeGVsIGJ1ZmZlciBlbmRpYW5lc3MuCisKKyAgICAg ICAgKiBmYXN0L2ltYWdlcy9yZXNvdXJjZXMvcmdiLWpwZWctYmx1ZS5qcGc6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ncmVlbi5qcGc6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1yZWQuanBnOiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2ltYWdlcy9yZ2ItanBlZy1lbmRpYW4tcGl4ZWxzLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy5o dG1sOiBBZGRlZC4KKwogMjAxMS0xMS0xNCAgVG9ueSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IGZvbnRDYWNoZSgpLT5nZW5lcmF0 aW9uKCkgPT0gbV9nZW5lcmF0aW9uIChydW5uaW5nIG5ldy1ydW4td2Via2l0LXRlc3RzKQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL3JnYi1qcGVnLWJsdWUu anBnIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL3JnYi1qcGVnLWJsdWUuanBn Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjA0YjQ1ZDNlYmI0NmZiNjZiNzc2NzBjMGUwYzEwMjRiMjBkMmNiYTQKR0lU IGJpbmFyeSBwYXRjaApsaXRlcmFsIDY5NQp6Y21leD08TnBIJjBXVVhDSHdII1ZNdXIzK1djWXVa IUlePUhrcjlOVGZTSHZVMWxVK3VtfDVBYCp4NW10Z09pKCsKemdNKjhNb3Q9eDlpO0o1RjItckZL Xzw0RXdLeH5qOUFuaFBzSypZbnImSCsrRTh1KSpKTDZDI05meCZeOVFIZztgCnprZGF4Q0AmNkc5 Yz9KZVhSLWtKXjR1JTNvQ1QxMl5IbFVOWnhQYzBgM0lMdFklKitJSUVHcjhPUDwxVShvYEZTPgp6 Ulk9aiRreGUpLWt6SmAhI0hleE5MSm5vOGpSIUA4RWBDcmtQQVkyUjxQc0I/a2QjdFlRYGdZY0dC R3RYeDNJS3cKemM1IXVjX3dlKXo0aGFubGtCRSMpUER4RW0mJmJSd0UtNVc1dWMpa1FaZlJ8NkA5 NkJCRzxuTEBZMTMhU29WOTUyCnpsQkxVKnVVTlRpKTg7Syh3ezczQ2JKd0I2TX4pc2xlJlhiKk9Q OC0peT58Vl4mMDd5Mkokfn1eKzRDMUtVdyE9YQp6YE9EWEQtKyVvNDFAYWRvMTJlPjFhRyM8MU9B elFVQ1NWK311IUg9PyRXI3UqJXpgWWVpaVRgTGopQ2xuZ35DY2sKempUfENRNkJsa2ckZjt9YF5n JVNLPXB2VnhpcGZMT2swN3NzZU1YJGVuI2w0USsrenJULUQyUWpXJn1uYXZtaz4jClkhPUtfc1VE fCpEKmxUbFhFTlVQWit5QjFfMDczKVQoRXREZAoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmVzb3VyY2VzL3JnYi1qcGVnLWdyZWVu LmpwZyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1ncmVlbi5q cGcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMTlhMGQyNGU3YjMyM2VjMTFiOTA3OTkxODY4Nzc0MDcwYzU4ODQ1ZQpH SVQgYmluYXJ5IHBhdGNoCmxpdGVyYWwgNjk1CnpjbWV4PTxOcEgmMFdVWENId0gjVk11cjMrV2NZ dVohSV49SGtyOU5UZlNIdlUxbFUrdW18NUFgKng1bXRnT2koKwp6Z00qOE1vdD14OWk7SjVGMi1y RktfPDRFd0t4fmo5QW5oUHNLKlluciZIKytFOHUpKkpMNkMjTmZ4Jl45UUhnO2AKemtkYXhDQCY2 RzljP0plWFIta0peNHUlM29DVDEyXkhsVU5aeFBjMGAzSUx0WSUqK0lJRUdyOE9QPDFVKG9gRlM+ CnpSWT1qJGt4ZSkta3pKYCEjSGV4TkxKbm84alIhQDhFYENya1BBWTJSPFBzQj9rZCN0WVFgZ1lj R0JHdFh4M0lLdwp6YzUhdWNfd2UpejRoYW5sa0JFIylQRHhFbSYmYlJ3RS01VzV1YylrUVpmUnw2 QDk2QkJHPG5MQFkxMyFTb1Y5NTIKemxCTFUqdVVOVGkpODtLKHd7NzNDYkp3QjZNfilzbGUmWGIq T1A4LSl5PnxWXiYwN3kySiR+fV4rNEMxS1V3IT1hCnpgT0RYRC0rJW80MUBhZG8xMmU+MWFHIzwx T0F6UVVDU1YrfXUhSD0/JFcjdSolemBZZWlpVGBMailDbG5nfkNjawp6alR8Q1E2QmxrZyRmO31g XmclU0s9cHZWeGlwZkxPazA3c3NlTVgkZW4jbDRRKyt6clQtRDJRalcmfW5hdm1rPiMKWSFgQ2oy TWYqPkV7dTlpbHY4YUp1WjIkaXowRFVVaHlaYF9JCgpsaXRlcmFsIDAKSGNtVj9kMDAwMDEKCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9yZXNvdXJjZXMvcmdiLWpwZWctcmVk LmpwZyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL3Jlc291cmNlcy9yZ2ItanBlZy1yZWQuanBn Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjlhNjlkYmJlNTljYmVmYjM4YzVjNDljYTAyYmM2OTE4MTE1YmY5ODgKR0lU IGJpbmFyeSBwYXRjaApsaXRlcmFsIDY5NQp6Y21leD08TnBIJjBXVVhDSHdII1ZNdXIzK1djWXVa IUlePUhrcjlOVGZTSHZVMWxVK3VtfDVBYCp4NW10Z09pKCsKemdNKjhNb3Q9eDlpO0o1RjItckZL Xzw0RXdLeH5qOUFuaFBzSypZbnImSCsrRTh1KSpKTDZDI05meCZeOVFIZztgCnprZGF4Q0AmNkc5 Yz9KZVhSLWtKXjR1JTNvQ1QxMl5IbFVOWnhQYzBgM0lMdFklKitJSUVHcjhPUDwxVShvYEZTPgp6 Ulk9aiRreGUpLWt6SmAhI0hleE5MSm5vOGpSIUA4RWBDcmtQQVkyUjxQc0I/a2QjdFlRYGdZY0dC R3RYeDNJS3cKemM1IXVjX3dlKXo0aGFubGtCRSMpUER4RW0mJmJSd0UtNVc1dWMpa1FaZlJ8NkA5 NkJCRzxuTEBZMTMhU29WOTUyCnpsQkxVKnVVTlRpKTg7Syh3ezczQ2JKd0I2TX4pc2xlJlhiKk9Q OC0peT58Vl4mMDd5Mkokfn1eKzRDMUtVdyE9YQp6YE9EWEQtKyVvNDFAYWRvMTJlPjFhRyM8MU9B elFVQ1NWK311IUg9PyRXI3UqJXpgWWVpaVRgTGopQ2xuZ35DY2sKempUfENRNkJsa2ckZjt9YF5n JVNLPXB2VnhpcGZMT2swN3NzZU1YJGVuI2w0USsrenJULUQyUWpXJn1uYXZtaz4jClkhO2dKazh0 YjFMfE5YPEl2OGFKdVoyJGl6MEQ+eW0mO1M0YwoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9yZ2ItanBlZy1lbmRpYW4tcGl4 ZWxzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZjYyNGJiMzEyODhlNWE2NTY3OWIzMTYyOTQ5 OTVkZjA0M2U4ZWQyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMv cmdiLWpwZWctZW5kaWFuLXBpeGVscy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitKUEVH IGltYWdlIFJHQiBwaXhlbHMgc2hvdWxkIHJlbmRlciB3aXRob3V0IGNvbG9yIGNvcnJ1cHRpb24g YW5kIGluIHN0cmljdAorb3JkZXIsIHJlZ2FyZGxlc3Mgb2YgdGhlIHVuZGVybHlpbmcgbWFjaGlu ZSBwaXhlbCBidWZmZXIgZW5kaWFuZXNzLgorCisgIAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9pbWFnZXMvcmdiLWpwZWctZW5kaWFuLXBpeGVscy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY4 Y2Y5NDAzOGE2NTE0NTI2MzgxZTAyZjAwNTQ2Yzk5NDQ0YmM4MGMKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9yZ2ItanBlZy1lbmRpYW4tcGl4ZWxzLmh0bWwKQEAg LTAsMCArMSw3NiBAQAorPCFET0NUWVBFIGh0bWw+CitKUEVHIGltYWdlIFJHQiBwaXhlbHMgc2hv dWxkIHJlbmRlciB3aXRob3V0IGNvbG9yIGNvcnJ1cHRpb24gYW5kIGluIHN0cmljdDxicj4KK29y ZGVyLCByZWdhcmRsZXNzIG9mIHRoZSB1bmRlcmx5aW5nIG1hY2hpbmUgcGl4ZWwgYnVmZmVyIGVu ZGlhbmVzcy48YnI+PGJyPgorCis8aW1nIHNyYz0icmVzb3VyY2VzL3JnYi1qcGVnLXJlZC5qcGci ICAgb25sb2FkPSJ0ZXN0KHRoaXMsIFsyNTUsMCwwLDI1NV0pIj4KKzxpbWcgc3JjPSJyZXNvdXJj ZXMvcmdiLWpwZWctZ3JlZW4uanBnIiBvbmxvYWQ9InRlc3QodGhpcywgWzAsMjU1LDAsMjU1XSki PgorPGltZyBzcmM9InJlc291cmNlcy9yZ2ItanBlZy1ibHVlLmpwZyIgIG9ubG9hZD0idGVzdCh0 aGlzLCBbMCwwLDI1NSwyNTVdKSI+CisKKzxwcmUgaWQ9ImxvZyI+UEFTUzwvcHJlPgorCis8c2Ny aXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgd2luZG93LmxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKworZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCit7Cisg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLnRleHRDb250ZW50ICs9ICdcbicgKyBt ZXNzYWdlOworfQorCitmdW5jdGlvbiBhdmVyYWdlUGl4ZWxDb21wb25lbnRzKGRhdGEsIHNpemUp Cit7CisgICAgdmFyIHIgPSAwLCBnID0gMCwgYiA9IDAsIGEgPSAwOworICAgIGZvciAodmFyIGkg PSAwLCB0b3RhbCA9IHNpemUgKiA0OyBpIDwgdG90YWw7IGkgKz0gNCkgeworICAgICAgICByICs9 IGRhdGFbaSArIDBdOworICAgICAgICBnICs9IGRhdGFbaSArIDFdOworICAgICAgICBiICs9IGRh dGFbaSArIDJdOworICAgICAgICBhICs9IGRhdGFbaSArIDNdOworICAgIH0KKworICAgIHJldHVy biBbciAvIHNpemUsIGcgLyBzaXplLCBiIC8gc2l6ZSwgYSAvIHNpemVdOworfQorCitmdW5jdGlv biBhdmVyYWdlUGl4ZWxTaG91bGRCZShwaXhlbCwgZXhwZWN0LCB0b2xlcmFuY2UpCit7CisgICAg dmFyIGRlbHRhID0gMDsKKyAgICBwaXhlbC5mb3JFYWNoKGZ1bmN0aW9uKGNvbXBvbmVudCwgaSkg eworICAgICAgICBkZWx0YSA9IE1hdGgubWF4KE1hdGguYWJzKHBpeGVsW2ldIC0gZXhwZWN0W2ld KSwgZGVsdGEpOworICAgIH0pOworCisgICAgaWYgKGRlbHRhID4gdG9sZXJhbmNlKQorICAgICAg IGxvZygnRkFJTDogWycgKyBwaXhlbCArICddIGV4cGVjdGVkIFsnICsgZXhwZWN0ICsgJ10gKy8t ICcgKyB0b2xlcmFuY2UpOworfQorCitmdW5jdGlvbiB0ZXN0SW1hZ2UoaW1hZ2UsIGV4cGVjdCkK K3sKKyAgICAvLyBDcmVhdGUgYSBjYW52YXMsIGxvYWQgdGhlIGdpdmVuIGltYWdlIGluIGl0Lgor ICAgIHZhciBjYW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJjYW52YXMiKTsKKyAgICBj YW52YXMud2lkdGggPSBjYW52YXMuaGVpZ2h0ID0gNjQ7CisgICAgdmFyIGNvbnRleHQgPSBjYW52 YXMuZ2V0Q29udGV4dCgiMmQiKTsKKyAgICBjb250ZXh0LmRyYXdJbWFnZShpbWFnZSwgMCwgMCk7 CisKKyAgICAvLyBDb21wYXJlIHRoZSBjYW52YXMgcGl4ZWwgY29tcG9uZW50IGF2ZXJhZ2VzLgor ICAgIHZhciBwaXhlbHMgPSBjb250ZXh0LmdldEltYWdlRGF0YSgwLCAwLCA2NCwgNjQpLmRhdGE7 CisgICAgdmFyIHJlc3VsdCA9IGF2ZXJhZ2VQaXhlbENvbXBvbmVudHMocGl4ZWxzLCA2NCAqIDY0 KTsKKworICAgIHZhciBwaXhlbFRvbGVyYW5jZSA9IDM7CisgICAgYXZlcmFnZVBpeGVsU2hvdWxk QmUocmVzdWx0LCBleHBlY3QsIHBpeGVsVG9sZXJhbmNlKTsKK30KKworZnVuY3Rpb24gdGVzdChp bWFnZSwgZXhwZWN0KQoreworICAgIHRyeSB7CisgICAgICAgIGxvYWRlZEltYWdlcyA9IHdpbmRv dy5sb2FkZWRJbWFnZXMgfHwgMDsKKyAgICAgICAgdGVzdEltYWdlKGltYWdlLCBleHBlY3QpOwor ICAgICAgICBpZiAoKytsb2FkZWRJbWFnZXMgPCAzKQorICAgICAgICAgICAgcmV0dXJuOworICAg IH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgbG9nKCdGQUlMOiAnICsgZS5tZXNzYWdlKTsKKyAgICB9 CisKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICB3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cg==