72217 2011-11-12 13:46:06 -0800 REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off) 2011-11-12 14:13:57 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz oldest_to_newest 501462 0 mitz 2011-11-12 13:46:06 -0800 REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off) 501463 1 mitz 2011-11-12 13:47:38 -0800 <rdar://problem/10294191> * SUMMARY In WebKit2 windows, the Lookup bubble does not line up exactly with the text. Its top is two pixels above where it should be, and the content is shifted up by two pixels. * NOTES Sometimes it’s only off by one, and sometimes the bubble height is wrong as well. 501464 2 114842 mitz 2011-11-12 13:50:17 -0800 Created attachment 114842 Use the WebCore::Font’s ascender height instead of the derived NSFont’s ascender. 501466 3 mitz 2011-11-12 14:13:57 -0800 Fixed in <http://trac.webkit.org/r100083>. 114842 2011-11-12 13:50:17 -0800 2011-11-12 14:12:16 -0800 Use the WebCore::Font’s ascender height instead of the derived NSFont’s ascender. bug-72217-20111112135015.patch text/plain 2585 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDA4MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTEyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMjk0 MTkxPiBSRUdSRVNTSU9OIChXZWJLaXQyKTogTG9va3VwIGJ1YmJsZSBzaXplZCBhbmQgcG9zaXRp b25lZCBpbmNvcnJlY3RseSAodmVydGljYWxseSBvZmYpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudElt cGwubW06CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpkaWRQZXJmb3JtRGljdGlv bmFyeUxvb2t1cCk6IFJhdGhlciB0aGFuIGFkZGluZyB0aGUgTlNGb2504oCZcyBhc2NlbmRlcgor ICAgICAgICB0byB0aGUgdG9wIG9mIHRoZSB0ZXh0IHJlY3QgdG8gZXN0YWJsaXNoIHRoZSBiYXNl bGluZSBoZXJlLi4uCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFj Lm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpwZXJmb3JtRGljdGlvbmFyeUxvb2t1cEZv clJhbmdlKTogLi4uZG8gaXQgaGVyZSwgdXNpbmcgdGhlIFdlYkNvcmU6OkZvbnTigJlzCisgICAg ICAgIGFzY2VuZGVyLCB3aGljaCBpcyB3aGF04oCZcyBhY3R1YWxseSB1c2VkIHdoZW4gZHJhd2lu ZyB0aGUgdGV4dC4KKwogMjAxMS0xMS0xMSAgTmF5YW4gS3VtYXIgSyAgPG5heWFua2tAbW90b3Jv bGEuY29tPgogCiAgICAgICAgIFtHVEtdW1dFQktJVDJdIEFkZCBmb250IGFuZCBjaGFyc2V0IHBy b3BlcnRpZXMgdG8gV2ViS2l0V2ViU2V0dGluZ3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiA5OTkyNSkK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC00MDYsOCArNDA2LDcgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6ZGlk UGVyZm9ybURpY3Rpb25hcgogICAgIFthdHRyaWJ1dGVkU3RyaW5nLmdldCgpIGFkZEF0dHJpYnV0 ZTpOU0ZvbnRBdHRyaWJ1dGVOYW1lIHZhbHVlOmZvbnQgcmFuZ2U6TlNNYWtlUmFuZ2UoMCwgW2F0 dHJpYnV0ZWRTdHJpbmcuZ2V0KCkgbGVuZ3RoXSldOwogCiAgICAgTlNQb2ludCB0ZXh0QmFzZWxp bmVPcmlnaW4gPSBkaWN0aW9uYXJ5UG9wdXBJbmZvLm9yaWdpbjsKLSAgICB0ZXh0QmFzZWxpbmVP cmlnaW4ueSArPSBbZm9udCBhc2NlbmRlcl07Ci0gICAgCisKICNpZiAhZGVmaW5lZChCVUlMRElO R19PTl9TTk9XX0xFT1BBUkQpCiAgICAgLy8gQ29udmVydCB0byBzY3JlZW4gY29vcmRpbmF0ZXMu CiAgICAgdGV4dEJhc2VsaW5lT3JpZ2luID0gW21fd2tWaWV3IGNvbnZlcnRQb2ludDp0ZXh0QmFz ZWxpbmVPcmlnaW4gdG9WaWV3Om5pbF07CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCShyZXZpc2lvbiA5OTkyNSkKKysr IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkod29y a2luZyBjb3B5KQpAQCAtNTM5LDcgKzUzOSw3IEBAIHZvaWQgV2ViUGFnZTo6cGVyZm9ybURpY3Rp b25hcnlMb29rdXBGb3IKICAgICAKICAgICBEaWN0aW9uYXJ5UG9wdXBJbmZvIGRpY3Rpb25hcnlQ b3B1cEluZm87CiAgICAgZGljdGlvbmFyeVBvcHVwSW5mby50eXBlID0gdHlwZTsKLSAgICBkaWN0 aW9uYXJ5UG9wdXBJbmZvLm9yaWdpbiA9IEZsb2F0UG9pbnQocmFuZ2VSZWN0LngoKSwgcmFuZ2VS ZWN0LnkoKSk7CisgICAgZGljdGlvbmFyeVBvcHVwSW5mby5vcmlnaW4gPSBGbG9hdFBvaW50KHJh bmdlUmVjdC54KCksIHJhbmdlUmVjdC55KCkgKyBzdHlsZS0+Zm9udE1ldHJpY3MoKS5hc2NlbnQo KSk7CiAgICAgZGljdGlvbmFyeVBvcHVwSW5mby5mb250SW5mby5mb250QXR0cmlidXRlRGljdGlv bmFyeSA9IGZvbnREZXNjcmlwdG9yQXR0cmlidXRlczsKICNpZiAhZGVmaW5lZChCVUlMRElOR19P Tl9TTk9XX0xFT1BBUkQpCiAgICAgZGljdGlvbmFyeVBvcHVwSW5mby5vcHRpb25zID0gKENGRGlj dGlvbmFyeVJlZilvcHRpb25zOwo=