72193 2011-11-11 16:00:22 -0800 [Qt] Removing unneeded #ifdef from PopupMenuQt.cpp 2011-11-11 18:58:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Normal --- 1 luiz luiz hausmann webkit.review.bot oldest_to_newest 501193 0 luiz 2011-11-11 16:00:22 -0800 Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although this code is not related to the class QComboBox. 501198 1 114794 luiz 2011-11-11 16:06:09 -0800 Created attachment 114794 patch 501313 2 114794 webkit.review.bot 2011-11-11 18:58:25 -0800 Comment on attachment 114794 patch Clearing flags on attachment: 114794 Committed r100061: <http://trac.webkit.org/changeset/100061> 501314 3 webkit.review.bot 2011-11-11 18:58:30 -0800 All reviewed patches have been landed. Closing bug. 114794 2011-11-11 16:06:09 -0800 2011-11-11 18:58:25 -0800 patch 0001-Qt-Removing-unneeded-ifdef-from-PopupMenuQt.cpp.patch text/plain 2269 luiz RnJvbSBmN2Q4ZmVlYjhiMzE5NWMxYjk0OWQ0YzA0YWQwNTdjMWEwMDBhYjJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQHBhbG0uY29t PgpEYXRlOiBGcmksIDExIE5vdiAyMDExIDE2OjA0OjA4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0g W1F0XSBSZW1vdmluZyB1bm5lZWRlZCAjaWZkZWYgZnJvbSBQb3B1cE1lbnVRdC5jcHAKIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjE5MwoKUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgpQYXJ0IG9mIFBvcHVwTWVudVF0LmNwcCBjb2RlIGlzIGd1YXJkZWQgYnkg I2lmbmRlZiBRVF9OT19DT01CT0JPWCBhbHRob3VnaCB0aGF0CmNvZGUgaXMgbm90IHJlbGF0ZWQg dG8gdGhlIGNsYXNzIFFDb21ib0JveC4KCiogV2ViQ29yZVN1cHBvcnQvUG9wdXBNZW51UXQuY3Bw OgooV2ViQ29yZTo6UG9wdXBNZW51UXQ6OnNob3cpOgotLS0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hh bmdlTG9nICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBTb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0LmNwcCB8ICAgIDMgLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxv ZwppbmRleCA4OGY2MTBlLi40MTFiNGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDExLTExLTExICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBwYWxtLmNvbT4KKwor ICAgICAgICBbUXRdIFJlbW92aW5nIHVubmVlZGVkICNpZmRlZiBmcm9tIFBvcHVwTWVudVF0LmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxOTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJ0IG9m IFBvcHVwTWVudVF0LmNwcCBjb2RlIGlzIGd1YXJkZWQgYnkgI2lmbmRlZiBRVF9OT19DT01CT0JP WCBhbHRob3VnaCB0aGF0CisgICAgICAgIGNvZGUgaXMgbm90IHJlbGF0ZWQgdG8gdGhlIGNsYXNz IFFDb21ib0JveC4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudVF0OjpzaG93KToKKwogMjAxMS0xMS0xMSAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjk5OTY0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9Qb3B1cE1lbnVRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVT dXBwb3J0L1BvcHVwTWVudVF0LmNwcAppbmRleCA0NTI0MDBiLi4wN2M0OTZhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BvcHVwTWVudVF0LmNwcApAQCAtMjksNyAr MjksNiBAQAogI2luY2x1ZGUgIkNocm9tZUNsaWVudFF0LmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3 LmgiCiAjaW5jbHVkZSAiUG9wdXBNZW51Q2xpZW50LmgiCi0jaW5jbHVkZSAiUXRGYWxsYmFja1dl YlBvcHVwLmgiCiAKICNpbmNsdWRlICJxd2Via2l0cGxhdGZvcm1wbHVnaW4uaCIKIApAQCAtOTcs NyArOTYsNiBAQCB2b2lkIFBvcHVwTWVudVF0OjpkaXNjb25uZWN0Q2xpZW50KCkKIAogdm9pZCBQ b3B1cE1lbnVRdDo6c2hvdyhjb25zdCBJbnRSZWN0JiByZWN0LCBGcmFtZVZpZXcqIHZpZXcsIGlu dCBpbmRleCkKIHsKLSNpZm5kZWYgUVRfTk9fQ09NQk9CT1gKICAgICBpZiAoIW1fcG9wdXBDbGll bnQpCiAgICAgICAgIHJldHVybjsKIApAQCAtMTE0LDcgKzExMiw2IEBAIHZvaWQgUG9wdXBNZW51 UXQ6OnNob3coY29uc3QgSW50UmVjdCYgcmVjdCwgRnJhbWVWaWV3KiB2aWV3LCBpbnQgaW5kZXgp CiAKICAgICBtX3NlbGVjdERhdGEgPSBhZG9wdFB0cihuZXcgU2VsZWN0RGF0YShtX3BvcHVwQ2xp ZW50KSk7CiAgICAgbV9wb3B1cC0+c2hvdygqbV9zZWxlY3REYXRhLmdldCgpKTsKLSNlbmRpZgog fQogCiB2b2lkIFBvcHVwTWVudVF0OjpkaWRIaWRlKCkKLS0gCjEuNy43LjIKCg==