72188 2011-11-11 14:47:52 -0800 Expose compositeAndReadback in WebLayerTreeView 2011-11-14 16:51:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 vollick webkit-unassigned fishd jamesr piman webkit.review.bot oldest_to_newest 501123 0 vollick 2011-11-11 14:47:52 -0800 Expose compositeAndReadback in WebLayerTreeView 501131 1 114777 vollick 2011-11-11 14:56:26 -0800 Created attachment 114777 Patch 501134 2 webkit.review.bot 2011-11-11 14:58:34 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 501162 3 piman 2011-11-11 15:24:43 -0800 View in context: https://bugs.webkit.org/attachment.cgi?id=114777&action=review > Source/WebKit/chromium/public/WebLayerTreeView.h:86 > + int height); WebKit is not subject to the 80 cols restrictions, so you can make it a single line. > Source/WebKit/chromium/src/WebLayerTreeView.cpp:90 > + int height) Single line > Source/WebKit/chromium/src/WebLayerTreeView.cpp:93 > + pixels, WebCore::IntRect(0, 0, width, height)); Single line 501173 4 114777 jamesr 2011-11-11 15:34:08 -0800 Comment on attachment 114777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114777&action=review > Source/WebKit/chromium/public/WebLayerTreeView.h:86 > + int width, > + int height); this should not line wrap and it should use a WebSize parameter instead of a pair of ints can you document the ownership model and requirements of the pixels buffer, and what goes into them (pretty sure it's rgba values) you also need to document the return value and what happens to *pixels when this function returns false > Source/WebKit/chromium/src/WebLayerTreeView.cpp:93 > + pixels, WebCore::IntRect(0, 0, width, height)); don't line wrap this either 501190 5 114792 vollick 2011-11-11 15:58:18 -0800 Created attachment 114792 Patch 501596 6 114792 fishd 2011-11-13 20:40:00 -0800 Comment on attachment 114792 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114792&action=review > Source/WebKit/chromium/src/WebLayerTreeView.cpp:91 > + return m_private->compositeAndReadback(pixels, WebCore::IntRect(0, 0, size.width, size.height)); any reason not to expose the underlying subset capability? WebKit API changes LGTM 501900 7 114947 vollick 2011-11-14 07:35:55 -0800 Created attachment 114947 Patch 501902 8 vollick 2011-11-14 07:37:48 -0800 fishd: There was not a good reason for not exposing the subset functionality. It's now exposed. 502468 9 114947 webkit.review.bot 2011-11-14 16:51:47 -0800 Comment on attachment 114947 Patch Clearing flags on attachment: 114947 Committed r100217: <http://trac.webkit.org/changeset/100217> 502469 10 webkit.review.bot 2011-11-14 16:51:51 -0800 All reviewed patches have been landed. Closing bug. 114777 2011-11-11 14:56:26 -0800 2011-11-11 15:58:07 -0800 Patch bug-72188-20111111175624.patch text/plain 2556 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4YjdlNGIzMDAwN2Q1NDM0NDQzMWQ2MmQwMWFiZjBjZmZkN2I2ZWQuLjNhNTJhZGExNGUwNzJj NTBlMDkyYWUyM2U5MjBjODBmMDk1NjdjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMTEgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgRXhwb3NlIGNvbXBvc2l0ZUFuZFJlYWRiYWNrIGluIFdlYkxheWVy VHJlZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcyMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAqIHNyYy9XZWJMYXllclRyZWVW aWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlVmlldzo6Y29tcG9zaXRlQW5k UmVhZGJhY2spOgorCiAyMDExLTExLTExICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTAwMDEwLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmll dy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCmlu ZGV4IGFhOGIyMTM5MGUwZTk5NTNiZTE4NjRkMjAwMjQzYjRiNWIwNDM5NTMuLmRkOGYzNTI2NTk1 NDI2MzdjZmU4ZDA2OTRmMzVjOGM4YWJhYjEyOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKQEAgLTgxLDYgKzgxLDEwIEBAIHB1Ymxp YzoKICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgc2V0Vmlld3BvcnRTaXplKGNvbnN0IFdlYlNpemUm KTsKICAgICBXRUJLSVRfRVhQT1JUIFdlYlNpemUgdmlld3BvcnRTaXplKCkgY29uc3Q7CiAKKyAg ICBXRUJLSVRfRVhQT1JUIGJvb2wgY29tcG9zaXRlQW5kUmVhZGJhY2sodm9pZCAqcGl4ZWxzLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgd2lkdGgsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBoZWlnaHQpOwor CiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgV2ViTGF5ZXJUcmVlVmlldyhjb25zdCBX VEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0PiYpOwogICAgIFdlYkxheWVy VHJlZVZpZXcmIG9wZXJhdG9yPShjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6Q0NMYXll clRyZWVIb3N0PiYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi TGF5ZXJUcmVlVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRy ZWVWaWV3LmNwcAppbmRleCAwMmQ2Y2E2MjVhYmE5YTNhZTM1NmJiNjc5MTdlMzUyNzlkM2U2Yzdl Li5lYTMxNjlhN2ZiOGY5OGY2NGYxNjQ0MmQ4MTA0YmIxYjE5YTcyYTZjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVWaWV3LmNwcApAQCAtMjYsNiArMjYs NyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYkxheWVyVHJlZVZpZXcuaCIK IAorI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRlICJXZWJMYXllclRyZWVWaWV3SW1wbC5o IgogI2luY2x1ZGUgIldlYlNpemUuaCIKICNpbmNsdWRlICJjYy9DQ0xheWVyVHJlZUhvc3QuaCIK QEAgLTg0LDYgKzg1LDE0IEBAIFdlYlNpemUgV2ViTGF5ZXJUcmVlVmlldzo6dmlld3BvcnRTaXpl KCkgY29uc3QKICAgICByZXR1cm4gV2ViU2l6ZShtX3ByaXZhdGUtPnZpZXdwb3J0U2l6ZSgpKTsK IH0KIAorYm9vbCBXZWJMYXllclRyZWVWaWV3Ojpjb21wb3NpdGVBbmRSZWFkYmFjayh2b2lkICpw aXhlbHMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCB3 aWR0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGhl aWdodCkKK3sKKyAgICByZXR1cm4gbV9wcml2YXRlLT5jb21wb3NpdGVBbmRSZWFkYmFjaygKKyAg ICAgICAgcGl4ZWxzLCBXZWJDb3JlOjpJbnRSZWN0KDAsIDAsIHdpZHRoLCBoZWlnaHQpKTsKK30K KwogV2ViTGF5ZXJUcmVlVmlldzo6V2ViTGF5ZXJUcmVlVmlldyhjb25zdCBQYXNzUmVmUHRyPEND TGF5ZXJUcmVlSG9zdD4mIG5vZGUpCiAgICAgOiBtX3ByaXZhdGUobm9kZSkKIHsK 114792 2011-11-11 15:58:18 -0800 2011-11-14 07:35:48 -0800 Patch bug-72188-20111111185816.patch text/plain 2818 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4YjdlNGIzMDAwN2Q1NDM0NDQzMWQ2MmQwMWFiZjBjZmZkN2I2ZWQuLjNhNTJhZGExNGUwNzJj NTBlMDkyYWUyM2U5MjBjODBmMDk1NjdjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMTEgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgRXhwb3NlIGNvbXBvc2l0ZUFuZFJlYWRiYWNrIGluIFdlYkxheWVy VHJlZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcyMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAqIHNyYy9XZWJMYXllclRyZWVW aWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlVmlldzo6Y29tcG9zaXRlQW5k UmVhZGJhY2spOgorCiAyMDExLTExLTExICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTAwMDEwLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmll dy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCmlu ZGV4IGFhOGIyMTM5MGUwZTk5NTNiZTE4NjRkMjAwMjQzYjRiNWIwNDM5NTMuLjc1OTAwNjc5MjUy Zjc3YzdlOGMzYTAzMWVmZWY3ZTE2YTFlYjYwY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKQEAgLTgxLDYgKzgxLDE0IEBAIHB1Ymxp YzoKICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgc2V0Vmlld3BvcnRTaXplKGNvbnN0IFdlYlNpemUm KTsKICAgICBXRUJLSVRfRVhQT1JUIFdlYlNpemUgdmlld3BvcnRTaXplKCkgY29uc3Q7CiAKKyAg ICAvLyBDb21wb3NpdGVzIGFuZCBhdHRlbXB0cyB0byByZWFkIGJhY2sgdGhlIHJlc3VsdCBpbnRv IHRoZSBwcm92aWRlZAorICAgIC8vIGJ1ZmZlci4gSWYgaXQgd2Fzbid0IHBvc3NpYmxlLCBlLmcu IGR1ZSB0byBjb250ZXh0IGxvc3QsIHdpbGwgcmV0dXJuCisgICAgLy8gZmFsc2UuIFBpeGVsIGZv cm1hdCBpcyAzMmJpdCAoUkdCQSksIGFuZCB0aGUgcHJvdmlkZWQgYnVmZmVyIG11c3QgYmUKKyAg ICAvLyBsYXJnZSBlbm91Z2ggY29udGFpbiB2aWV3cG9ydFNpemUoKS53aWR0aCgpICogdmlld3Bv cnRTaXplKCkuaGVpZ2h0KCkKKyAgICAvLyBwaXhlbHMuIFRoZSBXZWJMYXllclRyZWVWaWV3IGRv ZXMgbm90IGFzc3VtZSBvd25lcnNoaXAgb2YgdGhlIGJ1ZmZlci4KKyAgICAvLyBUaGUgYnVmZmVy IGlzIG5vdCBtb2RpZmllZCBpZiB0aGUgZmFsc2UgaXMgcmV0dXJuZWQuCisgICAgV0VCS0lUX0VY UE9SVCBib29sIGNvbXBvc2l0ZUFuZFJlYWRiYWNrKHZvaWQgKnBpeGVscyk7CisKICNpZiBXRUJL SVRfSU1QTEVNRU5UQVRJT04KICAgICBXZWJMYXllclRyZWVWaWV3KGNvbnN0IFdURjo6UGFzc1Jl ZlB0cjxXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q+Jik7CiAgICAgV2ViTGF5ZXJUcmVlVmlldyYg b3BlcmF0b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q+ Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJMYXllclRyZWVW aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3Bw CmluZGV4IDAyZDZjYTYyNWFiYTlhM2FlMzU2YmI2NzkxN2UzNTI3OWQzZTZjN2UuLmNjNzdkYjFi NDBiM2FhY2Q5ZDhlNzExZTBhMmQ5ODBkMGIzMWM0NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5j bHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViTGF5ZXJUcmVlVmlldy5oIgogCisjaW5jbHVk ZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIldlYkxheWVyVHJlZVZpZXdJbXBsLmgiCiAjaW5jbHVk ZSAiV2ViU2l6ZS5oIgogI2luY2x1ZGUgImNjL0NDTGF5ZXJUcmVlSG9zdC5oIgpAQCAtODQsNiAr ODUsMTIgQEAgV2ViU2l6ZSBXZWJMYXllclRyZWVWaWV3Ojp2aWV3cG9ydFNpemUoKSBjb25zdAog ICAgIHJldHVybiBXZWJTaXplKG1fcHJpdmF0ZS0+dmlld3BvcnRTaXplKCkpOwogfQogCitib29s IFdlYkxheWVyVHJlZVZpZXc6OmNvbXBvc2l0ZUFuZFJlYWRiYWNrKHZvaWQgKnBpeGVscykKK3sK KyAgICBjb25zdCBXZWJTaXplJiBzaXplID0gdmlld3BvcnRTaXplKCk7CisgICAgcmV0dXJuIG1f cHJpdmF0ZS0+Y29tcG9zaXRlQW5kUmVhZGJhY2socGl4ZWxzLCBXZWJDb3JlOjpJbnRSZWN0KDAs IDAsIHNpemUud2lkdGgsIHNpemUuaGVpZ2h0KSk7Cit9CisKIFdlYkxheWVyVHJlZVZpZXc6Oldl YkxheWVyVHJlZVZpZXcoY29uc3QgUGFzc1JlZlB0cjxDQ0xheWVyVHJlZUhvc3Q+JiBub2RlKQog ICAgIDogbV9wcml2YXRlKG5vZGUpCiB7Cg== 114947 2011-11-14 07:35:55 -0800 2011-11-14 16:51:46 -0800 Patch bug-72188-20111114103553.patch text/plain 2917 vollick U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4YjdlNGIzMDAwN2Q1NDM0NDQzMWQ2MmQwMWFiZjBjZmZkN2I2ZWQuLjNhNTJhZGExNGUwNzJj NTBlMDkyYWUyM2U5MjBjODBmMDk1NjdjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMTEgIElhbiBWb2xsaWNrICA8dm9sbGlja0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgRXhwb3NlIGNvbXBvc2l0ZUFuZFJlYWRiYWNrIGluIFdlYkxheWVy VHJlZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcyMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAqIHNyYy9XZWJMYXllclRyZWVW aWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTGF5ZXJUcmVlVmlldzo6Y29tcG9zaXRlQW5k UmVhZGJhY2spOgorCiAyMDExLTExLTExICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTAwMDEwLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmll dy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCmlu ZGV4IGFhOGIyMTM5MGUwZTk5NTNiZTE4NjRkMjAwMjQzYjRiNWIwNDM5NTMuLmNhMDhjZWQwNzRi OTQ5MzI0YmI5Y2MwNzQ4MTNkMmMyMWJmZTcxZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKQEAgLTM3LDYgKzM3LDcgQEAgc3RydWN0 IENDU2V0dGluZ3M7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIGNsYXNzIFdlYkxheWVyOwogY2xhc3Mg V2ViTGF5ZXJUcmVlVmlld0NsaWVudDsKK3N0cnVjdCBXZWJSZWN0Owogc3RydWN0IFdlYlNpemU7 CiAKIGNsYXNzIFdlYkxheWVyVHJlZVZpZXcgewpAQCAtODEsNiArODIsMTQgQEAgcHVibGljOgog ICAgIFdFQktJVF9FWFBPUlQgdm9pZCBzZXRWaWV3cG9ydFNpemUoY29uc3QgV2ViU2l6ZSYpOwog ICAgIFdFQktJVF9FWFBPUlQgV2ViU2l6ZSB2aWV3cG9ydFNpemUoKSBjb25zdDsKIAorICAgIC8v IENvbXBvc2l0ZXMgYW5kIGF0dGVtcHRzIHRvIHJlYWQgYmFjayB0aGUgcmVzdWx0IGludG8gdGhl IHByb3ZpZGVkCisgICAgLy8gYnVmZmVyLiBJZiBpdCB3YXNuJ3QgcG9zc2libGUsIGUuZy4gZHVl IHRvIGNvbnRleHQgbG9zdCwgd2lsbCByZXR1cm4KKyAgICAvLyBmYWxzZS4gUGl4ZWwgZm9ybWF0 IGlzIDMyYml0IChSR0JBKSwgYW5kIHRoZSBwcm92aWRlZCBidWZmZXIgbXVzdCBiZQorICAgIC8v IGxhcmdlIGVub3VnaCBjb250YWluIHZpZXdwb3J0U2l6ZSgpLndpZHRoKCkgKiB2aWV3cG9ydFNp emUoKS5oZWlnaHQoKQorICAgIC8vIHBpeGVscy4gVGhlIFdlYkxheWVyVHJlZVZpZXcgZG9lcyBu b3QgYXNzdW1lIG93bmVyc2hpcCBvZiB0aGUgYnVmZmVyLgorICAgIC8vIFRoZSBidWZmZXIgaXMg bm90IG1vZGlmaWVkIGlmIHRoZSBmYWxzZSBpcyByZXR1cm5lZC4KKyAgICBXRUJLSVRfRVhQT1JU IGJvb2wgY29tcG9zaXRlQW5kUmVhZGJhY2sodm9pZCAqcGl4ZWxzLCBjb25zdCBXZWJSZWN0Jik7 CisKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04KICAgICBXZWJMYXllclRyZWVWaWV3KGNvbnN0 IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3Q+Jik7CiAgICAgV2ViTGF5 ZXJUcmVlVmlldyYgb3BlcmF0b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpDQ0xh eWVyVHJlZUhvc3Q+Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJMYXllclRyZWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVy VHJlZVZpZXcuY3BwCmluZGV4IDAyZDZjYTYyNWFiYTlhM2FlMzU2YmI2NzkxN2UzNTI3OWQzZTZj N2UuLmM3NjhlMWE2NjI5NzdhZDYxYjQxMjVhOTU4NDMyNmQwYTU5ZjU3NWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkxheWVyVHJlZVZpZXcuY3BwCkBAIC0yNyw2ICsy Nyw3IEBACiAjaW5jbHVkZSAiV2ViTGF5ZXJUcmVlVmlldy5oIgogCiAjaW5jbHVkZSAiV2ViTGF5 ZXJUcmVlVmlld0ltcGwuaCIKKyNpbmNsdWRlICJXZWJSZWN0LmgiCiAjaW5jbHVkZSAiV2ViU2l6 ZS5oIgogI2luY2x1ZGUgImNjL0NDTGF5ZXJUcmVlSG9zdC5oIgogCkBAIC04NCw2ICs4NSwxMSBA QCBXZWJTaXplIFdlYkxheWVyVHJlZVZpZXc6OnZpZXdwb3J0U2l6ZSgpIGNvbnN0CiAgICAgcmV0 dXJuIFdlYlNpemUobV9wcml2YXRlLT52aWV3cG9ydFNpemUoKSk7CiB9CiAKK2Jvb2wgV2ViTGF5 ZXJUcmVlVmlldzo6Y29tcG9zaXRlQW5kUmVhZGJhY2sodm9pZCAqcGl4ZWxzLCBjb25zdCBXZWJS ZWN0JiByZWN0KQoreworICAgIHJldHVybiBtX3ByaXZhdGUtPmNvbXBvc2l0ZUFuZFJlYWRiYWNr KHBpeGVscywgcmVjdCk7Cit9CisKIFdlYkxheWVyVHJlZVZpZXc6OldlYkxheWVyVHJlZVZpZXco Y29uc3QgUGFzc1JlZlB0cjxDQ0xheWVyVHJlZUhvc3Q+JiBub2RlKQogICAgIDogbV9wcml2YXRl KG5vZGUpCiB7Cg==