72183 2011-11-11 14:20:33 -0800 Remove expected crashes for skia-gpu canvas from test expectations 2011-11-14 08:45:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon senorblanco webkit.review.bot oldest_to_newest 501096 0 bsalomon 2011-11-11 14:20:33 -0800 Remove expected crashes for skia-gpu canvas from test expectations 501101 1 114771 bsalomon 2011-11-11 14:21:25 -0800 Created attachment 114771 Patch 501118 2 bsalomon 2011-11-11 14:42:53 -0800 This has been fixed for a while. 501228 3 114771 senorblanco 2011-11-11 16:53:10 -0800 Comment on attachment 114771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114771&action=review > LayoutTests/platform/chromium/test_expectations.txt:-3730 > -BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT CRASH This test is still failing TEXT on Windows, I believe (thanks to my recent patch). Could you change line 3869 from MAC LINUX GPU to just GPU to accomodate WIN as well? Thanks. 501830 4 114925 bsalomon 2011-11-14 05:49:48 -0800 Created attachment 114925 Patch 501831 5 bsalomon 2011-11-14 05:50:33 -0800 (In reply to comment #3) > (From update of attachment 114771 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114771&action=review > > > LayoutTests/platform/chromium/test_expectations.txt:-3730 > > -BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT CRASH > > This test is still failing TEXT on Windows, I believe (thanks to my recent patch). Could you change line 3869 from MAC LINUX GPU to just GPU to accomodate WIN as well? Thanks. Sure, done. For some reason webkit-patch printed "Path does not exist." about every entry in test_expectations.txt. I don't think it has anything to do with my change though. 501835 6 webkit.review.bot 2011-11-14 05:57:46 -0800 Attachment 114925 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: tml [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3840: Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3842: Path does not exist. storage/indexeddb/key-type-array.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3844: Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3846: Path does not exist. fast/js/array-functions-non-arrays.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3847: Path does not exist. fast/js/eval-cross-window.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3848: Path does not exist. fast/js/regexp-caching.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3849: Path does not exist. fast/js/toString-overrides.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3850: Path does not exist. fast/js/toString-recursion.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3851: Path does not exist. http/tests/security/xss-eval.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3853: Path does not exist. fast/dom/javascript-url-exception-isolation.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3854: Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3856: Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3858: Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3860: Path does not exist. inspector/debugger/script-formatter.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3863: Path does not exist. fast/js/mozilla/strict/15.4.5.1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3865: Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3867: Path does not exist. media/track/tracklist-is-reachable.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3869: Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3870: Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3872: Path does not exist. http/tests/security/cross-frame-access-custom.html [test/expectations] [2] Total errors found: 2122 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 501901 7 114925 senorblanco 2011-11-14 07:36:50 -0800 Comment on attachment 114925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114925&action=review Thanks for the cleanup. r=me >> LayoutTests/platform/chromium/test_expectations.txt:3865 >> +BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT > > Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html [test/expectations] [2] Not sure what's going on with the style bot; those paths look fine to me. 501947 8 114925 webkit.review.bot 2011-11-14 08:45:24 -0800 Comment on attachment 114925 Patch Clearing flags on attachment: 114925 Committed r100148: <http://trac.webkit.org/changeset/100148> 501948 9 webkit.review.bot 2011-11-14 08:45:32 -0800 All reviewed patches have been landed. Closing bug. 114771 2011-11-11 14:21:25 -0800 2011-11-14 05:49:44 -0800 Patch bug-72183-20111111172123.patch text/plain 2376 bsalomon SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMDAyMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTExICBCcmlhbiBTYWxvbW9uICA8 YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgZXhwZWN0ZWQgY3Jhc2hlcyBm b3Igc2tpYS1ncHUgY2FudmFzIGZyb20gdGVzdCBleHBlY3RhdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMTgzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTEtMTEgIEJlbiBXZWxscyAgPGJlbndlbGxzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUgZXhwZWN0ZWQgcmVzdWx0cyBmb3IgY29tcG9z aXRlZCBjYW52YXMgb3BlcmF0aW9ucwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkocmV2aXNpb24gMTAwMDE4KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0zNzEyLDIyICszNzEyLDYgQEAgQlVHQ1IyOTE2NCBXSU4gTElOVVggOiBm YXN0L2ZyYW1lcy9zYW5kYgogCiBCVUdXSzY5OTk4IExJTlVYIFdJTiA6IHBsdWdpbnMvcmVmY291 bnQtbGVha3MuaHRtbCA9IFBBU1MgVEVYVAogQlVHV0s3MDAwMSBMSU5VWCBXSU4gOiBmYXN0L2lt YWdlcy9jb2xvci1qcGVnLXdpdGgtY29sb3ItcHJvZmlsZS5odG1sID0gRkFJTCBNSVNTSU5HCi0v LyBSYW5kb20gY3Jhc2ggb2YgY2FudmFzIHRlc3RzLgotQlVHV0s3MDAxMyBXSU4gR1BVIDogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC50cmFuc2Zvcm1hdGlvbi5yb3RhdGUud3JhcC5odG1sID0gUEFT UyBDUkFTSAotQlVHV0s3MDAxMyBXSU4gR1BVIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC50cmFu c2Zvcm1hdGlvbi5zZXRUcmFuc2Zvcm0uc2tld2VkLmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcw MDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9hcmMzNjAuaHRtbCA9IFBBU1MgQ1JBU0gKLUJVR1dL NzAwMTMgV0lOIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy1hcmMtMzYwLXdpbmRpbmcuaHRtbCA9 IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lOIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy1hcmMt Y29ubmVjdGluZy1saW5lLmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBm YXN0L2NhbnZhcy9jYW52YXMtZHJhd0ltYWdlLXNoYWRvdy5odG1sID0gUEFTUyBDUkFTSAotQlVH V0s3MDAxMyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWZpbGxQYXRoLWFscGhhLXNoYWRv dy5odG1sID0gUEFTUyBDUkFTSAotQlVHV0s3MDAxMyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2Fu dmFzLWZpbGxQYXRoLWdyYWRpZW50LXNoYWRvdy5odG1sID0gUEFTUyBDUkFTSAotQlVHV0s3MDAx MyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWZpbGxQYXRoLXBhdHRlcm4tc2hhZG93Lmh0 bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52YXMt ZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBm YXN0L2NhbnZhcy9jYW52YXMtbGFyZ2VkcmF3cy5odG1sID0gUEFTUyBDUkFTSAotQlVHV0s3MDAx MyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWxpbmVXaWR0aC1pbnRhY3QtYWZ0ZXItc3Ry b2tlUmVjdC5odG1sID0gUEFTUyBDUkFTSAotQlVHV0s3MDAxMyBXSU4gR1BVIDogZmFzdC9jYW52 YXMvY2FudmFzLXN0cm9rZVBhdGgtYWxwaGEtc2hhZG93Lmh0bWwgPSBQQVNTIENSQVNICi1CVUdX SzcwMDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52YXMtc3Ryb2tlUGF0aC1zaGFkb3cuaHRt bCA9IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lOIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy10 cmFuc2Zvcm1zLWZpbGxSZWN0LXNoYWRvdy5odG1sID0gVEVYVCBDUkFTSAogCiBCVUdWOF8xNzY4 IDogZmFzdC9qcy9kZWxldGUtc3ludGF4Lmh0bWwgPSBURVhUCiAK 114925 2011-11-14 05:49:48 -0800 2011-11-14 08:45:24 -0800 Patch bug-72183-20111114084947.patch text/plain 2794 bsalomon SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMDEzNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTE0ICBCcmlhbiBTYWxvbW9uICA8 YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgZXhwZWN0ZWQgY3Jhc2hlcyBm b3Igc2tpYS1ncHUgY2FudmFzIGZyb20gdGVzdCBleHBlY3RhdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMTgzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMTEtMTQgIFRvbnkgR2VudGlsY29yZSAgPHRvbnln QGNocm9taXVtLm9yZz4KIAogICAgICAgICBUZXN0cyBvY2Nhc2lvbmFsbHkgcmVwb3J0IG1pc3Np bmcgZXhwZWN0YXRpb25zCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiAxMDAxMzQpCisrKyBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTM3MTYsMjIgKzM3MTYsNiBAQCBCVUdDUjI5MTY0IFdJTiBMSU5VWCA6IGZhc3QvZnJh bWVzL3NhbmRiCiAKIEJVR1dLNjk5OTggTElOVVggV0lOIDogcGx1Z2lucy9yZWZjb3VudC1sZWFr cy5odG1sID0gUEFTUyBURVhUCiBCVUdXSzcwMDAxIExJTlVYIFdJTiA6IGZhc3QvaW1hZ2VzL2Nv bG9yLWpwZWctd2l0aC1jb2xvci1wcm9maWxlLmh0bWwgPSBGQUlMIE1JU1NJTkcKLS8vIFJhbmRv bSBjcmFzaCBvZiBjYW52YXMgdGVzdHMuCi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnRyYW5zZm9ybWF0aW9uLnJvdGF0ZS53cmFwLmh0bWwgPSBQQVNTIENSQVNI Ci1CVUdXSzcwMDEzIFdJTiBHUFUgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnRyYW5zZm9ybWF0 aW9uLnNldFRyYW5zZm9ybS5za2V3ZWQuaHRtbCA9IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lO IEdQVSA6IGZhc3QvY2FudmFzL2FyYzM2MC5odG1sID0gUEFTUyBDUkFTSAotQlVHV0s3MDAxMyBX SU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWFyYy0zNjAtd2luZGluZy5odG1sID0gUEFTUyBD UkFTSAotQlVHV0s3MDAxMyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLWFyYy1jb25uZWN0 aW5nLWxpbmUuaHRtbCA9IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lOIEdQVSA6IGZhc3QvY2Fu dmFzL2NhbnZhcy1kcmF3SW1hZ2Utc2hhZG93Lmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEz IFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52YXMtZmlsbFBhdGgtYWxwaGEtc2hhZG93Lmh0bWwg PSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52YXMtZmls bFBhdGgtZ3JhZGllbnQtc2hhZG93Lmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBH UFUgOiBmYXN0L2NhbnZhcy9jYW52YXMtZmlsbFBhdGgtcGF0dGVybi1zaGFkb3cuaHRtbCA9IFBB U1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lOIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy1maWxsUGF0 aC1zaGFkb3cuaHRtbCA9IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMgV0lOIEdQVSA6IGZhc3QvY2Fu dmFzL2NhbnZhcy1sYXJnZWRyYXdzLmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBH UFUgOiBmYXN0L2NhbnZhcy9jYW52YXMtbGluZVdpZHRoLWludGFjdC1hZnRlci1zdHJva2VSZWN0 Lmh0bWwgPSBQQVNTIENSQVNICi1CVUdXSzcwMDEzIFdJTiBHUFUgOiBmYXN0L2NhbnZhcy9jYW52 YXMtc3Ryb2tlUGF0aC1hbHBoYS1zaGFkb3cuaHRtbCA9IFBBU1MgQ1JBU0gKLUJVR1dLNzAwMTMg V0lOIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy1zdHJva2VQYXRoLXNoYWRvdy5odG1sID0gUEFT UyBDUkFTSAotQlVHV0s3MDAxMyBXSU4gR1BVIDogZmFzdC9jYW52YXMvY2FudmFzLXRyYW5zZm9y bXMtZmlsbFJlY3Qtc2hhZG93Lmh0bWwgPSBURVhUIENSQVNICiAKIEJVR1Y4XzE3NjggOiBmYXN0 L2pzL2RlbGV0ZS1zeW50YXguaHRtbCA9IFRFWFQKIApAQCAtMzg3OCw3ICszODYyLDcgQEAgQlVH V0s3MjIwNCA6IGluc3BlY3Rvci9kZWJ1Z2dlci9zY3JpcHQtZgogLy8gRml4ZWQgRVM1IGJ1Z3Mg ZHVyaW5nIHRoZSBWOCByb2xsLCB1cHN0cmVhbSBpbiBwcm9ncmVzcy4KIEJVR01TVEFSWklOR0VS IDogZmFzdC9qcy9tb3ppbGxhL3N0cmljdC8xNS40LjUuMS5odG1sID0gVEVYVAogCi1CVUdfU0VO T1JCTEFOQ08gTUFDIExJTlVYIEdQVSA6IGZhc3QvY2FudmFzL2NhbnZhcy10cmFuc2Zvcm1zLWZp bGxSZWN0LXNoYWRvdy5odG1sID0gVEVYVAorQlVHX1NFTk9SQkxBTkNPIEdQVSA6IGZhc3QvY2Fu dmFzL2NhbnZhcy10cmFuc2Zvcm1zLWZpbGxSZWN0LXNoYWRvdy5odG1sID0gVEVYVAogCiBCVUdX SzcyMTQ5IDogbWVkaWEvdHJhY2svdHJhY2tsaXN0LWlzLXJlYWNoYWJsZS5odG1sID0gVEVYVAog Cg==