72169 2011-11-11 13:13:09 -0800 [Qt] FrameLoaderClientQt::canShowMIMEType should always return true 2014-02-03 03:19:14 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID Qt, QtTriaged P2 Normal --- 72512 1 jesus jesus hausmann ossy webkit.review.bot oldest_to_newest 501028 0 jesus 2011-11-11 13:13:09 -0800 Currently FrameLoaderClientQt::canShowMIMEType is called after dispatchDecidePolicyForResponse. We might have a bug if decidePolicyForResponse returns PolicyUse while canShowMIMEType returns false. We should keep this implementation in WK1 as in WK2, always returning true. 501034 1 114758 jesus 2011-11-11 13:19:45 -0800 Created attachment 114758 Patch 501526 2 114758 hausmann 2011-11-13 11:04:39 -0800 Comment on attachment 114758 Patch r=me 503851 3 114758 webkit.review.bot 2011-11-16 07:12:45 -0800 Comment on attachment 114758 Patch Clearing flags on attachment: 114758 Committed r100448: <http://trac.webkit.org/changeset/100448> 503852 4 webkit.review.bot 2011-11-16 07:12:49 -0800 All reviewed patches have been landed. Closing bug. 503866 5 ossy 2011-11-16 07:49:18 -0800 It broke a test: --- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/text-content-type-with-binary-extension-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/text-content-type-with-binary-extension-actual.txt @@ -2,11 +2,14 @@ main frame - didCommitLoadForFrame frame "iframe" - didStartProvisionalLoadForFrame main frame - didFinishDocumentLoadForFrame +frame "iframe" - didCommitLoadForFrame +frame "iframe" - didFinishDocumentLoadForFrame +frame "iframe" - didHandleOnloadEventsForFrame main frame - didHandleOnloadEventsForFrame -frame "iframe" - didFailProvisionalLoadWithError +frame "iframe" - didFinishLoadForFrame main frame - didFinishLoadForFrame Test for https://bugs.webkit.org/show_bug.cgi?id=17360 REGRESSION: mp4 file downloaded from server is downloaded as html. -Binary data not loaded as text. Maybe PASS. +FAIL 503883 6 jesus 2011-11-16 08:01:17 -0800 (In reply to comment #5) > It broke a test: Ossy, why can't I see this in http://build.webkit.org/console?category=core ?! Or am I missing something there? 503885 7 ossy 2011-11-16 08:06:27 -0800 (In reply to comment #6) > (In reply to comment #5) > > It broke a test: > > Ossy, why can't I see this in http://build.webkit.org/console?category=core ?! > Or am I missing something there? You should see orange bubble here, which means that bot is red and it was red before your patch. But it doesn't inform you if there is additional failing test or not. You should check waterfall. 503950 8 ossy 2011-11-16 09:08:08 -0800 Reopen, because it was rolled out: http://trac.webkit.org/changeset/100459 975342 9 jturcotte 2014-02-03 03:19:14 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 114758 2011-11-11 13:19:45 -0800 2011-11-16 07:12:44 -0800 Patch bug-72169-20111111181927.patch text/plain 2277 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDg4ZjYxMGVjNDMw MDBhZjBkODQ1ZGM3NjZlYzczNDNlOWM2NTBmZDYuLjhjNjQwZjQwOGQ3YTkxNmJlYmEwOGM2OTdk NGRmMDAzMGM3YTNjMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTEt MTEgIEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3Jn PgorCisgICAgICAgIFtRdF0gRnJhbWVMb2FkZXJDbGllbnRRdDo6Y2FuU2hvd01JTUVUeXBlIHNo b3VsZCBhbHdheXMgcmV0dXJuIHRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTcyMTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3VycmVudGx5IEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmNhblNob3dNSU1F VHlwZSBpcyBjYWxsZWQgYWZ0ZXIKKyAgICAgICAgZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JSZXNw b25zZS4gSWYgZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UgcmV0dXJucworICAgICAgICBQb2xpY3lV c2UgYW5kIGNhblNob3dNSU1FVHlwZSByZXR1cm5zIGZhbHNlLCB0aGVuIHdlIGhhdmUgYSBidWcu CisgICAgICAgIFRoZXJlZm9yZSwgRnJhbWVMb2FkZXJDbGllbnRRdDo6Y2FuU2hvd01JTUVUeXBl IG5vdyB3aWxsIGFsd2F5cworICAgICAgICByZXR1cm4gdHJ1ZSwgZm9sbG93aW5nIHRoZSBpbXBs ZW1lbmF0aW9uIG9mIFdlYktpdDIuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6 OmNhblNob3dNSU1FVHlwZSk6CisKIDIwMTEtMTEtMTEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5 OTk2NC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50UXQuY3BwCmluZGV4IDA0YjFlM2Y4OTAyNDA0OTkxYTgxMTA2ZDAyNmZjZmJj MDI3MWNmZmYuLmZhZmMyOWZhMDFmZTg2NWM1MDQxMjMwNGMyYmVmMzk2YTE3OTcyN2IgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRR dC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudFF0LmNwcApAQCAtNjUwLDI1ICs2NTAsMTAgQEAgYm9vbCBGcmFtZUxvYWRlckNsaWVudFF0 OjpjYW5TaG93TUlNRVR5cGVBc0hUTUwoY29uc3QgU3RyaW5nJiBNSU1FVHlwZSkgY29uc3QKICAg ICBub3RJbXBsZW1lbnRlZCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0KLSAgICAKKwogYm9vbCBG cmFtZUxvYWRlckNsaWVudFF0OjpjYW5TaG93TUlNRVR5cGUoY29uc3QgU3RyaW5nJiBNSU1FVHlw ZSkgY29uc3QKIHsKLSAgICBTdHJpbmcgdHlwZSA9IE1JTUVUeXBlOwotICAgIHR5cGUubWFrZUxv d2VyKCk7Ci0gICAgaWYgKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlw ZSh0eXBlKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICBpZiAoTUlNRVR5cGVSZWdpc3Ry eTo6aXNTdXBwb3J0ZWROb25JbWFnZU1JTUVUeXBlKHR5cGUpKQotICAgICAgICByZXR1cm4gdHJ1 ZTsKLQotICAgIGlmIChNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZE1lZGlhTUlNRVR5cGUo dHlwZSkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0gICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFt ZS0+c2V0dGluZ3MoKSAgJiYgbV9mcmFtZS0+c2V0dGluZ3MoKS0+YXJlUGx1Z2luc0VuYWJsZWQo KQotICAgICAgICAmJiBQbHVnaW5EYXRhYmFzZTo6aW5zdGFsbGVkUGx1Z2lucygpLT5pc01JTUVU eXBlUmVnaXN0ZXJlZCh0eXBlKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0KLSAgICByZXR1cm4g ZmFsc2U7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIGJvb2wgRnJhbWVMb2FkZXJDbGllbnRRdDo6 cmVwcmVzZW50YXRpb25FeGlzdHNGb3JVUkxTY2hlbWUoY29uc3QgU3RyaW5nJikgY29uc3QK