72167 2011-11-11 12:47:44 -0800 REGRESSION: Scroll position not restored on back after scroll 2011-11-11 14:21:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified OS X 10.7 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 501007 0 bdakin 2011-11-11 12:47:44 -0800 1) Visit http://newyork.craigslist.org/csr/ 2) Scroll to middle of listings, e.g. more than one screen page in. 3) Click on link. 4) Once on the linked page, go back. 5) Scroll. At this point, the page visually jumps to the top and starts scrolling from the top. This jump should not occur; it should just start scrolling. <rdar://problem/10410684> This is a regression from http://trac.webkit.org/changeset/98178 501015 1 114754 bdakin 2011-11-11 12:53:48 -0800 Created attachment 114754 Patch 501092 2 114754 simon.fraser 2011-11-11 14:17:11 -0800 Comment on attachment 114754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114754&action=review > Source/WebCore/ChangeLog:12 > + therefore it's not on an active page). We should not notify AppKit that the page …therefor when not…? 501099 3 bdakin 2011-11-11 14:21:09 -0800 Agreed, that phrasing is better. Committed change with revision 100022. 114754 2011-11-11 12:53:48 -0800 2011-11-11 14:17:11 -0800 Patch for-review.txt text/plain 2130 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDAwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDExLTExLTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzIxNjcKKyAgICAgICAgUkVHUkVTU0lPTjogU2Nyb2xsIHBvc2l0 aW9uIG5vdCByZXN0b3JlZCBvbiBiYWNrIGFmdGVyIHNjcm9sbCAKKyAgICAgICAgLWFuZCBjb3Jy ZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA0MTA2ODQ+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgY2FuJ3QganVzdCByZXR1 cm4gZWFybHkgaWYgd2UgYXJlIG5vdCBvbiBhbiBhY3RpdmUgcGFnZS4gCisgICAgICAgIG5vdGlm eVBvc2l0aW9uQ2hhbmdlZCgpIGlzIGNhbGxlZCB3aGVuIGEgcGFnZSBpcyBnb2luZyBpbnRvIHRo ZSBwYWdlIGNhY2hlIChhbmQgCisgICAgICAgIHRoZXJlZm9yZSBpdCdzIG5vdCBvbiBhbiBhY3Rp dmUgcGFnZSkuIFdlIHNob3VsZCBub3Qgbm90aWZ5IEFwcEtpdCB0aGF0IHRoZSBwYWdlIAorICAg ICAgICBoYXMgc2Nyb2xsZWQgaW4gdGhhdCBjYXNlLCBidXQgd2Ugc3RpbGwgbmVlZCB0byBjYWxs IAorICAgICAgICBTY3JvbGxBbmltYXRvcjo6bm90aWZ5UG9zaXRpb25DaGFuZ2VkKCk7LiBTbyB0 aGlzIHBhdGNoIHJlbW92ZXMgdGhlIGVhcmx5IHJldHVybiwgCisgICAgICAgIGFuZCByZXBsYWNl cyBpdCB3aXRoIGEgY29uZGl0aW9uYWwgYXJvdW5kIHRoZSByZWxldmFudCBjb2RlLgorICAgICAg ICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbEFuaW1hdG9yTWFjOjpub3RpZnlQb3NpdGlvbkNoYW5nZWQpOgorCiAyMDExLTExLTEx ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGpzQ2FzdCB0byByZXBsYWNlIHN0YXRpY19jYXN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCShyZXZpc2lvbiA5OTkxMCkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtNzExLDEwICs3MTEsMTIgQEAgdm9pZCBTY3JvbGxBbmltYXRvck1hYzo6aW1t ZWRpYXRlU2Nyb2xsVAogCiB2b2lkIFNjcm9sbEFuaW1hdG9yTWFjOjpub3RpZnlQb3NpdGlvbkNo YW5nZWQoKQogewotICAgIGlmICghc2Nyb2xsYWJsZUFyZWEoKS0+aXNPbkFjdGl2ZVBhZ2UoKSkK LSAgICAgICAgcmV0dXJuOwogI2lmIFVTRShTQ1JPTExCQVJfUEFJTlRFUikKLSAgICBbbV9zY3Jv bGxiYXJQYWludGVyQ29udHJvbGxlci5nZXQoKSBjb250ZW50QXJlYVNjcm9sbGVkXTsKKyAgICAv LyBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCB3aGVuIGEgcGFnZSBpcyBnb2luZyBpbnRvIHRoZSBw YWdlIGNhY2hlLCBidXQgdGhlIHBhZ2UgCisgICAgLy8gaXNuJ3QgcmVhbGx5IHNjcm9sbGluZyBp biB0aGF0IGNhc2UuIFdlIHNob3VsZCBvbmx5IHBhc3MgdGhlIG1lc3NhZ2Ugb24gdG8gdGhlCisg ICAgLy8gU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIgd2hlbiB3ZSdyZSByZWFsbHkgc2Nyb2xs aW5nIG9uIGFuIGFjdGl2ZSBwYWdlLgorICAgIGlmIChzY3JvbGxhYmxlQXJlYSgpLT5pc09uQWN0 aXZlUGFnZSgpKQorICAgICAgICBbbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlci5nZXQoKSBj b250ZW50QXJlYVNjcm9sbGVkXTsKICNlbmRpZgogICAgIFNjcm9sbEFuaW1hdG9yOjpub3RpZnlQ b3NpdGlvbkNoYW5nZWQoKTsKIH0K