72159 2011-11-11 11:19:38 -0800 Incorrect inter-caps in “ShouldSkipMetaData” etc. 2014-07-09 11:36:57 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 1 mitz psolanki psolanki oldest_to_newest 500954 0 mitz 2011-11-11 11:19:38 -0800 Metadata is a single word, so the D should not be capitalized in ImageSource::ShouldSkipMetaData, its values, and related variables. 605934 1 137978 psolanki 2012-04-19 14:43:00 -0700 Created attachment 137978 Patch 606006 2 psolanki 2012-04-19 15:33:47 -0700 Committed r114683: <http://trac.webkit.org/changeset/114683> 137978 2012-04-19 14:43:00 -0700 2014-07-09 11:36:57 -0700 Patch bug-72159-20120419144259.patch text/plain 7701 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWUyNTk3ZDllN2RkODll NTEwZDk2ZWM0M2JhZDY5NjVmMWI1Yzc2Ny4uMmZjMzQ5MDMzYTFkNWVmOWE5YjQ5MTc3ZjNjZjVl NjU1OTFiMzMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTE5ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNvcnJlY3QgaW50 ZXItY2FwcyBpbiDigJxTaG91bGRTa2lwTWV0YURhdGHigJ0gZXRjLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxNTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2Ugbm8gY2hh bmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFn ZVNvdXJjZS5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6aW1hZ2VTb3VyY2VPcHRpb25zKToKKyAgICAgICAgKFdl YkNvcmU6OkltYWdlU291cmNlOjppc1NpemVBdmFpbGFibGUpOgorICAgICAgICAoV2ViQ29yZTo6 SW1hZ2VTb3VyY2U6OmZyYW1lU2l6ZUF0SW5kZXgpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VT b3VyY2U6Om9yaWVudGF0aW9uQXRJbmRleCk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZVNvdXJj ZTo6Z2V0SG90U3BvdCk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZVNvdXJjZTo6cmVwZXRpdGlv bkNvdW50KToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlU291cmNlOjpjcmVhdGVGcmFtZUF0SW5k ZXgpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OmZyYW1lRHVyYXRpb25BdEluZGV4 KToKKwogMjAxMi0wNC0xOSAgS2VuIEJ1Y2hhbmFuICA8a2VucmJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFBvc2l0aW9uZWQgY2hpbGRyZW4gb2YgcnVieSBydW5zIG5vdCBoYW5kbGVkIGNvcnJl Y3RseSBkdXJpbmcgbGF5b3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZVNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv SW1hZ2VTb3VyY2UuaAppbmRleCAzYTdmYWZjOTBmM2VlM2VlMjg4OGE1Y2MwZjZmZmY2MThjMjYy NDExLi5kYmI3NjQ1NzNiOGMxMjAyMWVjNWUzZTQ1OGRlMTUyNGM5MjAyYTNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmgKQEAgLTEzNCw5ICsx MzQsOSBAQCBwdWJsaWM6CiAgICAgfTsKIAogI2lmIFVTRShDRykKLSAgICBlbnVtIFNob3VsZFNr aXBNZXRhRGF0YSB7Ci0gICAgICAgIERvTm90U2tpcE1ldGFEYXRhLAotICAgICAgICBTa2lwTWV0 YURhdGEKKyAgICBlbnVtIFNob3VsZFNraXBNZXRhZGF0YSB7CisgICAgICAgIERvTm90U2tpcE1l dGFkYXRhLAorICAgICAgICBTa2lwTWV0YWRhdGEKICAgICB9OwogI2VuZGlmCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAK aW5kZXggOTM5NDI3Y2NmZjMyYmMyNGUxNTc2MzUwZTdjY2NmY2YwYjFlMWQ3My4uNDMzNTM2NTBj ZDA0MjVlNTdmMzIzNmVhZTQ0MjQyNWIxYjczNzBjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKQEAgLTEwOSw3ICsx MDksNyBAQCB2b2lkIEltYWdlU291cmNlOjpjbGVhcihib29sIGRlc3Ryb3lBbGxGcmFtZXMsIHNp emVfdCwgU2hhcmVkQnVmZmVyKiBkYXRhLCBib29sCiAgICAgICAgIHNldERhdGEoZGF0YSwgYWxs RGF0YVJlY2VpdmVkKTsKIH0KIAotc3RhdGljIENGRGljdGlvbmFyeVJlZiBpbWFnZVNvdXJjZU9w dGlvbnMoSW1hZ2VTb3VyY2U6OlNob3VsZFNraXBNZXRhRGF0YSBza2lwTWV0YURhdGEpCitzdGF0 aWMgQ0ZEaWN0aW9uYXJ5UmVmIGltYWdlU291cmNlT3B0aW9ucyhJbWFnZVNvdXJjZTo6U2hvdWxk U2tpcE1ldGFkYXRhIHNraXBNZXRhZGF0YSkKIHsKICAgICBzdGF0aWMgQ0ZEaWN0aW9uYXJ5UmVm IG9wdGlvbnM7CiAKQEAgLTEyMSwxMyArMTIxLDEzIEBAIHN0YXRpYyBDRkRpY3Rpb25hcnlSZWYg aW1hZ2VTb3VyY2VPcHRpb25zKEltYWdlU291cmNlOjpTaG91bGRTa2lwTWV0YURhdGEgc2tpcE1l CiAgICAgICAgIC8vIGFuZCBpbmNvcnJlY3RseSByZXR1cm4gY2FjaGVkIG1ldGFkYXRhIGlmIGFu IGltYWdlIGlzIHF1ZXJpZWQgb25jZSB3aXRoIGtDR0ltYWdlU291cmNlU2tpcE1ldGFEYXRhIHRy dWUKICAgICAgICAgLy8gYW5kIHRoZW4gc3Vic2VxdWVudGx5IHdpdGgga0NHSW1hZ2VTb3VyY2VT a2lwTWV0YURhdGEgZmFsc2UuCiAgICAgICAgIC8vIDxyZGFyOi8vcHJvYmxlbS8xMTE0ODE5Mj4K LSAgICAgICAgVU5VU0VEX1BBUkFNKHNraXBNZXRhRGF0YSk7Ci0gICAgICAgIGNvbnN0IENGQm9v bGVhblJlZiBpbWFnZVNvdXJjZVNraXBNZXRhRGF0YSA9IGtDRkJvb2xlYW5GYWxzZTsKKyAgICAg ICAgVU5VU0VEX1BBUkFNKHNraXBNZXRhZGF0YSk7CisgICAgICAgIGNvbnN0IENGQm9vbGVhblJl ZiBpbWFnZVNvdXJjZVNraXBNZXRhZGF0YSA9IGtDRkJvb2xlYW5GYWxzZTsKICNlbHNlCi0gICAg ICAgIGNvbnN0IENGQm9vbGVhblJlZiBpbWFnZVNvdXJjZVNraXBNZXRhRGF0YSA9IChza2lwTWV0 YURhdGEgPT0gSW1hZ2VTb3VyY2U6OlNraXBNZXRhRGF0YSkgPyBrQ0ZCb29sZWFuVHJ1ZSA6IGtD RkJvb2xlYW5GYWxzZTsKKyAgICAgICAgY29uc3QgQ0ZCb29sZWFuUmVmIGltYWdlU291cmNlU2tp cE1ldGFkYXRhID0gKHNraXBNZXRhZGF0YSA9PSBJbWFnZVNvdXJjZTo6U2tpcE1ldGFkYXRhKSA/ IGtDRkJvb2xlYW5UcnVlIDoga0NGQm9vbGVhbkZhbHNlOwogI2VuZGlmCiAgICAgICAgIGNvbnN0 IHZvaWQqIGtleXNbbnVtT3B0aW9uc10gPSB7IGtDR0ltYWdlU291cmNlU2hvdWxkQ2FjaGUsIGtD R0ltYWdlU291cmNlU2hvdWxkUHJlZmVyUkdCMzIsIGtDR0ltYWdlU291cmNlU2tpcE1ldGFEYXRh IH07Ci0gICAgICAgIGNvbnN0IHZvaWQqIHZhbHVlc1tudW1PcHRpb25zXSA9IHsga0NGQm9vbGVh blRydWUsIGtDRkJvb2xlYW5UcnVlLCBpbWFnZVNvdXJjZVNraXBNZXRhRGF0YSB9OworICAgICAg ICBjb25zdCB2b2lkKiB2YWx1ZXNbbnVtT3B0aW9uc10gPSB7IGtDRkJvb2xlYW5UcnVlLCBrQ0ZC b29sZWFuVHJ1ZSwgaW1hZ2VTb3VyY2VTa2lwTWV0YWRhdGEgfTsKICAgICAgICAgb3B0aW9ucyA9 IENGRGljdGlvbmFyeUNyZWF0ZShOVUxMLCBrZXlzLCB2YWx1ZXMsIG51bU9wdGlvbnMsIAogICAg ICAgICAgICAgJmtDRlR5cGVEaWN0aW9uYXJ5S2V5Q2FsbEJhY2tzLCAma0NGVHlwZURpY3Rpb25h cnlWYWx1ZUNhbGxCYWNrcyk7CiAgICAgfQpAQCAtMTg1LDcgKzE4NSw3IEBAIGJvb2wgSW1hZ2VT b3VyY2U6OmlzU2l6ZUF2YWlsYWJsZSgpCiAKICAgICAvLyBSYWduYXJvcyB5ZWxsczogVE9PIFNP T04hIFlvdSBoYXZlIGF3YWtlbmVkIG1lIFRPTyBTT09OLCBFeGVjdXR1cyEKICAgICBpZiAoaW1h Z2VTb3VyY2VTdGF0dXMgPj0ga0NHSW1hZ2VTdGF0dXNJbmNvbXBsZXRlKSB7Ci0gICAgICAgIFJl dGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IGltYWdlMFByb3BlcnRpZXMoQWRvcHRDRiwgQ0dJbWFn ZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2RlY29kZXIsIDAsIGltYWdlU291cmNlT3B0 aW9ucyhTa2lwTWV0YURhdGEpKSk7CisgICAgICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+ IGltYWdlMFByb3BlcnRpZXMoQWRvcHRDRiwgQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJ bmRleChtX2RlY29kZXIsIDAsIGltYWdlU291cmNlT3B0aW9ucyhTa2lwTWV0YWRhdGEpKSk7CiAg ICAgICAgIGlmIChpbWFnZTBQcm9wZXJ0aWVzKSB7CiAgICAgICAgICAgICBDRk51bWJlclJlZiB3 aWR0aE51bWJlciA9IChDRk51bWJlclJlZilDRkRpY3Rpb25hcnlHZXRWYWx1ZShpbWFnZTBQcm9w ZXJ0aWVzLmdldCgpLCBrQ0dJbWFnZVByb3BlcnR5UGl4ZWxXaWR0aCk7CiAgICAgICAgICAgICBD Rk51bWJlclJlZiBoZWlnaHROdW1iZXIgPSAoQ0ZOdW1iZXJSZWYpQ0ZEaWN0aW9uYXJ5R2V0VmFs dWUoaW1hZ2UwUHJvcGVydGllcy5nZXQoKSwga0NHSW1hZ2VQcm9wZXJ0eVBpeGVsSGVpZ2h0KTsK QEAgLTE5OCw3ICsxOTgsNyBAQCBib29sIEltYWdlU291cmNlOjppc1NpemVBdmFpbGFibGUoKQog CiBJbnRTaXplIEltYWdlU291cmNlOjpmcmFtZVNpemVBdEluZGV4KHNpemVfdCBpbmRleCwgUmVz cGVjdEltYWdlT3JpZW50YXRpb25FbnVtIHNob3VsZFJlc3BlY3RPcmllbnRhdGlvbikgY29uc3QK IHsKLSAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBwcm9wZXJ0aWVzKEFkb3B0Q0YsIENH SW1hZ2VTb3VyY2VDb3B5UHJvcGVydGllc0F0SW5kZXgobV9kZWNvZGVyLCBpbmRleCwgaW1hZ2VT b3VyY2VPcHRpb25zKFNraXBNZXRhRGF0YSkpKTsKKyAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5 UmVmPiBwcm9wZXJ0aWVzKEFkb3B0Q0YsIENHSW1hZ2VTb3VyY2VDb3B5UHJvcGVydGllc0F0SW5k ZXgobV9kZWNvZGVyLCBpbmRleCwgaW1hZ2VTb3VyY2VPcHRpb25zKFNraXBNZXRhZGF0YSkpKTsK IAogICAgIGlmICghcHJvcGVydGllcykKICAgICAgICAgcmV0dXJuIEludFNpemUoKTsKQEAgLTIx OSw3ICsyMTksNyBAQCBJbnRTaXplIEltYWdlU291cmNlOjpmcmFtZVNpemVBdEluZGV4KHNpemVf dCBpbmRleCwgUmVzcGVjdEltYWdlT3JpZW50YXRpb25FbnVtCiAKIEltYWdlT3JpZW50YXRpb24g SW1hZ2VTb3VyY2U6Om9yaWVudGF0aW9uQXRJbmRleChzaXplX3QgaW5kZXgpIGNvbnN0CiB7Ci0g ICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4gcHJvcGVydGllcyhBZG9wdENGLCBDR0ltYWdl U291cmNlQ29weVByb3BlcnRpZXNBdEluZGV4KG1fZGVjb2RlciwgaW5kZXgsIGltYWdlU291cmNl T3B0aW9ucyhTa2lwTWV0YURhdGEpKSk7CisgICAgUmV0YWluUHRyPENGRGljdGlvbmFyeVJlZj4g cHJvcGVydGllcyhBZG9wdENGLCBDR0ltYWdlU291cmNlQ29weVByb3BlcnRpZXNBdEluZGV4KG1f ZGVjb2RlciwgaW5kZXgsIGltYWdlU291cmNlT3B0aW9ucyhTa2lwTWV0YWRhdGEpKSk7CiAgICAg aWYgKCFwcm9wZXJ0aWVzKQogICAgICAgICByZXR1cm4gRGVmYXVsdEltYWdlT3JpZW50YXRpb247 CiAKQEAgLTIzOSw3ICsyMzksNyBAQCBJbnRTaXplIEltYWdlU291cmNlOjpzaXplKFJlc3BlY3RJ bWFnZU9yaWVudGF0aW9uRW51bSBzaG91bGRSZXNwZWN0T3JpZW50YXRpb24pCiAKIGJvb2wgSW1h Z2VTb3VyY2U6OmdldEhvdFNwb3QoSW50UG9pbnQmIGhvdFNwb3QpIGNvbnN0CiB7Ci0gICAgUmV0 YWluUHRyPENGRGljdGlvbmFyeVJlZj4gcHJvcGVydGllcyhBZG9wdENGLCBDR0ltYWdlU291cmNl Q29weVByb3BlcnRpZXNBdEluZGV4KG1fZGVjb2RlciwgMCwgaW1hZ2VTb3VyY2VPcHRpb25zKFNr aXBNZXRhRGF0YSkpKTsKKyAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBwcm9wZXJ0aWVz KEFkb3B0Q0YsIENHSW1hZ2VTb3VyY2VDb3B5UHJvcGVydGllc0F0SW5kZXgobV9kZWNvZGVyLCAw LCBpbWFnZVNvdXJjZU9wdGlvbnMoU2tpcE1ldGFkYXRhKSkpOwogICAgIGlmICghcHJvcGVydGll cykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC0yNzYsNyArMjc2LDcgQEAgaW50IEltYWdl U291cmNlOjpyZXBldGl0aW9uQ291bnQoKQogICAgIGlmICghaW5pdGlhbGl6ZWQoKSkKICAgICAg ICAgcmV0dXJuIHJlc3VsdDsKIAotICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IHByb3Bl cnRpZXMoQWRvcHRDRiwgQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzKG1fZGVjb2RlciwgaW1h Z2VTb3VyY2VPcHRpb25zKFNraXBNZXRhRGF0YSkpKTsKKyAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9u YXJ5UmVmPiBwcm9wZXJ0aWVzKEFkb3B0Q0YsIENHSW1hZ2VTb3VyY2VDb3B5UHJvcGVydGllcyht X2RlY29kZXIsIGltYWdlU291cmNlT3B0aW9ucyhTa2lwTWV0YWRhdGEpKSk7CiAgICAgaWYgKHBy b3BlcnRpZXMpIHsKICAgICAgICAgQ0ZEaWN0aW9uYXJ5UmVmIGdpZlByb3BlcnRpZXMgPSAoQ0ZE aWN0aW9uYXJ5UmVmKUNGRGljdGlvbmFyeUdldFZhbHVlKHByb3BlcnRpZXMuZ2V0KCksIGtDR0lt YWdlUHJvcGVydHlHSUZEaWN0aW9uYXJ5KTsKICAgICAgICAgaWYgKGdpZlByb3BlcnRpZXMpIHsK QEAgLTMwNCw3ICszMDQsNyBAQCBDR0ltYWdlUmVmIEltYWdlU291cmNlOjpjcmVhdGVGcmFtZUF0 SW5kZXgoc2l6ZV90IGluZGV4KQogICAgIGlmICghaW5pdGlhbGl6ZWQoKSkKICAgICAgICAgcmV0 dXJuIDA7CiAKLSAgICBSZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2UoQWRvcHRDRiwgQ0dJbWFn ZVNvdXJjZUNyZWF0ZUltYWdlQXRJbmRleChtX2RlY29kZXIsIGluZGV4LCBpbWFnZVNvdXJjZU9w dGlvbnMoU2tpcE1ldGFEYXRhKSkpOworICAgIFJldGFpblB0cjxDR0ltYWdlUmVmPiBpbWFnZShB ZG9wdENGLCBDR0ltYWdlU291cmNlQ3JlYXRlSW1hZ2VBdEluZGV4KG1fZGVjb2RlciwgaW5kZXgs IGltYWdlU291cmNlT3B0aW9ucyhTa2lwTWV0YWRhdGEpKSk7CiAgICAgQ0ZTdHJpbmdSZWYgaW1h Z2VVVEkgPSBDR0ltYWdlU291cmNlR2V0VHlwZShtX2RlY29kZXIpOwogICAgIHN0YXRpYyBjb25z dCBDRlN0cmluZ1JlZiB4Ym1VVEkgPSBDRlNUUigicHVibGljLnhiaXRtYXAtaW1hZ2UiKTsKICAg ICBpZiAoIWltYWdlVVRJIHx8ICFDRkVxdWFsKGltYWdlVVRJLCB4Ym1VVEkpKQpAQCAtMzQ1LDcg KzM0NSw3IEBAIGZsb2F0IEltYWdlU291cmNlOjpmcmFtZUR1cmF0aW9uQXRJbmRleChzaXplX3Qg aW5kZXgpCiAgICAgICAgIHJldHVybiAwOwogCiAgICAgZmxvYXQgZHVyYXRpb24gPSAwOwotICAg IFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IHByb3BlcnRpZXMoQWRvcHRDRiwgQ0dJbWFnZVNv dXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2RlY29kZXIsIGluZGV4LCBpbWFnZVNvdXJjZU9w dGlvbnMoU2tpcE1ldGFEYXRhKSkpOworICAgIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IHBy b3BlcnRpZXMoQWRvcHRDRiwgQ0dJbWFnZVNvdXJjZUNvcHlQcm9wZXJ0aWVzQXRJbmRleChtX2Rl Y29kZXIsIGluZGV4LCBpbWFnZVNvdXJjZU9wdGlvbnMoU2tpcE1ldGFkYXRhKSkpOwogICAgIGlm IChwcm9wZXJ0aWVzKSB7CiAgICAgICAgIENGRGljdGlvbmFyeVJlZiB0eXBlUHJvcGVydGllcyA9 IChDRkRpY3Rpb25hcnlSZWYpQ0ZEaWN0aW9uYXJ5R2V0VmFsdWUocHJvcGVydGllcy5nZXQoKSwg a0NHSW1hZ2VQcm9wZXJ0eUdJRkRpY3Rpb25hcnkpOwogICAgICAgICBpZiAodHlwZVByb3BlcnRp ZXMpIHsK