<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72156</bug_id>
          
          <creation_ts>2011-11-11 11:05:35 -0800</creation_ts>
          <short_desc>build-webkit: Accept --cmakeargs to pass additional arguments to CMake.</short_desc>
          <delta_ts>2011-11-14 22:43:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>dbates</cc>
    
    <cc>leandro</cc>
    
    <cc>mxie</cc>
    
    <cc>paroga</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>500936</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 11:05:35 -0800</bug_when>
    <thetext>build-webkit: Accept --cmakeargs to pass additional arguments to CMake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500940</commentid>
    <comment_count>1</comment_count>
      <attachid>114736</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 11:08:27 -0800</bug_when>
    <thetext>Created attachment 114736
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500942</commentid>
    <comment_count>2</comment_count>
      <attachid>114736</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2011-11-11 11:10:34 -0800</bug_when>
    <thetext>Comment on attachment 114736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114736&amp;action=review

&gt; Tools/Scripts/build-webkit:395
&gt; +  --cmakearg=&lt;arguments&gt;            Optional CMake flags

maybe you can add  (eg. --cmakearg=&quot;-DFOO=bar&quot;)  like for qmakearg here too?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500949</commentid>
    <comment_count>3</comment_count>
      <attachid>114738</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 11:14:09 -0800</bug_when>
    <thetext>Created attachment 114738
Add an example to the usage message</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500955</commentid>
    <comment_count>4</comment_count>
      <attachid>114738</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-11 11:21:00 -0800</bug_when>
    <thetext>Comment on attachment 114738
Add an example to the usage message

View in context: https://bugs.webkit.org/attachment.cgi?id=114738&amp;action=review

&gt; Tools/Scripts/build-webkit:62
&gt; +my $cmakeArgs = &quot;&quot;;

Nit: It&apos;s unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500998</commentid>
    <comment_count>5</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 12:13:43 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 114738 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=114738&amp;action=review
&gt; 
&gt; &gt; Tools/Scripts/build-webkit:62
&gt; &gt; +my $cmakeArgs = &quot;&quot;;
&gt; 
&gt; Nit: It&apos;s unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.

Thanks. I don&apos;t speak Perl, so this was mostly copy&apos;n&apos;paste from other places in build-webkit-patch and webkitdirs.pm :)

I haven&apos;t had my commit bit activated yet, so could you cq+ it too?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>502647</commentid>
    <comment_count>6</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-14 22:39:03 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 114738 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=114738&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Tools/Scripts/build-webkit:62
&gt; &gt; &gt; +my $cmakeArgs = &quot;&quot;;
&gt; &gt; 
&gt; &gt; Nit: It&apos;s unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.
&gt; 
&gt; Thanks. I don&apos;t speak Perl, so this was mostly copy&apos;n&apos;paste from other places in build-webkit-patch and webkitdirs.pm :)
&gt; 
&gt; I haven&apos;t had my commit bit activated yet, so could you cq+ it too?

Will remove explicit initialization of $cmakeArgs and land this patch by hand.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>502648</commentid>
    <comment_count>7</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-14 22:43:07 -0800</bug_when>
    <thetext>Committed r100241: &lt;http://trac.webkit.org/changeset/100241&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>114736</attachid>
            <date>2011-11-11 11:08:27 -0800</date>
            <delta_ts>2011-11-11 11:14:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-72156-20111111170848.patch</filename>
            <type>text/plain</type>
            <size>3819</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5NjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZjhmNjc1NTA0YzZjZmFjNWY1MDhlNWRiMjg3MTM1Zjk5
MGQ3YWQzLi5iMjE5N2RlZjJlYWRiMTI0NDM0NzA3ZjNiNmE4MjUyZDI3YzgwNjk3IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v
Ymk+CisKKyAgICAgICAgYnVpbGQtd2Via2l0OiBBY2NlcHQgLS1jbWFrZWFyZyB0byBwYXNzIGFk
ZGl0aW9uYWwgYXJndW1lbnRzIHRvIENNYWtlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBTaW1pbGFyIHRvIC0tbWFrZWFyZyBhbmQgLS1xbWFrZWFyZywg
LS1jbWFrZWFyZyBsZXRzIG9uZSBwYXNzCisgICAgICAgIGFkZGl0aW9uYWwgYXJndW1lbnRzIHRv
IENNYWtlIChlZy4gLS1jbWFrZWFyZz0iLURGT089YmFyIikuCisKKyAgICAgICAgKiBTY3JpcHRz
L2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAg
IChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisKIDIwMTEtMTEtMTEgIFRv
ciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtR
dF0gQWRkIG1pc3NpbmcgaW5jbHVkZSB0byBQbGF0Zm9ybVdlYlZpZXdRdApkaWZmIC0tZ2l0IGEv
VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApp
bmRleCBhYzNiZWQ1Yzc1ZjhjYzU1OWZjZWI0MTNmZGM2ZTNmOTcwMjZjMDg4Li40NGFhNzlkZTRh
ZTBhYWY5YWZlNDE2NGU0NDdjYWZmODg0YjFiZjY3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRz
L2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNTksNiAr
NTksNyBAQCBteSAkaW5zdGFsbEhlYWRlcnM7CiBteSAkaW5zdGFsbExpYnM7CiBteSAkcHJlZml4
UGF0aDsKIG15ICRtYWtlQXJncyA9ICIiOworbXkgJGNtYWtlQXJncyA9ICIiOwogbXkgJG9ubHlX
ZWJLaXRQcm9qZWN0ID0gMDsKIG15ICRub1dlYktpdDIgPSAwOwogbXkgJHN0YXJ0VGltZSA9IHRp
bWUoKTsKQEAgLTM5MSw2ICszOTIsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBb
b3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1wcmVmaXg9PHBhdGg+ICAgICAg
ICAgICAgICAgICAgIFNldCBpbnN0YWxsYXRpb24gcHJlZml4IHRvIHRoZSBnaXZlbiBwYXRoIChH
dGsvRWZsIG9ubHkpCiAgIC0tbWFrZWFyZ3M9PGFyZ3VtZW50cz4gICAgICAgICAgICBPcHRpb25h
bCBNYWtlZmlsZSBmbGFncwogICAtLXFtYWtlYXJnPTxhcmd1bWVudHM+ICAgICAgICAgICAgT3B0
aW9uYWwgcW1ha2UgZmxhZ3MgKFF0IG9ubHksIGUuZy4gLS1xbWFrZWFyZz0iQ09ORklHKz13ZWJr
aXQyIiB0byBidWlsZCBXZWJLaXQyKQorICAtLWNtYWtlYXJnPTxhcmd1bWVudHM+ICAgICAgICAg
ICAgT3B0aW9uYWwgQ01ha2UgZmxhZ3MKIAogICAtLW1pbmltYWwgICAgICAgICAgICAgICAgICAg
ICAgICAgTm8gb3B0aW9uYWwgZmVhdHVyZXMsIHVubGVzcyBleHBsaWNpdGx5IGVuYWJsZWQKIApA
QCAtNDA3LDYgKzQwOSw3IEBAIG15ICVvcHRpb25zID0gKAogICAgICdpbnN0YWxsLWxpYnM9cycg
PT4gXCRpbnN0YWxsTGlicywKICAgICAncHJlZml4PXMnID0+IFwkcHJlZml4UGF0aCwKICAgICAn
bWFrZWFyZ3M9cycgPT4gXCRtYWtlQXJncywKKyAgICAnY21ha2VhcmdzPXMnID0+IFwkY21ha2VB
cmdzLAogICAgICdtaW5pbWFsJyA9PiBcJG1pbmltYWwsCiAgICAgJ3Y4JyA9PiBcJHY4LAogICAg
ICdvbmx5LXdlYmtpdCcgPT4gXCRvbmx5V2ViS2l0UHJvamVjdCwKQEAgLTU5OCwxMSArNjAxLDEx
IEBAIGlmIChpc0Nocm9taXVtKCkpIHsKIGlmIChpc0VmbCgpKSB7CiAgICAgIyBCeSBkZWZhdWx0
IHdlIGJ1aWxkIHVzaW5nIGFsbCBvZiB0aGUgYXZhaWxhYmxlIENQVXMuCiAgICAgJG1ha2VBcmdz
IC49ICgkbWFrZUFyZ3MgPyAiICIgOiAiIikgLiAiLWoiIC4gbnVtYmVyT2ZDUFVzKCkgaWYgJG1h
a2VBcmdzICF+IC8talxzKlxkKy87Ci0gICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJGNsZWFu
LCAiRWZsIiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgY01ha2VBcmdzRnJvbUZlYXR1cmVzKCkp
OworICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIkVmbCIsICRwcmVmaXhQYXRo
LCAkbWFrZUFyZ3MsIGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpLCAkY21ha2VBcmdzKTsKIH0KIAog
aWYgKGlzV2luQ0UoKSkgewotICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIldp
bkNFIiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgKCItRENNQUtFX1dJTkNFX1NESz1cIlNUQU5E
QVJEU0RLXzUwMCAoQVJNVjRJKVwiIiwgY01ha2VBcmdzRnJvbUZlYXR1cmVzKCkpKTsKKyAgICBi
dWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4sICJXaW5DRSIsICRwcmVmaXhQYXRoLCAkbWFr
ZUFyZ3MsICgiLURDTUFLRV9XSU5DRV9TREs9XCJTVEFOREFSRFNES181MDAgKEFSTVY0SSlcIiIs
IGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpKSwgJGNtYWtlQXJncyk7CiB9CiAKICMgQnVpbGQsIGFu
ZCBhYm9ydCBpZiB0aGUgYnVpbGQgZmFpbHMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl
YmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNjUxNTRlMTA2
OTg0M2QzODA1YzIwMzU0Y2FiZTQxMGY0YWUzZTFkZS4uOTIzNmRkMjY5NzY0YTQwOGI4YzMyMGJl
ODA3OWJiYTUyY2I2ZWI2YiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt
CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTYyNSw3ICsxNjI1LDcgQEAg
c3ViIGJ1aWxkQXV0b3Rvb2xzUHJvamVjdCgkQCkKIAogc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1G
cm9tQ01ha2VQcm9qZWN0CiB7Ci0gICAgbXkgKCRwb3J0LCAkcHJlZml4UGF0aCwgQGNtYWtlQXJn
cykgPSBAXzsKKyAgICBteSAoJHBvcnQsICRwcmVmaXhQYXRoLCBAY21ha2VBcmdzLCAkYWRkaXRp
b25hbENNYWtlQXJncykgPSBAXzsKICAgICBteSAkY29uZmlnID0gY29uZmlndXJhdGlvbigpOwog
ICAgIG15ICRidWlsZFBhdGggPSBGaWxlOjpTcGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwg
JGNvbmZpZyk7CiAgICAgRmlsZTo6UGF0aDo6bWtwYXRoKCRidWlsZFBhdGgpIHVubGVzcyAtZCAk
YnVpbGRQYXRoOwpAQCAtMTY0MSw2ICsxNjQxLDggQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1G
cm9tQ01ha2VQcm9qZWN0CiAgICAgICAgIHB1c2ggQGFyZ3MsICItRENNQUtFX0JVSUxEX1RZUEU9
RGVidWciOwogICAgIH0KICAgICBwdXNoIEBhcmdzLCBAY21ha2VBcmdzIGlmIEBjbWFrZUFyZ3M7
CisgICAgcHVzaCBAYXJncywgJGFkZGl0aW9uYWxDTWFrZUFyZ3MgaWYgJGFkZGl0aW9uYWxDTWFr
ZUFyZ3M7CisKICAgICBwdXNoIEBhcmdzLCAnIicgLiBGaWxlOjpTcGVjLT5jYXRkaXIoc291cmNl
RGlyKCksICJTb3VyY2UiKSAuICciJzsKIAogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtlIEBh
cmdzIikgaW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3MgaXMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>114738</attachid>
            <date>2011-11-11 11:14:09 -0800</date>
            <delta_ts>2011-11-14 22:38:53 -0800</delta_ts>
            <desc>Add an example to the usage message</desc>
            <filename>bug-72156-20111111171430.patch</filename>
            <type>text/plain</type>
            <size>3880</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5NjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZjhmNjc1NTA0YzZjZmFjNWY1MDhlNWRiMjg3MTM1Zjk5
MGQ3YWQzLi5iMjE5N2RlZjJlYWRiMTI0NDM0NzA3ZjNiNmE4MjUyZDI3YzgwNjk3IDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg
QEAKKzIwMTEtMTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v
Ymk+CisKKyAgICAgICAgYnVpbGQtd2Via2l0OiBBY2NlcHQgLS1jbWFrZWFyZyB0byBwYXNzIGFk
ZGl0aW9uYWwgYXJndW1lbnRzIHRvIENNYWtlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxNTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBTaW1pbGFyIHRvIC0tbWFrZWFyZyBhbmQgLS1xbWFrZWFyZywg
LS1jbWFrZWFyZyBsZXRzIG9uZSBwYXNzCisgICAgICAgIGFkZGl0aW9uYWwgYXJndW1lbnRzIHRv
IENNYWtlIChlZy4gLS1jbWFrZWFyZz0iLURGT089YmFyIikuCisKKyAgICAgICAgKiBTY3JpcHRz
L2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAg
IChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisKIDIwMTEtMTEtMTEgIFRv
ciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtR
dF0gQWRkIG1pc3NpbmcgaW5jbHVkZSB0byBQbGF0Zm9ybVdlYlZpZXdRdApkaWZmIC0tZ2l0IGEv
VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApp
bmRleCBhYzNiZWQ1Yzc1ZjhjYzU1OWZjZWI0MTNmZGM2ZTNmOTcwMjZjMDg4Li41NGVkN2UzODlh
Y2RjYWQxYjRjMDIzNTJiYTU3NDExODVkOGM4MDg4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRz
L2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNTksNiAr
NTksNyBAQCBteSAkaW5zdGFsbEhlYWRlcnM7CiBteSAkaW5zdGFsbExpYnM7CiBteSAkcHJlZml4
UGF0aDsKIG15ICRtYWtlQXJncyA9ICIiOworbXkgJGNtYWtlQXJncyA9ICIiOwogbXkgJG9ubHlX
ZWJLaXRQcm9qZWN0ID0gMDsKIG15ICRub1dlYktpdDIgPSAwOwogbXkgJHN0YXJ0VGltZSA9IHRp
bWUoKTsKQEAgLTM5MSw2ICszOTIsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBb
b3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1wcmVmaXg9PHBhdGg+ICAgICAg
ICAgICAgICAgICAgIFNldCBpbnN0YWxsYXRpb24gcHJlZml4IHRvIHRoZSBnaXZlbiBwYXRoIChH
dGsvRWZsIG9ubHkpCiAgIC0tbWFrZWFyZ3M9PGFyZ3VtZW50cz4gICAgICAgICAgICBPcHRpb25h
bCBNYWtlZmlsZSBmbGFncwogICAtLXFtYWtlYXJnPTxhcmd1bWVudHM+ICAgICAgICAgICAgT3B0
aW9uYWwgcW1ha2UgZmxhZ3MgKFF0IG9ubHksIGUuZy4gLS1xbWFrZWFyZz0iQ09ORklHKz13ZWJr
aXQyIiB0byBidWlsZCBXZWJLaXQyKQorICAtLWNtYWtlYXJnPTxhcmd1bWVudHM+ICAgICAgICAg
ICAgT3B0aW9uYWwgQ01ha2UgZmxhZ3MgKGUuZy4gLS1jbWFrZWFyZz0iLURGT089YmFyIC1EQ01B
S0VfUFJFRklYX1BBVEg9L3Vzci9sb2NhbCIpCiAKICAgLS1taW5pbWFsICAgICAgICAgICAgICAg
ICAgICAgICAgIE5vIG9wdGlvbmFsIGZlYXR1cmVzLCB1bmxlc3MgZXhwbGljaXRseSBlbmFibGVk
CiAKQEAgLTQwNyw2ICs0MDksNyBAQCBteSAlb3B0aW9ucyA9ICgKICAgICAnaW5zdGFsbC1saWJz
PXMnID0+IFwkaW5zdGFsbExpYnMsCiAgICAgJ3ByZWZpeD1zJyA9PiBcJHByZWZpeFBhdGgsCiAg
ICAgJ21ha2VhcmdzPXMnID0+IFwkbWFrZUFyZ3MsCisgICAgJ2NtYWtlYXJncz1zJyA9PiBcJGNt
YWtlQXJncywKICAgICAnbWluaW1hbCcgPT4gXCRtaW5pbWFsLAogICAgICd2OCcgPT4gXCR2OCwK
ICAgICAnb25seS13ZWJraXQnID0+IFwkb25seVdlYktpdFByb2plY3QsCkBAIC01OTgsMTEgKzYw
MSwxMSBAQCBpZiAoaXNDaHJvbWl1bSgpKSB7CiBpZiAoaXNFZmwoKSkgewogICAgICMgQnkgZGVm
YXVsdCB3ZSBidWlsZCB1c2luZyBhbGwgb2YgdGhlIGF2YWlsYWJsZSBDUFVzLgogICAgICRtYWtl
QXJncyAuPSAoJG1ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1qIiAuIG51bWJlck9mQ1BVcygpIGlm
ICRtYWtlQXJncyAhfiAvLWpccypcZCsvOwotICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRj
bGVhbiwgIkVmbCIsICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIGNNYWtlQXJnc0Zyb21GZWF0dXJl
cygpKTsKKyAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4sICJFZmwiLCAkcHJlZml4
UGF0aCwgJG1ha2VBcmdzLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKSwgJGNtYWtlQXJncyk7CiB9
CiAKIGlmIChpc1dpbkNFKCkpIHsKLSAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4s
ICJXaW5DRSIsICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsICgiLURDTUFLRV9XSU5DRV9TREs9XCJT
VEFOREFSRFNES181MDAgKEFSTVY0SSlcIiIsIGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpKSk7Cisg
ICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJGNsZWFuLCAiV2luQ0UiLCAkcHJlZml4UGF0aCwg
JG1ha2VBcmdzLCAoIi1EQ01BS0VfV0lOQ0VfU0RLPVwiU1RBTkRBUkRTREtfNTAwIChBUk1WNEkp
XCIiLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKSksICRjbWFrZUFyZ3MpOwogfQogCiAjIEJ1aWxk
LCBhbmQgYWJvcnQgaWYgdGhlIGJ1aWxkIGZhaWxzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0
cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDY1MTU0
ZTEwNjk4NDNkMzgwNWMyMDM1NGNhYmU0MTBmNGFlM2UxZGUuLjkyMzZkZDI2OTc2NGE0MDhiOGMz
MjBiZTgwNzliYmE1MmNiNmViNmIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly
cy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE2MjUsNyArMTYyNSw3
IEBAIHN1YiBidWlsZEF1dG90b29sc1Byb2plY3QoJEApCiAKIHN1YiBnZW5lcmF0ZUJ1aWxkU3lz
dGVtRnJvbUNNYWtlUHJvamVjdAogewotICAgIG15ICgkcG9ydCwgJHByZWZpeFBhdGgsIEBjbWFr
ZUFyZ3MpID0gQF87CisgICAgbXkgKCRwb3J0LCAkcHJlZml4UGF0aCwgQGNtYWtlQXJncywgJGFk
ZGl0aW9uYWxDTWFrZUFyZ3MpID0gQF87CiAgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24o
KTsKICAgICBteSAkYnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGly
KCksICRjb25maWcpOwogICAgIEZpbGU6OlBhdGg6Om1rcGF0aCgkYnVpbGRQYXRoKSB1bmxlc3Mg
LWQgJGJ1aWxkUGF0aDsKQEAgLTE2NDEsNiArMTY0MSw4IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lz
dGVtRnJvbUNNYWtlUHJvamVjdAogICAgICAgICBwdXNoIEBhcmdzLCAiLURDTUFLRV9CVUlMRF9U
WVBFPURlYnVnIjsKICAgICB9CiAgICAgcHVzaCBAYXJncywgQGNtYWtlQXJncyBpZiBAY21ha2VB
cmdzOworICAgIHB1c2ggQGFyZ3MsICRhZGRpdGlvbmFsQ01ha2VBcmdzIGlmICRhZGRpdGlvbmFs
Q01ha2VBcmdzOworCiAgICAgcHVzaCBAYXJncywgJyInIC4gRmlsZTo6U3BlYy0+Y2F0ZGlyKHNv
dXJjZURpcigpLCAiU291cmNlIikgLiAnIic7CiAKICAgICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFr
ZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFrZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdz
IGlzCg==
</data>
<flag name="review"
          id="113467"
          type_id="1"
          status="+"
          setter="dbates"
    />
    <flag name="commit-queue"
          id="113468"
          type_id="3"
          status="-"
          setter="dbates"
    />
          </attachment>
      

    </bug>

</bugzilla>