72140 2011-11-11 09:18:35 -0800 [EFL] Clean up and refactor the memory cache functions in ewk_settings. 2011-12-15 11:45:57 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 500835 0 rakuco 2011-11-11 09:18:35 -0800 [EFL] Clean up and refactor the memory cache functions in ewk_settings. 500837 1 114715 rakuco 2011-11-11 09:20:04 -0800 Created attachment 114715 Patch 500844 2 114715 gyuyoung.kim 2011-11-11 09:28:04 -0800 Comment on attachment 114715 Patch Attachment 114715 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10396270 500846 3 114715 rakuco 2011-11-11 09:32:26 -0800 Comment on attachment 114715 Patch Unmarking r? as this depends on an upcoming patch. 503983 4 114715 rakuco 2011-11-16 09:44:04 -0800 Comment on attachment 114715 Patch Patch applies fine now, flagging r? and cq? 517052 5 114715 gyuyoung.kim 2011-12-07 18:03:30 -0800 Comment on attachment 114715 Patch LGTM. 522109 6 114715 webkit.review.bot 2011-12-15 11:45:52 -0800 Comment on attachment 114715 Patch Clearing flags on attachment: 114715 Committed r102971: <http://trac.webkit.org/changeset/102971> 522110 7 webkit.review.bot 2011-12-15 11:45:57 -0800 All reviewed patches have been landed. Closing bug. 114715 2011-11-11 09:20:04 -0800 2011-12-15 11:45:52 -0800 Patch bug-72140-20111111152024.patch text/plain 5539 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA3NDIwODlmYzY1 ZjY2ODI3Yjg5NTVjYzE4NDY2ZDM5NjI3NTdhOWY5Li44MDdiYmQwYWY4ZWE3ZDU4ZjdkYTMyMTRk NDU0NTA3YWZkNDIyNTk5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTEt MTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKKyAg ICAgICAgW0VGTF0gQ2xlYW4gdXAgYW5kIHJlZmFjdG9yIHRoZSBtZW1vcnkgY2FjaGUgZnVuY3Rp b25zIGluIGV3a19zZXR0aW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcyMTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIGEgYmV0dGVyIG5hbWluZyBwcmVmaXgsIGFzICJld2tfc2V0dGluZ3Nf Y2FjaGUiIHdhcyB0b28gZ2VuZXJhbCwKKyAgICAgICAgYW5kIG1ha2UgaXQgcG9zc2libGUgdG8g cGFzcyBhbGwgcGFyYW1ldGVycyB0bworICAgICAgICBNZW1vcnlDYWNoZTo6c2V0Q2FwYWNpdGll cygpLgorCisgICAgICAgICogZXdrL2V3a19zZXR0aW5ncy5jcHA6CisgICAgICAgIChld2tfc2V0 dGluZ3Nfb2JqZWN0X2NhY2hlX2NhcGFjaXR5X3NldCk6CisgICAgICAgIChld2tfc2V0dGluZ3Nf b2JqZWN0X2NhY2hlX2VuYWJsZV9nZXQpOgorICAgICAgICAoZXdrX3NldHRpbmdzX29iamVjdF9j YWNoZV9lbmFibGVfc2V0KToKKyAgICAgICAgKiBld2svZXdrX3NldHRpbmdzLmg6CisKKzIwMTEt MTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKICAg ICAgICAgW0VGTF0gQ2xlYW4gdXAgdGhlIHdlYiBkYXRhYmFzZS1yZWxhdGVkIGZ1bmN0aW9ucyBp biBld2tfc2V0dGluZ3MuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MjEzOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Nl dHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCmluZGV4 IGIzNDAyMmVmOGEzMDY2YTUxNjQ2YWRkODE0NTFlNGFhODViMWM4NjYuLjA3NGEyZmU1MTc0MWNi YzMzZDk4MTZmYmU4ZTQ3YWE1ZWMzYzkxOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0 dGluZ3MuY3BwCkBAIC0xODksMjQgKzE4OSwxOSBAQCBFdmFzX09iamVjdCogZXdrX3NldHRpbmdz X2ljb25fZGF0YWJhc2VfaWNvbl9vYmplY3RfYWRkKGNvbnN0IGNoYXIqIHVybCwgRXZhcyogYwog ICAgIHJldHVybiBld2tfdXRpbF9pbWFnZV9mcm9tX2NhaXJvX3N1cmZhY2VfYWRkKGNhbnZhcywg c3VyZmFjZSk7CiB9CiAKLUVpbmFfQm9vbCBld2tfc2V0dGluZ3NfY2FjaGVfZW5hYmxlX2dldCh2 b2lkKQordm9pZCBld2tfc2V0dGluZ3Nfb2JqZWN0X2NhY2hlX2NhcGFjaXR5X3NldCh1bnNpZ25l ZCBtaW5EZWFkQ2FwYWNpdHksIHVuc2lnbmVkIG1heERlYWRDYXBhY2l0eSwgdW5zaWduZWQgdG90 YWxDYXBhY2l0eSkKIHsKLSAgICBXZWJDb3JlOjpNZW1vcnlDYWNoZSogY2FjaGUgPSBXZWJDb3Jl OjptZW1vcnlDYWNoZSgpOwotICAgIHJldHVybiAhY2FjaGUtPmRpc2FibGVkKCk7CisgICAgV2Vi Q29yZTo6bWVtb3J5Q2FjaGUoKS0+c2V0Q2FwYWNpdGllcyhtaW5EZWFkQ2FwYWNpdHksIG1heERl YWRDYXBhY2l0eSwgdG90YWxDYXBhY2l0eSk7CiB9CiAKLXZvaWQgZXdrX3NldHRpbmdzX2NhY2hl X2VuYWJsZV9zZXQoRWluYV9Cb29sIHNldCkKK0VpbmFfQm9vbCBld2tfc2V0dGluZ3Nfb2JqZWN0 X2NhY2hlX2VuYWJsZV9nZXQoKQogewotICAgIFdlYkNvcmU6Ok1lbW9yeUNhY2hlKiBjYWNoZSA9 IFdlYkNvcmU6Om1lbW9yeUNhY2hlKCk7Ci0gICAgc2V0ID0gIXNldDsKLSAgICBpZiAoY2FjaGUt PmRpc2FibGVkKCkgIT0gc2V0KQotICAgICAgICBjYWNoZS0+c2V0RGlzYWJsZWQoc2V0KTsKKyAg ICByZXR1cm4gIVdlYkNvcmU6Om1lbW9yeUNhY2hlKCktPmRpc2FibGVkKCk7CiB9CiAKLXZvaWQg ZXdrX3NldHRpbmdzX2NhY2hlX2NhcGFjaXR5X3NldCh1bnNpZ25lZCBjYXBhY2l0eSkKK3ZvaWQg ZXdrX3NldHRpbmdzX29iamVjdF9jYWNoZV9lbmFibGVfc2V0KEVpbmFfQm9vbCBlbmFibGUpCiB7 Ci0gICAgV2ViQ29yZTo6TWVtb3J5Q2FjaGUqIGNhY2hlID0gV2ViQ29yZTo6bWVtb3J5Q2FjaGUo KTsKLSAgICBjYWNoZS0+c2V0Q2FwYWNpdGllcygwLCBjYXBhY2l0eSwgY2FwYWNpdHkpOworICAg IFdlYkNvcmU6Om1lbW9yeUNhY2hlKCktPnNldERpc2FibGVkKCFlbmFibGUpOwogfQogCiB2b2lk IGV3a19zZXR0aW5nc19yZXBhaW50X3Rocm90dGxpbmdfc2V0KGRvdWJsZSBkZWZlcnJlZFJlcGFp bnREZWxheSwgZG91YmxlIGluaXRpYWxEZWZlcnJlZFJlcGFpbnREZWxheUR1cmluZ0xvYWRpbmcs IGRvdWJsZSBtYXhEZWZlcnJlZFJlcGFpbnREZWxheUR1cmluZ0xvYWRpbmcsIGRvdWJsZSBkZWZl cnJlZFJlcGFpbnREZWxheUluY3JlbWVudER1cmluZ0xvYWRpbmcpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NldHRpbmdzLmgKaW5kZXggODUzY2M4MGNkNWE4NDQ2OWVhMDliOGExYmJkZWNiZjdkMTM1 YjQxMS4uODhjMjlmMTlkMzYyMjI0OWZhMjg2MDA5Nzg2ZTQwOWZhMWVmOTA4NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaApAQCAtMTYwLDMwICsxNjAsNTEgQEAgRUFQSSB2b2lk ICAgICAgICAgICAgIGV3a19zZXR0aW5nc19hcHBsaWNhdGlvbl9jYWNoZV9wYXRoX3NldChjb25z dCBjaGFyICpwYXRoKTsKIEVBUEkgY29uc3QgY2hhciAgICAgICpld2tfc2V0dGluZ3NfYXBwbGlj YXRpb25fY2FjaGVfcGF0aF9nZXQodm9pZCk7CiAKIC8qKgotICogR2V0cyBzdGF0dXMgb2YgdGhl IG1lbW9yeSBjYWNoZSBvZiBXZWJDb3JlLgorICogUmV0dXJucyB3aGV0aGVyIHRoZSBpbi1tZW1v cnkgb2JqZWN0IGNhY2hlIGlzIGVuYWJsZWQuCisgKgorICogVGhlIG9iamVjdCBjYWNoZSBpcyBy ZXNwb25zaWJsZSBmb3IgaG9sZGluZyByZXNvdXJjZXMgc3VjaCBhcyBzY3JpcHRzLCBzdHlsZXNo ZWV0cworICogYW5kIGltYWdlcyBpbiBtZW1vcnkuCisgKgorICogQnkgZGVmYXVsdCwgdGhlIGNh Y2hlIGlzIGVuYWJsZWQuCiAgKgogICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgdGhlIGNhY2hl IGlzIGVuYWJsZWQgb3IgQGMgRUlOQV9GQUxTRSBpZiBub3QKKyAqCisgKiBAc2EgZXdrX3NldHRp bmdzX29iamVjdF9jYWNoZV9jYXBhY2l0eV9zZXQKICAqLwotRUFQSSBFaW5hX0Jvb2wgICAgICAg IGV3a19zZXR0aW5nc19jYWNoZV9lbmFibGVfZ2V0KHZvaWQpOworRUFQSSBFaW5hX0Jvb2wgICAg ICAgIGV3a19zZXR0aW5nc19vYmplY3RfY2FjaGVfZW5hYmxlX2dldCh2b2lkKTsKIAogLyoqCi0g KiBFbmFibGVzL2Rpc2FibGVzIHRoZSBtZW1vcnkgY2FjaGUgb2YgV2ViQ29yZSwgcG9zc2libHkg Y2xlYXJpbmcgaXQuCisgKiBFbmFibGVzL2Rpc2FibGVzIHRoZSBpbi1tZW1vcnkgb2JqZWN0IGNh Y2hlIG9mIFdlYkNvcmUsIHBvc3NpYmx5IGNsZWFyaW5nIGl0LgorICoKKyAqIFRoZSBvYmplY3Qg Y2FjaGUgaXMgcmVzcG9uc2libGUgZm9yIGhvbGRpbmcgcmVzb3VyY2VzIHN1Y2ggYXMgc2NyaXB0 cywgc3R5bGVzaGVldHMKKyAqIGFuZCBpbWFnZXMgaW4gbWVtb3J5LgorICoKKyAqIEJ5IGRlZmF1 bHQsIHRoZSBjYWNoZSBpcyBlbmFibGVkLgogICoKICAqIERpc2FibGluZyB0aGUgY2FjaGUgd2ls bCByZW1vdmUgYWxsIHJlc291cmNlcyBmcm9tIHRoZSBjYWNoZS4KICAqIFRoZXkgbWF5IHN0aWxs IGxpdmUgb24gaWYgdGhleSBhcmUgcmVmZXJlbmNlZCBieSBzb21lIFdlYiBwYWdlIHRob3VnaC4K ICAqCiAgKiBAcGFyYW0gc2V0IEBjIEVJTkFfVFJVRSB0byBlbmFibGUgbWVtb3J5IGNhY2hlLCBA YyBFSU5BX0ZBTFNFIHRvIGRpc2FibGUKICAqLwotRUFQSSB2b2lkICAgICAgICAgICAgIGV3a19z ZXR0aW5nc19jYWNoZV9lbmFibGVfc2V0KEVpbmFfQm9vbCBzZXQpOworRUFQSSB2b2lkICAgICAg ICAgICAgIGV3a19zZXR0aW5nc19vYmplY3RfY2FjaGVfZW5hYmxlX3NldChFaW5hX0Jvb2wgc2V0 KTsKIAogLyoqCi0gKiBTZXRzIGNhcGFjaXR5IG9mIG1lbW9yeSBjYWNoZSBvZiBXZWJDb3JlLgor ICogRGVmaW5lcyB0aGUgY2FwYWNpdGllcyBmb3IgdGhlIGluLW1lbW9yeSBvYmplY3QgY2FjaGUu CisgKgorICogVGhlIG9iamVjdCBjYWNoZSBpcyByZXNwb25zaWJsZSBmb3IgaG9sZGluZyByZXNv dXJjZXMgc3VjaCBhcyBzY3JpcHRzLCBzdHlsZXNoZWV0cworICogYW5kIGltYWdlcyBpbiBtZW1v cnkuCisgKgorICogQnkgZGVmYXVsdCwgQHAgbWluX2RlYWRfYnl0ZXMgaXMgMCBhbmQgYm90aCBA cCBtYXhfZGVhZF9ieXRlcyBhbmQgQHAgdG90YWxfYnl0ZXMgYXJlIDhNQi4KICAqCi0gKiBXZWJD b3JlIHNldHMgZGVmYXVsdCB2YWx1ZSBvZiBtZW1vcnkgY2FjaGUgb24gODE5MiAqIDEwMjQgYnl0 ZXMuCisgKiBAcGFyYW0gbWluX2RlYWRfYnl0ZXMgVGhlIG1heGltdW0gbnVtYmVyIG9mIGJ5dGVz IHRoYXQgZGVhZCByZXNvdXJjZXMgc2hvdWxkIGNvbnN1bWUgd2hlbgorICogICAgICAgICAgICAg ICAgICAgICAgIHRoZSBjYWNoZSBpcyB1bmRlciBwcmVzc3VyZS4KKyAqIEBwYXJhbSBtYXhfZGVh ZF9ieXRlcyBUaGUgbWF4aW11bSBudW1iZXIgb2YgYnl0ZXMgdGhhdCBkZWFkIHJlc291cmNlcyBz aG91bGQgY29uc3VtZSB3aGVuCisgKiAgICAgICAgICAgICAgICAgICAgICAgdGhlIGNhY2hlIGlz IG5vdCB1bmRlciBwcmVzc3VyZS4KKyAqIEBwYXJhbSB0b3RhbF9ieXRlcyAgICBUaGUgbWF4aW11 bSBudW1iZXIgb2YgYnl0ZXMgdGhhdCB0aGUgY2FjaGUgc2hvdWxkIGNvbnN1bWUgb3ZlcmFsbC4K ICAqCiAgKiBAcGFyYW0gY2FwYWNpdHkgdGhlIG1heGltdW0gbnVtYmVyIG9mIGJ5dGVzIHRoYXQg dGhlIGNhY2hlIHNob3VsZCBjb25zdW1lIG92ZXJhbGwKICAqLwotRUFQSSB2b2lkICAgICAgICAg ICAgIGV3a19zZXR0aW5nc19jYWNoZV9jYXBhY2l0eV9zZXQodW5zaWduZWQgY2FwYWNpdHkpOwor RUFQSSB2b2lkICAgICAgICAgICAgIGV3a19zZXR0aW5nc19vYmplY3RfY2FjaGVfY2FwYWNpdHlf c2V0KHVuc2lnbmVkIG1pbl9kZWFkX2J5dGVzLCB1bnNpZ25lZCBtYXhfZGVhZF9ieXRlcywgdW5z aWduZWQgdG90YWxfYnl0ZXMpOwogCiAvKioKICAqIFNldHMgdmFsdWVzIGZvciByZXBhaW50IHRo cm90dGxpbmcuCg==