<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72139</bug_id>
          
          <creation_ts>2011-11-11 09:08:15 -0800</creation_ts>
          <short_desc>[EFL] Clean up the web database-related functions in ewk_settings.</short_desc>
          <delta_ts>2011-11-16 09:33:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>72127</dependson>
          <blocked>72148</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>leandro</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>500827</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 09:08:15 -0800</bug_when>
    <thetext>[EFL] Clean up the web database-related functions in ewk_settings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500832</commentid>
    <comment_count>1</comment_count>
      <attachid>114714</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-11 09:10:07 -0800</bug_when>
    <thetext>Created attachment 114714
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>501549</commentid>
    <comment_count>2</comment_count>
      <attachid>114714</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-13 14:51:44 -0800</bug_when>
    <thetext>Comment on attachment 114714
Patch

Rejecting attachment 114714 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
Parsed 3 diffs from patch file(s).
patching file Source/WebKit/efl/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/efl/ewk/ewk_settings.cpp
Hunk #2 succeeded at 47 with fuzz 1.
Hunk #3 FAILED at 77.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_settings.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_settings.h

Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Kenneth Rohde Christia...&quot; exit_code: 1

Full output: http://queues.webkit.org/results/10476029</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503929</commentid>
    <comment_count>3</comment_count>
      <attachid>114714</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-11-16 08:49:26 -0800</bug_when>
    <thetext>Comment on attachment 114714
Patch

This one is also applying fine now, reflagging r?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503968</commentid>
    <comment_count>4</comment_count>
      <attachid>114714</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-16 09:33:44 -0800</bug_when>
    <thetext>Comment on attachment 114714
Patch

Clearing flags on attachment: 114714

Committed r100463: &lt;http://trac.webkit.org/changeset/100463&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503969</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-16 09:33:49 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>114714</attachid>
            <date>2011-11-11 09:10:07 -0800</date>
            <delta_ts>2011-11-16 09:33:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-72139-20111111151028.patch</filename>
            <type>text/plain</type>
            <size>3976</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAyOWQzN2IxMDhi
NzUwMmRiOWY5OTZiMTc0NzMyYjYzZTQ2MTZkZTc2Li43NDIwODlmYzY1ZjY2ODI3Yjg5NTVjYzE4
NDY2ZDM5NjI3NTdhOWY5IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTEt
MTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKKyAg
ICAgICAgW0VGTF0gQ2xlYW4gdXAgdGhlIHdlYiBkYXRhYmFzZS1yZWxhdGVkIGZ1bmN0aW9ucyBp
biBld2tfc2V0dGluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD03MjEzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIE1vc3RseSByZW1vdmUgc29tZSB1bm5lY2Vzc2FyeSBFTkFCTEUoU1FMX0RBVEFCQVNF
KSBjaGVja3MgYW5kIHVzZSBhCisgICAgICAgIG1vcmUgc3RhbmRhcmQgbmFtaW5nIHNjaGVtZSBm
b3IgdGhlIHJlbGF0ZWQgc3RhdGljIHZhcmlhYmxlcy4KKworICAgICAgICAqIGV3ay9ld2tfc2V0
dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1
b3RhX2dldCk6CisgICAgICAgIChld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfc2V0KToK
KyAgICAgICAgKGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9nZXQpOgorICAgICAgICAq
IGV3ay9ld2tfc2V0dGluZ3MuaDogRG9jdW1lbnQgdGhlIGRlZmF1bHQgd2ViIGRhdGFiYXNlIHBh
dGggb24gZGlzay4KKworMjAxMS0xMS0xMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bw
cm9mdXNpb24ubW9iaT4KKwogICAgICAgICBbRUZMXSBJbXByb3ZlIHRoZSBkb2N1bWVudGF0aW9u
IG9mIGV3a192aWV3X3NldHRpbmdfbG9jYWxfc3RvcmFnZV8qLgogICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxMzUKIApkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv
ZXdrX3NldHRpbmdzLmNwcAppbmRleCA3MDVkZTMwYzhlOTllYWNlN2IyNzI2MTM5NGNkZjlkMTQ1
ZjExNTlhLi5iMzQwMjJlZjhhMzA2NmE1MTY0NmFkZDgxNDUxZTRhYTg1YjFjODY2IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcAorKysgYi9Tb3VyY2Uv
V2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcApAQCAtMjEsMTAgKzIxLDggQEAKICNpbmNs
dWRlICJjb25maWcuaCIKICNpbmNsdWRlICJld2tfc2V0dGluZ3MuaCIKIAotI2luY2x1ZGUgIkVX
ZWJLaXQuaCIKLSNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQogI2luY2x1ZGUgIkRhdGFiYXNlVHJh
Y2tlci5oIgotI2VuZGlmCisjaW5jbHVkZSAiRVdlYktpdC5oIgogI2luY2x1ZGUgIkZyYW1lVmll
dy5oIgogI2luY2x1ZGUgIkljb25EYXRhYmFzZS5oIgogI2luY2x1ZGUgIkltYWdlLmgiCkBAIC00
OSwxMCArNDcsOSBAQAogc3RhdGljIGNvbnN0IGNoYXIqIHNfb2ZmbGluZUFwcENhY2hlUGF0aCA9
IDA7CiAKIHN0YXRpYyBjb25zdCBjaGFyKiBfZXdrX2ljb25fZGF0YWJhc2VfcGF0aCA9IDA7Ci0j
aWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKLXN0YXRpYyBjb25zdCBjaGFyKiBfZXdrX2RlZmF1bHRf
d2ViX2RhdGFiYXNlX3BhdGggPSAwOwotc3RhdGljIHVpbnQ2NF90IF9ld2tfZGVmYXVsdF93ZWJf
ZGF0YWJhc2VfcXVvdGEgPSAxICogMTAyNCAqIDEwMjQ7Ci0jZW5kaWYKKworc3RhdGljIGNvbnN0
IGNoYXIqIHNfd2ViRGF0YWJhc2VQYXRoID0gMDsKK3N0YXRpYyB1aW50NjRfdCBzX3dlYkRhdGFi
YXNlUXVvdGEgPSAxICogMTAyNCAqIDEwMjQ7IC8vIDFNQi4KIAogc3RhdGljIFdURjo6U3RyaW5n
IF9ld2tfc2V0dGluZ3Nfd2Via2l0X3BsYXRmb3JtX2dldCgpCiB7CkBAIC04MCwyOCArNzcsMjAg
QEAgc3RhdGljIFdURjo6U3RyaW5nIF9ld2tfc2V0dGluZ3Nfd2Via2l0X29zX3ZlcnNpb25fZ2V0
KCkKIAogdWludDY0X3QgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1b3RhX2dl
dCgpCiB7Ci0jaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKLSAgICByZXR1cm4gX2V3a19kZWZhdWx0
X3dlYl9kYXRhYmFzZV9xdW90YTsKLSNlbHNlCi0gICAgcmV0dXJuIDA7Ci0jZW5kaWYKKyAgICBy
ZXR1cm4gc193ZWJEYXRhYmFzZVF1b3RhOwogfQogCiB2b2lkIGV3a19zZXR0aW5nc193ZWJfZGF0
YWJhc2VfcGF0aF9zZXQoY29uc3QgY2hhciogcGF0aCkKIHsKICNpZiBFTkFCTEUoU1FMX0RBVEFC
QVNFKQogICAgIFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tlcjo6dHJhY2tlcigpLnNldERhdGFiYXNl
RGlyZWN0b3J5UGF0aChXVEY6OlN0cmluZzo6ZnJvbVVURjgocGF0aCkpOwotICAgIGVpbmFfc3Ry
aW5nc2hhcmVfcmVwbGFjZSgmX2V3a19kZWZhdWx0X3dlYl9kYXRhYmFzZV9wYXRoLCBwYXRoKTsK
KyAgICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJnNfd2ViRGF0YWJhc2VQYXRoLCBwYXRoKTsK
ICNlbmRpZgogfQogCiBjb25zdCBjaGFyKiBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhf
Z2V0KHZvaWQpCiB7Ci0jaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKLSAgICByZXR1cm4gX2V3a19k
ZWZhdWx0X3dlYl9kYXRhYmFzZV9wYXRoOwotI2Vsc2UKLSAgICByZXR1cm4gMDsKLSNlbmRpZgor
ICAgIHJldHVybiBzX3dlYkRhdGFiYXNlUGF0aDsKIH0KIAogRWluYV9Cb29sIGV3a19zZXR0aW5n
c19pY29uX2RhdGFiYXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIqIGRpcmVjdG9yeSkKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJLaXQv
ZWZsL2V3ay9ld2tfc2V0dGluZ3MuaAppbmRleCA2MmMzZjU3M2I3ZDVjMDk2YTViMWFmNDhjNWY0
YjgwYWM0MzVlNjlkLi44NTNjYzgwY2Q1YTg0NDY5ZWEwOWI4YTFiYmRlY2JmN2QxMzViNDExIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKKysrIGIvU291
cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5ncy5oCkBAIC00Nyw2ICs0Nyw4IEBAIEVBUEkg
dWludDY0X3QgICAgICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX2RlZmF1bHRfcXVvdGFf
Z2V0KHZvaWQpOwogICogU2V0cyB0aGUgY3VycmVudCBwYXRoIHRvIHRoZSBkaXJlY3RvcnkgV2Vi
S2l0IHdpbGwgd3JpdGUgV2ViCiAgKiBEYXRhYmFzZSBkYXRhYmFzZXMuCiAgKgorICogQnkgZGVm
YXVsdCwgdGhlIHZhbHVlIGlzIEBjIH4vLndlYmtpdAorICoKICAqIEBwYXJhbSBwYXRoIHRoZSBu
ZXcgZGF0YWJhc2UgZGlyZWN0b3J5IHBhdGgKICAqLwogRUFQSSB2b2lkICAgICAgICAgICAgIGV3
a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9zZXQoY29uc3QgY2hhciAqcGF0aCk7CkBAIC01
NCw2ICs1Niw4IEBAIEVBUEkgdm9pZCAgICAgICAgICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFi
YXNlX3BhdGhfc2V0KGNvbnN0IGNoYXIgKnBhdGgpOwogLyoqCiAgKiBSZXR1cm5zIGRpcmVjdG9y
eSBwYXRoIHdoZXJlIHdlYiBkYXRhYmFzZSBpcyBzdG9yZWQuCiAgKgorICogQnkgZGVmYXVsdCwg
dGhlIHZhbHVlIGlzIEBjIH4vLndlYmtpdAorICoKICAqIFRoaXMgaXMgZ3VhcmFudGVlZCB0byBi
ZSBlaW5hX3N0cmluZ3NoYXJlLCBzbyB3aGVuZXZlciBwb3NzaWJsZQogICogc2F2ZSB5b3Vyc2Vs
ZiBzb21lIGNwdSBjeWNsZXMgYW5kIHVzZSBlaW5hX3N0cmluZ3NoYXJlX3JlZigpCiAgKiBpbnN0
ZWFkIG9mIGVpbmFfc3RyaW5nc2hhcmVfYWRkKCkgb3Igc3RyZHVwKCkuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>