72127 2011-11-11 08:07:46 -0800 [EFL] Simplify eina_stringshare usage in ewk_settings. 2011-11-13 15:04:06 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72132 72139 1 rakuco rakuco gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 500775 0 rakuco 2011-11-11 08:07:46 -0800 [EFL] Simplify eina_stringshare usage in ewk_settings. 500780 1 114700 rakuco 2011-11-11 08:10:52 -0800 Created attachment 114700 Patch 501553 2 114700 webkit.review.bot 2011-11-13 15:04:00 -0800 Comment on attachment 114700 Patch Clearing flags on attachment: 114700 Committed r100096: <http://trac.webkit.org/changeset/100096> 501554 3 webkit.review.bot 2011-11-13 15:04:06 -0800 All reviewed patches have been landed. Closing bug. 114700 2011-11-11 08:10:52 -0800 2011-11-13 15:03:59 -0800 Patch bug-72127-20111111141114.patch text/plain 3492 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5NjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA5MzIxNjY5Y2Q2 ZTE1YzI5YjZlMTI0MTMxYzljNzJiZTQ2N2Q0YjdmLi5jYWNiYmM4YjgxYTE0NWFjZDc5YTNlNWU3 OWIzNjM5ODU5NzQ1ZjBhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MTEtMTEgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gU2ltcGxpZnkgZWluYV9zdHJpbmdzaGFyZSB1c2FnZSBpbiBld2tfc2V0dGlu Z3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjEy NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjdHVh bGx5IHVzZSB0aGUgZWluYV9zdHJpbmdzaGFyZSBmdW5jdGlvbnMgaW4gYSBzYW5lIHdheS4KKwor ICAgICAgICAqIGV3ay9ld2tfc2V0dGluZ3MuY3BwOgorICAgICAgICAoZXdrX3NldHRpbmdzX3dl Yl9kYXRhYmFzZV9wYXRoX3NldCk6IEp1c3QgdXNlCisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVf cmVwbGFjZSBpbnN0ZWFkIG9mIGRvaW5nIG5lZWRsZXNzIGNoZWNrcyBhbmQgdXNpbmcKKyAgICAg ICAgZWluYV9zdHJpbmdzaGFyZV9hZGQuCisgICAgICAgIChld2tfc2V0dGluZ3NfY2FjaGVfZGly ZWN0b3J5X3BhdGhfc2V0KTogRGl0dG8uCisgICAgICAgIChld2tfc2V0dGluZ3NfaWNvbl9kYXRh YmFzZV9wYXRoX3NldCk6IERpdHRvIGFuZCBhbHdheXMgY2FsbAorICAgICAgICBlaW5hX3N0cmlu Z3NoYXJlX2RlbCwgYXMgcGFzc2luZyBOVUxMIHRvIGl0IGlzIGp1c3QgYSBOT1AuCisKIDIwMTEt MTEtMDkgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKICAg ICAgICAgW0VGTF0gUmVtb3ZlIHVubmVjZXNzYXJ5IGNhc3RzIHdoZW4gY3JlYXRpbmcgdGhlIFdl YkNvcmVTdXBwb3J0IG9iamVjdHMgaW4gZXdrX3ZpZXcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf c2V0dGluZ3MuY3BwCmluZGV4IDU0ZDdjNzIyMWUwM2I5ZmMyMGVjMDlhMzRmODA0ZjdkYTZlNTk5 YTMuLmNiYzg4ODk0MTIyNzNhMTNmNjNmNzZmZThkNTIwMzJiYWRlNjM0ZmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuY3BwCkBAIC05MCwxMyArOTAsOCBAQCB1aW50NjRfdCBl d2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX2RlZmF1bHRfcXVvdGFfZ2V0KCkKIHZvaWQgZXdrX3Nl dHRpbmdzX3dlYl9kYXRhYmFzZV9wYXRoX3NldChjb25zdCBjaGFyKiBwYXRoKQogewogI2lmIEVO QUJMRShTUUxfREFUQUJBU0UpCi0gICAgV1RGOjpTdHJpbmcgY29yZVBhdGggPSBXVEY6OlN0cmlu Zzo6ZnJvbVVURjgocGF0aCk7Ci0gICAgV2ViQ29yZTo6RGF0YWJhc2VUcmFja2VyOjp0cmFja2Vy KCkuc2V0RGF0YWJhc2VEaXJlY3RvcnlQYXRoKGNvcmVQYXRoKTsKLSAgICBpZiAoIV9ld2tfZGVm YXVsdF93ZWJfZGF0YWJhc2VfcGF0aCkKLSAgICAgICAgX2V3a19kZWZhdWx0X3dlYl9kYXRhYmFz ZV9wYXRoID0gZWluYV9zdHJpbmdzaGFyZV9hZGQoY29yZVBhdGgudXRmOCgpLmRhdGEoKSk7Ci0g ICAgZWxzZQotICAgICAgICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJl9ld2tfZGVmYXVsdF93 ZWJfZGF0YWJhc2VfcGF0aCwgY29yZVBhdGgudXRmOCgpLmRhdGEoKSk7Ci0KKyAgICBXZWJDb3Jl OjpEYXRhYmFzZVRyYWNrZXI6OnRyYWNrZXIoKS5zZXREYXRhYmFzZURpcmVjdG9yeVBhdGgoV1RG OjpTdHJpbmc6OmZyb21VVEY4KHBhdGgpKTsKKyAgICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2Uo Jl9ld2tfZGVmYXVsdF93ZWJfZGF0YWJhc2VfcGF0aCwgcGF0aCk7CiAjZW5kaWYKIH0KIApAQCAt MTM5LDE3ICsxMzQsMTQgQEAgRWluYV9Cb29sIGV3a19zZXR0aW5nc19pY29uX2RhdGFiYXNlX3Bh dGhfc2V0KGNvbnN0IGNoYXIqIGRpcmVjdG9yeSkKIAogICAgICAgICBXZWJDb3JlOjppY29uRGF0 YWJhc2UoKS5zZXRFbmFibGVkKHRydWUpOwogICAgICAgICBXZWJDb3JlOjppY29uRGF0YWJhc2Uo KS5vcGVuKFdURjo6U3RyaW5nOjpmcm9tVVRGOChkaXJlY3RvcnkpLCBXZWJDb3JlOjpJY29uRGF0 YWJhc2U6OmRlZmF1bHREYXRhYmFzZUZpbGVuYW1lKCkpOwotICAgICAgICBpZiAoIV9ld2tfaWNv bl9kYXRhYmFzZV9wYXRoKQotICAgICAgICAgICAgX2V3a19pY29uX2RhdGFiYXNlX3BhdGggPSBl aW5hX3N0cmluZ3NoYXJlX2FkZChkaXJlY3RvcnkpOwotICAgICAgICBlbHNlCi0gICAgICAgICAg ICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJl9ld2tfaWNvbl9kYXRhYmFzZV9wYXRoLCBkaXJl Y3RvcnkpOworCisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgmX2V3a19pY29uX2Rh dGFiYXNlX3BhdGgsIGRpcmVjdG9yeSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgV2ViQ29yZTo6 aWNvbkRhdGFiYXNlKCkuc2V0RW5hYmxlZChmYWxzZSk7CiAgICAgICAgIFdlYkNvcmU6Omljb25E YXRhYmFzZSgpLmNsb3NlKCk7Ci0gICAgICAgIGlmIChfZXdrX2ljb25fZGF0YWJhc2VfcGF0aCkg ewotICAgICAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoX2V3a19pY29uX2RhdGFiYXNlX3Bh dGgpOwotICAgICAgICAgICAgX2V3a19pY29uX2RhdGFiYXNlX3BhdGggPSAwOwotICAgICAgICB9 CisKKyAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoX2V3a19pY29uX2RhdGFiYXNlX3BhdGgp OworICAgICAgICBfZXdrX2ljb25fZGF0YWJhc2VfcGF0aCA9IDA7CiAgICAgfQogICAgIHJldHVy biB0cnVlOwogfQpAQCAtMjU3LDEwICsyNDksOCBAQCBFaW5hX0Jvb2wgZXdrX3NldHRpbmdzX2Nh Y2hlX2RpcmVjdG9yeV9wYXRoX3NldChjb25zdCBjaGFyKiBwYXRoKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICBXZWJDb3JlOjpjYWNoZVN0b3JhZ2UoKS5zZXRDYWNoZURpcmVjdG9yeShX VEY6OlN0cmluZzo6ZnJvbVVURjgocGF0aCkpOwotICAgIGlmICghX2V3a19jYWNoZV9kaXJlY3Rv cnlfcGF0aCkKLSAgICAgICAgX2V3a19jYWNoZV9kaXJlY3RvcnlfcGF0aCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKHBhdGgpOwotICAgIGVsc2UKLSAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBs YWNlKCZfZXdrX2NhY2hlX2RpcmVjdG9yeV9wYXRoLCBwYXRoKTsKKyAgICBlaW5hX3N0cmluZ3No YXJlX3JlcGxhY2UoJl9ld2tfY2FjaGVfZGlyZWN0b3J5X3BhdGgsIHBhdGgpOworCiAgICAgcmV0 dXJuIHRydWU7CiB9CiAK