72115 2011-11-11 05:07:42 -0800 [WIN] Fix build without precompiled header. 2011-11-11 23:57:54 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga webkit.review.bot oldest_to_newest 500685 0 paroga 2011-11-11 05:07:42 -0800 [WIN] Fix build without precompiled header. 500688 1 114676 paroga 2011-11-11 05:10:34 -0800 Created attachment 114676 Patch 500690 2 webkit.review.bot 2011-11-11 05:12:44 -0800 Attachment 114676 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/cf/ResourceError.h:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 500896 3 114676 ap 2011-11-11 10:30:16 -0800 Comment on attachment 114676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114676&action=review > Source/WebCore/platform/ContextMenu.h:39 > +#include <windows.h> Do we regularly include windows.h in headers, or do avoid doing that? 500965 4 paroga 2011-11-11 11:31:54 -0800 (In reply to comment #3) > (From update of attachment 114676 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114676&action=review > > > Source/WebCore/platform/ContextMenu.h:39 > > +#include <windows.h> > > Do we regularly include windows.h in headers, or do avoid doing that? AFAIK we try to minimize the usage in headers, but windows.h is already included in the following files: Source/JavaScriptCore/wtf/Atomics.h Source/JavaScriptCore/wtf/Assertions.h Source/JavaScriptCore/wtf/PageAllocation.h Source/JavaScriptCore/wtf/TCSpinLock.h Source/JavaScriptCore/wtf/ThreadingPrimitives.h Source/JavaScriptCore/wtf/ThreadSpecific.h Source/WebCore/platform/FileSystem.h Source/WebCore/platform/Pasteboard.h Source/WebCore/platform/cf/win/CertificateCFWin.h Source/WebCore/platform/chromium/KeyboardCodes.h Source/WebCore/platform/graphics/FontCache.h Source/WebCore/platform/graphics/GraphicsContext.h Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.h Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h Source/WebCore/platform/graphics/chromium/TransparencyWin.h Source/WebCore/platform/graphics/chromium/UniscribeHelper.h Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.h Source/WebCore/platform/graphics/skia/FontCustomPlatformData.h Source/WebCore/platform/graphics/skia/SkiaFontWin.h Source/WebCore/platform/graphics/win/GDIExtras.h Source/WebCore/platform/graphics/win/QTMovieGWorld.h Source/WebCore/platform/graphics/win/QTTrack.h Source/WebCore/platform/graphics/win/RefCountedGDIHandle.h Source/WebCore/platform/network/NetworkStateNotifier.h Source/WebCore/platform/network/ResourceHandleInternal.h Source/WebCore/platform/network/curl/ResourceHandleManager.h Source/WebCore/platform/text/wince/TextCodecWinCE.h Source/WebCore/platform/win/BitmapInfo.h Source/WebCore/platform/win/ClipboardUtilitiesWin.h Source/WebCore/platform/win/PEImage.h Source/WebCore/platform/win/SoftLinking.h Source/WebCore/platform/win/Win32Handle.h Source/WebCore/plugins/npapi.h Source/WebCore/plugins/win/PluginMessageThrottlerWin.h 501381 5 114676 webkit.review.bot 2011-11-11 23:57:50 -0800 Comment on attachment 114676 Patch Clearing flags on attachment: 114676 Committed r100072: <http://trac.webkit.org/changeset/100072> 501382 6 webkit.review.bot 2011-11-11 23:57:54 -0800 All reviewed patches have been landed. Closing bug. 114676 2011-11-11 05:10:34 -0800 2011-11-11 23:57:50 -0800 Patch bug-72115.patch text/plain 3925 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NzFkYTYwLi4xM2M5ZjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTEtMTEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dJTl0gRml4IGJ1aWxkIHdpdGhvdXQgcHJlY29tcGlsZWQgaGVhZGVyLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxMTUKKworICAg ICAgICBVbnJldmlld2VkLiBBZGQgbWlzc2luZyBpbmNsdWRlcyB0byBmaXggYnVpbGQgd2l0aG91 dCBwcmVjb21waWxlZCBoZWFkZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Db250ZXh0TWVudS5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9ESUJQaXhlbERhdGEuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5oOgorICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvci5oOgorICAgICAgICAqIHBs YXRmb3JtL3dpbi9MYW5ndWFnZVdpbi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vd2luL0xvY2Fs aXplZFN0cmluZ3NXaW4uY3BwOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9Mb2dnaW5nV2luLmNw cDoKKwogMjAxMS0xMS0xMCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViS2l0Q1NTU2hhZGVyVmFsdWUuaCBpcyBub3QgYSBtZW1iZXIgb2YgdGhlIFdlYkNvcmUg dGFyZ2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Db250ZXh0TWVudS5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQ29udGV4dE1lbnUuaAppbmRleCAyOTc3NzQ5Li5j YmRmNTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Db250ZXh0TWVudS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0NvbnRleHRNZW51LmgKQEAgLTM1LDYgKzM1 LDggQEAKICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAjZWxpZiBQTEFURk9STShRVCkKICNp bmNsdWRlIDxRTWVudT4KKyNlbGlmIFBMQVRGT1JNKFdJTikKKyNpbmNsdWRlIDx3aW5kb3dzLmg+ CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0RJQlBpeGVsRGF0YS5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0RJQlBpeGVsRGF0YS5oCmluZGV4IDIzZGVhOTkuLmZhMmE2 YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9ESUJQ aXhlbERhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRElC UGl4ZWxEYXRhLmgKQEAgLTMwLDggKzMwLDkgQEAKICNpbmNsdWRlICJJbnRTaXplLmgiCiAjaW5j bHVkZSA8d2luZG93cy5oPgogCi0jaWYgIVVTRShDRykKLS8vIFVJbnQ4IGlzIGRlZmluZWQgaW4g Q29yZUZvdW5kYXRpb24vQ0ZCYXNlLmgKKyNpZiBVU0UoQ0cpCisjaW5jbHVkZSA8Q29yZUZvdW5k YXRpb24vQ0ZCYXNlLmg+CisjZWxzZQogdHlwZWRlZiB1bnNpZ25lZCBjaGFyIFVJbnQ4OwogI2Vu ZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9G b250Q3VzdG9tUGxhdGZvcm1EYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93aW4vRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5oCmluZGV4IDY1Mzg4ZDguLmNkMWRlZTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9Gb250Q3VzdG9t UGxhdGZvcm1EYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2lu L0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuaApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkZv bnRXaWR0aFZhcmlhbnQuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUg IlRleHRPcmllbnRhdGlvbi5oIgorI2luY2x1ZGUgPHdpbmRvd3MuaD4KICNpbmNsdWRlIDx3dGYv Rm9yd2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlRXJyb3IuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VFcnJvci5oCmluZGV4IGE0Njg1 ZjcuLjI3YzYzZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvUmVzb3VyY2VFcnJvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvUmVzb3VyY2VFcnJvci5oCkBAIC0zMiw2ICszMiwxMCBAQAogI2lmIFVTRShDRk5FVFdPUksp CiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ0ZTdHJlYW0uaD4KICNlbmRpZgorI2lmIFBMQVRG T1JNKFdJTikKKyNpbmNsdWRlIDx3aW5kb3dzLmg+CisjaW5jbHVkZSA8d2luY3J5cHQuaD4gLy8g d2luZG93cy5oIG11c3QgYmUgaW5jbHVkZWQgYmVmb3JlIHdpbmNyeXB0LmguCisjZW5kaWYKIAog I2lmZGVmIF9fT0JKQ19fCiBAY2xhc3MgTlNFcnJvcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9MYW5ndWFnZVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS93aW4vTGFuZ3VhZ2VXaW4uY3BwCmluZGV4IDlmZDY5MmEuLmFhMDUwYTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9MYW5ndWFnZVdpbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL0xhbmd1YWdlV2luLmNwcApAQCAtMjYsNiArMjYsNyBAQAog I2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkxhbmd1YWdlLmgiCiAKKyNpbmNsdWRlIDx3 aW5kb3dzLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Mb2NhbGl6 ZWRTdHJpbmdzV2luLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Mb2NhbGl6ZWRT dHJpbmdzV2luLmNwcAppbmRleCAwMTliYWVkLi5jYzJmNWMyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS93aW4vTG9jYWxpemVkU3RyaW5nc1dpbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vd2luL0xvY2FsaXplZFN0cmluZ3NXaW4uY3BwCkBAIC0yNyw2ICsy Nyw3IEBACiAjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogCiAjaW5jbHVkZSAiV2ViQ29y ZUluc3RhbmNlSGFuZGxlLmgiCisjaW5jbHVkZSA8d2luZG93cy5oPgogI2luY2x1ZGUgPHd0Zi9B c3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRlIDx3dGYv U3RkTGliRXh0cmFzLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4v TG9nZ2luZ1dpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTG9nZ2luZ1dpbi5j cHAKaW5kZXggNWU5ZmJkYS4uM2I3MTU3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL0xvZ2dpbmdXaW4uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dp bi9Mb2dnaW5nV2luLmNwcApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIkxvZ2dpbmcuaCIK IAogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCisjaW5jbHVkZSA8d2luZG93cy5oPgogI2lu Y2x1ZGUgPHd0Zi9Pd25BcnJheVB0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==