72114 2011-11-11 04:59:30 -0800 [chromium] MediaStream API: Allow for null WebPeerConnectionHandler 2011-11-14 11:13:45 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tommyw tommyw abarth fishd grunell webkit.review.bot oldest_to_newest 500680 0 tommyw 2011-11-11 04:59:30 -0800 Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler to PeerConnectionHandlerInternal. 500682 1 114675 tommyw 2011-11-11 05:03:13 -0800 Created attachment 114675 Patch 500683 2 webkit.review.bot 2011-11-11 05:04:50 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 501619 3 114675 abarth 2011-11-13 22:13:55 -0800 Comment on attachment 114675 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review > Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 > + // May return null. It would be nice to explain the situations in which this function can return null. 501759 4 114908 tommyw 2011-11-14 03:01:27 -0800 Created attachment 114908 Patch 501760 5 114675 tommyw 2011-11-14 03:02:42 -0800 Comment on attachment 114675 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review >> Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 >> + // May return null. > > It would be nice to explain the situations in which this function can return null. Fixed. 501942 6 114908 abarth 2011-11-14 08:42:01 -0800 Comment on attachment 114908 Patch Technically we need fishd to review, but given that you're just adding a comment to the API, I think it's fine. 502043 7 114908 webkit.review.bot 2011-11-14 10:06:50 -0800 Comment on attachment 114908 Patch Clearing flags on attachment: 114908 Committed r100162: <http://trac.webkit.org/changeset/100162> 502044 8 webkit.review.bot 2011-11-14 10:06:56 -0800 All reviewed patches have been landed. Closing bug. 502113 9 114908 fishd 2011-11-14 11:13:45 -0800 Comment on attachment 114908 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114908&action=review > Source/WebKit/chromium/public/WebKitPlatformSupport.h:328 > + // May return null if WebRTC functionality is not avaliable or out of resources. nit: "avaliable" -> available 114675 2011-11-11 05:03:13 -0800 2011-11-14 03:02:42 -0800 Patch bug-72114-20111111140311.patch text/plain 6022 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5MzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NTY1NzE2NDc4ZThkOTc4ZDM5YWY5ZGEwODMzMjgzY2QxZGU2YTAzMi4uZWE1NGIxNGZmZGZmMzcx MjA5N2MzZWViMzUyODc3MjRiZDBkZTVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyOCBAQAorMjAxMS0xMS0xMSAgVG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29v Z2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIE1lZGlhU3RyZWFtIEFQSTogQWxsb3cgZm9y IG51bGwgV2ViUGVlckNvbm5lY3Rpb25IYW5kbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjExNAorCisgICAgICAgIEZpeGluZyBjcmFzaCBpZiBX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQgcmV0dXJucyBhIG51bGwgV2ViUGVlckNvbm5lY3Rpb25IYW5k bGVyCisgICAgICAgIHRvIFBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnJpZGdlL1BlZXJDb25u ZWN0aW9uSGFuZGxlckludGVybmFsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0 aW9uSGFuZGxlckludGVybmFsOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbCk6CisgICAg ICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvZHVjZUluaXRp YWxPZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5h bDo6aGFuZGxlSW5pdGlhbE9mZmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9u SGFuZGxlckludGVybmFsOjpwcm9jZXNzU0RQKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25u ZWN0aW9uSGFuZGxlckludGVybmFsOjpwcm9jZXNzUGVuZGluZ1N0cmVhbXMpOgorICAgICAgICAo V2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OnNlbmREYXRhU3RyZWFtTWVz c2FnZSk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6 c3RvcCk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6 ZGlkQ29tcGxldGVJQ0VQcm9jZXNzaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0 aW9uSGFuZGxlckludGVybmFsOjpkaWRHZW5lcmF0ZVNEUCk6CisgICAgICAgIChXZWJDb3JlOjpQ ZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6ZGlkUmVjZWl2ZURhdGFTdHJlYW1NZXNzYWdl KToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpkaWRB ZGRSZW1vdGVTdHJlYW0pOgorICAgICAgICAoV2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVy SW50ZXJuYWw6OmRpZFJlbW92ZVJlbW90ZVN0cmVhbSk6CisgICAgICAgICogcHVibGljL1dlYktp dFBsYXRmb3JtU3VwcG9ydC5oOgorCiAyMDExLTExLTEwICBEYW5pZWwgQ2hlbmcgIDxkY2hlbmdA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIHBsdW1iaW5nIGZvciBKUyB0 byB3cml0ZSB0byBjbGlwYm9hcmQgaW4gY29weS9jdXQgZXZlbnRzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9icmlkZ2UvUGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9icmlkZ2UvUGVlckNvbm5lY3Rpb25IYW5kbGVy SW50ZXJuYWwuY3BwCmluZGV4IGJjMDQxOWEwYjcwOTBiN2M2OWFiNjgwYzIxMDM3MWZhMjBlOGQw ZGMuLmMzMDI1Y2QzMzNkNDcyOTQ1YWQxOTM2MGIxZTNiYmE2OWI5NmE1YzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vYnJpZGdlL1BlZXJDb25uZWN0aW9uSGFuZGxlckludGVy bmFsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2JyaWRnZS9QZWVyQ29ubmVjdGlv bkhhbmRsZXJJbnRlcm5hbC5jcHAKQEAgLTQ0LDcgKzQ0LDEwIEBAIFBlZXJDb25uZWN0aW9uSGFu ZGxlckludGVybmFsOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbChQZWVyQ29ubmVjdGlv bkhhbmRsCiB7CiAgICAgQVNTRVJUKG1fY2xpZW50KTsKICAgICBtX3dlYkhhbmRsZXIgPSBhZG9w dFB0cihXZWJLaXQ6OndlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5jcmVhdGVQZWVyQ29ubmVjdGlv bkhhbmRsZXIodGhpcykpOwotICAgIG1fd2ViSGFuZGxlci0+aW5pdGlhbGl6ZShzZXJ2ZXJDb25m aWd1cmF0aW9uLCBzZWN1cml0eU9yaWdpbik7CisgICAgLy8gRklYTUU6IFdoZW4gdGhlcmUgaXMg c29tZSBlcnJvciByZXBvcnRpbmcgYXZhbGlhYmxlIGluIHRoZSBQZWVyQ29ubmVjdGlvbiBvYmpl Y3QgcmVwb3J0CisgICAgLy8gaWYgd2UgZGlkbid0IGdldCBhIFdlYlBlZXJDb25uZWN0aW9uSGFu ZGxlciBpbnN0YW5jZS4KKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX3dlYkhhbmRs ZXItPmluaXRpYWxpemUoc2VydmVyQ29uZmlndXJhdGlvbiwgc2VjdXJpdHlPcmlnaW4pOwogfQog CiBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6flBlZXJDb25uZWN0aW9uSGFuZGxlcklu dGVybmFsKCkKQEAgLTUzLDU3ICs1Niw2OCBAQCBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5h bDo6flBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsKCkKIAogdm9pZCBQZWVyQ29ubmVjdGlv bkhhbmRsZXJJbnRlcm5hbDo6cHJvZHVjZUluaXRpYWxPZmZlcihjb25zdCBNZWRpYVN0cmVhbURl c2NyaXB0b3JWZWN0b3ImIHBlbmRpbmdBZGRTdHJlYW1zKQogewotICAgIG1fd2ViSGFuZGxlci0+ cHJvZHVjZUluaXRpYWxPZmZlcihwZW5kaW5nQWRkU3RyZWFtcyk7CisgICAgaWYgKG1fd2ViSGFu ZGxlcikKKyAgICAgICAgbV93ZWJIYW5kbGVyLT5wcm9kdWNlSW5pdGlhbE9mZmVyKHBlbmRpbmdB ZGRTdHJlYW1zKTsKIH0KIAogdm9pZCBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6aGFu ZGxlSW5pdGlhbE9mZmVyKGNvbnN0IFN0cmluZyYgc2RwKQogewotICAgIG1fd2ViSGFuZGxlci0+ aGFuZGxlSW5pdGlhbE9mZmVyKHNkcCk7CisgICAgaWYgKG1fd2ViSGFuZGxlcikKKyAgICAgICAg bV93ZWJIYW5kbGVyLT5oYW5kbGVJbml0aWFsT2ZmZXIoc2RwKTsKIH0KIAogdm9pZCBQZWVyQ29u bmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1NEUChjb25zdCBTdHJpbmcmIHNkcCkKIHsK LSAgICBtX3dlYkhhbmRsZXItPnByb2Nlc3NTRFAoc2RwKTsKKyAgICBpZiAobV93ZWJIYW5kbGVy KQorICAgICAgICBtX3dlYkhhbmRsZXItPnByb2Nlc3NTRFAoc2RwKTsKIH0KIAogdm9pZCBQZWVy Q29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1BlbmRpbmdTdHJlYW1zKGNvbnN0IE1l ZGlhU3RyZWFtRGVzY3JpcHRvclZlY3RvciYgcGVuZGluZ0FkZFN0cmVhbXMsIGNvbnN0IE1lZGlh U3RyZWFtRGVzY3JpcHRvclZlY3RvciYgcGVuZGluZ1JlbW92ZVN0cmVhbXMpCiB7Ci0gICAgbV93 ZWJIYW5kbGVyLT5wcm9jZXNzUGVuZGluZ1N0cmVhbXMocGVuZGluZ0FkZFN0cmVhbXMsIHBlbmRp bmdSZW1vdmVTdHJlYW1zKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX3dlYkhh bmRsZXItPnByb2Nlc3NQZW5kaW5nU3RyZWFtcyhwZW5kaW5nQWRkU3RyZWFtcywgcGVuZGluZ1Jl bW92ZVN0cmVhbXMpOwogfQogCiB2b2lkIFBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpz ZW5kRGF0YVN0cmVhbU1lc3NhZ2UoY29uc3QgY2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCkKIHsK LSAgICBtX3dlYkhhbmRsZXItPnNlbmREYXRhU3RyZWFtTWVzc2FnZShkYXRhLCBsZW5ndGgpOwor ICAgIGlmIChtX3dlYkhhbmRsZXIpCisgICAgICAgIG1fd2ViSGFuZGxlci0+c2VuZERhdGFTdHJl YW1NZXNzYWdlKGRhdGEsIGxlbmd0aCk7CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVy SW50ZXJuYWw6OnN0b3AoKQogewotICAgIG1fd2ViSGFuZGxlci0+c3RvcCgpOworICAgIGlmICht X3dlYkhhbmRsZXIpCisgICAgICAgIG1fd2ViSGFuZGxlci0+c3RvcCgpOwogfQogCiB2b2lkIFBl ZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpkaWRDb21wbGV0ZUlDRVByb2Nlc3NpbmcoKQog ewotICAgIG1fY2xpZW50LT5kaWRDb21wbGV0ZUlDRVByb2Nlc3NpbmcoKTsKKyAgICBpZiAobV93 ZWJIYW5kbGVyKQorICAgICAgICBtX2NsaWVudC0+ZGlkQ29tcGxldGVJQ0VQcm9jZXNzaW5nKCk7 CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZEdlbmVyYXRlU0RQ KGNvbnN0IFdlYktpdDo6V2ViU3RyaW5nJiBzZHApCiB7Ci0gICAgbV9jbGllbnQtPmRpZEdlbmVy YXRlU0RQKHNkcCk7CisgICAgaWYgKG1fd2ViSGFuZGxlcikKKyAgICAgICAgbV9jbGllbnQtPmRp ZEdlbmVyYXRlU0RQKHNkcCk7CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJu YWw6OmRpZFJlY2VpdmVEYXRhU3RyZWFtTWVzc2FnZShjb25zdCBjaGFyKiBkYXRhLCBzaXplX3Qg bGVuZ3RoKQogewotICAgIG1fY2xpZW50LT5kaWRSZWNlaXZlRGF0YVN0cmVhbU1lc3NhZ2UoZGF0 YSwgbGVuZ3RoKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX2NsaWVudC0+ZGlk UmVjZWl2ZURhdGFTdHJlYW1NZXNzYWdlKGRhdGEsIGxlbmd0aCk7CiB9CiAKIHZvaWQgUGVlckNv bm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZEFkZFJlbW90ZVN0cmVhbShjb25zdCBXZWJLaXQ6 OldlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgd2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yKQogewot ICAgIG1fY2xpZW50LT5kaWRBZGRSZW1vdGVTdHJlYW0od2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9y KTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX2NsaWVudC0+ZGlkQWRkUmVtb3Rl U3RyZWFtKHdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcik7CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rp b25IYW5kbGVySW50ZXJuYWw6OmRpZFJlbW92ZVJlbW90ZVN0cmVhbShjb25zdCBXZWJLaXQ6Oldl Yk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgd2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yKQogewotICAg IG1fY2xpZW50LT5kaWRSZW1vdmVSZW1vdGVTdHJlYW0od2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9y KTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX2NsaWVudC0+ZGlkUmVtb3ZlUmVt b3RlU3RyZWFtKHdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcik7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktp dFBsYXRmb3JtU3VwcG9ydC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0 UGxhdGZvcm1TdXBwb3J0LmgKaW5kZXggNTI4MTQ3OTRkOWQyMTRhY2JjM2U4YzE3MjRhMjNlMDVh MTdlZTJhYi4uMDljMWE3YTFiMWZkYjg4NGQwOWYyMzczMTljYzc2ZGVlYzYxNTdhNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0UGxhdGZvcm1TdXBwb3J0 LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0UGxhdGZvcm1TdXBw b3J0LmgKQEAgLTMyNSw2ICszMjUsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBXZWJSVEMgLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCisg ICAgLy8gTWF5IHJldHVybiBudWxsLgogICAgIHZpcnR1YWwgV2ViUGVlckNvbm5lY3Rpb25IYW5k bGVyKiBjcmVhdGVQZWVyQ29ubmVjdGlvbkhhbmRsZXIoV2ViUGVlckNvbm5lY3Rpb25IYW5kbGVy Q2xpZW50KikgeyByZXR1cm4gMDsgfQogCiBwcm90ZWN0ZWQ6Cg== 114908 2011-11-14 03:01:27 -0800 2011-11-14 11:13:45 -0800 Patch bug-72114-20111114120126.patch text/plain 6104 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdiNDAwODZhYTQxOTY0NDk2ZjcwMjBjMWY0Mjc4YTc3MjExYzY2MGUuLmMxMzRiODEyMDEzMTUx YzBjZWY0ZTM1MmZlYjQwMTVjZWQ1MjViNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjggQEAKKzIwMTEtMTEtMTEgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBNZWRpYVN0cmVhbSBBUEk6IEFsbG93IGZv ciBudWxsIFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIxMTQKKworICAgICAgICBGaXhpbmcgY3Jhc2ggaWYg V2ViS2l0UGxhdGZvcm1TdXBwb3J0IHJldHVybnMgYSBudWxsIFdlYlBlZXJDb25uZWN0aW9uSGFu ZGxlcgorICAgICAgICB0byBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJyaWRnZS9QZWVyQ29u bmVjdGlvbkhhbmRsZXJJbnRlcm5hbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVj dGlvbkhhbmRsZXJJbnRlcm5hbDo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWwpOgorICAg ICAgICAoV2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OnByb2R1Y2VJbml0 aWFsT2ZmZXIpOgorICAgICAgICAoV2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJu YWw6OmhhbmRsZUluaXRpYWxPZmZlcik6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlv bkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1NEUCk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29u bmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1BlbmRpbmdTdHJlYW1zKToKKyAgICAgICAg KFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpzZW5kRGF0YVN0cmVhbU1l c3NhZ2UpOgorICAgICAgICAoV2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6 OnN0b3ApOgorICAgICAgICAoV2ViQ29yZTo6UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6 OmRpZENvbXBsZXRlSUNFUHJvY2Vzc2luZyk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVj dGlvbkhhbmRsZXJJbnRlcm5hbDo6ZGlkR2VuZXJhdGVTRFApOgorICAgICAgICAoV2ViQ29yZTo6 UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZFJlY2VpdmVEYXRhU3RyZWFtTWVzc2Fn ZSk6CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6ZGlk QWRkUmVtb3RlU3RyZWFtKToKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uSGFuZGxl ckludGVybmFsOjpkaWRSZW1vdmVSZW1vdGVTdHJlYW0pOgorICAgICAgICAqIHB1YmxpYy9XZWJL aXRQbGF0Zm9ybVN1cHBvcnQuaDoKKwogMjAxMS0xMS0xMyAgTmF0IER1Y2EgIDxuZHVjYUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBMYXllclJlbmRlcmVyQ2hyb21pdW06Omlu aXRpYWxpemUgc2hvdWxkIGZhaWwgd2hlbiBHYXBoaWNzQ29udGV4dDNEOjptYWtlQ3VycmVudCBm YWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9icmlkZ2UvUGVlckNvbm5l Y3Rpb25IYW5kbGVySW50ZXJuYWwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9icmlkZ2Uv UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWwuY3BwCmluZGV4IGJjMDQxOWEwYjcwOTBiN2M2 OWFiNjgwYzIxMDM3MWZhMjBlOGQwZGMuLmMzMDI1Y2QzMzNkNDcyOTQ1YWQxOTM2MGIxZTNiYmE2 OWI5NmE1YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vYnJpZGdlL1BlZXJD b25uZWN0aW9uSGFuZGxlckludGVybmFsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L2JyaWRnZS9QZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbC5jcHAKQEAgLTQ0LDcgKzQ0LDEw IEBAIFBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpQZWVyQ29ubmVjdGlvbkhhbmRsZXJJ bnRlcm5hbChQZWVyQ29ubmVjdGlvbkhhbmRsCiB7CiAgICAgQVNTRVJUKG1fY2xpZW50KTsKICAg ICBtX3dlYkhhbmRsZXIgPSBhZG9wdFB0cihXZWJLaXQ6OndlYktpdFBsYXRmb3JtU3VwcG9ydCgp LT5jcmVhdGVQZWVyQ29ubmVjdGlvbkhhbmRsZXIodGhpcykpOwotICAgIG1fd2ViSGFuZGxlci0+ aW5pdGlhbGl6ZShzZXJ2ZXJDb25maWd1cmF0aW9uLCBzZWN1cml0eU9yaWdpbik7CisgICAgLy8g RklYTUU6IFdoZW4gdGhlcmUgaXMgc29tZSBlcnJvciByZXBvcnRpbmcgYXZhbGlhYmxlIGluIHRo ZSBQZWVyQ29ubmVjdGlvbiBvYmplY3QgcmVwb3J0CisgICAgLy8gaWYgd2UgZGlkbid0IGdldCBh IFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlciBpbnN0YW5jZS4KKyAgICBpZiAobV93ZWJIYW5kbGVy KQorICAgICAgICBtX3dlYkhhbmRsZXItPmluaXRpYWxpemUoc2VydmVyQ29uZmlndXJhdGlvbiwg c2VjdXJpdHlPcmlnaW4pOwogfQogCiBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6flBl ZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsKCkKQEAgLTUzLDU3ICs1Niw2OCBAQCBQZWVyQ29u bmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6flBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsKCkK IAogdm9pZCBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvZHVjZUluaXRpYWxPZmZl cihjb25zdCBNZWRpYVN0cmVhbURlc2NyaXB0b3JWZWN0b3ImIHBlbmRpbmdBZGRTdHJlYW1zKQog ewotICAgIG1fd2ViSGFuZGxlci0+cHJvZHVjZUluaXRpYWxPZmZlcihwZW5kaW5nQWRkU3RyZWFt cyk7CisgICAgaWYgKG1fd2ViSGFuZGxlcikKKyAgICAgICAgbV93ZWJIYW5kbGVyLT5wcm9kdWNl SW5pdGlhbE9mZmVyKHBlbmRpbmdBZGRTdHJlYW1zKTsKIH0KIAogdm9pZCBQZWVyQ29ubmVjdGlv bkhhbmRsZXJJbnRlcm5hbDo6aGFuZGxlSW5pdGlhbE9mZmVyKGNvbnN0IFN0cmluZyYgc2RwKQog ewotICAgIG1fd2ViSGFuZGxlci0+aGFuZGxlSW5pdGlhbE9mZmVyKHNkcCk7CisgICAgaWYgKG1f d2ViSGFuZGxlcikKKyAgICAgICAgbV93ZWJIYW5kbGVyLT5oYW5kbGVJbml0aWFsT2ZmZXIoc2Rw KTsKIH0KIAogdm9pZCBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1NEUChj b25zdCBTdHJpbmcmIHNkcCkKIHsKLSAgICBtX3dlYkhhbmRsZXItPnByb2Nlc3NTRFAoc2RwKTsK KyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX3dlYkhhbmRsZXItPnByb2Nlc3NTRFAo c2RwKTsKIH0KIAogdm9pZCBQZWVyQ29ubmVjdGlvbkhhbmRsZXJJbnRlcm5hbDo6cHJvY2Vzc1Bl bmRpbmdTdHJlYW1zKGNvbnN0IE1lZGlhU3RyZWFtRGVzY3JpcHRvclZlY3RvciYgcGVuZGluZ0Fk ZFN0cmVhbXMsIGNvbnN0IE1lZGlhU3RyZWFtRGVzY3JpcHRvclZlY3RvciYgcGVuZGluZ1JlbW92 ZVN0cmVhbXMpCiB7Ci0gICAgbV93ZWJIYW5kbGVyLT5wcm9jZXNzUGVuZGluZ1N0cmVhbXMocGVu ZGluZ0FkZFN0cmVhbXMsIHBlbmRpbmdSZW1vdmVTdHJlYW1zKTsKKyAgICBpZiAobV93ZWJIYW5k bGVyKQorICAgICAgICBtX3dlYkhhbmRsZXItPnByb2Nlc3NQZW5kaW5nU3RyZWFtcyhwZW5kaW5n QWRkU3RyZWFtcywgcGVuZGluZ1JlbW92ZVN0cmVhbXMpOwogfQogCiB2b2lkIFBlZXJDb25uZWN0 aW9uSGFuZGxlckludGVybmFsOjpzZW5kRGF0YVN0cmVhbU1lc3NhZ2UoY29uc3QgY2hhciogZGF0 YSwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBtX3dlYkhhbmRsZXItPnNlbmREYXRhU3RyZWFtTWVz c2FnZShkYXRhLCBsZW5ndGgpOworICAgIGlmIChtX3dlYkhhbmRsZXIpCisgICAgICAgIG1fd2Vi SGFuZGxlci0+c2VuZERhdGFTdHJlYW1NZXNzYWdlKGRhdGEsIGxlbmd0aCk7CiB9CiAKIHZvaWQg UGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OnN0b3AoKQogewotICAgIG1fd2ViSGFuZGxl ci0+c3RvcCgpOworICAgIGlmIChtX3dlYkhhbmRsZXIpCisgICAgICAgIG1fd2ViSGFuZGxlci0+ c3RvcCgpOwogfQogCiB2b2lkIFBlZXJDb25uZWN0aW9uSGFuZGxlckludGVybmFsOjpkaWRDb21w bGV0ZUlDRVByb2Nlc3NpbmcoKQogewotICAgIG1fY2xpZW50LT5kaWRDb21wbGV0ZUlDRVByb2Nl c3NpbmcoKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBtX2NsaWVudC0+ZGlkQ29t cGxldGVJQ0VQcm9jZXNzaW5nKCk7CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVySW50 ZXJuYWw6OmRpZEdlbmVyYXRlU0RQKGNvbnN0IFdlYktpdDo6V2ViU3RyaW5nJiBzZHApCiB7Ci0g ICAgbV9jbGllbnQtPmRpZEdlbmVyYXRlU0RQKHNkcCk7CisgICAgaWYgKG1fd2ViSGFuZGxlcikK KyAgICAgICAgbV9jbGllbnQtPmRpZEdlbmVyYXRlU0RQKHNkcCk7CiB9CiAKIHZvaWQgUGVlckNv bm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZFJlY2VpdmVEYXRhU3RyZWFtTWVzc2FnZShjb25z dCBjaGFyKiBkYXRhLCBzaXplX3QgbGVuZ3RoKQogewotICAgIG1fY2xpZW50LT5kaWRSZWNlaXZl RGF0YVN0cmVhbU1lc3NhZ2UoZGF0YSwgbGVuZ3RoKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQor ICAgICAgICBtX2NsaWVudC0+ZGlkUmVjZWl2ZURhdGFTdHJlYW1NZXNzYWdlKGRhdGEsIGxlbmd0 aCk7CiB9CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZEFkZFJlbW90 ZVN0cmVhbShjb25zdCBXZWJLaXQ6OldlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgd2ViTWVkaWFT dHJlYW1EZXNjcmlwdG9yKQogewotICAgIG1fY2xpZW50LT5kaWRBZGRSZW1vdGVTdHJlYW0od2Vi TWVkaWFTdHJlYW1EZXNjcmlwdG9yKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBt X2NsaWVudC0+ZGlkQWRkUmVtb3RlU3RyZWFtKHdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcik7CiB9 CiAKIHZvaWQgUGVlckNvbm5lY3Rpb25IYW5kbGVySW50ZXJuYWw6OmRpZFJlbW92ZVJlbW90ZVN0 cmVhbShjb25zdCBXZWJLaXQ6OldlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYgd2ViTWVkaWFTdHJl YW1EZXNjcmlwdG9yKQogewotICAgIG1fY2xpZW50LT5kaWRSZW1vdmVSZW1vdGVTdHJlYW0od2Vi TWVkaWFTdHJlYW1EZXNjcmlwdG9yKTsKKyAgICBpZiAobV93ZWJIYW5kbGVyKQorICAgICAgICBt X2NsaWVudC0+ZGlkUmVtb3ZlUmVtb3RlU3RyZWFtKHdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcik7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKaW5kZXggNTI4MTQ3OTRkOWQy MTRhY2JjM2U4YzE3MjRhMjNlMDVhMTdlZTJhYi4uZmE4MzEyZWFiMmVhMzIxYmU0MTVmYzU5OWIz NmI0NzZkODg3Y2QxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKQEAgLTMyNSw2ICszMjUsNyBAQCBwdWJsaWM6CiAK ICAgICAvLyBXZWJSVEMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogCisgICAgLy8gTWF5IHJldHVybiBudWxsIGlmIFdlYlJUQyBmdW5j dGlvbmFsaXR5IGlzIG5vdCBhdmFsaWFibGUgb3Igb3V0IG9mIHJlc291cmNlcy4KICAgICB2aXJ0 dWFsIFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlciogY3JlYXRlUGVlckNvbm5lY3Rpb25IYW5kbGVy KFdlYlBlZXJDb25uZWN0aW9uSGFuZGxlckNsaWVudCopIHsgcmV0dXJuIDA7IH0KIAogcHJvdGVj dGVkOgo=