72088 2011-11-10 20:15:43 -0800 Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h: 2011-11-14 09:57:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thestig webkit-unassigned tkent tony webkit.review.bot oldest_to_newest 500487 0 thestig 2011-11-10 20:15:43 -0800 Doing some cleanup on the Chromium side and it failed to build due to a missing include here. 500971 1 114746 thestig 2011-11-11 11:36:00 -0800 Created attachment 114746 patch 501282 2 114746 webkit.review.bot 2011-11-11 18:10:44 -0800 Comment on attachment 114746 patch Rejecting attachment 114746 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file DumpRenderTree/chromium/AccessibilityUIElement.h Hunk #1 FAILED at 33. 1 out of 1 hunk FAILED -- saving rejects to file DumpRenderTree/chromium/AccessibilityUIElement.h.rej patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10453052 501287 3 thestig 2011-11-11 18:20:15 -0800 Did the patch need to be for Tools/DumpRenderTree/chromium/AccessibilityUIElement.h rather than DumpRenderTree/chromium/AccessibilityUIElement.h ? 501299 4 tony 2011-11-11 18:37:45 -0800 (In reply to comment #3) > Did the patch need to be for Tools/DumpRenderTree/chromium/AccessibilityUIElement.h rather than DumpRenderTree/chromium/AccessibilityUIElement.h ? Yeah, the base of the checkout has to be trunk of the repo. 501302 5 114811 thestig 2011-11-11 18:43:41 -0800 Created attachment 114811 patch with the right base dir 501305 6 webkit.review.bot 2011-11-11 18:48:02 -0800 Attachment 114811 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/c..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 502011 7 114970 tony 2011-11-14 09:42:34 -0800 Created attachment 114970 Patch for landing 502031 8 114970 webkit.review.bot 2011-11-14 09:56:56 -0800 Comment on attachment 114970 Patch for landing Clearing flags on attachment: 114970 Committed r100160: <http://trac.webkit.org/changeset/100160> 502032 9 webkit.review.bot 2011-11-14 09:57:00 -0800 All reviewed patches have been landed. Closing bug. 114746 2011-11-11 11:36:00 -0800 2011-11-11 18:43:41 -0800 patch iwyu.diff text/plain 962 thestig SW5kZXg6IER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5VUlFbGVt ZW50LmgJKHJldmlzaW9uIDk5OTIzKQorKysgRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vQWNjZXNz aWJpbGl0eVVJRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiAKICNp bmNsdWRlICJDcHBCb3VuZENsYXNzLmgiCiAjaW5jbHVkZSAiV2ViQWNjZXNzaWJpbGl0eU9iamVj dC5oIgorI2luY2x1ZGUgPHZlY3Rvcj4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIGNsYXNz IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQgOiBwdWJsaWMgQ3BwQm91bmRDbGFzcyB7CkluZGV4OiBD aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiA5OTkyMykKKysrIENo YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisyMDExLTExLTEwICBMZWkg WmhhbmcgIDx0aGVzdGlnQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEFkZCBh IG1pc3NpbmcgaW5jbHVkZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnQuaDoKKwogMjAxMS0xMS0xMCAgQW5kcmV3IFNjaGVya3VzICA8c2NoZXJrdXNAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gb25seSBydW4gbWVkaWEgR1BVIGxheW91dCB0ZXN0 cyBvbiBwbGF0Zm9ybXMgc3VwcG9ydGluZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZwo= 114811 2011-11-11 18:43:41 -0800 2011-11-14 09:42:32 -0800 patch with the right base dir iwyu.diff text/plain 998 thestig SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50LmgJKHJldmlzaW9uIDk5OTIzKQorKysgVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z Myw2ICszMyw3IEBACiAKICNpbmNsdWRlICJDcHBCb3VuZENsYXNzLmgiCiAjaW5jbHVkZSAiV2Vi QWNjZXNzaWJpbGl0eU9iamVjdC5oIgorI2luY2x1ZGUgPHZlY3Rvcj4KICNpbmNsdWRlIDx3dGYv VmVjdG9yLmg+CiAKIGNsYXNzIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQgOiBwdWJsaWMgQ3BwQm91 bmRDbGFzcyB7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hh bmdlTG9nCShyZXZpc2lvbiA5OTkyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDExIEBACisyMDExLTExLTEwICBMZWkgWmhhbmcgIDx0aGVzdGlnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEFkZCBhIG1pc3NpbmcgaW5jbHVkZS4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuaDoKKwogMjAxMS0xMS0xMCAg QW5kcmV3IFNjaGVya3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJv bWl1bV0gb25seSBydW4gbWVkaWEgR1BVIGxheW91dCB0ZXN0cyBvbiBwbGF0Zm9ybXMgc3VwcG9y dGluZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZwo= 114970 2011-11-14 09:42:34 -0800 2011-11-14 09:56:56 -0800 Patch for landing bug-72088-20111114094251.patch text/plain 1190 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzNkNGE4NDMyNjJjZWI5YjNjMDBkNmEzOTllODJjMGI5 YjgzMGU3My4uZWNhYzU4ZWE3MWEwOTc0ZTk4MTVkNTc1Y2ZkMmJjZjQ4YjY0NDRiYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTE0ICBMZWkgWmhhbmcgIDx0aGVzdGlnQGNocm9taXVtLm9yZz4KKworICAg ICAgICBNaXNzaW5nIGluY2x1ZGUgaW4gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vQWNj ZXNzaWJpbGl0eVVJRWxlbWVudC5oOgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzIwODgKKworICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vQWNjZXNzaWJpbGl0eVVJRWxlbWVu dC5oOgorCiAyMDExLTExLTE0ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5v a2lhLmNvbT4KIAogICAgICAgICBbUXRdIE1vdmUgdGhlIFF0V2ViS2l0IG1vZHVsZSBmaWxlIHRv IG1hdGNoIHRoZSBsYXlvdXQgb2YgUXQncyBta3NwZWNzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmggYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmgKaW5kZXggZDIxZTBk OWZiNTc0M2M1OGVlNjM1MjZjNGE4ODVhMTI2N2Q4OTAwMi4uZDE2OTUyNGFiY2MzNTA5ODMwNzQx ZjA5OTAwN2MxNWE4ZGUxNmMxYyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuaApAQCAtMzMsNiArMzMsNyBAQAogCiAj aW5jbHVkZSAiQ3BwQm91bmRDbGFzcy5oIgogI2luY2x1ZGUgIldlYkFjY2Vzc2liaWxpdHlPYmpl Y3QuaCIKKyNpbmNsdWRlIDx2ZWN0b3I+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiBjbGFz cyBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IDogcHVibGljIENwcEJvdW5kQ2xhc3Mgewo=