72081 2011-11-10 18:04:46 -0800 [chromium] Fix CCLayerTreeHost leak in webkit_unit_tests 2011-11-11 04:19:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne fishd hclam kbr nduca ojan vangelis oldest_to_newest 500451 0 jamesr 2011-11-10 18:04:46 -0800 [chromium] Fix CCLayerTreeHost leak in webkit_unit_tests 500454 1 114612 jamesr 2011-11-10 18:06:10 -0800 Created attachment 114612 Patch 500455 2 jamesr 2011-11-10 18:08:23 -0800 http://trac.webkit.org/changeset/99844 broke webkit_unit_tests, but only some bots since the failure depends on the order in which the tests are run. 500467 3 114612 kbr 2011-11-10 18:39:30 -0800 Comment on attachment 114612 Patch Looks fine. Do you need to do anything with m_rootLayer as well? 500507 4 114612 jamesr 2011-11-10 21:32:17 -0800 Comment on attachment 114612 Patch Nah, once the two are disentangled dropping the ref on layer is enough for everything to free up. 500637 5 hclam 2011-11-11 03:43:10 -0800 Whoops! Thanks for fixing this! I'll be more careful about the refs.. 500654 6 114612 hclam 2011-11-11 04:17:32 -0800 Comment on attachment 114612 Patch Clearing flags on attachment: 114612 Committed r99943: <http://trac.webkit.org/changeset/99943> 500655 7 hclam 2011-11-11 04:17:39 -0800 All reviewed patches have been landed. Closing bug. 500656 8 hclam 2011-11-11 04:19:16 -0800 Commit queue is stuck so I landed this as: http://trac.webkit.org/changeset/99943 114612 2011-11-10 18:06:10 -0800 2011-11-11 04:17:32 -0800 Patch bug-72081-20111110180847.patch text/plain 2413 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5MDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZDFlOGVkOTVkYmZlNTRjM2FhZmVmMmY4NjUyNTJkMzQ1YjM1MjkxYS4uMzBjOWU1MzE4ZGMzMDNi NTJjYjdiZDk5YTIxNDZiODUwZjU5NWExOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAxMS0xMS0xMCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IENDTGF5ZXJUcmVlSG9zdCBsZWFrIGlu IHdlYmtpdF91bml0X3Rlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MjA4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIExheWVyQ2hyb21pdW0gYW5kIENDTGF5ZXJUcmVlSG9zdHMgaG9sZCBSZWZQdHI8 PnMgdG8gZWFjaCBvdGhlciwgc28gaWYKKyAgICAgICAgeW91IGRvIG5vdCBjbGVhciBvdXQgdGhl IGxheWVyVHJlZUhvc3QgcG9pbnRlciBvbiB0aGUgTGF5ZXJDaHJvbWl1bQorICAgICAgICB0aGUg bGF5ZXIgdHJlZSBpcyBsZWFrZWQuIFRoZSByZWFsIGNvZGUgZG9lcyB0aGlzIGluIFdlYlZpZXdJ bXBsIGJ1dAorICAgICAgICB0aGlzIHRlc3Qgd2FzIG5vdC4KKworICAgICAgICAqIHRlc3RzL0ND TGF5ZXJUcmVlSG9zdFRlc3QuY3BwOgorICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhvc3RUZXN0 OjpydW5UZXN0KToKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVIb3N0VGVzdDo6ZG9CZWdpblRl c3QpOgorCiAyMDExLTExLTEwICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwCmluZGV4IGJlYzI3 OTgzM2I5OTFiNzM0ZDkzZGYyZmUwZGRmNWFmOGQwYTAyYWIuLjc5ZmQwMWE3YTY5NjM1YjE2MmQ3 ZDg2NWI3MDVlNjViNzc5NjQ4NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcApAQCAtMzE3LDYgKzMxNyw3IEBAIHByb3Rl Y3RlZDoKICAgICAgICAgICAgIEZBSUwoKSA8PCAiVGVzdCB0aW1lZCBvdXQiOwogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CisgICAgICAgIG1fcm9vdExheWVyLT5zZXRMYXllclRyZWVI b3N0KDApOwogICAgICAgICBhZnRlclRlc3QoKTsKICAgICB9CiAKQEAgLTMyOSw2ICszMzAsNyBA QCBwcml2YXRlOgogICAgIGJvb2wgbV9lbmRXaGVuQmVnaW5SZXR1cm5zOwogICAgIGJvb2wgbV90 aW1lZE91dDsKIAorICAgIFJlZlB0cjxMYXllckNocm9taXVtPiBtX3Jvb3RMYXllcjsKICAgICBP d25QdHI8V2ViVGhyZWFkPiBtX3dlYlRocmVhZDsKICAgICBSZWZQdHI8Q0NTY29wZWRNYWluVGhy ZWFkUHJveHk+IG1fbWFpblRocmVhZFByb3h5OwogICAgIFRpbWVvdXRUYXNrKiBtX3RpbWVvdXRU YXNrOwpAQCAtMzM5LDEwICszNDEsMTAgQEAgdm9pZCBDQ0xheWVyVHJlZUhvc3RUZXN0Ojpkb0Jl Z2luVGVzdCgpCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBtX2NsaWVudCA9IE1v Y2tMYXllclRyZWVIb3N0Q2xpZW50OjpjcmVhdGUodGhpcyk7CiAKLSAgICBSZWZQdHI8TGF5ZXJD aHJvbWl1bT4gcm9vdExheWVyID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKDApOwotICAgIG1fbGF5 ZXJUcmVlSG9zdCA9IE1vY2tMYXllclRyZWVIb3N0OjpjcmVhdGUodGhpcywgbV9jbGllbnQuZ2V0 KCksIHJvb3RMYXllciwgbV9zZXR0aW5ncyk7CisgICAgbV9yb290TGF5ZXIgPSBMYXllckNocm9t aXVtOjpjcmVhdGUoMCk7CisgICAgbV9sYXllclRyZWVIb3N0ID0gTW9ja0xheWVyVHJlZUhvc3Q6 OmNyZWF0ZSh0aGlzLCBtX2NsaWVudC5nZXQoKSwgbV9yb290TGF5ZXIsIG1fc2V0dGluZ3MpOwog ICAgIEFTU0VSVChtX2xheWVyVHJlZUhvc3QpOwotICAgIHJvb3RMYXllci0+c2V0TGF5ZXJUcmVl SG9zdChtX2xheWVyVHJlZUhvc3QuZ2V0KCkpOworICAgIG1fcm9vdExheWVyLT5zZXRMYXllclRy ZWVIb3N0KG1fbGF5ZXJUcmVlSG9zdC5nZXQoKSk7CiAKICAgICBtX2JlZ2lubmluZyA9IHRydWU7 CiAgICAgYmVnaW5UZXN0KCk7Cg==