72069 2011-11-10 15:54:34 -0800 ASSERT when outdenting styled line break 2011-11-10 17:26:50 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 500367 0 enrica 2011-11-10 15:54:34 -0800 Given the following markup: <body contenteditable> <blockquote style….> <img> </blockquote> </body> placing the selection on the last and performing and outdent command will trigger an assert. 500369 1 enrica 2011-11-10 15:57:46 -0800 <rdar://problem/10429739> 500411 2 114602 enrica 2011-11-10 16:48:28 -0800 Created attachment 114602 Patch 500417 3 114602 rniwa 2011-11-10 16:55:39 -0800 Comment on attachment 114602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114602&action=review > Source/WebCore/ChangeLog:10 > + the assert. Could you fit "the assert" on the previous line to avoid an awkward line break? > Source/WebCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). This line should appear before the description. 500420 4 enrica 2011-11-10 16:59:55 -0800 (In reply to comment #3) > (From update of attachment 114602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114602&action=review > > > Source/WebCore/ChangeLog:10 > > + the assert. > > Could you fit "the assert" on the previous line to avoid an awkward line break? > > > Source/WebCore/ChangeLog:12 > > + Reviewed by NOBODY (OOPS!). > > This line should appear before the description. Will do. Thanks for the review! 500436 5 enrica 2011-11-10 17:26:50 -0800 Committed revision 99918. 114602 2011-11-10 16:48:28 -0800 2011-11-10 16:55:38 -0800 Patch outdent-crash.txt text/plain 5735 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5OTA5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMTEtMTAgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlQgd2hlbiBvdXRkZW50 aW5nIHN0eWxlZCBsaW5lIGJyZWFrLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzIwNjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwNDI5NzM5Pgor CisgICAgICAgIFdoZW4gb3V0ZGVudGluZyBhIGxpbmUgYnJlYWsgdGhhdCBoYXMgc29tZSBpbmxp bmUgc3R5bGUsIHdlIGRvbid0IGNvbnNpZGVyCisgICAgICAgIHRoZSBlbmNsb3NpbmcgZWxlbWVu dHMgdGhhdCBwcm92aWRlIHRoZSBzdHlsZS4KKyAgICAgICAgVGhpcyBjYXVzZXMgdGhlIHNwbGl0 dGluZyB0byBvY2N1ciBpbiB0aGUgd3JvbmcgcG9zaXRpb24sIHRyaWdnZXJpbmcKKyAgICAgICAg dGhlIGFzc2VydC4KKyAgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtYnJlYWstd2l0 aC1zdHlsZS5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkluZGVudE91dGRlbnRDb21tYW5kOjpvdXRkZW50UGFyYWdy YXBoKTogVGhlIGZpeCBjb25zaXN0cworICAgICAgICBpbiBjaG9vc2luZyB0aGUgaGlnaGVzdCBp bmxpbmUgYW5jZXN0b3IgYXMgc3BsaXR0aW5nIHBvaW50LgorICAgICAgICAqIGVkaXRpbmcvaHRt bGVkaXRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNJbmxpbmUpOiBBZGRlZC4KKyAgICAg ICAgKiBlZGl0aW5nL2h0bWxlZGl0aW5nLmg6IEFkZGVkIGlzSW5saW5lLgorCiAyMDExLTExLTEw ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZWZmZWN0 Qm91bmRpbmdCb3hNb2RlIGZyb20gQ1NTIEZpbHRlcnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCShyZXZpc2lvbiA5OTkwOCkKKysr IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNzgsNyArMTc4LDggQEAgdm9pZCBJbmRlbnRPdXRkZW50Q29tbWFuZDo6b3V0 ZGVudFBhcmFncgogICAgICAgICBzcGxpdEJsb2NrcXVvdGVOb2RlID0gc3BsaXRUcmVlVG9Ob2Rl KGVuY2xvc2luZ0Jsb2NrRmxvdywgZW5jbG9zaW5nTm9kZSwgdHJ1ZSk7CiAgICAgZWxzZSB7CiAg ICAgICAgIC8vIFdlIHNwbGl0IHRoZSBibG9ja3F1b3RlIGF0IHdoZXJlIHdlIHN0YXJ0IG91dGRl bnRpbmcuCi0gICAgICAgIHNwbGl0RWxlbWVudChzdGF0aWNfY2FzdDxFbGVtZW50Kj4oZW5jbG9z aW5nTm9kZSksIHZpc2libGVTdGFydE9mUGFyYWdyYXBoLmRlZXBFcXVpdmFsZW50KCkuZGVwcmVj YXRlZE5vZGUoKSk7CisgICAgICAgIE5vZGUqIGhpZ2hlc3RJbmxpbmVOb2RlID0gaGlnaGVzdEVu Y2xvc2luZ05vZGVPZlR5cGUodmlzaWJsZVN0YXJ0T2ZQYXJhZ3JhcGguZGVlcEVxdWl2YWxlbnQo KSwgaXNJbmxpbmUsIENhbm5vdENyb3NzRWRpdGluZ0JvdW5kYXJ5LCBlbmNsb3NpbmdCbG9ja0Zs b3cpOworICAgICAgICBzcGxpdEVsZW1lbnQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KGVuY2xvc2lu Z05vZGUpLCAoaGlnaGVzdElubGluZU5vZGUpID8gaGlnaGVzdElubGluZU5vZGUgOiB2aXNpYmxl U3RhcnRPZlBhcmFncmFwaC5kZWVwRXF1aXZhbGVudCgpLmRlcHJlY2F0ZWROb2RlKCkpOwogICAg IH0KICAgICBSZWZQdHI8Tm9kZT4gcGxhY2Vob2xkZXIgPSBjcmVhdGVCcmVha0VsZW1lbnQoZG9j dW1lbnQoKSk7CiAgICAgaW5zZXJ0Tm9kZUJlZm9yZShwbGFjZWhvbGRlciwgc3BsaXRCbG9ja3F1 b3RlTm9kZSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmNwcAkocmV2 aXNpb24gOTk5MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjk2LDYgKzI5NiwxMSBAQCBib29sIGlzQmxvY2soY29uc3QgTm9k ZSogbm9kZSkKICAgICByZXR1cm4gbm9kZSAmJiBub2RlLT5yZW5kZXJlcigpICYmICFub2RlLT5y ZW5kZXJlcigpLT5pc0lubGluZSgpOwogfQogCitib29sIGlzSW5saW5lKGNvbnN0IE5vZGUqIG5v ZGUpCit7CisgICAgcmV0dXJuIG5vZGUgJiYgbm9kZS0+cmVuZGVyZXIoKSAmJiBub2RlLT5yZW5k ZXJlcigpLT5pc0lubGluZSgpOworfQorCiAvLyBGSVhNRTogRGVwbG95IHRoaXMgaW4gYWxsIG9m IHRoZSBwbGFjZXMgd2hlcmUgZW5jbG9zaW5nQmxvY2tGbG93L2VuY2xvc2luZ0Jsb2NrRmxvd09y VGFibGVFbGVtZW50IGFyZSB1c2VkLgogLy8gRklYTUU6IFBhc3MgYSBwb3NpdGlvbiB0byB0aGlz IGZ1bmN0aW9uLiAgVGhlIGVuY2xvc2luZyBibG9jayBvZiBbdGFibGUsIHhdIGZvciBleGFtcGxl LCBzaG91bGQgYmUgdGhlIAogLy8gYmxvY2sgdGhhdCBjb250YWlucyB0aGUgdGFibGUgYW5kIG5v dCB0aGUgdGFibGUsIGFuZCB0aGlzIGZ1bmN0aW9uIHNob3VsZCBiZSB0aGUgb25seSBvbmUgcmVz cG9uc2libGUgZm9yIApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9odG1sZWRpdGluZy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaHRtbGVkaXRpbmcuaAkocmV2 aXNpb24gOTk5MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmgJKHdv cmtpbmcgY29weSkKQEAgLTk2LDYgKzk2LDcgQEAgaW5saW5lIGJvb2wgY2FuSGF2ZUNoaWxkcmVu Rm9yRWRpdGluZyhjbwogCiBib29sIGlzQXRvbWljTm9kZShjb25zdCBOb2RlKik7CiBib29sIGlz QmxvY2soY29uc3QgTm9kZSopOworYm9vbCBpc0lubGluZShjb25zdCBOb2RlKik7CiBib29sIGlz U3BlY2lhbEVsZW1lbnQoY29uc3QgTm9kZSopOwogYm9vbCBpc1RhYlNwYW5Ob2RlKGNvbnN0IE5v ZGUqKTsKIGJvb2wgaXNUYWJTcGFuVGV4dE5vZGUoY29uc3QgTm9kZSopOwpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gOTk5MDkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0xMS0xMCAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUu Y29tPgorCisgICAgICAgIEFTU0VSVCB3aGVuIG91dGRlbnRpbmcgc3R5bGVkIGxpbmUgYnJlYWsu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjA2OQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA0Mjk3Mzk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQt YnJlYWstd2l0aC1zdHlsZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcv ZXhlY0NvbW1hbmQvb3V0ZGVudC1icmVhay13aXRoLXN0eWxlLmh0bWw6IEFkZGVkLgorCiAyMDEx LTExLTEwICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIwNjAKSW5kZXg6IExheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvb3V0ZGVudC1icmVhay13aXRoLXN0eWxlLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQt YnJlYWstd2l0aC1zdHlsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtYnJlYWstd2l0aC1zdHlsZS1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOCBAQAorVGhpcyB0ZXN0IG91dGRlbnRzIGFuIGVt cHR5IHBhcmFncmFwaCB3aXRoIGlubGluZSBzdHlsZS4KK3wgPGJsb2NrcXVvdGU+Cit8ICAgc3R5 bGU9Im1hcmdpbjogMCAwIDAgNDBweDsgYm9yZGVyOiBub25lOyBwYWRkaW5nOiAwcHg7IgorfCAg IDxpbWc+Cit8ICAgPGJyPgorfCA8Yj4KK3wgICA8I3NlbGVjdGlvbi1jYXJldD4KK3wgICA8YnI+ CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtYnJlYWstd2l0 aC1zdHlsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvb3V0ZGVudC1icmVhay13aXRoLXN0eWxlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtYnJlYWstd2l0aC1zdHlsZS5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJv ZHkgY29udGVudGVkaXRhYmxlPjwvYm9keT4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMv ZHVtcC1hcy1tYXJrdXAuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKyAgICAgICAgICAgIAoraWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisKK3doaWxlIChzY3JpcHQgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdz Y3JpcHQnKSkKKyAgICBzY3JpcHQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChzY3JpcHQpOworCitn ZXRTZWxlY3Rpb24oKS5zZXRQb3NpdGlvbihkb2N1bWVudC5ib2R5LCAwKTsKK2RvY3VtZW50LmV4 ZWNDb21tYW5kKCJJbnNlcnRJbWFnZSIsZmFsc2UpOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoIklu ZGVudCIpOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkJvbGQiKTsKK2RvY3VtZW50LmV4ZWNDb21t YW5kKCJJbnNlcnRMaW5lQnJlYWsiKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCJPdXRkZW50Iik7 CisKK01hcmt1cC5kZXNjcmlwdGlvbignVGhpcyB0ZXN0IG91dGRlbnRzIGFuIGVtcHR5IHBhcmFn cmFwaCB3aXRoIGlubGluZSBzdHlsZS4nKTsKK01hcmt1cC5kdW1wKGRvY3VtZW50LmJvZHkpOwor ICAgICAgICAgICAgCis8L3NjcmlwdD4KKworPC9odG1sPgo=