72057 2011-11-10 14:10:45 -0800 ChangeLog mistakenly recognizes any string between '*' and ':' as touched files 2011-11-10 14:52:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth eric leandro ojan webkit.review.bot oldest_to_newest 500266 0 rniwa 2011-11-10 14:10:45 -0800 e.g. it includes ) in the touched file when we have: (WebCore::KURL::operator NSURL *): 500287 1 eric 2011-11-10 14:27:13 -0800 You mean changelog.py I assume? 500289 2 114572 rniwa 2011-11-10 14:29:30 -0800 Created attachment 114572 fixes the bug 500293 3 rniwa 2011-11-10 14:34:11 -0800 (In reply to comment #1) > You mean changelog.py I assume? Yup. 500301 4 114572 eric 2011-11-10 14:40:35 -0800 Comment on attachment 114572 fixes the bug LGTM. THanks. 500318 5 rniwa 2011-11-10 14:52:36 -0800 Committed r99901: <http://trac.webkit.org/changeset/99901> 114572 2011-11-10 14:29:30 -0800 2011-11-10 14:40:35 -0800 fixes the bug bug-72057-20111110142929.patch text/plain 3999 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk5ODk4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTEtMTAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgQ2hhbmdlTG9nIG1pc3Rha2VubHkgcmVjb2duaXplIGFueSBzdHJpbmcgYmV0d2Vl biAnKicgYW5kICc6JyBhcyB0b3VjaGVkIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjA1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhlIHJlZ3VsYXIgZXhwcmVzc2lvbiBtb3JlIGV4 cGxpY2l0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hh bmdlbG9nLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2No YW5nZWxvZ191bml0dGVzdC5weToKKwogMjAxMS0xMS0xMCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFs YXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBYMTEgcGx1Z2lucyBuZWVkIHRvIGJlIHJl d29ya2VkIGZvciBRdDUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L2NoYW5nZWxvZy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHkJKHJldmlzaW9uIDk5ODk3KQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5CSh3b3JraW5nIGNvcHkp CkBAIC03NSw3ICs3NSw3IEBAIGNsYXNzIENoYW5nZUxvZ0VudHJ5KG9iamVjdCk6CiAgICAgZGF0 ZV9saW5lX3JlZ2V4cCA9IHInXig/UDxkYXRlPlxkezR9LVxkezJ9LVxkezJ9KVxzKyg/UDxuYW1l Pi4rPylccys8KD9QPGVtYWlsPltePD5dKyk+JCcKIAogICAgICMgZS5nLiAqIFNvdXJjZS9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcDogSW1wbGVtZW50IEZvb0JhclF1dXguCi0gICAgdG91 Y2hlZF9maWxlc19yZWdleHAgPSByJ1xzKlwqXHMqKD9QPGZpbGU+LispXDonCisgICAgdG91Y2hl ZF9maWxlc19yZWdleHAgPSByJ15ccypcKlxzKig/UDxmaWxlPltBLVphLXowLTlfXC1cLi9cXF0r KVxzKlw6JwogCiAgICAgIyBlLmcuIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgogICAgICMgKERp c2NhcmQgZXZlcnl0aGluZyBhZnRlciB0aGUgZmlyc3QgcGVyaW9kIHRvIG1hdGNoIG1vcmUgaW52 YWxpZCBsaW5lcy4pCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291 dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA5OTg5 NykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191 bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsMzEgQEAgY2xhc3MgQ2hhbmdl TG9nVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHRlc3RzLiBUaGUgY2xvc2UgbWV0 aG9kIGNhbiBiZSBjYWxsZWQgb24gYSB3aW5kb3cgdGhhdCdzIGFscmVhZHkgY2xvc2VkCiAgICAg ICAgIHNvIHdlIGNhbid0IGFzc2VydCBoZXJlLgogCisyMDExLTExLTA0ICBCZW5qYW1pbiBQb3Vs YWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFJlc291cmNlUmVxdWVz dCdzIG5zVVJMUmVxdWVzdCgpIGRvZXMgbm90IGRpZmZlcmVudGlhdGUgbnVsbCBhbmQgZW1wdHkg VVJMcyB3aXRoIENGTmV0d29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzE1MzkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCisK KyAgICAgICAgSW4gb3JkZXIgdG8gaGF2ZSBDRlVSTCBhbmQgTlNVUkwgdG8gYmUgY29uc2lzdGVu dCB3aGVuIGJvdGggYXJlIHVzZWQgb24gTWFjLAorICAgICAgICBLVVJMOjpjcmVhdGVDRlVSTCgp IGlzIGNoYW5nZWQgdG8gc3VwcG9ydCBlbXB0eSBVUkwgdmFsdWVzLgorCisgICAgICAgICogVGhp cyBjaGFuZ2UgbG9nIGVudHJ5IGlzIG1hZGUgdXAgdG8gdGVzdCBfcGFyc2VfZW50cnk6CisgICAg ICAgICAgICAqIGEgbGlzdCBvZiB0aGluZ3MKKworICAgICAgICAqIHBsYXRmb3JtL2NmL0tVUkxD Rk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVDRlVSTEZyb21CdWZmZXIpOgorICAg ICAgICAoV2ViQ29yZTo6S1VSTDo6Y3JlYXRlQ0ZVUkwpOgorICAgICAgICAqIHBsYXRmb3JtL21h Yy9LVVJMTWFjLm1tIDoKKyAgICAgICAgKFdlYkNvcmU6OktVUkw6Om9wZXJhdG9yIE5TVVJMICop OgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6Y3JlYXRlQ0ZVUkwpOgorICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVD bGllbnRFZmw6OmNsb3NlV2luZG93U29vbik6IGNhbGwgbmV3IGZ1bmN0aW9uIGFuZCBtb3ZlcyBp dHMKKyAgICAgICAgcHJldmlvdXMgZnVuY3Rpb25hbGl0eSB0aGVyZS4KKyAgICAgICAgKiBld2sv ZXdrX3ByaXZhdGUuaDoKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorCiA9PSBSb2xsZWQg b3ZlciB0byBDaGFuZ2VMb2ctMjAwOS0wNi0xNiA9PQogIiIiCiAKQEAgLTE1NiwxMCArMTgxLDEz IEBAIGNsYXNzIENoYW5nZUxvZ1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiB0ZXN0 X3BhcnNlX2xvZ19lbnRyaWVzX2Zyb21fY2hhbmdlbG9nKHNlbGYpOgogICAgICAgICBjaGFuZ2Vs b2dfZmlsZSA9IFN0cmluZ0lPKHNlbGYuX2V4YW1wbGVfY2hhbmdlbG9nKQogICAgICAgICBwYXJz ZWRfZW50cmllcyA9IGxpc3QoQ2hhbmdlTG9nLnBhcnNlX2VudHJpZXNfZnJvbV9maWxlKGNoYW5n ZWxvZ19maWxlKSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMobGVuKHBhcnNlZF9lbnRyaWVz KSwgMykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMobGVuKHBhcnNlZF9lbnRyaWVzKSwgNCkK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocGFyc2VkX2VudHJpZXNbMF0ucmV2aWV3ZXJfdGV4 dCgpLCAiRGF2aWQgTGV2aW4iKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhwYXJzZWRfZW50 cmllc1sxXS5hdXRob3JfZW1haWwoKSwgImRka2lsemVyQGFwcGxlLmNvbSIpCiAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWxzKHBhcnNlZF9lbnRyaWVzWzJdLnRvdWNoZWRfZmlsZXMoKSwgWyJEdW1w UmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVXaW5kb3cubW0iXSkKKyAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMocGFyc2VkX2VudHJpZXNbM10uYXV0aG9yX25hbWUoKSwgIkJlbmphbWluIFBv dWxhaW4iKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhwYXJzZWRfZW50cmllc1szXS50b3Vj aGVkX2ZpbGVzKCksIFsicGxhdGZvcm0vY2YvS1VSTENGTmV0LmNwcCIsICJwbGF0Zm9ybS9tYWMv S1VSTE1hYy5tbSIsCisgICAgICAgICAgICAiV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZs LmNwcCIsICJld2svZXdrX3ByaXZhdGUuaCIsICJld2svZXdrX3ZpZXcuY3BwIl0pCiAKICAgICBk ZWYgdGVzdF9sYXRlc3RfZW50cnlfcGFyc2Uoc2VsZik6CiAgICAgICAgIGNoYW5nZWxvZ19jb250 ZW50cyA9IHUiJXNcbiVzIiAlIChzZWxmLl9leGFtcGxlX2VudHJ5LCBzZWxmLl9leGFtcGxlX2No YW5nZWxvZykK