72054 2011-11-10 13:48:43 -0800 Could round rather than truncate in compileClampDoubleToByte? 2023-08-22 11:21:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar P2 Normal --- 260534 1 barraclough keith_miller ahmad.saleem792 commit-queue keith_miller webkit-bug-importer oldest_to_newest 500237 0 barraclough 2011-11-10 13:48:43 -0800 There is a +0.5 followed by truncate in the DFG JIT, may be able to replace this with a round. 1885828 1 ahmad.saleem792 2022-07-21 14:37:31 -0700 https://github.com/WebKit/WebKit/blob/main/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp#L3555 It is still present in the Source Code. 1970735 2 keith_miller 2023-08-11 10:29:07 -0700 This also has the wrong semantics. It should be a round to nearest not a round to infinity. Uploading a patch now. 1970744 3 keith_miller 2023-08-11 10:34:06 -0700 Pull request: https://github.com/WebKit/WebKit/pull/16609 1972448 4 ews-feeder 2023-08-21 11:56:55 -0700 Committed 267100@main (c55d0673236c): <https://commits.webkit.org/267100@main> Reviewed commits have been landed. Closing PR #16609 and removing active labels. 1972450 5 webkit-bug-importer 2023-08-21 11:57:16 -0700 <rdar://problem/114208146> 1972680 6 commit-queue 2023-08-22 11:21:36 -0700 Re-opened since this is blocked by bug 260534