72044 2011-11-10 12:30:32 -0800 Add a simple content layer to TiledCoreAnimationDrawingArea 2011-11-10 13:07:19 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 500137 0 andersca 2011-11-10 12:30:32 -0800 Add a simple content layer to TiledCoreAnimationDrawingArea 500143 1 114544 andersca 2011-11-10 12:37:33 -0800 Created attachment 114544 Patch 500152 2 114544 darin 2011-11-10 12:42:28 -0800 Comment on attachment 114544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114544&action=review > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:47 > +- (id)_initWithWebPage:(WebKit::WebPage *)webPage; Why the underscore? If the entire class is private, then I’d expect that to be expressed in the class name. Is there some sense in which this is private? > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:86 > - m_rootLayer.get().frame = (CGRect)m_webPage->bounds(); > + m_rootLayer.get().frame = static_cast<CGRect>(m_webPage->bounds()); Is there a way we can trigger this conversion without a cast? Maybe use a local variable? Back when I worked on Boost I had proposed an implicit_cast, which would do only conversions that could be done with an assignment and no cast at all. A static_cast seems too powerful to me. 500167 3 114544 andersca 2011-11-10 12:56:03 -0800 Comment on attachment 114544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114544&action=review >> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:47 >> +- (id)_initWithWebPage:(WebKit::WebPage *)webPage; > > Why the underscore? If the entire class is private, then I’d expect that to be expressed in the class name. Is there some sense in which this is private? It's just a placeholder for the real tiled layer container. I'll remove the underscore. >> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:86 >> + m_rootLayer.get().frame = static_cast<CGRect>(m_webPage->bounds()); > > Is there a way we can trigger this conversion without a cast? Maybe use a local variable? Back when I worked on Boost I had proposed an implicit_cast, which would do only conversions that could be done with an assignment and no cast at all. A static_cast seems too powerful to me. This is actually a workaround for a bug in GCC where you can't set a property to a temporary. I'll use a local variable. 500186 4 andersca 2011-11-10 13:07:19 -0800 Committed r99891: <http://trac.webkit.org/changeset/99891> 114544 2011-11-10 12:37:33 -0800 2011-11-10 12:56:03 -0800 Patch bug-72044-20111110123804.patch text/plain 6100 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTk4ODAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAxZWU5NzA5ZDg2OWQ1ZGRh MWIzZDdlZDFkZmI2YTZkOGE4ZTU2NTZkLi40MmEyOWMwODNkMWM3YTY0Njg0YTg0OTI5OTdlNTEw OWNiNTAzZWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzIgQEAKIDIwMTEtMTEtMTAgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBBZGQgYSBzaW1wbGUg Y29udGVudCBsYXllciB0byBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIwNDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEuaDoKKyAgICAgICAgQWRkIGEgY29u dGVudCBsYXllciBtZW1iZXIgdmFyaWFibGUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAoLVtXS0Nv bnRlbnRMYXllciBfaW5pdFdpdGhXZWJQYWdlOldlYktpdDo6XSk6CisgICAgICAgIEFkZCBpbml0 aWFsaXplci4KKworICAgICAgICAoLVtXS0NvbnRlbnRMYXllciBkcmF3SW5Db250ZXh0Ol0pOgor ICAgICAgICBMYXkgb3V0IGFuZCBkcmF3IHRoZSB3ZWIgcGFnZS4KKworICAgICAgICAoV2ViS2l0 OjpUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2lu Z0FyZWEpOgorICAgICAgICBBZGQgdGhlIGNvbnRlbnQgbGF5ZXIgYXMgYSBzdWJsYXllciBvZiB0 aGUgcm9vdCBsYXllci4KKworICAgICAgICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25EcmF3 aW5nQXJlYTo6c2V0TmVlZHNEaXNwbGF5KToKKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWE6OnNjcm9sbCk6CisgICAgICAgIFRlbGwgdGhlIGNvbnRlbnQgbGF5 ZXIgdG8gcGFpbnQuCisKKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2lu Z0FyZWE6OnVwZGF0ZUdlb21ldHJ5KToKKyAgICAgICAgUmVzaXplIHRoZSBjb250ZW50IGxheWVy IGFzIHdlbGwuCisKKzIwMTEtMTEtMTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKwogICAgICAgICBUaGUgV0tWaWV3IGxheWVyIGhvc3Rpbmcgc3VidmlldyBuZWVkcyB0 byBiZSBmbGlwcGVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MjA0MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmggYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLmgKaW5k ZXggYjQyNTkyODg0NDdhODQ1NmFhMjgyM2U3MjVkYmJmY2NiOTMyZjg5OS4uYzY5NDQyODE0YzI4 YzY1YzYyZTc0NjM5NDk4MDgxMjZhMjRmMTNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0 aW9uRHJhd2luZ0FyZWEuaApAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgPHd0Zi9SZXRhaW5Q dHIuaD4KIAogT0JKQ19DTEFTUyBDQUxheWVyOworT0JKQ19DTEFTUyBXS0NvbnRlbnRMYXllcjsK IAogdHlwZWRlZiBzdHJ1Y3QgX19XS0NBUmVtb3RlTGF5ZXJDbGllbnRSZWYqIFdLQ0FSZW1vdGVM YXllckNsaWVudFJlZjsKIApAQCAtNTYsNiArNTcsOCBAQCBwcml2YXRlOgogICAgIFJldGFpblB0 cjxXS0NBUmVtb3RlTGF5ZXJDbGllbnRSZWY+IG1fcmVtb3RlTGF5ZXJDbGllbnQ7CiAKICAgICBS ZXRhaW5QdHI8Q0FMYXllcj4gbV9yb290TGF5ZXI7CisKKyAgICBSZXRhaW5QdHI8V0tDb250ZW50 TGF5ZXI+IG1fY29udGVudExheWVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFu aW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQppbmRleCBiYmM3M2YyZjVmZmM0 NGQ0YTlmMDgyODhiYzdkOWZmZmQzNmMyODg0Li44YmIxN2Q4YmUxZWJiMDcwZTdjNTc2YTkwODlk ZWExNWU2NGQxNTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEu bW0KQEAgLTMxLDYgKzMxLDcgQEAKICNpbXBvcnQgIldlYlBhZ2UuaCIKICNpbXBvcnQgIldlYlBy b2Nlc3MuaCIKICNpbXBvcnQgPFF1YXJ0ekNvcmUvUXVhcnR6Q29yZS5oPgorI2ltcG9ydCA8V2Vi Q29yZS9HcmFwaGljc0NvbnRleHQuaD4KICNpbXBvcnQgPFdlYktpdFN5c3RlbUludGVyZmFjZS5o PgogCiBAaW50ZXJmYWNlIENBVHJhbnNhY3Rpb24gKERldGFpbHMpCkBAIC0zOSw2ICs0MCwzNyBA QAogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAorQGludGVyZmFjZSBXS0NvbnRlbnRMYXll ciA6IENBTGF5ZXIgeworICAgIFdlYktpdDo6V2ViUGFnZSAqX3dlYlBhZ2U7Cit9CisKKy0gKGlk KV9pbml0V2l0aFdlYlBhZ2U6KFdlYktpdDo6V2ViUGFnZSAqKXdlYlBhZ2U7CisKK0BlbmQKKwor QGltcGxlbWVudGF0aW9uIFdLQ29udGVudExheWVyCisKKy0gKGlkKV9pbml0V2l0aFdlYlBhZ2U6 KFdlYktpdDo6V2ViUGFnZSAqKXdlYlBhZ2UKK3sKKyAgICBzZWxmID0gW3N1cGVyIGluaXRdOwor ICAgIGlmIChzZWxmKQorICAgICAgICBzZWxmLT5fd2ViUGFnZSA9IHdlYlBhZ2U7CisKKyAgICBy ZXR1cm4gc2VsZjsKK30KKworLSAodm9pZClkcmF3SW5Db250ZXh0OihDR0NvbnRleHRSZWYpY29u dGV4dAoreworICAgIF93ZWJQYWdlLT5sYXlvdXRJZk5lZWRlZCgpOworCisgICAgQ0dSZWN0IGNs aXBSZWN0ID0gQ0dDb250ZXh0R2V0Q2xpcEJvdW5kaW5nQm94KGNvbnRleHQpOworCisgICAgR3Jh cGhpY3NDb250ZXh0IGdyYXBoaWNzQ29udGV4dChjb250ZXh0KTsKKyAgICBfd2ViUGFnZS0+ZHJh d1JlY3QoZ3JhcGhpY3NDb250ZXh0LCBlbmNsb3NpbmdJbnRSZWN0KGNsaXBSZWN0KSk7Cit9CisK K0BlbmQKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIFBhc3NPd25QdHI8VGlsZWRDb3JlQW5pbWF0 aW9uRHJhd2luZ0FyZWE+IFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpjcmVhdGUoV2Vi UGFnZSogd2ViUGFnZSwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVy cykKQEAgLTUxLDE2ICs4MywyMiBAQCBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6VGls ZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEoV2ViUGFnZSogd2ViUGFnZSwgYwogewogICAgIG1f cm9vdExheWVyID0gW0NBTGF5ZXIgbGF5ZXJdOwogCi0gICAgbV9yb290TGF5ZXIuZ2V0KCkuZnJh bWUgPSAoQ0dSZWN0KW1fd2ViUGFnZS0+Ym91bmRzKCk7CisgICAgbV9yb290TGF5ZXIuZ2V0KCku ZnJhbWUgPSBzdGF0aWNfY2FzdDxDR1JlY3Q+KG1fd2ViUGFnZS0+Ym91bmRzKCkpOwogICAgIG1f cm9vdExheWVyLmdldCgpLm9wYXF1ZSA9IFlFUzsKKyAgICBtX3Jvb3RMYXllci5nZXQoKS5nZW9t ZXRyeUZsaXBwZWQgPSBZRVM7CiAKICAgICAvLyBHaXZlIHRoZSByb290IGxheWVyIGEgYmFja2dy b3VuZCBjb2xvciBzbyBpdCdzIHZpc2libGUgb24gc2NyZWVuLgogICAgIG1fcm9vdExheWVyLmdl dCgpLmJhY2tncm91bmRDb2xvciA9IENHQ29sb3JDcmVhdGVHZW5lcmljUkdCKDEsIDAsIDAsIDEp OwogCisgICAgbV9jb250ZW50TGF5ZXIuYWRvcHROUyhbW1dLQ29udGVudExheWVyIGFsbG9jXSBf aW5pdFdpdGhXZWJQYWdlOndlYlBhZ2VdKTsKKyAgICBtX2NvbnRlbnRMYXllci5nZXQoKS5mcmFt ZSA9IG1fcm9vdExheWVyLmdldCgpLmZyYW1lOworCisgICAgW21fcm9vdExheWVyLmdldCgpIGFk ZFN1YmxheWVyOm1fY29udGVudExheWVyLmdldCgpXTsKKwogICAgIG1hY2hfcG9ydF90IHNlcnZl clBvcnQgPSBXZWJQcm9jZXNzOjpzaGFyZWQoKS5jb21wb3NpdGluZ1JlbmRlclNlcnZlclBvcnQo KTsKICAgICBtX3JlbW90ZUxheWVyQ2xpZW50ID0gV0tDQVJlbW90ZUxheWVyQ2xpZW50TWFrZVdp dGhTZXJ2ZXJQb3J0KHNlcnZlclBvcnQpOwogICAgIFdLQ0FSZW1vdGVMYXllckNsaWVudFNldExh eWVyKG1fcmVtb3RlTGF5ZXJDbGllbnQuZ2V0KCksIG1fcm9vdExheWVyLmdldCgpKTsKLSAgICAK KwogICAgIExheWVyVHJlZUNvbnRleHQgbGF5ZXJUcmVlQ29udGV4dDsKICAgICBsYXllclRyZWVD b250ZXh0LmNvbnRleHRJRCA9IFdLQ0FSZW1vdGVMYXllckNsaWVudEdldENsaWVudElkKG1fcmVt b3RlTGF5ZXJDbGllbnQuZ2V0KCkpOwogICAgIG1fd2ViUGFnZS0+c2VuZChNZXNzYWdlczo6RHJh d2luZ0FyZWFQcm94eTo6RW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSgwLCBsYXllclRy ZWVDb250ZXh0KSk7CkBAIC03MCwxNCArMTA4LDE0IEBAIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdp bmdBcmVhOjp+VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEoKQogewogfQogCi12b2lkIFRp bGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXROZWVkc0Rpc3BsYXkoY29uc3QgSW50UmVj dCYpCit2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzZXROZWVkc0Rpc3BsYXko Y29uc3QgSW50UmVjdCYgcmVjdCkKIHsKLSAgICAvLyBGSVhNRTogSW1wbGVtZW50LgorICAgIFtt X2NvbnRlbnRMYXllci5nZXQoKSBzZXROZWVkc0Rpc3BsYXlJblJlY3Q6cmVjdF07CiB9CiAKIHZv aWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNjcm9sbChjb25zdCBJbnRSZWN0JiBz Y3JvbGxSZWN0LCBjb25zdCBJbnRTaXplJiBzY3JvbGxPZmZzZXQpCiB7Ci0gICAgLy8gRklYTUU6 IEltcGxlbWVudC4KKyAgICBbbV9jb250ZW50TGF5ZXIuZ2V0KCkgc2V0TmVlZHNEaXNwbGF5SW5S ZWN0OnNjcm9sbFJlY3RdOwogfQogCiB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVh OjpzZXRSb290Q29tcG9zaXRpbmdMYXllcihHcmFwaGljc0xheWVyKikKQEAgLTkyLDkgKzEzMCwx NSBAQCB2b2lkIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpzY2hlZHVsZUNvbXBvc2l0 aW5nTGF5ZXJTeW5jKCkKIAogdm9pZCBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6dXBk YXRlR2VvbWV0cnkoY29uc3QgSW50U2l6ZSYgdmlld1NpemUpCiB7CisgICAgbV93ZWJQYWdlLT5z ZXRTaXplKHZpZXdTaXplKTsKKyAgICBtX3dlYlBhZ2UtPmxheW91dElmTmVlZGVkKCk7CisKICAg ICBbQ0FUcmFuc2FjdGlvbiBiZWdpbl07CiAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFj dGlvbnM6WUVTXTsKLSAgICBbbV9yb290TGF5ZXIuZ2V0KCkgc2V0RnJhbWU6Q0dSZWN0TWFrZSgw LCAwLCB2aWV3U2l6ZS53aWR0aCgpLCB2aWV3U2l6ZS5oZWlnaHQoKSldOworCisgICAgbV9yb290 TGF5ZXIuZ2V0KCkuZnJhbWUgPSBDR1JlY3RNYWtlKDAsIDAsIHZpZXdTaXplLndpZHRoKCksIHZp ZXdTaXplLmhlaWdodCgpKTsKKyAgICBtX2NvbnRlbnRMYXllci5nZXQoKS5mcmFtZSA9IENHUmVj dE1ha2UoMCwgMCwgdmlld1NpemUud2lkdGgoKSwgdmlld1NpemUuaGVpZ2h0KCkpOworCiAgICAg W0NBVHJhbnNhY3Rpb24gY29tbWl0XTsKICAgICAKICAgICBbQ0FUcmFuc2FjdGlvbiBmbHVzaF07 Cg==