72026 2011-11-10 06:59:35 -0800 [chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest 2011-11-14 04:41:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 husky webkit-unassigned hclam husky jamesr webkit.review.bot oldest_to_newest 499870 0 husky 2011-11-10 06:59:35 -0800 [chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest 499874 1 114492 husky 2011-11-10 07:03:27 -0800 Created attachment 114492 Patch 499989 2 114492 webkit.review.bot 2011-11-10 09:15:02 -0800 Comment on attachment 114492 Patch Rejecting attachment 114492 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/trunk@9897; UUID don't match and there is local changes in /mnt/git/webkit-commit-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 111. Full output: http://queues.webkit.org/results/10414015 501077 3 114492 webkit.review.bot 2011-11-11 14:03:31 -0800 Comment on attachment 114492 Patch Rejecting attachment 114492 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: reviewer', u'Tony Gentilcore', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp Hunk #6 FAILED at 340. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Gentilcore', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10396535 501777 4 114914 husky 2011-11-14 03:48:05 -0800 Created attachment 114914 Rebased 501796 5 114914 webkit.review.bot 2011-11-14 04:41:19 -0800 Comment on attachment 114914 Rebased Clearing flags on attachment: 114914 Committed r100127: <http://trac.webkit.org/changeset/100127> 501797 6 webkit.review.bot 2011-11-14 04:41:24 -0800 All reviewed patches have been landed. Closing bug. 114492 2011-11-10 07:03:27 -0800 2011-11-14 03:47:51 -0800 Patch bug-72026-20111110150325.patch text/plain 3258 husky SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5OTg0OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTEtMTEtMTAgIElhaW4gTWVycmljayAgPGh1c2t5QGdvb2dsZS5jb20+CisKKyAgICAg ICAgW2Nocm9taXVtXSBGaXggaW5jb3JyZWN0IHVzYWdlIG9mIEFTU0VSVCBpbiBDQ0xheWVyVHJl ZUhvc3RUZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MjAyNgorCisgICAgICAgIEFTU0VSVCBpcyBzdHJpcHBlZCBvdXQgaW4gcmVsZWFzZSBidWls ZHMgc28gaXQgc2hvdWxkbid0IGJlIHVzZWQKKyAgICAgICAgaW4gdW5pdCB0ZXN0cywgZXhjZXB0 IHdoZW4gY2FsbGluZyBkZWJ1Zy1vbmx5IGZ1bmN0aW9ucyBsaWtlCisgICAgICAgIGlzTWFpblRo cmVhZCgpLgorCisgICAgICAgIFJlcGxhY2luZyB3aXRoIEFTU0VSVF9UUlVFIChvciBFWFBFQ1Rf VFJVRSBpbiBjb25zdHJ1Y3RvcnMsIHdoZXJlCisgICAgICAgIHdlIGNhbid0IHJldHVybiBhIHZh bHVlKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHRlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwOgorICAgICAgICAoV1RGOjpNb2NrTGF5ZXJU cmVlSG9zdDo6TW9ja0xheWVyVHJlZUhvc3QpOgorICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhv c3RUZXN0OjpvbkVuZFRlc3QpOgorICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhvc3RUZXN0Ojpk aXNwYXRjaFNldE5lZWRzQ29tbWl0KToKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVIb3N0VGVz dDo6ZGlzcGF0Y2hTZXROZWVkc1JlZHJhdyk6CisgICAgICAgIChXVEY6OkNDTGF5ZXJUcmVlSG9z dFRlc3Q6OnJ1blRlc3QpOgorICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhvc3RUZXN0Ojpkb0Jl Z2luVGVzdCk6CisKIDIwMTEtMTEtMTAgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIFNjcm9sbCBkZWx0YXMgYXJlIGNsZWFyZWQgZHVyaW5nIGNv bW1pdCB0byB0aGUgbWFpbiB0aHJlYWQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcAkocmV2aXNpb24gOTk4NDUpCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMTYsOCArMTE2LDcgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAg IHNldFJvb3RMYXllcihyb290TGF5ZXIpOwogICAgICAgICBib29sIHN1Y2Nlc3MgPSBpbml0aWFs aXplKCk7Ci0gICAgICAgIEFTU0VSVChzdWNjZXNzKTsKLSAgICAgICAgVU5VU0VEX1BBUkFNKHN1 Y2Nlc3MpOworICAgICAgICBFWFBFQ1RfVFJVRShzdWNjZXNzKTsKICAgICB9CiAKICAgICBUZXN0 SG9va3MqIG1fdGVzdEhvb2tzOwpAQCAtMjQ5LDcgKzI0OCw3IEBAIHByb3RlY3RlZDoKICAgICAg ICAgd2Via2l0X3N1cHBvcnQ6OlF1aXRNZXNzYWdlTG9vcCgpOwogICAgICAgICB3ZWJraXRfc3Vw cG9ydDo6UnVuQWxsUGVuZGluZ01lc3NhZ2VzKCk7CiAgICAgICAgIENDTGF5ZXJUcmVlSG9zdFRl c3QqIHRlc3QgPSBzdGF0aWNfY2FzdDxDQ0xheWVyVHJlZUhvc3RUZXN0Kj4oc2VsZik7Ci0gICAg ICAgIEFTU0VSVCh0ZXN0KTsKKyAgICAgICAgQVNTRVJUX1RSVUUodGVzdCk7CiAgICAgICAgIHRl c3QtPm1fbGF5ZXJUcmVlSG9zdC5jbGVhcigpOwogICAgIH0KIApAQCAtMjU3LDcgKzI1Niw3IEBA IHByb3RlY3RlZDoKICAgICB7CiAgICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgICAg Q0NMYXllclRyZWVIb3N0VGVzdCogdGVzdCA9IHN0YXRpY19jYXN0PENDTGF5ZXJUcmVlSG9zdFRl c3QqPihzZWxmKTsKLSAgICAgIEFTU0VSVCh0ZXN0KTsKKyAgICAgIEFTU0VSVF9UUlVFKHRlc3Qp OwogICAgICAgaWYgKHRlc3QtPm1fbGF5ZXJUcmVlSG9zdCkKICAgICAgICAgICB0ZXN0LT5tX2xh eWVyVHJlZUhvc3QtPnNldE5lZWRzQ29tbWl0KCk7CiAgICAgfQpAQCAtMjY2LDcgKzI2NSw3IEBA IHByb3RlY3RlZDoKICAgICB7CiAgICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgICAg Q0NMYXllclRyZWVIb3N0VGVzdCogdGVzdCA9IHN0YXRpY19jYXN0PENDTGF5ZXJUcmVlSG9zdFRl c3QqPihzZWxmKTsKLSAgICAgIEFTU0VSVCh0ZXN0KTsKKyAgICAgIEFTU0VSVF9UUlVFKHRlc3Qp OwogICAgICAgaWYgKHRlc3QtPm1fbGF5ZXJUcmVlSG9zdCkKICAgICAgICAgICB0ZXN0LT5tX2xh eWVyVHJlZUhvc3QtPnNldE5lZWRzUmVkcmF3KCk7CiAgICAgfQpAQCAtMzExLDcgKzMxMCw3IEBA IHByb3RlY3RlZDoKICAgICAgICAgaWYgKG1fdGltZW91dFRhc2spCiAgICAgICAgICAgICBtX3Rp bWVvdXRUYXNrLT5jbGVhclRlc3QoKTsKIAotICAgICAgICBBU1NFUlQoIW1fbGF5ZXJUcmVlSG9z dC5nZXQoKSk7CisgICAgICAgIEFTU0VSVF9GQUxTRShtX2xheWVyVHJlZUhvc3QuZ2V0KCkpOwog ICAgICAgICBtX2NsaWVudC5jbGVhcigpOwogICAgICAgICBpZiAobV90aW1lZE91dCkgewogICAg ICAgICAgICAgRkFJTCgpIDw8ICJUZXN0IHRpbWVkIG91dCI7CkBAIC0zNDEsNyArMzQwLDcgQEAg dm9pZCBDQ0xheWVyVHJlZUhvc3RUZXN0Ojpkb0JlZ2luVGVzdCgpCiAKICAgICBSZWZQdHI8TGF5 ZXJDaHJvbWl1bT4gcm9vdExheWVyID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKDApOwogICAgIG1f bGF5ZXJUcmVlSG9zdCA9IE1vY2tMYXllclRyZWVIb3N0OjpjcmVhdGUodGhpcywgbV9jbGllbnQu Z2V0KCksIHJvb3RMYXllciwgbV9zZXR0aW5ncyk7Ci0gICAgQVNTRVJUKG1fbGF5ZXJUcmVlSG9z dCk7CisgICAgQVNTRVJUX1RSVUUobV9sYXllclRyZWVIb3N0KTsKICAgICByb290TGF5ZXItPnNl dExheWVyVHJlZUhvc3QobV9sYXllclRyZWVIb3N0LmdldCgpKTsKIAogICAgIG1fYmVnaW5uaW5n ID0gdHJ1ZTsK 114914 2011-11-14 03:48:05 -0800 2011-11-14 04:41:18 -0800 Rebased bug-72026-20111114114804.patch text/plain 3271 husky SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDAxMjApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1 IEBACisyMDExLTExLTE0ICBJYWluIE1lcnJpY2sgIDxodXNreUBnb29nbGUuY29tPgorCisgICAg ICAgIFtjaHJvbWl1bV0gRml4IGluY29ycmVjdCB1c2FnZSBvZiBBU1NFUlQgaW4gQ0NMYXllclRy ZWVIb3N0VGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzIwMjYKKworICAgICAgICBBU1NFUlQgaXMgc3RyaXBwZWQgb3V0IGluIHJlbGVhc2UgYnVp bGRzIHNvIGl0IHNob3VsZG4ndCBiZSB1c2VkCisgICAgICAgIGluIHVuaXQgdGVzdHMsIGV4Y2Vw dCB3aGVuIGNhbGxpbmcgZGVidWctb25seSBmdW5jdGlvbnMgbGlrZQorICAgICAgICBpc01haW5U aHJlYWQoKS4KKworICAgICAgICBSZXBsYWNpbmcgd2l0aCBBU1NFUlRfVFJVRSAob3IgRVhQRUNU X1RSVUUgaW4gY29uc3RydWN0b3JzLCB3aGVyZQorICAgICAgICB3ZSBjYW4ndCByZXR1cm4gYSB2 YWx1ZSkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB0ZXN0cy9DQ0xheWVyVHJlZUhvc3RUZXN0LmNwcDoKKyAgICAgICAgKFdURjo6TW9ja0xheWVy VHJlZUhvc3Q6Ok1vY2tMYXllclRyZWVIb3N0KToKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVI b3N0VGVzdDo6b25FbmRUZXN0KToKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVIb3N0VGVzdDo6 ZGlzcGF0Y2hTZXROZWVkc0NvbW1pdCk6CisgICAgICAgIChXVEY6OkNDTGF5ZXJUcmVlSG9zdFRl c3Q6OmRpc3BhdGNoU2V0TmVlZHNSZWRyYXcpOgorICAgICAgICAoV1RGOjpDQ0xheWVyVHJlZUhv c3RUZXN0OjpydW5UZXN0KToKKyAgICAgICAgKFdURjo6Q0NMYXllclRyZWVIb3N0VGVzdDo6ZG9C ZWdpblRlc3QpOgorCiAyMDExLTExLTEzICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6aW5pdGlhbGl6ZSBz aG91bGQgZmFpbCB3aGVuIEdhcGhpY3NDb250ZXh0M0Q6Om1ha2VDdXJyZW50IGZhaWxzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdFRlc3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0 VGVzdC5jcHAJKHJldmlzaW9uIDEwMDEyMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVz dHMvQ0NMYXllclRyZWVIb3N0VGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNiw4ICsxMTYs NyBAQCBwcml2YXRlOgogICAgIHsKICAgICAgICAgc2V0Um9vdExheWVyKHJvb3RMYXllcik7CiAg ICAgICAgIGJvb2wgc3VjY2VzcyA9IGluaXRpYWxpemUoKTsKLSAgICAgICAgQVNTRVJUKHN1Y2Nl c3MpOwotICAgICAgICBVTlVTRURfUEFSQU0oc3VjY2Vzcyk7CisgICAgICAgIEVYUEVDVF9UUlVF KHN1Y2Nlc3MpOwogICAgIH0KIAogICAgIFRlc3RIb29rcyogbV90ZXN0SG9va3M7CkBAIC0yNTQs NyArMjUzLDcgQEAgcHJvdGVjdGVkOgogICAgICAgICB3ZWJraXRfc3VwcG9ydDo6UXVpdE1lc3Nh Z2VMb29wKCk7CiAgICAgICAgIHdlYmtpdF9zdXBwb3J0OjpSdW5BbGxQZW5kaW5nTWVzc2FnZXMo KTsKICAgICAgICAgQ0NMYXllclRyZWVIb3N0VGVzdCogdGVzdCA9IHN0YXRpY19jYXN0PENDTGF5 ZXJUcmVlSG9zdFRlc3QqPihzZWxmKTsKLSAgICAgICAgQVNTRVJUKHRlc3QpOworICAgICAgICBB U1NFUlRfVFJVRSh0ZXN0KTsKICAgICAgICAgdGVzdC0+bV9sYXllclRyZWVIb3N0LmNsZWFyKCk7 CiAgICAgfQogCkBAIC0yNjIsNyArMjYxLDcgQEAgcHJvdGVjdGVkOgogICAgIHsKICAgICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgICBDQ0xheWVyVHJlZUhvc3RUZXN0KiB0ZXN0ID0g c3RhdGljX2Nhc3Q8Q0NMYXllclRyZWVIb3N0VGVzdCo+KHNlbGYpOwotICAgICAgQVNTRVJUKHRl c3QpOworICAgICAgQVNTRVJUX1RSVUUodGVzdCk7CiAgICAgICBpZiAodGVzdC0+bV9sYXllclRy ZWVIb3N0KQogICAgICAgICAgIHRlc3QtPm1fbGF5ZXJUcmVlSG9zdC0+c2V0TmVlZHNDb21taXQo KTsKICAgICB9CkBAIC0yNzEsNyArMjcwLDcgQEAgcHJvdGVjdGVkOgogICAgIHsKICAgICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgICBDQ0xheWVyVHJlZUhvc3RUZXN0KiB0ZXN0ID0g c3RhdGljX2Nhc3Q8Q0NMYXllclRyZWVIb3N0VGVzdCo+KHNlbGYpOwotICAgICAgQVNTRVJUKHRl c3QpOworICAgICAgQVNTRVJUX1RSVUUodGVzdCk7CiAgICAgICBpZiAodGVzdC0+bV9sYXllclRy ZWVIb3N0KQogICAgICAgICAgIHRlc3QtPm1fbGF5ZXJUcmVlSG9zdC0+c2V0TmVlZHNSZWRyYXco KTsKICAgICB9CkBAIC0zMzQsNyArMzMzLDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBpZiAobV90 aW1lb3V0VGFzaykKICAgICAgICAgICAgIG1fdGltZW91dFRhc2stPmNsZWFyVGVzdCgpOwogCi0g ICAgICAgIEFTU0VSVCghbV9sYXllclRyZWVIb3N0LmdldCgpKTsKKyAgICAgICAgQVNTRVJUX0ZB TFNFKG1fbGF5ZXJUcmVlSG9zdC5nZXQoKSk7CiAgICAgICAgIG1fY2xpZW50LmNsZWFyKCk7CiAg ICAgICAgIGlmIChtX3RpbWVkT3V0KSB7CiAgICAgICAgICAgICBGQUlMKCkgPDwgIlRlc3QgdGlt ZWQgb3V0IjsKQEAgLTM2Niw3ICszNjUsNyBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdFRlc3Q6OmRv QmVnaW5UZXN0KCkKIAogICAgIG1fcm9vdExheWVyID0gTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKDAp OwogICAgIG1fbGF5ZXJUcmVlSG9zdCA9IE1vY2tMYXllclRyZWVIb3N0OjpjcmVhdGUodGhpcywg bV9jbGllbnQuZ2V0KCksIG1fcm9vdExheWVyLCBtX3NldHRpbmdzKTsKLSAgICBBU1NFUlQobV9s YXllclRyZWVIb3N0KTsKKyAgICBBU1NFUlRfVFJVRShtX2xheWVyVHJlZUhvc3QpOwogICAgIG1f cm9vdExheWVyLT5zZXRMYXllclRyZWVIb3N0KG1fbGF5ZXJUcmVlSG9zdC5nZXQoKSk7CiAKICAg ICBtX2JlZ2lubmluZyA9IHRydWU7Cg==