72013 2011-11-10 04:27:43 -0800 Not able to navigate the Resource tab options properly with arrow keys after adding the sticky-notes. 2011-12-15 13:07:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC All RESOLVED FIXED http://www.webkit.org/demos/sticky-notes/ P2 Normal --- 0 rosen.dash webkit-unassigned pfeldman vsevik oldest_to_newest 499797 0 rosen.dash 2011-11-10 04:27:43 -0800 This bug is reported in chromium at http://code.google.com/p/chromium/issues/detail?id=100289 What steps will reproduce the problem? 1.Open the Browser 2.Open the mentioned URL. 3.Now add one or two Notes by clicking on the New Note Button provided. 4.Now Open the Developer Tools,and Click on the Resources Tab. 5.Now in the left side pane, expand the Databases -> Note Test -> WebKitStickyNotes. 6.Now with the arrow keys try navigate all the expanded items up and down. 7.It is not allowing to navigate to WebKitStickyNotes. What is the expected result? Navigation should work after expanding all the items. What happens instead? It is not able to navigate to all the items up and down. 500699 1 114681 rosen.dash 2011-11-11 05:18:03 -0800 Created attachment 114681 Fixing the Navigation through DatabaseTableTreeElement by up/down arrow key press This patch addresses proper navigation through DatabaseTableTreeElement(WebKitStickyNotes). While populating table names we remove the children of DatabaseTreeElement(NoteTest) and bind a callback to create the children again. This removing and creating of children should be done at one place. 501792 2 vsevik 2011-11-14 04:36:31 -0800 While this patch is probably a good thing to do, it is certainly not fixing the original problem and does not seem to be even related to it. The reason for this issue is that database view query console get focus once opened (arrow keys are used to access console history). 501795 3 114681 pfeldman 2011-11-14 04:40:15 -0800 Comment on attachment 114681 Fixing the Navigation through DatabaseTableTreeElement by up/down arrow key press r- as per Vsevolod's comment. 501807 4 rosen.dash 2011-11-14 04:56:23 -0800 (In reply to comment #2) > While this patch is probably a good thing to do, it is certainly not fixing the original problem and does not seem to be even related to it. > > The reason for this issue is that database view query console get focus once opened (arrow keys are used to access console history). This is certainly related. Even if we give focus by mouse to "NoteTest" and press down arrow key, it skips "WebKitStickyNotes" and moves to "LocalStorage". Similarly while the focus is on "LocalStorage" we press up arrow key the focus doesn't move any where. To check this, keep abases -> Note Test -> WebKitStickyNotes expanded. Secondly, I thought DatabaseQueryView taking focus is a feature as function "moveBackIfOutside" is called in "wasShown" function of "DatabaseQueryView" which takes the caret to prompt. Please reply If I have said something irrelevant. 501814 5 vsevik 2011-11-14 05:22:48 -0800 > This is certainly related. Even if we give focus by mouse to "NoteTest" and press down arrow key, it skips "WebKitStickyNotes" and moves to "LocalStorage". > Similarly while the focus is on "LocalStorage" we press up arrow key the focus doesn't move any where. > > To check this, keep abases -> Note Test -> WebKitStickyNotes expanded. Ok, I can see how is that related now. But I can't see how this fix makes this any better, it is still not working for me. Looks like onpopulate is called when the node is expanded and while traversing the tree. I think this code should me moved to onexpand, since repopulating the node on down key press is not obvious way for the user to refresh table names list and the only other visible result is this issue. > Secondly, I thought DatabaseQueryView taking focus is a feature as function "moveBackIfOutside" is called in "wasShown" function of "DatabaseQueryView" which takes the caret to prompt. This is probably a feature but not a good one. We should remove that. Also, please don't use resourcesLastSelectedItem setting like that, the default node should only be revealed on resources panel load, while table names populating can happen later in application lifecycle. 502809 6 115143 rosen.dash 2011-11-15 04:46:10 -0800 Created attachment 115143 Focus moves to Query Prompt on tab key press While navigating though the resource panel focus goes to Query Prompt which ceases keyboard navigation. After this patch we have to press tab key to move into query prompt while that view is being shown. This provides proper keyboard navigation of ResourcePanel. 502814 7 rosen.dash 2011-11-15 04:50:49 -0800 (In reply to comment #5) > > This is certainly related. Even if we give focus by mouse to "NoteTest" and press down arrow key, it skips "WebKitStickyNotes" and moves to "LocalStorage". > > Similarly while the focus is on "LocalStorage" we press up arrow key the focus doesn't move any where. > > > > To check this, keep abases -> Note Test -> WebKitStickyNotes expanded. > Ok, I can see how is that related now. But I can't see how this fix makes this any better, it is still not working for me. > > Looks like onpopulate is called when the node is expanded and while traversing the tree. I think this code should me moved to onexpand, since repopulating the node on down key press is not obvious way for the user to refresh table names list and the only other visible result is this issue. While traversing the tree the method traverseNextTreeElement has the option in third argument to choose whether we want to populate the list or not. I think the re-population is desired so that any update in children list will be reflected and ResourcePanel and view will be in sync. > > > Secondly, I thought DatabaseQueryView taking focus is a feature as function "moveBackIfOutside" is called in "wasShown" function of "DatabaseQueryView" which takes the caret to prompt. > This is probably a feature but not a good one. We should remove that. > > Also, please don't use resourcesLastSelectedItem setting like that, the default node should only be revealed on resources panel load, while table names populating can happen later in application lifecycle. 518904 8 115143 pfeldman 2011-12-11 09:45:46 -0800 Comment on attachment 115143 Focus moves to Query Prompt on tab key press Clearing r- as per Vsevolod's comments. Vsevolod, could you work with Rosen to get it resolved? 522030 9 119455 vsevik 2011-12-15 10:32:19 -0800 Created attachment 119455 Patch 522031 10 vsevik 2011-12-15 10:33:45 -0800 I uploaded a new version where tables list is updated only on expand. We should not update this list while traversing the tree, because it's unexpected to the user. 522176 11 vsevik 2011-12-15 13:07:32 -0800 Committed r102977: <http://trac.webkit.org/changeset/102977> 114681 2011-11-11 05:18:03 -0800 2011-11-15 04:46:10 -0800 Fixing the Navigation through DatabaseTableTreeElement by up/down arrow key press W_72013.patch text/plain 1270 rosen.dash ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2Vz UGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1Bh bmVsLmpzCmluZGV4IDMyNTBjNWUuLmI3NTkyNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTQ1NywxMyArMTQ1 NywxOCBAQCBXZWJJbnNwZWN0b3IuRGF0YWJhc2VUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAK ICAgICBvbnBvcHVsYXRlOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB0aGlzLnJlbW92ZUNo aWxkcmVuKCk7Ci0KICAgICAgICAgZnVuY3Rpb24gdGFibGVOYW1lc0NhbGxiYWNrKHRhYmxlTmFt ZXMpCiAgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBpdGVtVVJMID0gV2ViSW5zcGVjdG9yLnNl dHRpbmdzLnJlc291cmNlc0xhc3RTZWxlY3RlZEl0ZW0uZ2V0KCk7CisgICAgICAgICAgICB0aGlz LnJlbW92ZUNoaWxkcmVuKCk7CisKICAgICAgICAgICAgIHZhciB0YWJsZU5hbWVzTGVuZ3RoID0g dGFibGVOYW1lcy5sZW5ndGg7Ci0gICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRhYmxl TmFtZXNMZW5ndGg7ICsraSkKLSAgICAgICAgICAgICAgICB0aGlzLmFwcGVuZENoaWxkKG5ldyBX ZWJJbnNwZWN0b3IuRGF0YWJhc2VUYWJsZVRyZWVFbGVtZW50KHRoaXMuX3N0b3JhZ2VQYW5lbCwg dGhpcy5fZGF0YWJhc2UsIHRhYmxlTmFtZXNbaV0pKTsKKyAgICAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgdGFibGVOYW1lc0xlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIGVs ZW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLkRhdGFiYXNlVGFibGVUcmVlRWxlbWVudCh0aGlzLl9z dG9yYWdlUGFuZWwsIHRoaXMuX2RhdGFiYXNlLCB0YWJsZU5hbWVzW2ldKTsKKyAgICAgICAgICAg ICAgICB0aGlzLmFwcGVuZENoaWxkKGVsZW1lbnQpOworICAgICAgICAgICAgICAgIGlmIChpdGVt VVJMICYmIGl0ZW1VUkwgPT09IGVsZW1lbnQuaXRlbVVSTCkKKyAgICAgICAgICAgICAgICAgICAg ZWxlbWVudC5yZXZlYWxBbmRTZWxlY3QoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg ICAgICB0aGlzLl9kYXRhYmFzZS5nZXRUYWJsZU5hbWVzKHRhYmxlTmFtZXNDYWxsYmFjay5iaW5k KHRoaXMpKTsKICAgICB9Cg== 115143 2011-11-15 04:46:10 -0800 2011-12-15 10:32:04 -0800 Focus moves to Query Prompt on tab key press W_72013.patch text/plain 4786 rosen.dash ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjVmNzc4Li40NDJkMmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMTEtMTUgIFJvc2VuIERhc2ggIDxyb3Nlbi5kYXNoQG1vdG9yb2xhLmNvbT4KKwor ICAgICAgICBOb3QgYWJsZSB0byBuYXZpZ2F0ZSB0aGUgUmVzb3VyY2UgdGFiIG9wdGlvbnMgcHJv cGVybHkgd2l0aCBhcnJvdyBrZXlzIGFmdGVyIGFkZGluZyB0aGUgc3RpY2t5LW5vdGVzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIwMTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvRGF0YWJhc2VRdWVyeVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0 YWJhc2VRdWVyeVZpZXcucHJvdG90eXBlLmFmdGVyU2hvdyk6IENhcmV0IGlzIG1vdmVkIGluc2lk ZSBxdWVyeSBwcm9tcHQgYWZ0ZXIgdGFiCisgICAgICAgIGtleSBwcmVzc2VkIG9uIGNvcnJyZXNw b25kaW5nIFJlc291cmNlIFBhbmVsIEVsZW1lbnQuCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhYmFzZVRy ZWVFbGVtZW50LnByb3RvdHlwZS5vbnBvcHVsYXRlLnRhYmxlTmFtZXNDYWxsYmFjay5nZXQgdGhp cyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VUcmVlRWxlbWVudC5wcm90b3R5cGUu b25wb3B1bGF0ZSk6IFJlbW92aW5nIGFuZCBhZGRpbmcgY2hpbGRyZW4gd2hpbGUgcG9wdWxhdGlu ZworICAgICAgICBpcyBkb25lIGF0IHNhbWUgcGxhY2UgdG8gYXZvaWQgaW5jb25zaXN0ZW50IGJl aGF2aW91ci4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhYmFzZVRyZWVFbGVtZW50LnByb3Rv dHlwZS5vbnRhYik6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdHJlZW91 dGxpbmUuanM6CisgICAgICAgIChUcmVlT3V0bGluZS5wcm90b3R5cGUuX3RyZWVLZXlEb3duKTog VGFiIGtleSBwcmVzcyBpcyBoYW5kbGVkLgorCiAyMDExLTExLTE0ICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbcmVncmVzc2lv biByOTk5NjBdIG51bGwgY2FsbGJhY2sgYWNjZXNzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZVF1ZXJ5Vmlldy5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YWJhc2VRdWVyeVZpZXcuanMKaW5kZXggZmVmYjU4 OC4uMGFiYzFjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EYXRhYmFzZVF1ZXJ5Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0RhdGFiYXNlUXVlcnlWaWV3LmpzCkBAIC01NCw3ICs1NCwxMiBAQCBXZWJJbnNwZWN0 b3IuRGF0YWJhc2VRdWVyeVZpZXcuRXZlbnRzID0gewogfQogCiBXZWJJbnNwZWN0b3IuRGF0YWJh c2VRdWVyeVZpZXcucHJvdG90eXBlID0gewotICAgIHdhc1Nob3duOiBmdW5jdGlvbigpCisgICAg YWZ0ZXJTaG93OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0Q3Vy cmVudEZvY3VzRWxlbWVudCh0aGlzLl9wcm9tcHRFbGVtZW50KTsKKyAgICB9LAorCisgICAgYWZ0 ZXJUYWI6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGZ1bmN0aW9uIG1vdmVCYWNrSWZPdXRz aWRlKCkKICAgICAgICAgewpAQCAtNjUsMTEgKzcwLDYgQEAgV2ViSW5zcGVjdG9yLkRhdGFiYXNl UXVlcnlWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgc2V0VGltZW91dChtb3ZlQmFja0lmT3V0 c2lkZS5iaW5kKHRoaXMpLCAwKTsKICAgICB9LAogCi0gICAgYWZ0ZXJTaG93OiBmdW5jdGlvbigp Ci0gICAgewotICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0Q3VycmVudEZvY3VzRWxlbWVudCh0aGlz Ll9wcm9tcHRFbGVtZW50KTsKLSAgICB9LAotCiAgICAgY29tcGxldGlvbnM6IGZ1bmN0aW9uKHdv cmRSYW5nZSwgZm9yY2UsIGNvbXBsZXRpb25zUmVhZHlDYWxsYmFjaykKICAgICB7CiAgICAgICAg IHZhciBwcmVmaXggPSB3b3JkUmFuZ2UudG9TdHJpbmcoKS50b0xvd2VyQ2FzZSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMK aW5kZXggNDg5MGUzNy4uZjM4ODUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCkBAIC0xLDYgKzEsNyBAQAogLyoKICAq IENvcHlyaWdodCAoQykgMjAwNywgMjAwOCwgMjAxMCBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJl c2VydmVkLgogICogQ29weXJpZ2h0IChDKSAyMDA5IEpvc2VwaCBQZWNvcmFybworICogUG9ydGlv bnMgQ29weXJpZ2h0IChDKSAyMDExIE1vdG9yb2xhIE1vYmlsaXR5LCBJbmMuICBBbGwgcmlnaHRz IHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNDU3LDE1ICsx NDU4LDI5IEBAIFdlYkluc3BlY3Rvci5EYXRhYmFzZVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsK IAogICAgIG9ucG9wdWxhdGU6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMucmVtb3Zl Q2hpbGRyZW4oKTsKLQogICAgICAgICBmdW5jdGlvbiB0YWJsZU5hbWVzQ2FsbGJhY2sodGFibGVO YW1lcykKICAgICAgICAgeworICAgICAgICAgICAgdmFyIGl0ZW1VUkwgPSBXZWJJbnNwZWN0b3Iu c2V0dGluZ3MucmVzb3VyY2VzTGFzdFNlbGVjdGVkSXRlbS5nZXQoKTsKKyAgICAgICAgICAgIHRo aXMucmVtb3ZlQ2hpbGRyZW4oKTsKKwogICAgICAgICAgICAgdmFyIHRhYmxlTmFtZXNMZW5ndGgg PSB0YWJsZU5hbWVzLmxlbmd0aDsKLSAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGFi bGVOYW1lc0xlbmd0aDsgKytpKQotICAgICAgICAgICAgICAgIHRoaXMuYXBwZW5kQ2hpbGQobmV3 IFdlYkluc3BlY3Rvci5EYXRhYmFzZVRhYmxlVHJlZUVsZW1lbnQodGhpcy5fc3RvcmFnZVBhbmVs LCB0aGlzLl9kYXRhYmFzZSwgdGFibGVOYW1lc1tpXSkpOworICAgICAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCB0YWJsZU5hbWVzTGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAgICAgICB2YXIg ZWxlbWVudCA9IG5ldyBXZWJJbnNwZWN0b3IuRGF0YWJhc2VUYWJsZVRyZWVFbGVtZW50KHRoaXMu X3N0b3JhZ2VQYW5lbCwgdGhpcy5fZGF0YWJhc2UsIHRhYmxlTmFtZXNbaV0pOworICAgICAgICAg ICAgICAgIHRoaXMuYXBwZW5kQ2hpbGQoZWxlbWVudCk7CisgICAgICAgICAgICAgICAgaWYgKGl0 ZW1VUkwgJiYgaXRlbVVSTCA9PT0gZWxlbWVudC5pdGVtVVJMKQorICAgICAgICAgICAgICAgICAg ICBlbGVtZW50LnJldmVhbEFuZFNlbGVjdCgpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAg ICAgICAgIHRoaXMuX2RhdGFiYXNlLmdldFRhYmxlTmFtZXModGFibGVOYW1lc0NhbGxiYWNrLmJp bmQodGhpcykpOworICAgIH0sCisKKyAgICBvbnRhYjogZnVuY3Rpb24oKQorICAgIHsKKyAgICAg ICBpZiAodGhpcy5fZGF0YWJhc2UgJiYgdGhpcy5fZGF0YWJhc2UuX3F1ZXJ5VmlldykgeworICAg ICAgICAgICAgdmlldyA9IHRoaXMuX2RhdGFiYXNlLl9xdWVyeVZpZXc7CisgICAgICAgICAgICBp ZiAodmlldy5hZnRlclRhYikKKyAgICAgICAgICAgICAgICB2aWV3LmFmdGVyVGFiKCk7CisgICAg ICAgfQogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC90cmVlb3V0bGluZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvdHJlZW91dGxpbmUuanMKaW5kZXggMTAwMzk4Yi4uYjQwYjI0ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0bGluZS5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RyZWVvdXRsaW5lLmpzCkBAIC00MDQsNiAr NDA0LDkgQEAgVHJlZU91dGxpbmUucHJvdG90eXBlLl90cmVlS2V5RG93biA9IGZ1bmN0aW9uKGV2 ZW50KQogICAgIH0gZWxzZSBpZiAoaXNFbnRlcktleShldmVudCkpIHsKICAgICAgICAgaWYgKHRo aXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5vbmVudGVyKQogICAgICAgICAgICAgaGFuZGxlZCA9IHRo aXMuc2VsZWN0ZWRUcmVlRWxlbWVudC5vbmVudGVyKCk7CisgICAgfSBlbHNlIGlmIChldmVudC5r ZXlDb2RlID09PSA5IC8qIFRhYiAqLykgeworICAgICAgICBpZiAodGhpcy5zZWxlY3RlZFRyZWVF bGVtZW50Lm9udGFiKQorICAgICAgICAgICAgaGFuZGxlZCA9IHRoaXMuc2VsZWN0ZWRUcmVlRWxl bWVudC5vbnRhYigpOwogICAgIH0KIAogICAgIGlmIChuZXh0U2VsZWN0ZWRFbGVtZW50KSB7Cg== 119455 2011-12-15 10:32:19 -0800 2011-12-15 10:36:06 -0800 Patch bug-72013-20111215223216.patch text/plain 3700 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGEzZDBiN2IwNWM1Mjcx ZmZhOTQxMmMxZGI3ODQzMDUwODg1NTExNC4uODlmZDkyOTZiNmRiNTg2ZmE3MzAwOTQ3ODc2NTE0 M2EzZjgxMzY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTE1ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5vdCBhYmxlIHRv IG5hdmlnYXRlIHRoZSBSZXNvdXJjZSB0YWIgb3B0aW9ucyBwcm9wZXJseSB3aXRoIGFycm93IGtl eXMgYWZ0ZXIgYWRkaW5nIHRoZSBzdGlja3ktbm90ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjAxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZVF1 ZXJ5Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhYmFzZVF1ZXJ5Vmlldyk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VRdWVyeVZpZXcucHJvdG90eXBlLl9tZXNzYWdl c0NsaWNrZWQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VUcmVlRWxlbWVudC5wcm90b3R5cGUu b25leHBhbmQpOgorCiAyMDExLTEyLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogI2hleCBjb2xvcnMgYXJlIG5vdCBo aWdobGlnaHRlZCBpbiBDU1MgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRGF0YWJhc2VRdWVyeVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0RhdGFiYXNlUXVlcnlWaWV3LmpzCmluZGV4IGZlZmI1ODhjNjk1NDQ2 YjM4Yzk3NzBhNTU5YmY5Nzk0NzE3YjlkODMuLmJlMjMzYTE3MzliNTIzMDJmY2FlYjUzMDZmOTU2 MWM0OWRhMmNhNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRGF0YWJhc2VRdWVyeVZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EYXRhYmFzZVF1ZXJ5Vmlldy5qcwpAQCAtMzYsNyArMzYsNiBAQCBXZWJJbnNwZWN0 b3IuRGF0YWJhc2VRdWVyeVZpZXcgPSBmdW5jdGlvbihkYXRhYmFzZSkKICAgICB0aGlzLmVsZW1l bnQuYWRkU3R5bGVDbGFzcygic3RvcmFnZS12aWV3Iik7CiAgICAgdGhpcy5lbGVtZW50LmFkZFN0 eWxlQ2xhc3MoInF1ZXJ5Iik7CiAgICAgdGhpcy5lbGVtZW50LmFkZFN0eWxlQ2xhc3MoIm1vbm9z cGFjZSIpOwotICAgIHRoaXMuZWxlbWVudC50YWJJbmRleCA9IDA7CiAgICAgdGhpcy5lbGVtZW50 LmFkZEV2ZW50TGlzdGVuZXIoInNlbGVjdHN0YXJ0IiwgdGhpcy5fc2VsZWN0U3RhcnQuYmluZCh0 aGlzKSwgZmFsc2UpOwogCiAgICAgdGhpcy5fcHJvbXB0RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoImRpdiIpOwpAQCAtNDcsNiArNDYsOCBAQCBXZWJJbnNwZWN0b3IuRGF0YWJhc2VR dWVyeVZpZXcgPSBmdW5jdGlvbihkYXRhYmFzZSkKIAogICAgIHRoaXMucHJvbXB0ID0gbmV3IFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0V2l0aEhpc3RvcnkodGhpcy5jb21wbGV0aW9ucy5iaW5kKHRo aXMpLCAiICIpOwogICAgIHRoaXMucHJvbXB0LmF0dGFjaCh0aGlzLl9wcm9tcHRFbGVtZW50KTsK KyAgICAKKyAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9t ZXNzYWdlc0NsaWNrZWQuYmluZCh0aGlzKSwgdHJ1ZSk7CiB9CiAKIFdlYkluc3BlY3Rvci5EYXRh YmFzZVF1ZXJ5Vmlldy5FdmVudHMgPSB7CkBAIC01NCwyMiArNTUsMTIgQEAgV2ViSW5zcGVjdG9y LkRhdGFiYXNlUXVlcnlWaWV3LkV2ZW50cyA9IHsKIH0KIAogV2ViSW5zcGVjdG9yLkRhdGFiYXNl UXVlcnlWaWV3LnByb3RvdHlwZSA9IHsKLSAgICB3YXNTaG93bjogZnVuY3Rpb24oKQorICAgIF9t ZXNzYWdlc0NsaWNrZWQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIGZ1bmN0aW9uIG1vdmVC YWNrSWZPdXRzaWRlKCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKCF0aGlzLnByb21wdC5p c0NhcmV0SW5zaWRlUHJvbXB0KCkgJiYgd2luZG93LmdldFNlbGVjdGlvbigpLmlzQ29sbGFwc2Vk KQotICAgICAgICAgICAgICAgIHRoaXMucHJvbXB0Lm1vdmVDYXJldFRvRW5kT2ZQcm9tcHQoKTsK LSAgICAgICAgfQotCi0gICAgICAgIHNldFRpbWVvdXQobW92ZUJhY2tJZk91dHNpZGUuYmluZCh0 aGlzKSwgMCk7CisgICAgICAgIGlmICghdGhpcy5wcm9tcHQuaXNDYXJldEluc2lkZVByb21wdCgp ICYmIHdpbmRvdy5nZXRTZWxlY3Rpb24oKS5pc0NvbGxhcHNlZCkKKyAgICAgICAgICAgIHRoaXMu cHJvbXB0Lm1vdmVDYXJldFRvRW5kT2ZQcm9tcHQoKTsKICAgICB9LAotCi0gICAgYWZ0ZXJTaG93 OiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0Q3VycmVudEZvY3Vz RWxlbWVudCh0aGlzLl9wcm9tcHRFbGVtZW50KTsKLSAgICB9LAotCisgICAgCiAgICAgY29tcGxl dGlvbnM6IGZ1bmN0aW9uKHdvcmRSYW5nZSwgZm9yY2UsIGNvbXBsZXRpb25zUmVhZHlDYWxsYmFj aykKICAgICB7CiAgICAgICAgIHZhciBwcmVmaXggPSB3b3JkUmFuZ2UudG9TdHJpbmcoKS50b0xv d2VyQ2FzZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VzUGFuZWwuanMKaW5kZXggN2MyYjNiYWQ1ZDc5YzY0ZjBhODI4ZGQ2NDZjMzZjZTFj M2ZlY2M1OC4uZmRmYjdiMzFhYmRhZTQ2YTI3YmVhMWM3NmQzZWQyYzExNGNkMjRiMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVs LmpzCkBAIC0xNDM2LDE0ICsxNDM2LDEyIEBAIFdlYkluc3BlY3Rvci5EYXRhYmFzZVRyZWVFbGVt ZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fc3RvcmFnZVBhbmVsLnNob3dEYXRhYmFz ZSh0aGlzLl9kYXRhYmFzZSk7CiAgICAgfSwKIAotICAgIG9uY29sbGFwc2U6IGZ1bmN0aW9uKCkK KyAgICBvbmV4cGFuZDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgLy8gUmVxdWVzdCBhIHJl ZnJlc2ggYWZ0ZXIgZXZlcnkgY29sbGFwc2Ugc28gdGhlIG5leHQKLSAgICAgICAgLy8gZXhwYW5k IHdpbGwgaGF2ZSBhbiB1cGRhdGVkIHRhYmxlIGxpc3QuCi0gICAgICAgIHRoaXMuc2hvdWxkUmVm cmVzaENoaWxkcmVuID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5fdXBkYXRlQ2hpbGRyZW4oKTsKICAg ICB9LAogCi0gICAgb25wb3B1bGF0ZTogZnVuY3Rpb24oKQorICAgIF91cGRhdGVDaGlsZHJlbjog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5yZW1vdmVDaGlsZHJlbigpOwogCg==