71990 2011-11-09 19:23:13 -0800 [GTK] [WebKit2] Fix remaining gtkdoc errors 2011-11-10 08:47:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cgarcia pnormand webkit.review.bot xan.lopez oldest_to_newest 499595 0 mrobinson 2011-11-09 19:23:13 -0800 This bug tracks fixing a few remaining gtkdoc errors in the WebKit2 API. 499599 1 114421 mrobinson 2011-11-09 19:27:47 -0800 Created attachment 114421 Patch 499600 2 webkit.review.bot 2011-11-09 19:31:03 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 499698 3 114421 cgarcia 2011-11-10 00:14:00 -0800 Comment on attachment 114421 Patch LGTM 499953 4 114421 webkit.review.bot 2011-11-10 08:47:43 -0800 Comment on attachment 114421 Patch Clearing flags on attachment: 114421 Committed r99863: <http://trac.webkit.org/changeset/99863> 499954 5 webkit.review.bot 2011-11-10 08:47:48 -0800 All reviewed patches have been landed. Closing bug. 114421 2011-11-09 19:27:47 -0800 2011-11-10 08:47:43 -0800 Patch bug-71990-20111109192745.patch text/plain 3673 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogOTk4MDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAzOGQ4MWMzODgxOTdmYTcw MDM2YTgwNGRkMzQ0OGY5NDdkNmVmMDM0Li40M2M1NjFmMzBmNWM3YmIwY2Y0NzNlOGI4Y2YzNThi MDgyMjVjOTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTEtMDkgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtXZWJL aXQyXSBGaXggcmVtYWluaW5nIGd0a2RvYyBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxOTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 LmNwcDogVXBkYXRlIGFkZCB0aGUgcGhyYXNlICJwcm9wZXJ0eSIgdG8KKyAgICAgICAgcmVmZXJl bmNlcyB0byBwcm9wZXJ0aWVzLCBiZWNhdXNlIHRoZSBndGtkb2Mgc3R5bGVzaGVldCBkb2VzIG5v dCBkaWZmZXJlbmlhdGUKKyAgICAgICAgYmV0d2VlbiBwcm9wZXJ0aWVzIGFuZCBzaWduYWxzLiBT dGFuZGFyZGl6ZSB0aGUgd2F5IHdlIHRhbGsgYWJvdXQgcHJvcGVydHkKKyAgICAgICAgbm90aWZp Y2F0aW9ucy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstZG9j cy5zZ21sOiBBZGQgYW4gaW5jbHVkZSB0byBzaWxlbmNlIAorICAgICAgICB3YXJuaW5ncyBhYm91 dCBHSVIgYW5ub3RhdGlvbnMuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJr aXQyZ3RrLXNlY3Rpb25zLnR4dDogQWRkIHRoZSBkZWNvcmF0b3JzIHRoZSBwcml2YXRlIHNlY3Rp b24uCisKIDIwMTEtMTAtMjYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIFtXZWJLaXRdIFJlcGxhY2UgdGhlIGd0a2RvYyBhdXRvb2xzIG1h Z2ljIHdpdGggc29tZXRoaW5nIG1vcmUgZmxleGlibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggMTVhOWFjZDI4NjllZjg5 YTg3YTA0MjVkMTQ4NzZjMjFmZGEyMGRlYS4uYzIzMzExZWE5YWI1N2E0NTg5ZWVjZTU0YjJlYzRh ZjdjZjY0MmEzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlldy5jcHAKQEAgLTQxOSw4ICs0MTksOCBAQCB2b2lkIHdlYmtpdF93ZWJfdmll d19sb2FkX2FsdGVybmF0ZV9odG1sKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGNvbnN0IGdjaGFy KiBjbwogICogd2Via2l0X3dlYl92aWV3X2dldF90aXRsZToKICAqIEB3ZWJfdmlldzogYSAjV2Vi S2l0V2ViVmlldwogICogCi0gKiBHZXRzIHRoZSB2YWx1ZSBvZiAjV2ViS2l0V2ViVmlldzp0aXRs ZS4KLSAqIFlvdSBjYW4gY29ubmVjdCB0byAjV2ViS2l0V2ViVmlldzo6bm90aWZ5IHNpZ25hbCBv ZiBAd2ViX3ZpZXcgdG8gCisgKiBHZXRzIHRoZSB2YWx1ZSBvZiB0aGUgI1dlYktpdFdlYlZpZXc6 dGl0bGUgcHJvcGVydHkuCisgKiBZb3UgY2FuIGNvbm5lY3QgdG8gbm90aWZ5Ojp0aXRsZSBzaWdu YWwgb2YgQHdlYl92aWV3IHRvIAogICogYmUgbm90aWZpZWQgd2hlbiB0aGUgdGl0bGUgaGFzIGJl ZW4gcmVjZWl2ZWQuCiAgKgogICogUmV0dXJuczogVGhlIG1haW4gZnJhbWUgZG9jdW1lbnQgdGl0 bGUgb2YgQHdlYl92aWV3LgpAQCAtNjUwLDkgKzY1MCw5IEBAIHZvaWQgd2Via2l0X3dlYl92aWV3 X3NldF9jdXN0b21fY2hhcnNldChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBjb25zdCBnY2hhciog Y2hhCiAgKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzOgogICog QHdlYl92aWV3OiBhICNXZWJLaXRXZWJWaWV3CiAgKgotICogR2V0cyB0aGUgdmFsdWUgb2YgI1dl YktpdFdlYlZpZXc6ZXN0aW1hdGVkLWxvYWQtcHJvZ3Jlc3MuCisgKiBHZXRzIHRoZSB2YWx1ZSBv ZiB0aGUgI1dlYktpdFdlYlZpZXc6ZXN0aW1hdGVkLWxvYWQtcHJvZ3Jlc3MgcHJvcGVydHkuCiAg KiBZb3UgY2FuIG1vbml0b3IgdGhlIGVzdGltYXRlZCBwcm9ncmVzcyBvZiBhIGxvYWQgb3BlcmF0 aW9uIGJ5Ci0gKiBjb25uZWN0aW5nIHRvIHRoZSA6Om5vdGlmeSBzaWduYWwgb2YgQHdlYl92aWV3 LgorICogY29ubmVjdGluZyB0byB0aGUgbm90aWZ5Ojplc3RpbWF0ZWQtbG9hZC1wcm9ncmVzcyBz aWduYWwgb2YgQHdlYl92aWV3LgogICoKICAqIFJldHVybnM6IGFuIGVzdGltYXRlIG9mIHRoZSBv ZiB0aGUgcGVyY2VudCBjb21wbGV0ZSBmb3IgYSBkb2N1bWVudAogICogICAgIGxvYWQgYXMgYSBy YW5nZSBmcm9tIDAuMCB0byAxLjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstZG9jcy5zZ21sIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLWRvY3Muc2dtbAppbmRleCAzODgxZTcxODYy YmE4ZGZhOTA2Njc3YTY0NzE3N2I1ZDRjOWM2Y2IzLi4wNWI0ZGFlYWRhY2M1ZjIyNDJmOGUzMTY1 YTA4Yzg5NGZlOGUwZjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9kb2NzL3dlYmtpdDJndGstZG9jcy5zZ21sCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1kb2NzLnNnbWwKQEAgLTI0LDQgKzI0LDUgQEAK ICAgPGluZGV4IGlkPSJpbmRleC1hbGwiPgogICAgIDx0aXRsZT5JbmRleDwvdGl0bGU+CiAgIDwv aW5kZXg+CisgIDx4aTppbmNsdWRlIGhyZWY9InhtbC9hbm5vdGF0aW9uLWdsb3NzYXJ5LnhtbCI+ PHhpOmZhbGxiYWNrIC8+PC94aTppbmNsdWRlPgogPC9ib29rPgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9u cy50eHQKaW5kZXggYWIxNWY5MjllOGU2MWVhZmEwNzA3MTA0ODQ5M2VlMmVkM2UxMGQwOC4uYTNj NzJhZmY0Nzk2ZjViY2FmZjgzNzhlOWQ0NzI1MmIxOTE0ZjQ2MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25zLnR4dAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2Vj dGlvbnMudHh0CkBAIC0xNSw2ICsxNSw4IEBAIFdFQktJVF9XRUJfVklFV19CQVNFX0dFVF9DTEFT UwogPFNVQlNFQ1RJT04gUHJpdmF0ZT4KIHdlYmtpdF93ZWJfdmlld19iYXNlX2dldF90eXBlCiBX ZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUKK1dFQktJVF9BUEkKK1dFQktJVF9PQlNPTEVURV9BUEkK IDwvU0VDVElPTj4KIAogPFNFQ1RJT04+Cg==