71980 2011-11-09 17:48:50 -0800 Remove unneeded frame check in FrameView::detachCustomScrollbars 2011-11-11 14:01:46 -0800 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix andersca webkit.review.bot oldest_to_newest 499537 0 jchaffraix 2011-11-09 17:48:50 -0800 Looks like this is a left-over from several refactorings that changed the function. The remainder of detachCustomScrollbars definitely does not care about having a Frame. Patch forthcoming. 499542 1 114412 jchaffraix 2011-11-09 17:52:19 -0800 Created attachment 114412 Trivial change: remove the check. 500109 2 114412 andersca 2011-11-10 12:15:40 -0800 Comment on attachment 114412 Trivial change: remove the check. Can you remove this because m_frame is never going to be null, or because m_frame is never dereferenced? If it is because m_frame is never going to be null, you can assert that. 500416 3 jchaffraix 2011-11-10 16:54:32 -0800 (In reply to comment #2) > (From update of attachment 114412 [details]) > Can you remove this because m_frame is never going to be null, or because m_frame is never dereferenced? If it is because m_frame is never going to be null, you can assert that. The latter I am afraid: AFAICT this check was introduced because we would crash if we did not check the Frame but the code has changed and this check is not needed anymore. 501073 4 114412 webkit.review.bot 2011-11-11 14:01:42 -0800 Comment on attachment 114412 Trivial change: remove the check. Clearing flags on attachment: 114412 Committed r100014: <http://trac.webkit.org/changeset/100014> 501074 5 webkit.review.bot 2011-11-11 14:01:46 -0800 All reviewed patches have been landed. Closing bug. 114412 2011-11-09 17:52:19 -0800 2011-11-11 14:01:42 -0800 Trivial change: remove the check. bug-71980-20111109175218.patch text/plain 1381 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogOTk3MjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjZDJhZmU0Nzc3Zjc0OWUx OTkzMjE0NTJiNjVkODBmMmE3ZmY5NTdjLi45ZDQ3ZGY3MDFiZjcxMmRjYzFkZTdlZDcyYWU1NWEy OWViMGU5OTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDkgIEp1bGll biBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVu bmVlZGVkIGZyYW1lIGNoZWNrIGluIEZyYW1lVmlldzo6ZGV0YWNoQ3VzdG9tU2Nyb2xsYmFycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE5ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgY292 ZXJlZCBieSB0aGUgZXhpc3RpbmcgdGVzdHMgaW4gc2Nyb2xsYmFycy8uCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmRldGFjaEN1 c3RvbVNjcm9sbGJhcnMpOgorICAgICAgICBSZW1vdmUgdGhlIGxlZnRvdmVyIGNoZWNrIHRoYXQg d2FzIGZvcmdvdHRlbiBieSB0aGUgZGlmZmVyZW50IHJlZmFjdG9yaW5nLgorCiAyMDExLTExLTA5 ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBTdHlsZVNoZWV0 OiBEZXZpcnR1YWxpemUgc3R5bGVTaGVldENoYW5nZWQoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAppbmRleCAzNTc3MGQwMTFiZjY3YTdlN2JmODQwNjVjNTQ4ZDRiMzg4ZGQ1ZjYxLi5jOGQ2 ZjU5N2Y0ZjJhMmYwODJjNGJmYzc4MTUwZDYwNTNjMGMwMWQwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCkBAIC0zMDUsOSArMzA1LDYgQEAgdm9pZCBGcmFtZVZpZXc6OmluaXQoKQogCiB2 b2lkIEZyYW1lVmlldzo6ZGV0YWNoQ3VzdG9tU2Nyb2xsYmFycygpCiB7Ci0gICAgaWYgKCFtX2Zy YW1lKQotICAgICAgICByZXR1cm47Ci0KICAgICBTY3JvbGxiYXIqIGhvcml6b250YWxCYXIgPSBo b3Jpem9udGFsU2Nyb2xsYmFyKCk7CiAgICAgaWYgKGhvcml6b250YWxCYXIgJiYgaG9yaXpvbnRh bEJhci0+aXNDdXN0b21TY3JvbGxiYXIoKSkKICAgICAgICAgc2V0SGFzSG9yaXpvbnRhbFNjcm9s bGJhcihmYWxzZSk7Cg==