71969 2011-11-09 16:40:29 -0800 De-virtualize JSGlobalObject::allowsAccessFrom 2011-11-11 11:35:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 499470 0 mhahnenberg 2011-11-09 16:40:29 -0800 There's only one call site of this function in WebScriptObject which we can safely cast to JSDOMWindowBase and call that version of the function, eliminating the need for this function to be virtual (or present in JSGlobalObject at all). 499503 1 114399 mhahnenberg 2011-11-09 17:08:52 -0800 Created attachment 114399 Patch 500970 2 mhahnenberg 2011-11-11 11:35:40 -0800 Committed r99993: <http://trac.webkit.org/changeset/99993> 114399 2011-11-09 17:08:52 -0800 2011-11-10 14:56:38 -0800 Patch bug-71969-20111109170851.patch text/plain 4008 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogOTk3ODAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJk ZGMxMDZiNzdiYmNjOTY0MDE0ZGY1OTE2NjBlMzU0ZjA1OTczOWYuLjMyNTkwMmQ4NWMxMDMyM2Iw MWM3MGYzODFmOWJlYTg0YjhhM2FjYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDE1IEBACiAyMDExLTExLTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBs ZS5jb20+CiAKKyAgICAgICAgRGUtdmlydHVhbGl6ZSBKU0dsb2JhbE9iamVjdDo6YWxsb3dzQWNj ZXNzRnJvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzE5NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuaDogUmVtb3ZlZCBhbGxvd3NBY2Nlc3NGcm9tIGZyb20g SlNHbG9iYWxPYmplY3Qgc2luY2UgaXQgaXMgZXhjbHVzaXZlIHRvIAorICAgICAgICBKU0RPTVdp bmRvd0Jhc2UgYW5kIFdlYlNjcmlwdE9iamVjdC4KKworMjAxMS0xMS0wOSAgTWFyayBIYWhuZW5i ZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeGluZyBidWlsZCBicmVh a2FnZQogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE0NzY2 YmYxNDQyMDViODE3ZTBkNGZmZmUxYTQ3MTY0YWRlNjM5ZS4uZmU3NTMxNTAzOTU2MzI0NTRlY2Jm ZGZkNDAwYjc5NWFiMzNhNzYxMCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEx LTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAg RGUtdmlydHVhbGl6ZSBKU0dsb2JhbE9iamVjdDo6YWxsb3dzQWNjZXNzRnJvbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE5NjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAg ICAgICAgU2luY2UgYWxsb3dzQWNjZXNzRnJvbSBpcyBvbmx5IHVzZWQgYnkgV2ViU2NyaXB0T2Jq ZWN0LCB3ZSBrbm93IHRoYXQgd2UnbGwgYWx3YXlzIGhhdmUgYSAKKyAgICAgICAgSlNET01XaW5k b3dCYXNlLCBzbyB3ZSBjYW4gc2ltcGx5IGhhdmUgYWxsb3dzQWNjZXNzRnJvbSB0byBsaXZlIGlu IEpTRE9NV2luZG93QmFzZSByYXRoZXIgCisgICAgICAgIHRoYW4gSlNHbG9iYWxPYmplY3QuCisK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuaDogRGUtdmlydHVhbGl6ZWQg YWxsb3dzQWNjZXNzRnJvbS4KKyAgICAgICAgKiBiaW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVj dC5tbToKKyAgICAgICAgKC1bV2ViU2NyaXB0T2JqZWN0IF9pc1NhZmVTY3JpcHRdKTogIEFkZGVk IGEgY2FzdCBmcm9tIGEgSlNHbG9iYWxPYmplY3QgdG8gYSBKU0RPTVdpbmRvd0Jhc2UgaW4gCisg ICAgICAgIG9yZGVyIHRvIGNhbGwgdGhlIGFsbG93c0FjY2Vzc0Zyb20gbWV0aG9kLgorCiAyMDEx LTExLTA5ICBEb21pbmljIENvb25leSAgPGRvbWluaWNjQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZW1vdmUgV2ViR0xDb250ZXh0RXZlbnQuaW5pdEV2ZW50IG1ldGhvZApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmgKaW5kZXggYjhjYmQxNmE3YTQz OWM5MjA1YzIyYjcyOWJmMjZjMTRjYzY0Mjc3Ny4uMWM0Y2U4Y2I0N2VjOGVmMTEzMDBmZDM4MTRh ZDEyN2U5ZTc4MjJlYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNHbG9iYWxPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ds b2JhbE9iamVjdC5oCkBAIC0yNzEsOCArMjcxLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAg ICAgdmlydHVhbCBib29sIHNob3VsZEludGVycnVwdFNjcmlwdCgpIGNvbnN0IHsgcmV0dXJuIHRy dWU7IH0KIAotICAgICAgICB2aXJ0dWFsIGJvb2wgYWxsb3dzQWNjZXNzRnJvbShjb25zdCBKU0ds b2JhbE9iamVjdCopIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KLQogICAgICAgICBib29sIGlzRHlu YW1pY1Njb3BlKGJvb2wmIHJlcXVpcmVzRHluYW1pY0NoZWNrcykgY29uc3Q7CiAKICAgICAgICAg dm9pZCBzZXRFdmFsRW5hYmxlZChib29sIGVuYWJsZWQpIHsgbV9ldmFsRW5hYmxlZCA9IGVuYWJs ZWQ7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 QmFzZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmgKaW5k ZXggNDk5NDdjNjE1ZTUwMGY5NjRhMmUzOWYzZTUzZGE0N2EwMjQxZWVkMi4uZWZlZjc5MzgwYTU3 ZDJkZjMzMGEyYWZhZjA0ZWZhM2Y1YTFiMGYxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNET01XaW5kb3dCYXNlLmgKQEAgLTY2LDcgKzY2LDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB2b2lkIHByaW50RXJyb3JNZXNzYWdlKGNvbnN0IFN0cmluZyYpIGNvbnN0 OwogCiAgICAgICAgIC8vIERvbid0IGNhbGwgdGhpcyB2ZXJzaW9uIG9mIGFsbG93c0FjY2Vzc0Zy b20gLS0gaXQncyBhIHNsaWdodGx5IGluY29ycmVjdCBpbXBsZW1lbnRhdGlvbiB1c2VkIG9ubHkg YnkgV2ViU2NyaXB0T2JqZWN0Ci0gICAgICAgIHZpcnR1YWwgYm9vbCBhbGxvd3NBY2Nlc3NGcm9t KGNvbnN0IEpTQzo6SlNHbG9iYWxPYmplY3QqKSBjb25zdDsKKyAgICAgICAgYm9vbCBhbGxvd3NB Y2Nlc3NGcm9tKGNvbnN0IEpTQzo6SlNHbG9iYWxPYmplY3QqKSBjb25zdDsKICAgICAgICAgCiAg ICAgICAgIHN0YXRpYyBKU0M6OkpTT2JqZWN0KiB0b1RoaXNPYmplY3QoSlNDOjpKU0NlbGwqLCBK U0M6OkV4ZWNTdGF0ZSopOwogICAgICAgICBKU0RPTVdpbmRvd1NoZWxsKiBzaGVsbCgpIGNvbnN0 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9XZWJTY3JpcHRPYmpl Y3QubW0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVjdC5tbQpp bmRleCAzOGQyNDZjMjJiYzk3YTI3Y2M2OTk3MTBhZDhkMzZjMjA5MDUyMzRmLi43YTQxMzE1YWI4 YWI0ZDU4YzIyMmFlMDljZWFjNWNiYzAxN2ZlZTc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVjdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVjdC5tbQpAQCAtMjIxLDcgKzIyMSw3IEBAIHN0YXRp YyB2b2lkIF9kaWRFeGVjdXRlKFdlYlNjcmlwdE9iamVjdCAqb2JqKQogICAgIGlmICghX3ByaXZh dGUtPm9yaWdpblJvb3RPYmplY3QtPmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog Ci0gICAgcmV0dXJuIHJvb3QtPmdsb2JhbE9iamVjdCgpLT5hbGxvd3NBY2Nlc3NGcm9tKF9wcml2 YXRlLT5vcmlnaW5Sb290T2JqZWN0LT5nbG9iYWxPYmplY3QoKSk7CisgICAgcmV0dXJuIHN0YXRp Y19jYXN0PEpTRE9NV2luZG93QmFzZSo+KHJvb3QtPmdsb2JhbE9iamVjdCgpKS0+YWxsb3dzQWNj ZXNzRnJvbShfcHJpdmF0ZS0+b3JpZ2luUm9vdE9iamVjdC0+Z2xvYmFsT2JqZWN0KCkpOwogfQog CiAtICh2b2lkKWRlYWxsb2MK