71964 2011-11-09 16:10:52 -0800 WebProcess doesn't use AuthBrokerAgent for proxy credentials 2011-11-09 18:49:00 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap beidson webkit.review.bot oldest_to_newest 499442 0 ap 2011-11-09 16:10:52 -0800 In Lion, CFNetwork has an agent that provides access to proxy credentials. WebKit doesn't need to participate in retrieving or storing proxy credentials. The symptom of not using AuthBrokerAgent is that a number of confusing dialogs and sheets appear once you configure a proxy. There can be an AuthBrokerAgent dialog for system services like MobileMe or for Safari itself (as it downloads safe browsing database), Safari sheets for requests coming from WebKit, and Keychain dialogs asking whether Safari can access keychain items created by System Preferences or by AuthBrokerAgent. <rdar://problem/10423024> 499451 1 114389 ap 2011-11-09 16:18:53 -0800 Created attachment 114389 proposed patch 499583 2 114389 webkit.review.bot 2011-11-09 18:48:56 -0800 Comment on attachment 114389 proposed patch Clearing flags on attachment: 114389 Committed r99800: <http://trac.webkit.org/changeset/99800> 499584 3 webkit.review.bot 2011-11-09 18:49:00 -0800 All reviewed patches have been landed. Closing bug. 114389 2011-11-09 16:18:53 -0800 2011-11-09 18:48:56 -0800 proposed patch MachLookup.txt text/plain 5420 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5Nzc5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMDkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEw NDIzMDI0PiBXZWJQcm9jZXNzIGRvZXNuJ3QgdXNlIEF1dGhCcm9rZXJBZ2VudCBmb3IgcHJveHkg Y3JlZGVudGlhbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxOTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwOiAoV2ViQ29y ZTo6UmVzb3VyY2VIYW5kbGU6OmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSk6Cisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW06IChXZWJD b3JlOjpSZXNvdXJjZUhhbmRsZTo6ZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKToK KyAgICAgICAgRG9uJ3QgYXNrIHRoZSBjbGllbnQgZm9yIHByb3h5IGNyZWRlbnRpYWxzLiBDRk5l dHdvcmsgcmVzdWx0cyBhcmUgYXV0aG9yaXRhdGl2ZSwgYW5kIHByb3h5CisgICAgICAgIGNyZWRl bnRpYWxzIGFyZSBzeXN0ZW0td2lkZS4KKwogMjAxMS0xMS0wOSAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEVsZW1lbnQ6OmJvdW5kc0luV2luZG93U3Bh Y2Ugc2hvdWxkIGJlIEVsZW1lbnQ6OmJvdW5kc0luUm9vdFZpZXdTcGFjZQpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFu ZGxlQ0ZOZXQuY3BwCShyZXZpc2lvbiA5OTc1OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3 Nyw2ICs1NzcsMTYgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6ZGlkUmVjZWl2ZUF1dGhlbnRpYwog ICAgIEFTU0VSVChjaGFsbGVuZ2UuY2ZVUkxBdXRoQ2hhbGxlbmdlUmVmKCkpOwogICAgIEFTU0VS VChjaGFsbGVuZ2UuYXV0aGVudGljYXRpb25DbGllbnQoKSA9PSB0aGlzKTsgLy8gU2hvdWxkIGJl IGFscmVhZHkgc2V0LgogCisjaWYgIVBMQVRGT1JNKFdJTikKKyAgICAvLyBQcm94eSBhdXRoZW50 aWNhdGlvbiBpcyBoYW5kbGVkIGJ5IENGTmV0d29yayBpbnRlcm5hbGx5LiBXZSBjYW4gZ2V0IGhl cmUgaWYgdGhlIHVzZXIgY2FuY2VscworICAgIC8vIENGTmV0d29yayBhdXRoZW50aWNhdGlvbiBk aWFsb2csIGFuZCB3ZSBzaG91bGRuJ3QgYXNrIHRoZSBjbGllbnQgdG8gZGlzcGxheSBhbm90aGVy IG9uZSBpbiB0aGF0IGNhc2UuCisgICAgaWYgKGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKS5p c1Byb3h5KCkpIHsKKyAgICAgICAgLy8gQ2Fubm90IHVzZSByZWNlaXZlZFJlcXVlc3RUb0NvbnRp bnVlV2l0aG91dENyZWRlbnRpYWwoKSwgYmVjYXVzZSBjdXJyZW50IGNoYWxsZW5nZSBpcyBub3Qg eWV0IHNldC4KKyAgICAgICAgQ0ZVUkxDb25uZWN0aW9uVXNlQ3JlZGVudGlhbChkLT5tX2Nvbm5l Y3Rpb24uZ2V0KCksIDAsIGNoYWxsZW5nZS5jZlVSTEF1dGhDaGFsbGVuZ2VSZWYoKSk7CisgICAg ICAgIHJldHVybjsKKyAgICB9CisjZW5kaWYKKwogICAgIGlmICghZC0+bV91c2VyLmlzTnVsbCgp ICYmICFkLT5tX3Bhc3MuaXNOdWxsKCkpIHsKICAgICAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVm PiB1c2VyKEFkb3B0Q0YsIGQtPm1fdXNlci5jcmVhdGVDRlN0cmluZygpKTsKICAgICAgICAgUmV0 YWluUHRyPENGU3RyaW5nUmVmPiBwYXNzKEFkb3B0Q0YsIGQtPm1fcGFzcy5jcmVhdGVDRlN0cmlu ZygpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNl SGFuZGxlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCShyZXZpc2lvbiA5OTc1OCkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCSh3b3JraW5n IGNvcHkpCkBAIC01MjQsNiArNTI0LDE2IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmRpZFJlY2Vp dmVBdXRoZW50aWMKICAgICAvLyB3ZSBtYWtlIHN1cmUgdGhhdCBpcyBhY3R1YWxseSBwcmVzZW50 CiAgICAgQVNTRVJUKGNoYWxsZW5nZS5uc1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKCkpOwog CisjaWYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkgJiYgIWRlZmluZWQoQlVJTERJTkdf T05fU05PV0xFT1BBUkQpCisgICAgLy8gUHJveHkgYXV0aGVudGljYXRpb24gaXMgaGFuZGxlZCBi eSBDRk5ldHdvcmsgaW50ZXJuYWxseS4gV2UgY2FuIGdldCBoZXJlIGlmIHRoZSB1c2VyIGNhbmNl bHMKKyAgICAvLyBDRk5ldHdvcmsgYXV0aGVudGljYXRpb24gZGlhbG9nLCBhbmQgd2Ugc2hvdWxk bid0IGFzayB0aGUgY2xpZW50IHRvIGRpc3BsYXkgYW5vdGhlciBvbmUgaW4gdGhhdCBjYXNlLgor ICAgIGlmIChjaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkuaXNQcm94eSgpKSB7CisgICAgICAg IC8vIENhbm5vdCB1c2UgcmVjZWl2ZWRSZXF1ZXN0VG9Db250aW51ZVdpdGhvdXRDcmVkZW50aWFs KCksIGJlY2F1c2UgY3VycmVudCBjaGFsbGVuZ2UgaXMgbm90IHlldCBzZXQuCisgICAgICAgIFtj aGFsbGVuZ2Uuc2VuZGVyKCkgY29udGludWVXaXRob3V0Q3JlZGVudGlhbEZvckF1dGhlbnRpY2F0 aW9uQ2hhbGxlbmdlOmNoYWxsZW5nZS5uc1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKCldOwor ICAgICAgICByZXR1cm47CisgICAgfQorI2VuZGlmCisKICAgICBpZiAoIWQtPm1fdXNlci5pc051 bGwoKSAmJiAhZC0+bV9wYXNzLmlzTnVsbCgpKSB7CiAgICAgICAgIE5TVVJMQ3JlZGVudGlhbCAq Y3JlZGVudGlhbCA9IFtbTlNVUkxDcmVkZW50aWFsIGFsbG9jXSBpbml0V2l0aFVzZXI6ZC0+bV91 c2VyCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFzc3dvcmQ6ZC0+bV9wYXNzCkBAIC01NjQsNiArNTc0LDkgQEAgdm9p ZCBSZXNvdXJjZUhhbmRsZTo6ZGlkUmVjZWl2ZUF1dGhlbnRpYwogICAgIGQtPm1fY3VycmVudFdl YkNoYWxsZW5nZSA9IGNvcmUoZC0+bV9jdXJyZW50TWFjQ2hhbGxlbmdlKTsKICAgICBkLT5tX2N1 cnJlbnRXZWJDaGFsbGVuZ2Uuc2V0QXV0aGVudGljYXRpb25DbGllbnQodGhpcyk7CiAKKyAgICAv LyBGSVhNRTogU2V2ZXJhbCBjb25jdXJyZW50IHJlcXVlc3RzIGNhbiByZXR1cm4gd2l0aCB0aGUg YW4gYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGZvciB0aGUgc2FtZSBwcm90ZWN0aW9uIHNwYWNl LgorICAgIC8vIFdlIHNob3VsZCBhdm9pZCBtYWtpbmcgYWRkaXRpb25hbCBjbGllbnQgY2FsbHMg Zm9yIHRoZSBzYW1lIHByb3RlY3Rpb24gc3BhY2Ugd2hlbiBhbHJlYWR5IHdhaXRpbmcgZm9yIHRo ZSB1c2VyLAorICAgIC8vIGJlY2F1c2UgdHlwaW5nIHRoZSBzYW1lIGNyZWRlbnRpYWxzIHNldmVy YWwgdGltZXMgaXMgYW5ub3lpbmcuCiAgICAgaWYgKGNsaWVudCgpKQogICAgICAgICBjbGllbnQo KS0+ZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHRoaXMsIGQtPm1fY3VycmVudFdl YkNoYWxsZW5nZSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA5OTc3OSkKKysrIFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEx LTExLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMDQyMzAyND4gV2ViUHJvY2VzcyBkb2Vzbid0IHVzZSBBdXRoQnJva2Vy QWdlbnQgZm9yIHByb3h5IGNyZWRlbnRpYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MTk2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYjog QWxsb3cgbWFjaC1sb29rdXAgb2YgY29tLmFwcGxlLmNmbmV0d29yay5BdXRoQnJva2VyQWdlbnQu CisKIDIwMTEtMTEtMDkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBFbGVtZW50Ojpib3VuZHNJbldpbmRvd1NwYWNlIHNob3VsZCBiZSBFbGVtZW50Ojpi b3VuZHNJblJvb3RWaWV3U3BhY2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvY29t LmFwcGxlLldlYlByb2Nlc3Muc2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYgkocmV2aXNpb24gOTk3NTgpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiCSh3b3JraW5nIGNvcHkp CkBAIC0xNjcsNiArMTY3LDkgQEAKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS53aW5k b3dfcHJveGllcyIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUud2luZG93c2VydmVy LmFjdGl2ZSIpCiAKKyAgICAgICAgOzsgRklYTUU6IFRoaXMgd2lsbCBiZSBzdXBlcmZsdW91cyBv bmNlIDxyZGFyOi8vcHJvYmxlbS8xMDQyMDU1NT4gaXMgZml4ZWQuCisgICAgICAgKGdsb2JhbC1u YW1lICJjb20uYXBwbGUuY2ZuZXR3b3JrLkF1dGhCcm9rZXJBZ2VudCIpCisKICAgICAgICA7OyBG SVhNRTogVGhpcyBzaG91bGQgYmUgcmVtb3ZlZCB3aGVuIDxyZGFyOi8vcHJvYmxlbS85Mjc2Mzkz PiBpcyBmaXhlZC4KICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5tZXRhZGF0YS5tZHMi KSkKIAo=