71962 2011-11-09 16:01:57 -0800 Simplify the way that images are passed into a filter chain 2018-09-03 10:51:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 simon.fraser dino dino krit simon.fraser thorton webkit-bug-importer zimmermann oldest_to_newest 499432 0 simon.fraser 2011-11-09 16:01:57 -0800 Looking at the patch in bug 68472, I think the way that data gets into and out of filter chains could be improved. The code currently has to do: m_filter->setSourceImageRect(size); m_filter->setSourceImage(ImageBuffer::create(layoutSize)); GraphicsContext* sourceGraphicsContext = m_filter->sourceImage()->context(); // paint stuff m_filter->effect()->apply(); p->drawImageBuffer(m_filter->effect()->asImageBuffer(), ...) It seems like it would be much clearer as: 1. Make an ImageBuffer 2. Paint into the ImageBuffer 3. Hand the ImageBuffer to the filter. 4. Get the filtered result as an image buffer 5. Paint that image buffer. 501117 1 webkit-bug-importer 2011-11-11 14:42:32 -0800 <rdar://problem/10435248> 925418 2 krit 2013-09-05 23:35:19 -0700 (In reply to comment #0) > Looking at the patch in bug 68472, I think the way that data gets into and out of filter chains could be improved. The code currently has to do: > > m_filter->setSourceImageRect(size); > m_filter->setSourceImage(ImageBuffer::create(layoutSize)); > GraphicsContext* sourceGraphicsContext = m_filter->sourceImage()->context(); > // paint stuff > > m_filter->effect()->apply(); > p->drawImageBuffer(m_filter->effect()->asImageBuffer(), ...) > > > It seems like it would be much clearer as: > > 1. Make an ImageBuffer > 2. Paint into the ImageBuffer > 3. Hand the ImageBuffer to the filter. > 4. Get the filtered result as an image buffer > 5. Paint that image buffer. Well, that seems what we are doing right now. What is your suggestion? 1456186 3 simon.fraser 2018-09-03 10:51:30 -0700 True dat.