71940 2011-11-09 11:24:05 -0800 [GTK] Make the ENABLE(FEATURE) macro work in DRT 2011-11-10 07:24:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66477 0 scaroo webkit-unassigned webkit.review.bot oldest_to_newest 499183 0 scaroo 2011-11-09 11:24:05 -0800 [GTK] Make the ENABLE(FEATURE) macro work in DRT 499185 1 114325 scaroo 2011-11-09 11:24:28 -0800 Created attachment 114325 Patch 499189 2 114325 pnormand 2011-11-09 11:32:18 -0800 Comment on attachment 114325 Patch Missing ChangeLog! 499758 3 114463 scaroo 2011-11-10 02:49:42 -0800 Created attachment 114463 Patch 499759 4 scaroo 2011-11-10 02:56:34 -0800 (In reply to comment #3) > Created an attachment (id=114463) [details] > Patch Updated: - add ChangeLog entry 499808 5 114463 pnormand 2011-11-10 05:20:18 -0800 Comment on attachment 114463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review > Tools/ChangeLog:1 > +2011-11-09 Alexandre Mazari <alexandre.mazari@gmail.com> This is not consistent with your other patches. Any reason to no use your igalia address? > Tools/ChangeLog:9 > + * GNUmakefile.am: > + Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about. 499843 6 114482 scaroo 2011-11-10 06:12:36 -0800 Created attachment 114482 Patch 499845 7 scaroo 2011-11-10 06:15:02 -0800 Hi Philippe, Thanks for your review. (In reply to comment #5) > (From update of attachment 114463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review > > > Tools/ChangeLog:1 > > +2011-11-09 Alexandre Mazari <alexandre.mazari@gmail.com> > > This is not consistent with your other patches. Any reason to no use your igalia address? Fixed. Don't even know where the changelog generator got this email from :) > > > Tools/ChangeLog:9 > > + * GNUmakefile.am: > > + > > Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about. Done. 499893 8 114482 webkit.review.bot 2011-11-10 07:24:12 -0800 Comment on attachment 114482 Patch Clearing flags on attachment: 114482 Committed r99852: <http://trac.webkit.org/changeset/99852> 499894 9 webkit.review.bot 2011-11-10 07:24:16 -0800 All reviewed patches have been landed. Closing bug. 114325 2011-11-09 11:24:28 -0800 2011-11-10 02:49:34 -0800 Patch bug-71940-20111109202426.patch text/plain 548 scaroo U3VidmVyc2lvbiBSZXZpc2lvbjogOTgzMjcKZGlmZiAtLWdpdCBhL1Rvb2xzL0dOVW1ha2VmaWxl LmFtIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0KaW5kZXggMGMyMjAwNjA1OGIyYmRhNTc2Y2E1OTYw MjcyOTUyNmNmNDRiMzA3OC4uMmEwNjM1ZjM1ZWE5ZWQ5NTVmYjQ1MDE1N2Y4M2Y5MGZhZGE0MzUw ZiAxMDA2NDQKLS0tIGEvVG9vbHMvR05VbWFrZWZpbGUuYW0KKysrIGIvVG9vbHMvR05VbWFrZWZp bGUuYW0KQEAgLTEzMiw3ICsxMzIsOCBAQCBQcm9ncmFtc19EdW1wUmVuZGVyVHJlZV9DUFBGTEFH UyA9IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL2pzIFwKIAktSSQodG9w X2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcyBcCiAJLUkkKHRvcF9idWlsZGRpcikvU291cmNlL1dl YktpdC9ndGsgXAotCSQoamF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MpCisJJChqYXZhc2NyaXB0Y29y ZV9jcHBmbGFncykgXAorCSQod2ViY29yZV9jcHBmbGFncykKIAogaWYgVEFSR0VUX1gxMQogUHJv Z3JhbXNfRHVtcFJlbmRlclRyZWVfQ1BQRkxBR1MgKz0gXAo= 114463 2011-11-10 02:49:42 -0800 2011-11-10 06:12:28 -0800 Patch bug-71940-20111110114940.patch text/plain 1086 scaroo U3VidmVyc2lvbiBSZXZpc2lvbjogOTk4MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwZGI0NzdlOTg5YTYzOTYwYTA1YTQxZjU0ZWUzMGI2ZDBl MzNjYmQyLi5kOTYxN2U0MjZiZmRlNmZkMDI2OWNlNzdmMjZkOTNiNjdhZjgyYmRlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTEtMDkgIEFsZXhhbmRyZSBNYXphcmkgIDxhbGV4YW5kcmUubWF6YXJpQGdtYWls LmNvbT4KKworICAgICAgICBbR1RLXSBNYWtlIHRoZSBFTkFCTEUoRkVBVFVSRSkgbWFjcm8gd29y ayBpbiBEUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxOTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBHTlVtYWtlZmlsZS5hbToKKwogMjAxMS0wOC0xOCAgQWxleGFuZHJlIE1hemFyaSAgPGFtYXph cmlAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0KaW5k ZXggOTU5YTZlOTNkOWMzZmY4OTFmYTU2MTU4MDVlYzdmMzZjMTc2YTUwOC4uZmQ5ZWY3MDE0M2Vi Y2ZhYTQ2ODEzYjEyODBiYWVjYTRkNjMwYjM0YSAxMDA2NDQKLS0tIGEvVG9vbHMvR05VbWFrZWZp bGUuYW0KKysrIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0KQEAgLTgxLDcgKzgxLDggQEAgUHJvZ3Jh bXNfRHVtcFJlbmRlclRyZWVfQ1BQRkxBR1MgPSBcCiAJLUkkKHNyY2RpcikvU291cmNlL1dlYkNv cmUvdGVzdGluZy9qcyBcCiAJLUkkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJjZXMgXAogCS1J JCh0b3BfYnVpbGRkaXIpL1NvdXJjZS9XZWJLaXQvZ3RrIFwKLQkkKGphdmFzY3JpcHRjb3JlX2Nw cGZsYWdzKQorCSQoamF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MpIFwKKwkkKHdlYmNvcmVfY3BwZmxh Z3MpCiAKIGlmIFRBUkdFVF9YMTEKIFByb2dyYW1zX0R1bXBSZW5kZXJUcmVlX0NQUEZMQUdTICs9 IFwK 114482 2011-11-10 06:12:36 -0800 2011-11-10 07:24:12 -0800 Patch bug-71940-20111110151234.patch text/plain 1199 scaroo U3VidmVyc2lvbiBSZXZpc2lvbjogOTk4MjIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwZGI0NzdlOTg5YTYzOTYwYTA1YTQxZjU0ZWUzMGI2ZDBl MzNjYmQyLi5kZGQ5NjEwZThiYWNiMGEzYzI3NTYwN2ZlZDcyNTY0MmJhZGFiZmNjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTEtMDkgIEFsZXhhbmRyZSBNYXphcmkgIDxhbWF6YXJpQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gTWFrZSB0aGUgRU5BQkxFKEZFQVRVUkUpIG1hY3JvIHdvcmsgaW4gRFJU CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTk0MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR05VbWFr ZWZpbGUuYW06CisgICAgICAgIEFkZCB3ZWJjb3JlX2NwcGZsYWdzIHRvIFByb2dyYW1zX0R1bXBS ZW5kZXJUcmVlX0NQUCBzbworICAgICAgICBFTkFCTEVfKiB2YXJpYWJsZXMgYXJlIHBhcnQgb2Yg dGhlIGVudmlyb25tZW50LgorCiAyMDExLTA4LTE4ICBBbGV4YW5kcmUgTWF6YXJpICA8YW1hemFy aUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZm IC0tZ2l0IGEvVG9vbHMvR05VbWFrZWZpbGUuYW0gYi9Ub29scy9HTlVtYWtlZmlsZS5hbQppbmRl eCA5NTlhNmU5M2Q5YzNmZjg5MWZhNTYxNTgwNWVjN2YzNmMxNzZhNTA4Li5mZDllZjcwMTQzZWJj ZmFhNDY4MTNiMTI4MGJhZWNhNGQ2MzBiMzRhIDEwMDY0NAotLS0gYS9Ub29scy9HTlVtYWtlZmls ZS5hbQorKysgYi9Ub29scy9HTlVtYWtlZmlsZS5hbQpAQCAtODEsNyArODEsOCBAQCBQcm9ncmFt c19EdW1wUmVuZGVyVHJlZV9DUFBGTEFHUyA9IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL2pzIFwKIAktSSQodG9wX2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcyBcCiAJLUkk KHRvcF9idWlsZGRpcikvU291cmNlL1dlYktpdC9ndGsgXAotCSQoamF2YXNjcmlwdGNvcmVfY3Bw ZmxhZ3MpCisJJChqYXZhc2NyaXB0Y29yZV9jcHBmbGFncykgXAorCSQod2ViY29yZV9jcHBmbGFn cykKIAogaWYgVEFSR0VUX1gxMQogUHJvZ3JhbXNfRHVtcFJlbmRlclRyZWVfQ1BQRkxBR1MgKz0g XAo=