71932 2011-11-09 10:36:13 -0800 [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes 2011-11-10 07:42:43 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand zimmermann zimmermann oldest_to_newest 499121 0 pnormand 2011-11-09 10:36:13 -0800 http://webkit-bots.igalia.com/amd64/svn_99724.core-when_1320861570-_-who_DumpRenderTree-_-why_11.trace.html Happens in the 64-bits Debug bot at least. #0 0x00002b0fa96aea6d in WTF::OwnPtr<WebCore::Page>::operator-> (this=0x47dacf80) at ../../Source/JavaScriptCore/wtf/OwnPtr.h:63 63 PtrType operator->() const { ASSERT(m_ptr); return m_ptr; } Thread 1 (Thread 0x2b0fb6abe8e0 (LWP 17874)): #0 0x00002b0fa96aea6d in WTF::OwnPtr<WebCore::Page>::operator-> (this=0x47dacf80) at ../../Source/JavaScriptCore/wtf/OwnPtr.h:63 #1 0x00002b0fa96ab027 in WebCore::SVGImage::drawSVGToImageBuffer (this=0x47dacf40, buffer=0x47c84190, size=..., zoom=1, shouldClear=WebCore::SVGImage::DontClearImageBuffer) at ../../Source/WebCore/svg/graphics/SVGImage.cpp:161 #2 0x00002b0fa96a5cb2 in WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer (this=0x47ec4e50, renderer=0x47ec6f98) at ../../Source/WebCore/svg/graphics/SVGImageCache.cpp:140 #3 0x00002b0fa91c3d0d in WebCore::CachedImage::lookupOrCreateImageForRenderer (this=0x47e94b00, renderer=0x47ec6f98) at ../../Source/WebCore/loader/cache/CachedImage.cpp:150 #4 0x00002b0fa91c29ac in WebCore::CachedImage::imageForRenderer (this=0x47e94b00, renderer=0x47ec6f98) at ../../Source/WebCore/loader/cache/CachedImage.cpp:191 #5 0x00002b0fa950e31c in WebCore::RenderImageResource::image (this=0x47e7e290) at ../../Source/WebCore/rendering/RenderImageResource.h:57 #6 0x00002b0fa950c4df in WebCore::RenderImage::paintReplaced (this=0x47ec6f98, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderImage.cpp:326 #7 0x00002b0fa95594d6 in WebCore::RenderReplaced::paint (this=0x47ec6f98, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderReplaced.cpp:152 #8 0x00002b0fa950c61d in WebCore::RenderImage::paint (this=0x47ec6f98, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderImage.cpp:344 #9 0x00002b0fa94466cb in WebCore::InlineBox::paint (this=0x48140b18, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/InlineBox.cpp:231 #10 0x00002b0fa944b852 in WebCore::InlineFlowBox::paint (this=0x47ea5498, paintInfo=..., paintOffset=..., lineTop=1, lineBottom=425) at ../../Source/WebCore/rendering/InlineFlowBox.cpp:1061 #11 0x00002b0fa95ac37e in WebCore::RootInlineBox::paint (this=0x47ea5498, paintInfo=..., paintOffset=..., lineTop=1, lineBottom=425) at ../../Source/WebCore/rendering/RootInlineBox.cpp:195 #12 0x00002b0fa9531acb in WebCore::RenderLineBoxList::paint (this=0x47e7f7c8, renderer=0x47e7f728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderLineBoxList.cpp:262 #13 0x00002b0fa946c826 in WebCore::RenderBlock::paintContents (this=0x47e7f728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2507 #14 0x00002b0fa946d0a6 in WebCore::RenderBlock::paintObject (this=0x47e7f728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2617 #15 0x00002b0fa946b909 in WebCore::RenderBlock::paint (this=0x47e7f728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2362 #16 0x00002b0fa946cb85 in WebCore::RenderBlock::paintChildren (this=0x47e7e728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2551 #17 0x00002b0fa946c83f in WebCore::RenderBlock::paintContents (this=0x47e7e728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2509 #18 0x00002b0fa946d0a6 in WebCore::RenderBlock::paintObject (this=0x47e7e728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2617 #19 0x00002b0fa946b909 in WebCore::RenderBlock::paint (this=0x47e7e728, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2362 #20 0x00002b0fa946cb85 in WebCore::RenderBlock::paintChildren (this=0x47eab3b8, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2551 #21 0x00002b0fa946c83f in WebCore::RenderBlock::paintContents (this=0x47eab3b8, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2509 #22 0x00002b0fa946d0a6 in WebCore::RenderBlock::paintObject (this=0x47eab3b8, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2617 #23 0x00002b0fa946b909 in WebCore::RenderBlock::paint (this=0x47eab3b8, paintInfo=..., paintOffset=...) at ../../Source/WebCore/rendering/RenderBlock.cpp:2362 #24 0x00002b0fa95235f3 in WebCore::RenderLayer::paintLayer (this=0x47ea0bc8, rootLayer=0x47e8ef68, p=0x7fffc9a09780, paintDirtyRect=..., paintBehavior=0, paintingRoot=0x0, region=0x0, overlapTestRequests=0x7fffc9a09480, paintFlags=0) at ../../Source/WebCore/rendering/RenderLayer.cpp:2806 #25 0x00002b0fa9523b57 in WebCore::RenderLayer::paintList (this=0x47e8ef68, list=0x47ea51d0, rootLayer=0x47e8ef68, p=0x7fffc9a09780, paintDirtyRect=..., paintBehavior=0, paintingRoot=0x0, region=0x0, overlapTestRequests=0x7fffc9a09480, paintFlags=0) at ../../Source/WebCore/rendering/RenderLayer.cpp:2865 #26 0x00002b0fa9523851 in WebCore::RenderLayer::paintLayer (this=0x47e8ef68, rootLayer=0x47e8ef68, p=0x7fffc9a09780, paintDirtyRect=..., paintBehavior=0, paintingRoot=0x0, region=0x0, overlapTestRequests=0x7fffc9a09480, paintFlags=0) at ../../Source/WebCore/rendering/RenderLayer.cpp:2827 #27 0x00002b0fa9522468 in WebCore::RenderLayer::paint (this=0x47e8ef68, p=0x7fffc9a09780, damageRect=..., paintBehavior=0, paintingRoot=0x0, region=0x0, paintFlags=0) at ../../Source/WebCore/rendering/RenderLayer.cpp:2549 #28 0x00002b0fa92cb9d6 in WebCore::FrameView::paintContents (this=0x47dadb40, p=0x7fffc9a09780, rect=...) at ../../Source/WebCore/page/FrameView.cpp:2772 #29 0x00002b0fa93eb341 in WebCore::ScrollView::paint (this=0x47dadb40, context=0x7fffc9a09780, rect=...) at ../../Source/WebCore/platform/ScrollView.cpp:1049 #30 0x00002b0fa8afe7c4 in WebKit::paintWebView (webView=0x1156050, frame=0x1184380, dirtyRegion=...) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:515 #31 0x00002b0fa8afeb54 in WebKit::ChromeClient::paint (this=0x1152fa0) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:560 #32 0x00002b0fa8afdcdd in WebKit::repaintEverythingSoonTimeout (client=0x1152fa0) at ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:387 #33 0x00002b0faddb1ddb in g_timeout_dispatch (source=0x47ed2c50, callback=<optimized out>, user_data=<optimized out>) at /tmp/buildd/glib2.0-2.28.6/./glib/gmain.c:3882 #34 0x00002b0faddb04a3 in g_main_dispatch (context=0x10dfe60) at /tmp/buildd/glib2.0-2.28.6/./glib/gmain.c:2440 #35 g_main_context_dispatch (context=0x10dfe60) at /tmp/buildd/glib2.0-2.28.6/./glib/gmain.c:3013 #36 0x00002b0faddb0c80 in g_main_context_iterate (context=0x10dfe60, block=1, dispatch=1, self=<optimized out>) at /tmp/buildd/glib2.0-2.28.6/./glib/gmain.c:3091 #37 0x00002b0faddb12f2 in g_main_loop_run (loop=0x47b091b0) at /tmp/buildd/glib2.0-2.28.6/./glib/gmain.c:3299 #38 0x00002b0fabb5e4cd in gtk_main () from /usr/lib/libgtk-3.so.0 #39 0x000000000042f805 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:708 #40 0x000000000042ee3d in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:500 #41 0x000000000043117d in main (argc=2, argv=0x7fffc9a0a538) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1206 499887 1 114497 zimmermann 2011-11-10 07:18:50 -0800 Created attachment 114497 Patch Obvious fix needed, thanks for noticing! 499899 2 114497 pnormand 2011-11-10 07:36:57 -0800 Comment on attachment 114497 Patch LGTM, bonus point if you unskip the test in GTK when landing the patch! 499902 3 zimmermann 2011-11-10 07:42:43 -0800 Thanks, landed in r99856. 114497 2011-11-10 07:18:50 -0800 2011-11-10 07:36:57 -0800 Patch A-CrashFix.diff text/plain 1436 zimmermann SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5ODUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMTAgIE5pa29sYXMg WmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CisKKyAgICAgICAgW0dUS10gc3ZnL2Fz LWltYWdlL3N2Zy1pbWFnZS1jaGFuZ2UtY29udGVudC1zaXplLnhodG1sIGNyYXNoZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxOTMyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTnVsbCBjaGVjayBtX3Bh Z2UgaW4gZHJhd1NWR1RvSW1hZ2VCdWZmZXIoKSwganVzdCBsaWtlIGFsbCBvdGhlcnMgbWV0aG9k cyBkby4KKyAgICAgICAgQXMgZHJhd1NWR1RvSW1hZ2VCdWZmZXIoKSBpcyBmaXJlZCBmcm9tIGEg dGltZXIsIGl0IG1heSBnZXQgaW50byB0aGlzIHN0YXRlIHVuZGVyIGNlcnRhaW4gY29uZGl0aW9u cywgYXMgc2VlbiBvbiB0aGUgNjRiaXQgZ3RrIGJvdC4KKworICAgICAgICAqIHN2Zy9ncmFwaGlj cy9TVkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6ZHJhd1NWR1RvSW1h Z2VCdWZmZXIpOgorCiAyMDExLTExLTEwICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdyBtZWRpYSBxdWVyaWVzIGFz c29jaWF0ZWQgd2l0aCBzcGVjaWZpYyBDU1MgcnVsZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2 Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3Zn L2dyYXBoaWNzL1NWR0ltYWdlLmNwcAkocmV2aXNpb24gOTk4MzgpCisrKyBTb3VyY2UvV2ViQ29y ZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTgsNiArMTU4 LDkgQEAgdm9pZCBTVkdJbWFnZTo6ZHJhd1NWR1RvSW1hZ2VCdWZmZXIoSW1hZwogICAgIEFTU0VS VChidWZmZXIpOwogICAgIEFTU0VSVCghc2l6ZS5pc0VtcHR5KCkpOwogCisgICAgaWYgKCFtX3Bh Z2UpCisgICAgICAgIHJldHVybjsKKwogICAgIEZyYW1lKiBmcmFtZSA9IG1fcGFnZS0+bWFpbkZy YW1lKCk7CiAgICAgU1ZHU1ZHRWxlbWVudCogcm9vdEVsZW1lbnQgPSBzdGF0aWNfY2FzdDxTVkdE b2N1bWVudCo+KGZyYW1lLT5kb2N1bWVudCgpKS0+cm9vdEVsZW1lbnQoKTsKICAgICBpZiAoIXJv b3RFbGVtZW50KQo=