71912 2011-11-09 07:18:15 -0800 Fixing build on MacOSX SL after 71838 2011-11-09 10:41:34 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achicu achicu andersca webkit.review.bot oldest_to_newest 498930 0 achicu 2011-11-09 07:18:15 -0800 I have the following error when building on MacOSX SL: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: In constructor ‘WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea(WebKit::WebPage*, const WebKit::WebPageCreationParameters&)’: Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:54: error: setting a C++ non-POD object value is not implemented - assign the value to a temporary and use the temporary. cc1objplus: warnings being treated as errors Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:54: warning: left-hand operand of comma has no effect 498936 1 114272 achicu 2011-11-09 07:23:34 -0800 Created attachment 114272 Patch 499089 2 114272 andersca 2011-11-09 09:54:31 -0800 Comment on attachment 114272 Patch I'd prefer static_cast over a C-style cast, but r=me anyway. 499127 3 114272 webkit.review.bot 2011-11-09 10:41:30 -0800 Comment on attachment 114272 Patch Clearing flags on attachment: 114272 Committed r99735: <http://trac.webkit.org/changeset/99735> 499128 4 webkit.review.bot 2011-11-09 10:41:34 -0800 All reviewed patches have been landed. Closing bug. 114272 2011-11-09 07:23:34 -0800 2011-11-09 10:41:30 -0800 Patch bug-71912-20111109172332.patch text/plain 1491 achicu U3VidmVyc2lvbiBSZXZpc2lvbjogOTk2OTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1YmEzNTkzYzJjZTg0YzJk OWExOGNkZjU0ZmVhZWIyODBjMDkxY2JhLi5kZjQzMWQwNzFjOTc5NDE2NmI5MjFmMzA3MzY0ZDAy NzkzM2U2YWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMDkgIEFsZXhh bmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIEZpeGluZyBidWls ZCBvbiBNYWNPU1ggU0wgYWZ0ZXIgNzE4MzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcxOTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1h dGlvbkRyYXdpbmdBcmVhLm1tOgorICAgICAgICAoV2ViS2l0OjpUaWxlZENvcmVBbmltYXRpb25E cmF3aW5nQXJlYTo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEpOgorCiAyMDExLTExLTA5 ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdIEZpeCBnZW9sb2NhdGlvbiBlbmFibGVkIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJl YS5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWEubW0KaW5kZXggODljZjFmMTJkMWFmMDQwY2M2ZTgzM2UyYzE0Y2Yz MGY1Mzc5MjJhYy4uYmJjNzNmMmY1ZmZjNDRkNGE5ZjA4Mjg4YmM3ZDlmZmZkMzZjMjg4NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVB bmltYXRpb25EcmF3aW5nQXJlYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCkBAIC01MSw3ICs1MSw3 IEBAIFRpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhOjpUaWxlZENvcmVBbmltYXRpb25EcmF3 aW5nQXJlYShXZWJQYWdlKiB3ZWJQYWdlLCBjCiB7CiAgICAgbV9yb290TGF5ZXIgPSBbQ0FMYXll ciBsYXllcl07CiAKLSAgICBtX3Jvb3RMYXllci5nZXQoKS5mcmFtZSA9IG1fd2ViUGFnZS0+Ym91 bmRzKCk7CisgICAgbV9yb290TGF5ZXIuZ2V0KCkuZnJhbWUgPSAoQ0dSZWN0KW1fd2ViUGFnZS0+ Ym91bmRzKCk7CiAgICAgbV9yb290TGF5ZXIuZ2V0KCkub3BhcXVlID0gWUVTOwogCiAgICAgLy8g R2l2ZSB0aGUgcm9vdCBsYXllciBhIGJhY2tncm91bmQgY29sb3Igc28gaXQncyB2aXNpYmxlIG9u IHNjcmVlbi4K