71895 2011-11-09 06:00:45 -0800 MediaStream API: Extending MediaStreamRegistry 2011-11-09 08:47:54 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 56459 1 tommyw tommyw abarth adam.bergkvist grunell harald oldest_to_newest 498869 0 tommyw 2011-11-09 06:00:45 -0800 Extending MediaStreamRegistry so that MediaStreamDescriptors can be looked up by label as well as any public blob URLs. 498872 1 114258 tommyw 2011-11-09 06:12:28 -0800 Created attachment 114258 Patch 498949 2 adam.bergkvist 2011-11-09 07:40:24 -0800 How is this intended to be used? The MediaStream label is not guaranteed to be unique to a particular MediaStream instance. 498992 3 114258 abarth 2011-11-09 08:30:23 -0800 Comment on attachment 114258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114258&action=review > Source/WebCore/ChangeLog:8 > + MediaStream API: Extending MediaStreamRegistry > + https://bugs.webkit.org/show_bug.cgi?id=71895 > + > + Reviewed by NOBODY (OOPS!). > + > + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. Can you add more of an explanation to the ChangeLog? The ChangeLog should explain why we're making this change. I don't really understand what this change achieves (mostly due to my ignorance). 499009 4 tommyw 2011-11-09 08:45:48 -0800 (In reply to comment #2) > How is this intended to be used? The MediaStream label is not guaranteed to be unique to a particular MediaStream instance. Right, I forgot the bounced MediaStream scenario... 499011 5 tommyw 2011-11-09 08:47:54 -0800 This was to slightly simplify the embedder code but Adam Bergkvist reminded me why this wont work. (In reply to comment #3) > (From update of attachment 114258 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114258&action=review > > > Source/WebCore/ChangeLog:8 > > + MediaStream API: Extending MediaStreamRegistry > > + https://bugs.webkit.org/show_bug.cgi?id=71895 > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code. > > Can you add more of an explanation to the ChangeLog? The ChangeLog should explain why we're making this change. I don't really understand what this change achieves (mostly due to my ignorance). 114258 2011-11-09 06:12:28 -0800 2011-11-09 08:46:04 -0800 Patch bug-71895-20111109151226.patch text/plain 4596 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMjY2Njg4ZGU5YTRjODFh ZDEzYWQxN2M3OGI1ZWE3NDRmN2U2MjUwLi45Yjc0ZDY0MmNkNjkyMmIxMzQ5NTkzZWFiYjMxNWRj MTIxNDk5ODIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTEtMDkgIFRvbW15 IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CisKKyAgICAgICAgTWVkaWFTdHJlYW0g QVBJOiBFeHRlbmRpbmcgTWVkaWFTdHJlYW1SZWdpc3RyeQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE4OTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0cyBmb3IgdGhlIE1lZGlhIFN0cmVhbSBBUEkg d2lsbCBiZSBwcm92aWRlZCBieSB0aGUgYnVnIDU2NTg3LCBwZW5kaW5nIGVub3VnaCBsYW5kZWQg Y29kZS4KKworICAgICAgICAqIG1lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhU3RyZWFtOjpNZWRpYVN0cmVhbSk6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVN0cmVhbTo6fk1lZGlhU3RyZWFtKToKKyAgICAgICAgKiBtZWRpYXN0cmVhbS9NZWRpYVN0 cmVhbVJlZ2lzdHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtUmVnaXN0cnk6 OnJlZ2lzdGVyTWVkaWFTdHJlYW0pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1SZWdp c3RyeTo6dW5yZWdpc3Rlck1lZGlhU3RyZWFtKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3Ry ZWFtUmVnaXN0cnk6Omxvb2t1cE1lZGlhU3RyZWFtRGVzY3JpcHRvcik6CisgICAgICAgICogbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW1SZWdpc3RyeS5oOgorCiAyMDExLTExLTA3ICBZdXJ5IFNlbWlr aGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJl ZmFjdG9yIHNob3J0Y3V0cyBhbmQgc2V0dGluZ3Mgc2NyZWVucwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwIGIvU291cmNlL1dlYkNvcmUvbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW0uY3BwCmluZGV4IGZjZGJmNWZlMzM5ODJhOTc4Y2IxZjM0MTNh YTQ3MjU0ZmY0MGU2MjcuLjdhYzdjMmMwNTY5YjRjYjk1NmI2MGU4MmYwNDUxN2I4Mzc3ZDZiNGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5jcHAKQEAgLTI5LDYg KzI5LDcgQEAKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogCiAjaW5jbHVkZSAiRXZlbnQuaCIK KyNpbmNsdWRlICJNZWRpYVN0cmVhbVJlZ2lzdHJ5LmgiCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0 aW9uQ29udGV4dC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01MiwxMCArNTMsMTMgQEAg TWVkaWFTdHJlYW06Ok1lZGlhU3RyZWFtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQs IFBhc3NSZWZQdHI8TWVkaWFTdHJlYW0KICAgICAgICAgdHJhY2tWZWN0b3IuYXBwZW5kKE1lZGlh U3RyZWFtVHJhY2s6OmNyZWF0ZShtX2Rlc2NyaXB0b3IsIGkpKTsKIAogICAgIG1fdHJhY2tzID0g TWVkaWFTdHJlYW1UcmFja0xpc3Q6OmNyZWF0ZSh0cmFja1ZlY3Rvcik7CisKKyAgICBNZWRpYVN0 cmVhbVJlZ2lzdHJ5OjpyZWdpc3RyeSgpLnJlZ2lzdGVyTWVkaWFTdHJlYW0odGhpcyk7CiB9CiAK IE1lZGlhU3RyZWFtOjp+TWVkaWFTdHJlYW0oKQogeworICAgIE1lZGlhU3RyZWFtUmVnaXN0cnk6 OnJlZ2lzdHJ5KCkudW5yZWdpc3Rlck1lZGlhU3RyZWFtKHRoaXMpOwogICAgIG1fZGVzY3JpcHRv ci0+c2V0T3duZXIoMCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21lZGlhc3Ry ZWFtL01lZGlhU3RyZWFtUmVnaXN0cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0v TWVkaWFTdHJlYW1SZWdpc3RyeS5jcHAKaW5kZXggZWI5ZmRiYmIzYjRiYmE5MDY0YWMwYzIyMmFk NGRmNGMzYTEzNTMxOC4uMjJjZjg4MDhkYmMwNjlhMDBmNzcyMjA3M2IxOGJlOWIwNTdhMzY5NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1SZWdpc3Ry eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1SZWdpc3Ry eS5jcHAKQEAgLTQwLDYgKzQwLDE5IEBAIE1lZGlhU3RyZWFtUmVnaXN0cnkmIE1lZGlhU3RyZWFt UmVnaXN0cnk6OnJlZ2lzdHJ5KCkKICAgICByZXR1cm4gaW5zdGFuY2U7CiB9CiAKK3ZvaWQgTWVk aWFTdHJlYW1SZWdpc3RyeTo6cmVnaXN0ZXJNZWRpYVN0cmVhbShQYXNzUmVmUHRyPE1lZGlhU3Ry ZWFtPiBwcnBTdHJlYW0pCit7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAgICBSZWZQ dHI8TWVkaWFTdHJlYW0+IHN0cmVhbSA9IHBycFN0cmVhbTsKKyAgICBtX3N0cmVhbURlc2NyaXB0 b3JzLnNldChzdHJlYW0tPmRlc2NyaXB0b3IoKS0+bGFiZWwoKSwgc3RyZWFtLT5kZXNjcmlwdG9y KCkpOworfQorCit2b2lkIE1lZGlhU3RyZWFtUmVnaXN0cnk6OnVucmVnaXN0ZXJNZWRpYVN0cmVh bShQYXNzUmVmUHRyPE1lZGlhU3RyZWFtPiBzdHJlYW0pCit7CisgICAgQVNTRVJUKGlzTWFpblRo cmVhZCgpKTsKKyAgICBtX3N0cmVhbURlc2NyaXB0b3JzLnJlbW92ZShzdHJlYW0tPmRlc2NyaXB0 b3IoKS0+bGFiZWwoKSk7Cit9CisKIHZvaWQgTWVkaWFTdHJlYW1SZWdpc3RyeTo6cmVnaXN0ZXJN ZWRpYVN0cmVhbVVSTChjb25zdCBLVVJMJiB1cmwsIFBhc3NSZWZQdHI8TWVkaWFTdHJlYW0+IHN0 cmVhbSkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwpAQCAtNTIsMTAgKzY1LDEwIEBA IHZvaWQgTWVkaWFTdHJlYW1SZWdpc3RyeTo6dW5yZWdpc3Rlck1lZGlhU3RyZWFtVVJMKGNvbnN0 IEtVUkwmIHVybCkKICAgICBtX3N0cmVhbURlc2NyaXB0b3JzLnJlbW92ZSh1cmwuc3RyaW5nKCkp OwogfQogCi1NZWRpYVN0cmVhbURlc2NyaXB0b3IqIE1lZGlhU3RyZWFtUmVnaXN0cnk6Omxvb2t1 cE1lZGlhU3RyZWFtRGVzY3JpcHRvcihjb25zdCBTdHJpbmcmIHVybCkKK01lZGlhU3RyZWFtRGVz Y3JpcHRvciogTWVkaWFTdHJlYW1SZWdpc3RyeTo6bG9va3VwTWVkaWFTdHJlYW1EZXNjcmlwdG9y KGNvbnN0IFN0cmluZyYga2V5KQogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7Ci0gICAg cmV0dXJuIG1fc3RyZWFtRGVzY3JpcHRvcnMuZ2V0KHVybCkuZ2V0KCk7CisgICAgcmV0dXJuIG1f c3RyZWFtRGVzY3JpcHRvcnMuZ2V0KGtleSkuZ2V0KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt UmVnaXN0cnkuaCBiL1NvdXJjZS9XZWJDb3JlL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtUmVnaXN0 cnkuaAppbmRleCAxZjkyNzQ1MDk1ZTk0ZmU3MzQyMDlhYzhjZTAzODcyOTdiMDA4YjMwLi40YmY4 MDgzNjcwYzdlNTA1ZTI2MDE2OWNiZGYzNjY0ZjAwZDc5OGY1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVJlZ2lzdHJ5LmgKKysrIGIvU291cmNlL1dl YkNvcmUvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1SZWdpc3RyeS5oCkBAIC00MiwxMSArNDIsMTYg QEAgcHVibGljOgogICAgIC8vIFJldHVybnMgYSBzaW5nbGUgaW5zdGFuY2Ugb2YgTWVkaWFTdHJl YW1SZWdpc3RyeS4KICAgICBzdGF0aWMgTWVkaWFTdHJlYW1SZWdpc3RyeSYgcmVnaXN0cnkoKTsK IAorICAgIC8vIFJlZ2lzdGVycyBhIGxhYmVsIHJlZmVycmluZyB0byB0aGUgc3BlY2lmaWVkIHN0 cmVhbSBkYXRhLgorICAgIHZvaWQgcmVnaXN0ZXJNZWRpYVN0cmVhbShQYXNzUmVmUHRyPE1lZGlh U3RyZWFtPik7CisgICAgdm9pZCB1bnJlZ2lzdGVyTWVkaWFTdHJlYW0oUGFzc1JlZlB0cjxNZWRp YVN0cmVhbT4pOworCiAgICAgLy8gUmVnaXN0ZXJzIGEgYmxvYiBVUkwgcmVmZXJyaW5nIHRvIHRo ZSBzcGVjaWZpZWQgc3RyZWFtIGRhdGEuCiAgICAgdm9pZCByZWdpc3Rlck1lZGlhU3RyZWFtVVJM KGNvbnN0IEtVUkwmLCBQYXNzUmVmUHRyPE1lZGlhU3RyZWFtPik7CiAgICAgdm9pZCB1bnJlZ2lz dGVyTWVkaWFTdHJlYW1VUkwoY29uc3QgS1VSTCYpOwogCi0gICAgTWVkaWFTdHJlYW1EZXNjcmlw dG9yKiBsb29rdXBNZWRpYVN0cmVhbURlc2NyaXB0b3IoY29uc3QgU3RyaW5nJiB1cmwpOworICAg IC8vIGtleSBjYW4gYmUgZWl0aGVyIGEgbGFiZWwgb3IgYSBibG9iIFVSTC4KKyAgICBNZWRpYVN0 cmVhbURlc2NyaXB0b3IqIGxvb2t1cE1lZGlhU3RyZWFtRGVzY3JpcHRvcihjb25zdCBTdHJpbmcm IGtleSk7CiAKIHByaXZhdGU6CiAgICAgSGFzaE1hcDxTdHJpbmcsIFJlZlB0cjxNZWRpYVN0cmVh bURlc2NyaXB0b3I+ID4gbV9zdHJlYW1EZXNjcmlwdG9yczsK