71891 2011-11-09 05:06:44 -0800 [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view. 2011-11-09 09:33:09 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 498840 0 rakuco 2011-11-09 05:06:44 -0800 [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view. 498843 1 114253 rakuco 2011-11-09 05:07:56 -0800 Created attachment 114253 Patch 498900 2 114253 tonikitoo 2011-11-09 06:47:50 -0800 Comment on attachment 114253 Patch raw "new" calls? mmmm.... :) 498923 3 rakuco 2011-11-09 07:11:01 -0800 (In reply to comment #2) > (From update of attachment 114253 [details]) > raw "new" calls? mmmm.... :) That's the common approach. Page::PageClient is passed to Page's constructor, which then adoptPtr's these pointers. Could you cq+ the patch as well? 499069 4 114253 webkit.review.bot 2011-11-09 09:33:04 -0800 Comment on attachment 114253 Patch Clearing flags on attachment: 114253 Committed r99728: <http://trac.webkit.org/changeset/99728> 499070 5 webkit.review.bot 2011-11-09 09:33:09 -0800 All reviewed patches have been landed. Closing bug. 114253 2011-11-09 05:07:56 -0800 2011-11-09 09:33:04 -0800 Patch bug-71891-20111109110819.patch text/plain 2493 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTk2ODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBmMjAyYzg1YTg4 Y2MxMTA2MTZiZmYwYzJhMGUwNGJhMDMwODVhMzA4Li5hYTc5YTIwZjhlY2M1YmZmYWYyMDc0NGQ0 YzE2MTA2MTk3YjcyMjUyIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MTEtMDkgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgW0VGTF0gUmVtb3ZlIHVubmVjZXNzYXJ5IGNhc3RzIHdoZW4gY3JlYXRpbmcgdGhlIFdl YkNvcmVTdXBwb3J0IG9iamVjdHMgaW4gZXdrX3ZpZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTg5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgQysrIGNvZGUsIHRoZXJlIGlzIG5vIG5l ZWQgdG8gY2FzdCB0aGUgbmV3IG9iamVjdHMgdG8gdGhlaXIKKyAgICAgICAgcGFyZW50cyB3aGVu IGNyZWF0aW5nIHRoZW0uCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAo X2V3a192aWV3X3ByaXZfbmV3KToKKwogMjAxMS0xMS0wNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91 bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIE5lZWQgdG8gcmVwbGFjZSBhcGkn cyBvYmplY3QgcGFyYW1ldGVyIHdpdGggcHJvcGVyIG5hbWUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmNwcAppbmRleCBmZTQ3MzY2MDI0MzRlMmIwOGRlYWEzZDhmYjhlZDVlZGIwNTMxMTM3Li41 YjgwYjIxYzcwNWNlMWEyMDllOWFjNjU1MWM3NGY4ODhmNGE0NzMzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlldy5jcHAKQEAgLTYwMywxMyArNjAzLDEzIEBAIHN0YXRpYyBFd2tfVmlld19Qcml2 YXRlX0RhdGEqIF9ld2tfdmlld19wcml2X25ldyhFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERh dGEpCiAgICAgfQogCiAgICAgV2ViQ29yZTo6UGFnZTo6UGFnZUNsaWVudHMgcGFnZUNsaWVudHM7 Ci0gICAgcGFnZUNsaWVudHMuY2hyb21lQ2xpZW50ID0gc3RhdGljX2Nhc3Q8V2ViQ29yZTo6Q2hy b21lQ2xpZW50Kj4obmV3IFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbChzbWFydERhdGEtPnNlbGYp KTsKLSAgICBwYWdlQ2xpZW50cy5lZGl0b3JDbGllbnQgPSBzdGF0aWNfY2FzdDxXZWJDb3JlOjpF ZGl0b3JDbGllbnQqPihuZXcgV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsKHNtYXJ0RGF0YS0+c2Vs ZikpOwotICAgIHBhZ2VDbGllbnRzLmRyYWdDbGllbnQgPSBzdGF0aWNfY2FzdDxXZWJDb3JlOjpE cmFnQ2xpZW50Kj4obmV3IFdlYkNvcmU6OkRyYWdDbGllbnRFZmwpOwotICAgIHBhZ2VDbGllbnRz Lmluc3BlY3RvckNsaWVudCA9IHN0YXRpY19jYXN0PFdlYkNvcmU6Okluc3BlY3RvckNsaWVudCo+ KG5ldyBXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRFZmwpOworICAgIHBhZ2VDbGllbnRzLmNocm9t ZUNsaWVudCA9IG5ldyBXZWJDb3JlOjpDaHJvbWVDbGllbnRFZmwoc21hcnREYXRhLT5zZWxmKTsK KyAgICBwYWdlQ2xpZW50cy5lZGl0b3JDbGllbnQgPSBuZXcgV2ViQ29yZTo6RWRpdG9yQ2xpZW50 RWZsKHNtYXJ0RGF0YS0+c2VsZik7CisgICAgcGFnZUNsaWVudHMuZHJhZ0NsaWVudCA9IG5ldyBX ZWJDb3JlOjpEcmFnQ2xpZW50RWZsOworICAgIHBhZ2VDbGllbnRzLmluc3BlY3RvckNsaWVudCA9 IG5ldyBXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRFZmw7CiAjaWYgRU5BQkxFKERFVklDRV9PUklF TlRBVElPTikKLSAgICBwYWdlQ2xpZW50cy5kZXZpY2VNb3Rpb25DbGllbnQgPSBzdGF0aWNfY2Fz dDxXZWJDb3JlOjpEZXZpY2VNb3Rpb25DbGllbnQqPihuZXcgV2ViQ29yZTo6RGV2aWNlTW90aW9u Q2xpZW50RWZsKTsKLSAgICBwYWdlQ2xpZW50cy5kZXZpY2VPcmllbnRhdGlvbkNsaWVudCA9IHN0 YXRpY19jYXN0PFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uQ2xpZW50Kj4obmV3IFdlYkNvcmU6 OkRldmljZU9yaWVudGF0aW9uQ2xpZW50RWZsKTsKKyAgICBwYWdlQ2xpZW50cy5kZXZpY2VNb3Rp b25DbGllbnQgPSBuZXcgV2ViQ29yZTo6RGV2aWNlTW90aW9uQ2xpZW50RWZsOworICAgIHBhZ2VD bGllbnRzLmRldmljZU9yaWVudGF0aW9uQ2xpZW50ID0gbmV3IFdlYkNvcmU6OkRldmljZU9yaWVu dGF0aW9uQ2xpZW50RWZsOwogI2VuZGlmCiAgICAgcHJpdi0+cGFnZSA9IG5ldyBXZWJDb3JlOjpQ YWdlKHBhZ2VDbGllbnRzKTsKICAgICBpZiAoIXByaXYtPnBhZ2UpIHsK