71890 2011-11-09 04:55:11 -0800 [GTK][DRT] window internals object is not reset after each test 2011-11-09 12:11:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo mrobinson ossy pnormand webkit.review.bot oldest_to_newest 498832 0 pnormand 2011-11-09 04:55:11 -0800 If a test for instance modifies the Pagination setting, the next tests not explicitely resetting that setting will fail or simply appear flaky. Proper fix would be to call WebCoreTestSupport::resetInternalsObject() when needed, like mac and qt do... 498835 1 114252 pnormand 2011-11-09 04:58:36 -0800 Created attachment 114252 proposed patch 498839 2 114252 xan.lopez 2011-11-09 05:05:55 -0800 Comment on attachment 114252 proposed patch Dunno if it makes sense to share this with Qt or not, but looks good to me. Good catch. 498842 3 webkit.review.bot 2011-11-09 05:07:30 -0800 Attachment 114252 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:70: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 498849 4 pnormand 2011-11-09 05:15:05 -0800 Committed r99691: <http://trac.webkit.org/changeset/99691> 499006 5 ossy 2011-11-09 08:44:18 -0800 (In reply to comment #4) > Committed r99691: <http://trac.webkit.org/changeset/99691> It broke the GTK build: ./.libs/libwebkitgtk-3.0.so: undefined reference to `WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*)' 499017 6 pnormand 2011-11-09 08:54:28 -0800 (In reply to comment #5) > (In reply to comment #4) > > Committed r99691: <http://trac.webkit.org/changeset/99691> > > It broke the GTK build: > > ./.libs/libwebkitgtk-3.0.so: undefined reference to `WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*)' A clean build is in progress to confirm that. It passed on the Debug bots though... 499158 7 pnormand 2011-11-09 11:07:22 -0800 Turns out this broke non GNU-Gold builds. Sorry! Working on a follow-up patch 499215 8 114334 pnormand 2011-11-09 11:55:15 -0800 Created attachment 114334 updated patch 499229 9 114334 mrobinson 2011-11-09 12:05:55 -0800 Comment on attachment 114334 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=114334&action=review Thank you! > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:727 > + JSGlobalContextRef globalContext = webkit_web_frame_get_global_context(mainFrame); > + WebCoreTestSupport::resetInternalsObject(globalContext); Can probably just be one line. 499234 10 pnormand 2011-11-09 12:11:22 -0800 Committed r99748: <http://trac.webkit.org/changeset/99748> 114252 2011-11-09 04:58:36 -0800 2011-11-09 11:11:47 -0800 proposed patch proposed-patch.patch text/plain 4250 pnormand RnJvbSBlZGY5NWVhMGUzNjAxZmQwZjY2YWE4MTI3N2JjMmRlYzBkY2FmMzVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDkgTm92IDIwMTEgMTM6NTg6MDEgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L0R1 bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIC4u Li9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmggIHwgICAgMiAr KwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDEwICsrKysrKysrKysKIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5j cHAgICAgICAgIHwgICAgMiArKwogNSBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAw IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA5Y2QzNmRhLi5iZTVjYjA2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDkgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW0RSVF0gd2luZG93IGlu dGVybmFscyBvYmplY3QgaXMgbm90IHJlc2V0IGFmdGVyIGVhY2ggdGVzdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE4OTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEUlRTdXBwb3J0IGluZnJhc3RydWN0 dXJlIHRvIHJlc2V0IHRoZSBJbnRlcm5hbHMgb2JqZWN0LCBsaWtlIGluIFF0LgorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAg KER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6cmVzZXRJbnRlcm5hbHNPYmplY3QpOgorICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oOgorCiAyMDExLTEx LTA3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBzdGF0 aWMgInBvbGljeSIgc3RhdGUgZnJvbSBTZWN1cml0eU9yaWdpbi5jcHAgdG8gU2VjdXJpdHlQb2xp Y3kuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAppbmRleCA4NzBhNTJlLi4zNDFmNTRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJl ZVN1cHBvcnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1 bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTY3LDYgKzY3LDcgQEAKICNpbmNsdWRlICJ3 ZWJraXR3ZWJ2aWV3LmgiCiAjaW5jbHVkZSAid2Via2l0d2Vidmlld3ByaXZhdGUuaCIKICNpbmNs dWRlIDxKYXZhU2NyaXB0Q29yZS9BUElDYXN0Lmg+CisjaW5jbHVkZSAiV2ViQ29yZVRlc3RTdXBw b3J0LmgiCiAKICNpZiBFTkFCTEUoU1ZHKQogI2luY2x1ZGUgIlNWR0RvY3VtZW50RXh0ZW5zaW9u cy5oIgpAQCAtODkwLDMgKzg5MSwxOCBAQCBpbnQgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpu dW1iZXJPZlBlbmRpbmdHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0cyhXZWJLaQogICAgIHJl dHVybiAwOwogI2VuZGlmCiB9CisKK3ZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpyZXNl dEludGVybmFsc09iamVjdChXZWJLaXRXZWJGcmFtZSogZnJhbWUpCit7CisgICAgRnJhbWUqIGNv cmVGcmFtZSA9IGNvcmUoZnJhbWUpOworICAgIGlmICghY29yZUZyYW1lKQorICAgICAgICByZXR1 cm47CisKKyAgICBKU0xvY2sgbG9jayhTaWxlbmNlQXNzZXJ0aW9uc09ubHkpOworCisgICAgSlNH bG9iYWxDb250ZXh0UmVmIGdsb2JhbENvbnRleHQgPSB3ZWJraXRfd2ViX2ZyYW1lX2dldF9nbG9i YWxfY29udGV4dChmcmFtZSk7CisgICAgRXhlY1N0YXRlKiBleGVjID0gdG9KUyhnbG9iYWxDb250 ZXh0KTsKKworICAgIEpTQ29udGV4dFJlZiBjb250ZXh0ID0gdG9SZWYoZXhlYyk7CisgICAgV2Vi Q29yZVRlc3RTdXBwb3J0OjpyZXNldEludGVybmFsc09iamVjdChjb250ZXh0KTsKK30KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3Vw cG9ydEd0ay5oIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRy ZWVTdXBwb3J0R3RrLmgKaW5kZXggY2M5Y2M5Ny4uZDVjMmY1NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKKysr IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmgKQEAgLTEyNiw2ICsxMjYsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0TW9j a0dlb2xvY2F0aW9uRXJyb3IoV2ViS2l0V2ViVmlldyosIGludCBlcnJvckNvZGUsIGNvbnN0IGdj aGFyKiBlcnJvck1lc3NhZ2UpOwogICAgIHN0YXRpYyBpbnQgbnVtYmVyT2ZQZW5kaW5nR2VvbG9j YXRpb25QZXJtaXNzaW9uUmVxdWVzdHMoV2ViS2l0V2ViVmlldyopOwogCisgICAgc3RhdGljIHZv aWQgcmVzZXRJbnRlcm5hbHNPYmplY3QoV2ViS2l0V2ViRnJhbWUqKTsKKwogcHJpdmF0ZToKICAg ICBzdGF0aWMgYm9vbCBzX2RydFJ1bjsKICAgICBzdGF0aWMgYm9vbCBzX2xpbmtzSW5jbHVkZWRJ blRhYkNoYWluOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IGVhYTViMGQuLjlkZjM2ZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMS0wOSAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bRFJUXSB3aW5k b3cgaW50ZXJuYWxzIG9iamVjdCBpcyBub3QgcmVzZXQgYWZ0ZXIgZWFjaCB0ZXN0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTg5MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv Z3RrL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHJ1blRlc3QpOiByZXNldCB0aGUgSW50 ZXJuYWxzIG9iamVjdCBhZnRlciBlYWNoIHRlc3QuCisKIDIwMTEtMTEtMDkgIFRvciBBcm5lIFZl c3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gRG9uJ3Qg b3ZlcnJpZGUgY29uZmlnIGZvciB0aGUgYnVpbGRfcGFzcyBvZiBkZWJ1Z19hbmRfcmVsZWFzZQpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggYTRlY2E5 Ny4uM2RkMzYwMCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5k ZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwCkBAIC03MjMsNiArNzIzLDggQEAgc3RhdGljIHZvaWQgcnVuVGVzdChjb25zdCBzdHJpbmcm IHRlc3RQYXRoT3JVUkwpCiAgICAgICAgIHdlYlZpZXdMaXN0ID0gMDsKICAgICB9CiAKKyAgICBE dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnJlc2V0SW50ZXJuYWxzT2JqZWN0KG1haW5GcmFtZSk7 CisKICAgICAvLyBBIGJsYW5rIGxvYWQgc2VlbXMgdG8gYmUgbmVjZXNzYXJ5IHRvIHJlc2V0IHN0 YXRlIGFmdGVyIGNlcnRhaW4gdGVzdHMuCiAgICAgd2Via2l0X3dlYl92aWV3X29wZW4od2ViVmll dywgImFib3V0OmJsYW5rIik7CiAKLS0gCjEuNy43LjE= 114334 2011-11-09 11:55:15 -0800 2011-11-09 12:05:55 -0800 updated patch updated-patch.patch text/plain 5816 pnormand RnJvbSA5MmIxNzg2Mjk4ZTk0OTAyNDhkOTYzMzE2YmE1NTNlYjQyMDcyNmMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDkgTm92IDIwMTEgMjA6NTQ6NDMgKzAxMDAKU3ViamVjdDogW1BBVENIXSB1 cGRhdGVkIHBhdGNoCgotLS0KIENoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAgOSArKysrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL1dlYkNvcmVT dXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAgICAgfCAgIDE2IC0tLS0tLS0tLS0t LS0tLS0KIC4uLi9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgg IHwgICAgMiAtLQogU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlciAgICAgICAgICAgICAg ICAgICAgfCAgICAxIC0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RHVtcFJlbmRlclRyZWUuY3BwICAgICAgICB8ICAgIDMgKystCiA3IGZpbGVzIGNoYW5nZWQsIDM1 IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCA4NGEyYjQxLi5jNzc3ODE2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMTEtMDkgIFBoaWxpcHBlIE5v cm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdW0RSVF0gd2luZG93 IGludGVybmFscyBvYmplY3QgaXMgbm90IHJlc2V0IGFmdGVyIGVhY2ggdGVzdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE4OTAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMv c3ltYm9scy5maWx0ZXI6IFJldmVydCB1bi1uZWVkZWQgc3ltYm9sLgorCisyMDExLTExLTA5ICBQ aGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmll d2VkLCBhdHRlbXB0IHRvIGZpeCBHVEsgMzItYml0cyBSZWxlYXNlIGJ1aWxkIGFmdGVyIHI5OTY5 MS4KIAogICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXI6IEFkZCB0aGUg bWlzc2luZyBzeW1ib2wgZm9yIHJlc2V0SW50ZXJuYWxzT2JqZWN0LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmlu ZGV4IDJkM2JiMzkuLmQ5YzE4MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTMsNiArMywxNyBAQAog ICAgICAgICBbR1RLXVtEUlRdIHdpbmRvdyBpbnRlcm5hbHMgb2JqZWN0IGlzIG5vdCByZXNldCBh ZnRlciBlYWNoIHRlc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcxODkwCiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwOiBSZW1v dmUgcHJvYmxlbWF0aWMKKyAgICAgICAgY2FsbHMgdG8gV2ViQ29yZVN1cHBvcnQgd2hpY2ggYmVs b25ncyB0byBsaWJXZWJDb3JlSW50ZXJuYWxzLCBub3QgbGlid2Via2l0Z3RrLgorICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oOgorCisyMDExLTExLTA5 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtEUlRdIHdpbmRvdyBpbnRlcm5hbHMgb2JqZWN0IGlzIG5vdCByZXNldCBhZnRlciBlYWNoIHRl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxODkw CisKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgogCiAgICAgICAgIERSVFN1cHBvcnQg aW5mcmFzdHJ1Y3R1cmUgdG8gcmVzZXQgdGhlIEludGVybmFscyBvYmplY3QsIGxpa2UgaW4gUXQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcAppbmRleCAzYWNjY2VjLi44NzBhNTJlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0ay5jcHAKQEAgLTU5LDcgKzU5LDYgQEAKICNpbmNsdWRlICJTZWN1cml0 eVBvbGljeS5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCiAjaW5jbHVkZSAiVGV4dEl0ZXJhdG9y LmgiCi0jaW5jbHVkZSAiV2ViQ29yZVRlc3RTdXBwb3J0LmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9N UmFuZ2VQcml2YXRlLmgiCiAjaW5jbHVkZSAiV29ya2VyVGhyZWFkLmgiCiAjaW5jbHVkZSAid2Vi a2l0Z2xvYmFsc3ByaXZhdGUuaCIKQEAgLTg5MSwxOCArODkwLDMgQEAgaW50IER1bXBSZW5kZXJU cmVlU3VwcG9ydEd0azo6bnVtYmVyT2ZQZW5kaW5nR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVz dHMoV2ViS2kKICAgICByZXR1cm4gMDsKICNlbmRpZgogfQotCi12b2lkIER1bXBSZW5kZXJUcmVl U3VwcG9ydEd0azo6cmVzZXRJbnRlcm5hbHNPYmplY3QoV2ViS2l0V2ViRnJhbWUqIGZyYW1lKQot ewotICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKGZyYW1lKTsKLSAgICBpZiAoIWNvcmVGcmFt ZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgSlNMb2NrIGxvY2soU2lsZW5jZUFzc2VydGlvbnNP bmx5KTsKLQotICAgIEpTR2xvYmFsQ29udGV4dFJlZiBnbG9iYWxDb250ZXh0ID0gd2Via2l0X3dl Yl9mcmFtZV9nZXRfZ2xvYmFsX2NvbnRleHQoZnJhbWUpOwotICAgIEV4ZWNTdGF0ZSogZXhlYyA9 IHRvSlMoZ2xvYmFsQ29udGV4dCk7Ci0KLSAgICBKU0NvbnRleHRSZWYgY29udGV4dCA9IHRvUmVm KGV4ZWMpOwotICAgIFdlYkNvcmVUZXN0U3VwcG9ydDo6cmVzZXRJbnRlcm5hbHNPYmplY3QoY29u dGV4dCk7Ci19CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuaCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBw b3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oCmluZGV4IGQ1YzJmNTcuLmNjOWNjOTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVl U3VwcG9ydEd0ay5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBS ZW5kZXJUcmVlU3VwcG9ydEd0ay5oCkBAIC0xMjYsOCArMTI2LDYgQEAgcHVibGljOgogICAgIHN0 YXRpYyB2b2lkIHNldE1vY2tHZW9sb2NhdGlvbkVycm9yKFdlYktpdFdlYlZpZXcqLCBpbnQgZXJy b3JDb2RlLCBjb25zdCBnY2hhciogZXJyb3JNZXNzYWdlKTsKICAgICBzdGF0aWMgaW50IG51bWJl ck9mUGVuZGluZ0dlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RzKFdlYktpdFdlYlZpZXcqKTsK IAotICAgIHN0YXRpYyB2b2lkIHJlc2V0SW50ZXJuYWxzT2JqZWN0KFdlYktpdFdlYkZyYW1lKik7 Ci0KIHByaXZhdGU6CiAgICAgc3RhdGljIGJvb2wgc19kcnRSdW47CiAgICAgc3RhdGljIGJvb2wg c19saW5rc0luY2x1ZGVkSW5UYWJDaGFpbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9hdXRvdG9vbHMv c3ltYm9scy5maWx0ZXIgYi9Tb3VyY2UvYXV0b3Rvb2xzL3N5bWJvbHMuZmlsdGVyCmluZGV4IDk5 MDMxZjAuLjMyYTRkOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0 ZXIKKysrIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgpAQCAtODEsNyArODEsNiBA QCBfWk43V2ViQ29yZTE0U2Nyb2xsYWJsZUFyZWEyOHNldFNjcm9sbE9mZnNldEZyb21JbnRlcm5h bHNFUktOU184SW50UG9pbnRFOwogX1pON1dlYkNvcmUxMFNjcm9sbFZpZXcyM3NldFNjcm9sbGJh cnNTdXBwcmVzc2VkRWJiOwogX1pON1dlYkNvcmU5RnJhbWVWaWV3MTdwYWludENvbnRyb2xUaW50 c0V2OwogX1pON1dlYkNvcmU5RnJhbWVWaWV3MTlzY3JvbGxFbGVtZW50VG9SZWN0RVBOU183RWxl bWVudEVSS05TXzdJbnRSZWN0RTsKLV9aTjE4V2ViQ29yZVRlc3RTdXBwb3J0MjByZXNldEludGVy bmFsc09iamVjdEVQSzE1T3BhcXVlSlNDb250ZXh0OwogbG9jYWw6CiBfWio7CiBjdGkqOwpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGJmNzE4MDAu LmY0MTBmZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0xMS0wOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bRFJUXSB3aW5kb3cgaW50ZXJuYWxzIG9i amVjdCBpcyBub3QgcmVzZXQgYWZ0ZXIgZWFjaCB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgV2ViQ29yZVRlc3RTdXBwb3J0OjpyZXNldElu dGVybmFsc09iamVjdCB3aXRob3V0IGdvaW5nCisgICAgICAgIHRocm91Z2ggRHVtcFJlbmRlclRy ZWVTdXBwb3J0LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVl LmNwcDoKKyAgICAgICAgKHJ1blRlc3QpOgorCiAyMDExLTExLTA5ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVjdWxhdGl2ZSBidWlsZCBmaXguCmRpZmYgLS1n aXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCAzZGQzNjAwLi41MTRh MjMwIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUu Y3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKQEAg LTcyMyw3ICs3MjMsOCBAQCBzdGF0aWMgdm9pZCBydW5UZXN0KGNvbnN0IHN0cmluZyYgdGVzdFBh dGhPclVSTCkKICAgICAgICAgd2ViVmlld0xpc3QgPSAwOwogICAgIH0KIAotICAgIER1bXBSZW5k ZXJUcmVlU3VwcG9ydEd0azo6cmVzZXRJbnRlcm5hbHNPYmplY3QobWFpbkZyYW1lKTsKKyAgICBK U0dsb2JhbENvbnRleHRSZWYgZ2xvYmFsQ29udGV4dCA9IHdlYmtpdF93ZWJfZnJhbWVfZ2V0X2ds b2JhbF9jb250ZXh0KG1haW5GcmFtZSk7CisgICAgV2ViQ29yZVRlc3RTdXBwb3J0OjpyZXNldElu dGVybmFsc09iamVjdChnbG9iYWxDb250ZXh0KTsKIAogICAgIC8vIEEgYmxhbmsgbG9hZCBzZWVt cyB0byBiZSBuZWNlc3NhcnkgdG8gcmVzZXQgc3RhdGUgYWZ0ZXIgY2VydGFpbiB0ZXN0cy4KICAg ICB3ZWJraXRfd2ViX3ZpZXdfb3Blbih3ZWJWaWV3LCAiYWJvdXQ6YmxhbmsiKTsKLS0gCjEuNy43 LjE=