71852 2011-11-08 13:16:55 -0800 DFG JIT calculation of OSR entry points is not THUMB2 safe 2011-11-08 13:57:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 498388 0 barraclough 2011-11-08 13:16:55 -0800 Executable addresses are tagged with a low bit set to distinguish between THUMB2 and traditional ARM. 498389 1 114141 barraclough 2011-11-08 13:18:26 -0800 Created attachment 114141 Fix 498397 2 114141 barraclough 2011-11-08 13:34:58 -0800 Comment on attachment 114141 Fix Reviewed by Oliver Hunt. 498416 3 barraclough 2011-11-08 13:57:38 -0800 Fixed in r99614 114141 2011-11-08 13:18:26 -0800 2011-11-08 13:34:58 -0800 Fix 71852.patch text/plain 5589 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTk2MTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAK KzIwMTEtMTEtMDggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIERGRyBKSVQgY2FsY3VsYXRpb24gb2YgT1NSIGVudHJ5IHBvaW50cyBpcyBub3Qg VEhVTUIyIHNhZmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxODUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRXhlY3V0YWJsZSBhZGRyZXNzZXMgYXJlIHRhZ2dlZCB3aXRoIGEgbG93IGJpdCBzZXQgdG8g ZGlzdGluZ3Vpc2gKKyAgICAgICAgYmV0d2VlbiBUSFVNQjIgYW5kIHRyYWRpdGlvbmFsIEFSTS4K KworICAgICAgICAqIGRmZy9ERkdKSVRDb21waWxlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6 SklUQ29tcGlsZXI6OmV4aXRTcGVjdWxhdGl2ZVdpdGhPU1IpOgorICAgICAgICAqIGRmZy9ERkdK SVRDb21waWxlcjMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6ZXhp dFNwZWN1bGF0aXZlV2l0aE9TUik6CisgICAgICAgICogZGZnL0RGR09TUkVudHJ5LmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpwcmVwYXJlT1NSRW50cnkpOgorICAgICAgICAqIGppdC9KSVRDb2Rl Lmg6CisgICAgICAgIChKU0M6OkpJVENvZGU6OmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQpOgor ICAgICAgICAoSlNDOjpKSVRDb2RlOjpzdGFydCk6CisgICAgICAgIChKU0M6OkpJVENvZGU6OnNp emUpOgorCiAyMDExLTExLTA4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgog CiAgICAgICAgIEpTQzo6UGFyc2VyOjpQYXJzZXIgbGVha3MgTGV4ZXIgbWVtYmVyCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyMzJfNjQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIzMl82NC5jcHAJ KHJldmlzaW9uIDk5NjA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21w aWxlcjMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEyLDcgKzUxMiw3IEBAIHZvaWQgSklU Q29tcGlsZXI6OmV4aXRTcGVjdWxhdGl2ZVdpdGhPU1IKICAgICAgICAgQVNTRVJUKG1hcHBpbmcp OwogICAgICAgICBBU1NFUlQobWFwcGluZy0+bV9ieXRlY29kZUluZGV4ID09IHJldHVybkJ5dGVj b2RlSW5kZXgpOwogICAgICAgICAKLSAgICAgICAgdm9pZCoganVtcFRhcmdldCA9IHJlaW50ZXJw cmV0X2Nhc3Q8dm9pZCo+KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihiYXNlbGluZUNvZGVC bG9ja0ZvckNhbGxlci0+Z2V0SklUQ29kZSgpLnN0YXJ0KCkpICsgbWFwcGluZy0+bV9tYWNoaW5l Q29kZU9mZnNldCk7CisgICAgICAgIHZvaWQqIGp1bXBUYXJnZXQgPSBiYXNlbGluZUNvZGVCbG9j a0ZvckNhbGxlci0+Z2V0SklUQ29kZSgpLmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQobWFwcGlu Zy0+bV9tYWNoaW5lQ29kZU9mZnNldCk7CiAKICAgICAgICAgR1BSUmVnIGNhbGxlckZyYW1lR1BS OwogICAgICAgICBpZiAoaW5saW5lQ2FsbEZyYW1lLT5jYWxsZXIuaW5saW5lQ2FsbEZyYW1lKSB7 CkBAIC01NDYsNyArNTQ2LDcgQEAgdm9pZCBKSVRDb21waWxlcjo6ZXhpdFNwZWN1bGF0aXZlV2l0 aE9TUgogICAgIEFTU0VSVChtYXBwaW5nKTsKICAgICBBU1NFUlQobWFwcGluZy0+bV9ieXRlY29k ZUluZGV4ID09IGV4aXQubV9jb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXgpOwogICAgIAotICAgIHZv aWQqIGp1bXBUYXJnZXQgPSByZWludGVycHJldF9jYXN0PHZvaWQqPihyZWludGVycHJldF9jYXN0 PHVpbnRwdHJfdD4oYmFzZWxpbmVDb2RlQmxvY2stPmdldEpJVENvZGUoKS5zdGFydCgpKSArIG1h cHBpbmctPm1fbWFjaGluZUNvZGVPZmZzZXQpOworICAgIHZvaWQqIGp1bXBUYXJnZXQgPSBiYXNl bGluZUNvZGVCbG9jay0+Z2V0SklUQ29kZSgpLmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQobWFw cGluZy0+bV9tYWNoaW5lQ29kZU9mZnNldCk7CiAgICAgCiAgICAgQVNTRVJUKEdQUkluZm86OnJl Z1QyICE9IEdQUkluZm86OmNhY2hlZFJlc3VsdFJlZ2lzdGVyICYmIEdQUkluZm86OnJlZ1QyICE9 IEdQUkluZm86OmNhY2hlZFJlc3VsdFJlZ2lzdGVyMik7CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkocmV2aXNpb24gOTk2MDkpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzU2LDcgKzc1Niw3IEBAIHZvaWQgSklUQ29tcGlsZXI6OmV4aXRTcGVjdWxhdGl2 ZVdpdGhPU1IKICAgICAgICAgQVNTRVJUKG1hcHBpbmcpOwogICAgICAgICBBU1NFUlQobWFwcGlu Zy0+bV9ieXRlY29kZUluZGV4ID09IHJldHVybkJ5dGVjb2RlSW5kZXgpOwogICAgICAgICAKLSAg ICAgICAgdm9pZCoganVtcFRhcmdldCA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KHJlaW50ZXJw cmV0X2Nhc3Q8dWludHB0cl90PihiYXNlbGluZUNvZGVCbG9ja0ZvckNhbGxlci0+Z2V0SklUQ29k ZSgpLnN0YXJ0KCkpICsgbWFwcGluZy0+bV9tYWNoaW5lQ29kZU9mZnNldCk7CisgICAgICAgIHZv aWQqIGp1bXBUYXJnZXQgPSBiYXNlbGluZUNvZGVCbG9ja0ZvckNhbGxlci0+Z2V0SklUQ29kZSgp LmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQobWFwcGluZy0+bV9tYWNoaW5lQ29kZU9mZnNldCk7 CiAKICAgICAgICAgR1BSUmVnIGNhbGxlckZyYW1lR1BSOwogICAgICAgICBpZiAoaW5saW5lQ2Fs bEZyYW1lLT5jYWxsZXIuaW5saW5lQ2FsbEZyYW1lKSB7CkBAIC03ODYsNyArNzg2LDcgQEAgdm9p ZCBKSVRDb21waWxlcjo6ZXhpdFNwZWN1bGF0aXZlV2l0aE9TUgogICAgIEFTU0VSVChtYXBwaW5n KTsKICAgICBBU1NFUlQobWFwcGluZy0+bV9ieXRlY29kZUluZGV4ID09IGV4aXQubV9jb2RlT3Jp Z2luLmJ5dGVjb2RlSW5kZXgpOwogICAgIAotICAgIHZvaWQqIGp1bXBUYXJnZXQgPSByZWludGVy cHJldF9jYXN0PHZvaWQqPihyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4oYmFzZWxpbmVDb2Rl QmxvY2stPmdldEpJVENvZGUoKS5zdGFydCgpKSArIG1hcHBpbmctPm1fbWFjaGluZUNvZGVPZmZz ZXQpOworICAgIHZvaWQqIGp1bXBUYXJnZXQgPSBiYXNlbGluZUNvZGVCbG9jay0+Z2V0SklUQ29k ZSgpLmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQobWFwcGluZy0+bV9tYWNoaW5lQ29kZU9mZnNl dCk7CiAgICAgCiAgICAgQVNTRVJUKEdQUkluZm86OnJlZ1QxICE9IEdQUkluZm86OmNhY2hlZFJl c3VsdFJlZ2lzdGVyKTsKICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRW50cnkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T1NSRW50cnkuY3BwCShyZXZpc2lvbiA5OTYwOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHT1NSRW50cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzgsNyArMTM4LDcgQEAgdm9p ZCogcHJlcGFyZU9TUkVudHJ5KEV4ZWNTdGF0ZSogZXhlYywgQwogICAgIAogICAgIC8vIDQpIEZp bmQgYW5kIHJldHVybiB0aGUgZGVzdGluYXRpb24gbWFjaGluZSBjb2RlIGFkZHJlc3MuCiAgICAg Ci0gICAgdm9pZCogcmVzdWx0ID0gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4ocmVpbnRlcnByZXRf Y2FzdDx1aW50cHRyX3Q+KGNvZGVCbG9jay0+Z2V0SklUQ29kZSgpLnN0YXJ0KCkpICsgZW50cnkt Pm1fbWFjaGluZUNvZGVPZmZzZXQpOworICAgIHZvaWQqIHJlc3VsdCA9IGNvZGVCbG9jay0+Z2V0 SklUQ29kZSgpLmV4ZWN1dGFibGVBZGRyZXNzQXRPZmZzZXQoZW50cnktPm1fbWFjaGluZUNvZGVP ZmZzZXQpOwogICAgIAogI2lmIEVOQUJMRShKSVRfVkVSQk9TRV9PU1IpCiAgICAgcHJpbnRmKCIg ICAgT1NSIHJldHVybmluZyBtYWNoaW5lIGNvZGUgYWRkcmVzcyAlcC5cbiIsIHJlc3VsdCk7Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaAkocmV2aXNpb24gOTk2MDkpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuaAkod29ya2luZyBjb3B5KQpAQCAtODcs NiArODcsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICByZXR1cm4gbV9yZWYuY29k ZSgpOwogICAgICAgICB9CiAKKyAgICAgICAgdm9pZCogZXhlY3V0YWJsZUFkZHJlc3NBdE9mZnNl dChzaXplX3Qgb2Zmc2V0KSBjb25zdAorICAgICAgICB7CisgICAgICAgICAgICBBU1NFUlQob2Zm c2V0IDwgc2l6ZSgpKTsKKyAgICAgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PGNoYXIq PihtX3JlZi5jb2RlKCkuZXhlY3V0YWJsZUFkZHJlc3MoKSkgKyBvZmZzZXQ7CisgICAgICAgIH0K KwogICAgICAgICAvLyBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIG9mZnNldCBpbiBieXRlcyBv ZiAncG9pbnRlckludG9Db2RlJyBpbnRvCiAgICAgICAgIC8vIHRoaXMgYmxvY2sgb2YgY29kZS4g IFRoZSBwb2ludGVyIHByb3ZpZGVkIG11c3QgYmUgYSBwb2ludGVyIGludG8gdGhpcwogICAgICAg ICAvLyBibG9jayBvZiBjb2RlLiAgSXQgaXMgQVNTRVJUZWQgdGhhdCBubyBjb2RlYmxvY2sgPjRn YiBpbiBzaXplLgpAQCAtMTA0LDEyICsxMTAsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAg ICAgICByZXR1cm4gZ2xvYmFsRGF0YS0+ZXhjZXB0aW9uID8ganNOdWxsKCkgOiByZXN1bHQ7CiAg ICAgICAgIH0KIAotICAgICAgICB2b2lkKiBzdGFydCgpCisgICAgICAgIHZvaWQqIHN0YXJ0KCkg Y29uc3QKICAgICAgICAgewogICAgICAgICAgICAgcmV0dXJuIG1fcmVmLmNvZGUoKS5kYXRhTG9j YXRpb24oKTsKICAgICAgICAgfQogCi0gICAgICAgIHNpemVfdCBzaXplKCkKKyAgICAgICAgc2l6 ZV90IHNpemUoKSBjb25zdAogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQobV9yZWYuY29k ZSgpLmV4ZWN1dGFibGVBZGRyZXNzKCkpOwogICAgICAgICAgICAgcmV0dXJuIG1fcmVmLnNpemUo KTsK