71844 2011-11-08 11:58:43 -0800 Move NSRange / DOMRange functions back to WebFrameInternal 2011-11-08 16:13:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck ap joepeck webkit.review.bot oldest_to_newest 498305 0 joepeck 2011-11-08 11:58:43 -0800 The concern was that these methods can easily be used incorrectly because they depend on selection, and exposing them as SPI is a bad idea. So moving them back to Internal. At least we got rid of a couple methods (the ones mentioning Dictionary.app)! 498309 1 114129 joepeck 2011-11-08 12:00:31 -0800 Created attachment 114129 [PATCH] Move Functions 498496 2 114129 webkit.review.bot 2011-11-08 16:13:31 -0800 Comment on attachment 114129 [PATCH] Move Functions Clearing flags on attachment: 114129 Committed r99628: <http://trac.webkit.org/changeset/99628> 498497 3 webkit.review.bot 2011-11-08 16:13:35 -0800 All reviewed patches have been landed. Closing bug. 114129 2011-11-08 12:00:31 -0800 2011-11-08 16:13:30 -0800 [PATCH] Move Functions internal.patch text/plain 3313 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCA0MTA3NWZlLi43ZjA1MjJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTEtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBNb3ZlIE5TUmFuZ2UgLyBET01SYW5nZSBmdW5jdGlvbnMgYmFj ayB0byBXZWJGcmFtZUludGVybmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MTg0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy9XZWJGcmFtZS5tbToKKyAgICAgICAgKC1bV2ViRnJhbWUg X2NvbnZlcnROU1JhbmdlVG9ET01SYW5nZTpdKToKKyAgICAgICAgKC1bV2ViRnJhbWUgX2NvbnZl cnRET01SYW5nZVRvTlNSYW5nZTpdKToKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lSW50ZXJu YWwuaDoKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lUHJpdmF0ZS5oOgorCiAyMDExLTExLTA3 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBEb21haW5S ZWxheGF0aW9uRm9yYmlkZGVuIHNjaGVtZSByZWdpc3RyeSB0byBTY2hlbWVSZWdpc3RyeQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbSBiL1NvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KaW5kZXggYjc3MGEzZC4uOTRkODYzNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCkBAIC02ODgsNiArNjg4LDE2IEBAIHN0 YXRpYyBpbmxpbmUgV2ViRGF0YVNvdXJjZSAqZGF0YVNvdXJjZShEb2N1bWVudExvYWRlciogbG9h ZGVyKQogICAgIHJldHVybiBUZXh0SXRlcmF0b3I6OnJhbmdlRnJvbUxvY2F0aW9uQW5kTGVuZ3Ro KF9wcml2YXRlLT5jb3JlRnJhbWUtPnNlbGVjdGlvbigpLT5yb290RWRpdGFibGVFbGVtZW50T3JE b2N1bWVudEVsZW1lbnQoKSwgbnNyYW5nZS5sb2NhdGlvbiwgbnNyYW5nZS5sZW5ndGgpOwogfQog CistIChET01SYW5nZSAqKV9jb252ZXJ0TlNSYW5nZVRvRE9NUmFuZ2U6KE5TUmFuZ2UpbnNyYW5n ZQoreworICAgIHJldHVybiBraXQoW3NlbGYgX2NvbnZlcnRUb0RPTVJhbmdlOm5zcmFuZ2VdLmdl dCgpKTsKK30KKworLSAoTlNSYW5nZSlfY29udmVydERPTVJhbmdlVG9OU1JhbmdlOihET01SYW5n ZSAqKXJhbmdlCit7CisgICAgcmV0dXJuIFtzZWxmIF9jb252ZXJ0VG9OU1JhbmdlOmNvcmUocmFu Z2UpXTsKK30KKwogLSAoRE9NUmFuZ2UgKilfbWFya0RPTVJhbmdlCiB7CiAgICAgcmV0dXJuIGtp dChfcHJpdmF0ZS0+Y29yZUZyYW1lLT5lZGl0b3IoKS0+bWFyaygpLnRvTm9ybWFsaXplZFJhbmdl KCkuZ2V0KCkpOwpAQCAtOTAzLDE2ICs5MTMsNiBAQCBzdGF0aWMgaW5saW5lIFdlYkRhdGFTb3Vy Y2UgKmRhdGFTb3VyY2UoRG9jdW1lbnRMb2FkZXIqIGxvYWRlcikKICAgICAgICAgX3ByaXZhdGUt PmNvcmVGcmFtZS0+c2VsZWN0aW9uKCktPnNldFNlbGVjdGlvbihWaXNpYmxlU2VsZWN0aW9uKGRv bVJhbmdlLmdldCgpLCBTRUxfREVGQVVMVF9BRkZJTklUWSkpOwogfQogCi0tIChET01SYW5nZSAq KV9jb252ZXJ0TlNSYW5nZVRvRE9NUmFuZ2U6KE5TUmFuZ2UpbnNyYW5nZQotewotICAgIHJldHVy biBraXQoW3NlbGYgX2NvbnZlcnRUb0RPTVJhbmdlOm5zcmFuZ2VdLmdldCgpKTsKLX0KLQotLSAo TlNSYW5nZSlfY29udmVydERPTVJhbmdlVG9OU1JhbmdlOihET01SYW5nZSAqKXJhbmdlCi17Ci0g ICAgcmV0dXJuIFtzZWxmIF9jb252ZXJ0VG9OU1JhbmdlOmNvcmUocmFuZ2UpXTsKLX0KLQogLSAo Qk9PTClfaXNEaXNwbGF5aW5nU3RhbmRhbG9uZUltYWdlCiB7CiAgICAgRG9jdW1lbnQqIGRvY3Vt ZW50ID0gX3ByaXZhdGUtPmNvcmVGcmFtZS0+ZG9jdW1lbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWVJbnRlcm5hbC5oIGIvU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJGcmFtZUludGVybmFsLmgKaW5kZXggZTJmNzIyOC4uNTVmNGYyMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZUludGVybmFsLmgKKysr IGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZUludGVybmFsLmgKQEAgLTEzMCw2 ICsxMzAsOSBAQCBXZWJWaWV3ICpnZXRXZWJWaWV3KFdlYkZyYW1lICp3ZWJGcmFtZSk7CiAtIChO U1N0cmluZyAqKV9zZWxlY3RlZFN0cmluZzsKIC0gKE5TU3RyaW5nICopX3N0cmluZ0ZvclJhbmdl OihET01SYW5nZSAqKXJhbmdlOwogCistIChET01SYW5nZSAqKV9jb252ZXJ0TlNSYW5nZVRvRE9N UmFuZ2U6KE5TUmFuZ2UpcmFuZ2U7CistIChOU1JhbmdlKV9jb252ZXJ0RE9NUmFuZ2VUb05TUmFu Z2U6KERPTVJhbmdlICopcmFuZ2U7CisKIC0gKE5TU3RyaW5nICopX21hcmt1cFN0cmluZ0Zyb21S YW5nZTooRE9NUmFuZ2UgKilyYW5nZSBub2RlczooTlNBcnJheSAqKilub2RlczsKIAogLSAoTlNS ZWN0KV9jYXJldFJlY3RBdFBvc2l0aW9uOihjb25zdCBXZWJDb3JlOjpQb3NpdGlvbiYpcG9zIGFm ZmluaXR5OihOU1NlbGVjdGlvbkFmZmluaXR5KWFmZmluaXR5OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViRnJhbWVQcml2YXRlLmgKaW5kZXggZmJmY2Q3Yi4uOThkYmI3MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVByaXZhdGUuaAorKysgYi9T b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lUHJpdmF0ZS5oCkBAIC04Myw5ICs4Myw2 IEBAIHR5cGVkZWYgZW51bSB7CiAtIChOU1JhbmdlKV9zZWxlY3RlZE5TUmFuZ2U7CiAtICh2b2lk KV9zZWxlY3ROU1JhbmdlOihOU1JhbmdlKXJhbmdlOwogCi0tIChET01SYW5nZSAqKV9jb252ZXJ0 TlNSYW5nZVRvRE9NUmFuZ2U6KE5TUmFuZ2UpcmFuZ2U7Ci0tIChOU1JhbmdlKV9jb252ZXJ0RE9N UmFuZ2VUb05TUmFuZ2U6KERPTVJhbmdlICopcmFuZ2U7Ci0KIC0gKEJPT0wpX2lzRGlzcGxheWlu Z1N0YW5kYWxvbmVJbWFnZTsKIAogLSAodW5zaWduZWQpX3BlbmRpbmdGcmFtZVVubG9hZEV2ZW50 Q291bnQ7Cg==