71842 2011-11-08 11:42:59 -0800 Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar. 2011-11-09 07:30:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 asvitkine webkit-unassigned fishd pfeldman webkit.review.bot yurys oldest_to_newest 498291 0 asvitkine 2011-11-08 11:42:59 -0800 Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar. 498292 1 114125 asvitkine 2011-11-08 11:44:34 -0800 Created attachment 114125 Patch 498296 2 webkit.review.bot 2011-11-08 11:47:54 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 498393 3 114125 fishd 2011-11-08 13:21:38 -0800 Comment on attachment 114125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114125&action=review > Source/WebKit/chromium/public/WebDevToolsFrontendClient.h:52 > + virtual void moveWindowBy(float x, float y) { } nit: had you considered using WebFloatPoint? 498903 4 114265 asvitkine 2011-11-09 06:51:16 -0800 Created attachment 114265 Patch 498904 5 asvitkine 2011-11-09 06:51:45 -0800 As suggested by Darin, here's a version of the patch that uses WebFloatPoint. 498935 6 asvitkine 2011-11-09 07:22:35 -0800 Can I get a commit-queue+? 498941 7 pfeldman 2011-11-09 07:30:54 -0800 Committed r99714: <http://trac.webkit.org/changeset/99714> 114125 2011-11-08 11:44:34 -0800 2011-11-09 06:51:09 -0800 Patch bug-71842-20111108144432.patch text/plain 2155 asvitkine SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5OTU5OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTEtMDggIEFsZXhlaSBTdml0a2luZSAgPGFzdml0a2luZUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQ2hyb21pdW06IEFkZCBwbHVtYmluZyB0byBlbmFibGUgZHJhZ2dpbmcgZGV2 IHRvb2xzIHZpYSB0aGUgZW1wdHkgc3BhY2Ugb24gdGhlIHRvb2xiYXIuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTg0MgorCisgICAgICAgIFRoZXNl IGFyZSB0aGUgb25seSBXZWJLaXQtc2lkZSBjaGFuZ2VzIG5lZWRlZC4gVGhlIHJlc3Qgd2lsbCBi ZSBkb25lIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorCisgICAgICAgIENocm9taXVtIGJ1ZzogaHR0 cDovL2NyYnVnLmNvbS80NDM1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaDoKKyAgICAg ICAgKFdlYktpdDo6V2ViRGV2VG9vbHNGcm9udGVuZENsaWVudDo6bW92ZVdpbmRvd0J5KToKKyAg ICAgICAgKiBzcmMvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsOjptb3ZlV2luZG93QnkpOgorCiAyMDEx LTExLTA4ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGRpc3BsYXkgbm90aWZpY2F0aW9uIGluIHRoZSBmcm9udC1lbmQgd2hl biBpbnNwZWN0ZWQgd29ya2VyIHRlcm1pbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgJKHJl dmlzaW9uIDk5NTk1KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9v bHNGcm9udGVuZENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw3IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgY2xvc2VXaW5kb3coKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQg cmVxdWVzdERvY2tXaW5kb3coKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFVuZG9ja1dp bmRvdygpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBtb3ZlV2luZG93QnkoZmxvYXQgeCwgZmxvYXQg eSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIHNhdmVBcyhjb25zdCBXZWJTdHJpbmcmIGZpbGVOYW1l LCBjb25zdCBXZWJTdHJpbmcmIGNvbnRlbnQpIHsgfQogCiAgICAgdmlydHVhbCBib29sIHNob3Vs ZEhpZGVTY3JpcHRzUGFuZWwoKSB7IHJldHVybiBmYWxzZTsgfQpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JbnNwZWN0b3JGcm9udGVuZENsaWVudElt cGwuY3BwCShyZXZpc2lvbiA5OTU5NSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lu c3BlY3RvckZyb250ZW5kQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxLDYgKzgx LDcgQEAgdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudEltcGw6OmZyb250ZQogCiB2b2lkIElu c3BlY3RvckZyb250ZW5kQ2xpZW50SW1wbDo6bW92ZVdpbmRvd0J5KGZsb2F0IHgsIGZsb2F0IHkp CiB7CisgICAgbV9jbGllbnQtPm1vdmVXaW5kb3dCeSh4LCB5KTsKIH0KIAogU3RyaW5nIEluc3Bl Y3RvckZyb250ZW5kQ2xpZW50SW1wbDo6bG9jYWxpemVkU3RyaW5nc1VSTCgpCg== 114265 2011-11-09 06:51:16 -0800 2011-11-09 07:25:56 -0800 Patch bug-71842-20111109095115.patch text/plain 2522 asvitkine SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5OTU5OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTEtMDggIEFsZXhlaSBTdml0a2luZSAgPGFzdml0a2luZUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgQ2hyb21pdW06IEFkZCBwbHVtYmluZyB0byBlbmFibGUgZHJhZ2dpbmcgZGV2 IHRvb2xzIHZpYSB0aGUgZW1wdHkgc3BhY2Ugb24gdGhlIHRvb2xiYXIuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTg0MgorCisgICAgICAgIFRoZXNl IGFyZSB0aGUgb25seSBXZWJLaXQtc2lkZSBjaGFuZ2VzIG5lZWRlZC4gVGhlIHJlc3Qgd2lsbCBi ZSBkb25lIG9uIHRoZSBDaHJvbWl1bSBzaWRlLgorCisgICAgICAgIENocm9taXVtIGJ1ZzogaHR0 cDovL2NyYnVnLmNvbS80NDM1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaDoKKyAgICAg ICAgKFdlYktpdDo6V2ViRGV2VG9vbHNGcm9udGVuZENsaWVudDo6bW92ZVdpbmRvd0J5KToKKyAg ICAgICAgKiBzcmMvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6SW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsOjptb3ZlV2luZG93QnkpOgorCiAyMDEx LTExLTA4ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGRpc3BsYXkgbm90aWZpY2F0aW9uIGluIHRoZSBmcm9udC1lbmQgd2hl biBpbnNwZWN0ZWQgd29ya2VyIHRlcm1pbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgJKHJl dmlzaW9uIDk5NTk1KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9v bHNGcm9udGVuZENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiBuYW1l c3BhY2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViU3RyaW5nOworc3RydWN0IFdlYkZsb2F0UG9pbnQ7 CiBzdHJ1Y3QgV2ViRGV2VG9vbHNNZXNzYWdlRGF0YTsKIAogY2xhc3MgV2ViRGV2VG9vbHNGcm9u dGVuZENsaWVudCB7CkBAIC00OSw2ICs1MCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQg Y2xvc2VXaW5kb3coKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdERvY2tXaW5kb3coKSB7 IH0KICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFVuZG9ja1dpbmRvdygpIHsgfQorICAgIHZpcnR1 YWwgdm9pZCBtb3ZlV2luZG93QnkoY29uc3QgV2ViRmxvYXRQb2ludCYpIHsgfQogICAgIHZpcnR1 YWwgdm9pZCBzYXZlQXMoY29uc3QgV2ViU3RyaW5nJiBmaWxlTmFtZSwgY29uc3QgV2ViU3RyaW5n JiBjb250ZW50KSB7IH0KIAogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRIaWRlU2NyaXB0c1BhbmVs KCkgeyByZXR1cm4gZmFsc2U7IH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0lu c3BlY3RvckZyb250ZW5kQ2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsLmNwcAkocmV2aXNpb24g OTk1OTUpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JbnNwZWN0b3JGcm9udGVuZENs aWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiAjaW5jbHVkZSAi VjhQcm94eS5oIgogI2luY2x1ZGUgIldlYkRldlRvb2xzRnJvbnRlbmRDbGllbnQuaCIKICNpbmNs dWRlICJXZWJEZXZUb29sc0Zyb250ZW5kSW1wbC5oIgorI2luY2x1ZGUgIldlYkZsb2F0UG9pbnQu aCIKICNpbmNsdWRlICJXZWJTdHJpbmcuaCIKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBA IC04MSw2ICs4Miw3IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRJbXBsOjpmcm9udGUK IAogdm9pZCBJbnNwZWN0b3JGcm9udGVuZENsaWVudEltcGw6Om1vdmVXaW5kb3dCeShmbG9hdCB4 LCBmbG9hdCB5KQogeworICAgIG1fY2xpZW50LT5tb3ZlV2luZG93QnkoV2ViRmxvYXRQb2ludCh4 LCB5KSk7CiB9CiAKIFN0cmluZyBJbnNwZWN0b3JGcm9udGVuZENsaWVudEltcGw6OmxvY2FsaXpl ZFN0cmluZ3NVUkwoKQo=