71836 2011-11-08 10:58:01 -0800 [WK2] Expose acceptMIMETypes for file inputs 2011-11-08 12:31:43 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee webkit-bug-importer oldest_to_newest 498259 0 jonlee 2011-11-08 10:58:01 -0800 <rdar://problem/10407367> 498261 1 114119 jonlee 2011-11-08 11:02:21 -0800 Created attachment 114119 Patch 498329 2 114119 andersca 2011-11-08 12:16:55 -0800 Comment on attachment 114119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114119&action=review > Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h:43 > +WK_EXPORT WKArrayRef WKOpenPanelParametersGetAcceptMIMETypes(WKOpenPanelParametersRef parameters); Since this copies the array of MIME types, the function should have Copy in its name. How about WKOpenPanelParametersCopyAcceptedMIMETypes? 498332 3 114119 andersca 2011-11-08 12:18:28 -0800 Comment on attachment 114119 Patch r=me with that change. 498348 4 jonlee 2011-11-08 12:31:43 -0800 Committed r99606: <http://trac.webkit.org/changeset/99606> 114119 2011-11-08 11:02:21 -0800 2011-11-08 12:18:28 -0800 Patch bug-71836-20111108110232.patch text/plain 4271 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhMThjYTllMTBiZDZlOWZm YWU4YmJiYmU1OGZlNjZiNzQ2ZmUyZGY4Li4zOTJmMmQzYjJlN2UyOThhZjllODY0ZTdjNDQwOWQ0 YzBiYTY0NTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTEtMDggIEpvbiBM ZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEV4cG9zZSBhY2NlcHRNSU1F VHlwZXMgZm9yIGZpbGUgaW5wdXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MTgzNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA0MDczNjc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQv V2ViT3BlblBhbmVsUGFyYW1ldGVycy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYk9wZW5QYW5l bFBhcmFtZXRlcnM6OmFjY2VwdE1JTUVUeXBlcyk6CisgICAgICAgICogU2hhcmVkL1dlYk9wZW5Q YW5lbFBhcmFtZXRlcnMuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQ YXJhbWV0ZXJzLmNwcDoKKyAgICAgICAgKFdLT3BlblBhbmVsUGFyYW1ldGVyc0dldEFjY2VwdE1J TUVUeXBlcyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVy cy5oOgorCiAyMDExLTExLTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgU2ltcGxpZnkgTmV0c2NhcGVQbHVnaW46OmNvbnZlcnRQb2ludCBhbmQgbWFr ZSBpdCB3b3JrIChpbiB0aGVvcnkpIHdpdGggdHJhbnNmb3JtZWQgcGx1Zy1pbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJPcGVuUGFuZWxQYXJhbWV0ZXJzLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJPcGVuUGFuZWxQYXJhbWV0ZXJzLmNwcAppbmRleCAxNGU0 OGQ0NTU4MjkzNTRkMmQ5YmM2NjYwOTViNmNhZGE3MjQ5NmU4Li5mNjcyMmJiYTAxY2RkNzljYTNl N2VkZDRhMjRlZjhkZTYwYTY4ZjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv V2ViT3BlblBhbmVsUGFyYW1ldGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dl Yk9wZW5QYW5lbFBhcmFtZXRlcnMuY3BwCkBAIC0yNiw2ICsyNiwxMCBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIldlYk9wZW5QYW5lbFBhcmFtZXRlcnMuaCIKIAorI2luY2x1ZGUg IkltbXV0YWJsZUFycmF5LmgiCisjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCisjaW5jbHVkZSA8d3Rm L1ZlY3Rvci5oPgorCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktp dCB7CkBAIC00NCw0ICs0OCwxNiBAQCBXZWJPcGVuUGFuZWxQYXJhbWV0ZXJzOjp+V2ViT3BlblBh bmVsUGFyYW1ldGVycygpCiB7CiB9CiAKK1Bhc3NSZWZQdHI8SW1tdXRhYmxlQXJyYXk+IFdlYk9w ZW5QYW5lbFBhcmFtZXRlcnM6OmFjY2VwdE1JTUVUeXBlcygpIGNvbnN0Cit7CisgICAgc2l6ZV90 IHNpemUgPSBtX3NldHRpbmdzLmFjY2VwdE1JTUVUeXBlcy5zaXplKCk7CisKKyAgICBWZWN0b3I8 UmVmUHRyPEFQSU9iamVjdD4gPiB2ZWN0b3I7CisgICAgdmVjdG9yLnJlc2VydmVJbml0aWFsQ2Fw YWNpdHkoc2l6ZSk7CisgICAgCisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyArK2kp CisgICAgICAgIHZlY3Rvci51bmNoZWNrZWRBcHBlbmQoV2ViU3RyaW5nOjpjcmVhdGUobV9zZXR0 aW5ncy5hY2NlcHRNSU1FVHlwZXNbaV0pKTsKKyAgICByZXR1cm4gSW1tdXRhYmxlQXJyYXk6OmFk b3B0KHZlY3Rvcik7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJPcGVuUGFuZWxQYXJhbWV0ZXJzLmggYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViT3BlblBhbmVsUGFyYW1ldGVycy5oCmluZGV4IDVhNTk0OTJjMWE5NDhm ZjhhOTAxMDlmYjY3MGIzZDhiNjZmMzk3ZjQuLmVjYTQ0ZTFlMzIyNzhjOGZiZjhkOTNjMDJhNjBh YTUzYjc2M2M4ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJPcGVuUGFu ZWxQYXJhbWV0ZXJzLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYk9wZW5QYW5lbFBh cmFtZXRlcnMuaApAQCAtMzMsNiArMzMsOCBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorY2xh c3MgSW1tdXRhYmxlQXJyYXk7CisKIGNsYXNzIFdlYk9wZW5QYW5lbFBhcmFtZXRlcnMgOiBwdWJs aWMgQVBJT2JqZWN0IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgY29uc3QgVHlwZSBBUElUeXBlID0g VHlwZU9wZW5QYW5lbFBhcmFtZXRlcnM7CkBAIC00MSw2ICs0Myw3IEBAIHB1YmxpYzoKICAgICB+ V2ViT3BlblBhbmVsUGFyYW1ldGVycygpOwogCiAgICAgYm9vbCBhbGxvd011bHRpcGxlRmlsZXMo KSBjb25zdCB7IHJldHVybiBtX3NldHRpbmdzLmFsbG93c011bHRpcGxlRmlsZXM7IH0gCisgICAg UGFzc1JlZlB0cjxJbW11dGFibGVBcnJheT4gYWNjZXB0TUlNRVR5cGVzKCkgY29uc3Q7CiAgICAg VmVjdG9yPFN0cmluZz4gc2VsZWN0ZWRGaWxlTmFtZXMoKSBjb25zdCB7IHJldHVybiBtX3NldHRp bmdzLnNlbGVjdGVkRmlsZXM7IH0KIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQy9XS09wZW5QYW5lbFBhcmFtZXRlcnMuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVycy5jcHAKaW5kZXggOGI3 OGQ2ZDk5YjQxZGVjMmJiZDYyYTVhN2NjZGYzNzJjNWY0YjM3OS4uYzE1N2M1OTc4ZjU0ZDJjMmUx ZWIwOTg1YjZlYmI0MTZkNWRiOWMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLT3BlblBhbmVsUGFyYW1ldGVycy5jcHAKQEAgLTI2LDYgKzI2LDcg QEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXS09wZW5QYW5lbFBhcmFtZXRlcnMu aCIKIAorI2luY2x1ZGUgIkltbXV0YWJsZUFycmF5LmgiCiAjaW5jbHVkZSAiV0tBUElDYXN0Lmgi CiAjaW5jbHVkZSAiV2ViT3BlblBhbmVsUGFyYW1ldGVycy5oIgogCkBAIC00MCwzICs0MSw4IEBA IGJvb2wgV0tPcGVuUGFuZWxQYXJhbWV0ZXJzR2V0QWxsb3dzTXVsdGlwbGVGaWxlcyhXS09wZW5Q YW5lbFBhcmFtZXRlcnNSZWYgcGFyYW1lCiB7CiAgICAgcmV0dXJuIHRvSW1wbChwYXJhbWV0ZXJz UmVmKS0+YWxsb3dNdWx0aXBsZUZpbGVzKCk7CiB9CisKK1dLQXJyYXlSZWYgV0tPcGVuUGFuZWxQ YXJhbWV0ZXJzR2V0QWNjZXB0TUlNRVR5cGVzKFdLT3BlblBhbmVsUGFyYW1ldGVyc1JlZiBwYXJh bWV0ZXJzUmVmKQoreworICAgIHJldHVybiB0b0FQSSh0b0ltcGwocGFyYW1ldGVyc1JlZiktPmFj Y2VwdE1JTUVUeXBlcygpLmxlYWtSZWYoKSk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQYXJhbWV0ZXJzLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvV0tPcGVuUGFuZWxQYXJhbWV0ZXJzLmgKaW5kZXggZjMyNzMxYzdk NTVmYzNiODc0MmYwMGYzZjY0ZmYzMDM2YTExMTFiMi4uZjI0N2U0ZjE1OTc4MGI3NjcyMDBiYjQx NTQxY2MxZTFmN2FkNDlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9DL1dLT3BlblBhbmVsUGFyYW1ldGVycy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQy9XS09wZW5QYW5lbFBhcmFtZXRlcnMuaApAQCAtNDAsNiArNDAsOCBAQCBXS19FWFBP UlQgV0tUeXBlSUQgV0tPcGVuUGFuZWxQYXJhbWV0ZXJzR2V0VHlwZUlEKCk7CiAKIFdLX0VYUE9S VCBib29sIFdLT3BlblBhbmVsUGFyYW1ldGVyc0dldEFsbG93c011bHRpcGxlRmlsZXMoV0tPcGVu UGFuZWxQYXJhbWV0ZXJzUmVmIHBhcmFtZXRlcnMpOwogCitXS19FWFBPUlQgV0tBcnJheVJlZiBX S09wZW5QYW5lbFBhcmFtZXRlcnNHZXRBY2NlcHRNSU1FVHlwZXMoV0tPcGVuUGFuZWxQYXJhbWV0 ZXJzUmVmIHBhcmFtZXRlcnMpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo=