71834 2011-11-08 10:36:28 -0800 [Mac] Disable C++ exceptions from DumpRenderTree 2011-11-08 19:37:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 71866 1 benjamin benjamin ddkilzer webkit.review.bot oldest_to_newest 498237 0 benjamin 2011-11-08 10:36:28 -0800 C++ exceptions are not handled in the Mac implementation of DumpRenderTree. They causes hard to debug issues, let's disable C++ exceptions so we see the problems where it happens. 498250 1 114114 benjamin 2011-11-08 10:46:42 -0800 Created attachment 114114 Patch 498407 2 114114 darin 2011-11-08 13:44:58 -0800 Comment on attachment 114114 Patch Sounds good. I don’t see any downside. 498480 3 114114 webkit.review.bot 2011-11-08 15:57:38 -0800 Comment on attachment 114114 Patch Clearing flags on attachment: 114114 Committed r99626: <http://trac.webkit.org/changeset/99626> 498481 4 webkit.review.bot 2011-11-08 15:57:42 -0800 All reviewed patches have been landed. Closing bug. 498613 5 benjamin 2011-11-08 19:37:13 -0800 Mark Rowe discovered GCC breaks Objective-C exceptions when disabling C++ exceptions on 32 bits. JavaScriptCore has a workaround for this problem: // Work around bug with C++ library that screws up Objective-C++ when exception support is disabled. #undef try #undef catch I don't think that is worth adding that to DumpRenderTree. It would be adding complexity for a small corner case. 114114 2011-11-08 10:46:42 -0800 2011-11-08 15:57:38 -0800 Patch bug-71834-20111108104641.patch text/plain 2265 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1ODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmN2JiZmI3ZmNmZTZmNTc3MTIwZTZiZWEyODA2NmZiZWRi Y2M2ZDE0Li5kODQ5Y2I0NjlmMjRlMmUzZDAwZjRhZGZlNTYxNjAzMjFjNzhjMDc3IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTEtMDggIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgW01hY10gRGlzYWJsZSBDKysgZXhjZXB0aW9ucyBmcm9tIER1bXBSZW5kZXJUcmVl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTgzNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIER1bXBSZW5k ZXJUcmVlIE1hYyBkb2VzIG5vdCBoYW5kbGUgQysrIGV4Y2VwdGlvbnMuIFdoZW4gc3VjaCBleGNl cHRpb24KKyAgICAgICAgaGFwcGVucywgaXQgdGVuZHMgdG8gY2F1c2UgdGhlIEF1dG9SZWxlYXNl UG9vbCBzdGFjayB0byBiZSBjb3JydXB0ZWQsCisgICAgICAgIHdoaWNoIGxlYWRzIHRvIGNyYXNo ZXMgbG9uZyBhZnRlciB0aGUgZXhjZXB0aW9uIHdhcyByYWlzZWQuCisKKyAgICAgICAgVGhpcyBw YXRjaCBkaXNhYmxlZCBDKysgZXhjZXB0aW9ucyBpbiBvcmRlciB0byBjYXRjaCB0aGUgcHJvYmxl bXMgd2hlcmUKKyAgICAgICAgdGhleSBoYXBwZW4gd2hlbiBhIEMrKyBleGNlcHRpb24gaXMgcmFp c2VkLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0R1bXBS ZW5kZXJUcmVlLnhjY29uZmlnOgorCiAyMDExLTExLTA4ICBBbmR5IFdpbmdvICA8d2luZ29AaWdh bGlhLmNvbT4KIAogICAgICAgICBTa2lwIHNvbWUgRUNNQVNjcmlwdCB0ZXN0cyB0aGF0IGZhaWwg b24gTGludXggaW4gc29tZSB0aW1lIHpvbmVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0R1bXBSZW5kZXJUcmVlLnhjY29uZmlnIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0R1bXBSZW5kZXJUcmVlLnhjY29uZmln CmluZGV4IDc1NGJmYTk2MmQ1ZGIxZTRiYjllMWI2MmIwYjEzZTM3ZjJiNDc5MGYuLjExZTkzZTkz M2QxODRlZTcxMjIxOTg0Yjk5ZmZmNTc4ZDVkMWQzMDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL21hYy9Db25maWd1cmF0aW9ucy9EdW1wUmVuZGVyVHJlZS54Y2NvbmZpZworKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvRHVtcFJlbmRlclRyZWUu eGNjb25maWcKQEAgLTI0LDUgKzI0LDYgQEAKIE9USEVSX0xERkxBR1MgPSAtc2VjdGNyZWF0ZSBf X0RBVEEgQWhlbSBxdC9mb250cy9BSEVNX19fXy5UVEYgLXNlY3RjcmVhdGUgX19EQVRBIFdlaWdo dFdhdGNoZXIxMDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjEwMC50dGYgLXNlY3RjcmVhdGUg X19EQVRBIFdlaWdodFdhdGNoZXIyMDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjIwMC50dGYg LXNlY3RjcmVhdGUgX19EQVRBIFdlaWdodFdhdGNoZXIzMDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0 Y2hlcjMwMC50dGYgLXNlY3RjcmVhdGUgX19EQVRBIFdlaWdodFdhdGNoZXI0MDAgZm9udHMvV2Vi S2l0V2VpZ2h0V2F0Y2hlcjQwMC50dGYgLXNlY3RjcmVhdGUgX19EQVRBIFdlaWdodFdhdGNoZXI1 MDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjUwMC50dGYgLXNlY3RjcmVhdGUgX19EQVRBIFdl aWdodFdhdGNoZXI2MDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjYwMC50dGYgLXNlY3RjcmVh dGUgX19EQVRBIFdlaWdodFdhdGNoZXI3MDAgZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjcwMC50 dGYgLXNlY3RjcmVhdGUgX19EQVRBIFdlaWdodFdhdGNoZXI4MDAgZm9udHMvV2ViS2l0V2VpZ2h0 V2F0Y2hlcjgwMC50dGYgLXNlY3RjcmVhdGUgX19EQVRBIFdlaWdodFdhdGNoZXI5MDAgZm9udHMv V2ViS2l0V2VpZ2h0V2F0Y2hlcjkwMC50dGYKIExEX1JVTlBBVEhfU0VBUkNIX1BBVEhTID0gIkBs b2FkZXJfcGF0aC8uIjsKIFBST0RVQ1RfTkFNRSA9IER1bXBSZW5kZXJUcmVlCitHQ0NfRU5BQkxF X0NQUF9FWENFUFRJT05TID0gTk8KIEdDQ19FTkFCTEVfT0JKQ19FWENFUFRJT05TID0gWUVTCiBH Q0NfUFJFRklYX0hFQURFUiA9IER1bXBSZW5kZXJUcmVlUHJlZml4LmgK