71830 2011-11-08 10:14:35 -0800 svg failures after r99561 2011-11-09 01:34:29 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan zimmermann ossy pnormand zimmermann oldest_to_newest 498200 0 ojan 2011-11-08 10:14:35 -0800 The following two tests started failing on the chromium bots after http://trac.webkit.org/changeset/99561: svg/zoom/page/zoom-svg-as-relative-image.html svg/zoom/page/relative-sized-document-scrollbars.svg They look like real regressions. I expect they're failing for the other ports as well if run with pixel tests. 498202 1 ojan 2011-11-08 10:16:15 -0800 It looks like svg/zoom/page/zoom-svg-as-relative-image.html is also failing the text diff on the chromium bots: @@ -1,6 +1,6 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x600 - RenderSVGRoot {svg} at (6,3) size 788x594 - RenderSVGPath {rect} at (6,3) size 788x594 [stroke={[type=SOLID] [color=#000000]}] [x=4.63] [y=3.47] [width=453.70] [height=340.28] + RenderSVGRoot {svg} at (12,8) size 788x592 + RenderSVGPath {rect} at (12,8) size 788x592 [stroke={[type=SOLID] [color=#000000]}] [x=8.00] [y=6.00] [width=784.00] [height=588.00] RenderSVGHiddenContainer {defs} at (0,0) size 0x0 498227 2 zimmermann 2011-11-08 10:30:55 -0800 (In reply to comment #1) > It looks like svg/zoom/page/zoom-svg-as-relative-image.html is also failing the text diff on the chromium bots: > > @@ -1,6 +1,6 @@ > layer at (0,0) size 800x600 > RenderView at (0,0) size 800x600 > layer at (0,0) size 800x600 > - RenderSVGRoot {svg} at (6,3) size 788x594 > - RenderSVGPath {rect} at (6,3) size 788x594 [stroke={[type=SOLID] [color=#000000]}] [x=4.63] [y=3.47] [width=453.70] [height=340.28] > + RenderSVGRoot {svg} at (12,8) size 788x592 > + RenderSVGPath {rect} at (12,8) size 788x592 [stroke={[type=SOLID] [color=#000000]}] [x=8.00] [y=6.00] [width=784.00] [height=588.00] > RenderSVGHiddenContainer {defs} at (0,0) size 0x0 Yeah, Qt also sees it. I'm going to try a full chromium build to debug this on my own... 498717 3 114222 zimmermann 2011-11-09 01:14:10 -0800 Created attachment 114222 Patch It was a merging regression, thanks for noticing! 498719 4 zimmermann 2011-11-09 01:16:22 -0800 Landed in r99669. Qt should be green again, if there are any rebaselines needed, I'll take care of them. 498727 5 zimmermann 2011-11-09 01:33:31 -0800 (In reply to comment #4) > Landed in r99669. Qt should be green again, if there are any rebaselines needed, I'll take care of them. Hm I just noticed that Ossy updated relative-sized-document-scrollbars.svg baseline in r99654, which was wrong. That needs to be undone. 498728 6 zimmermann 2011-11-09 01:34:29 -0800 Oh, and Philipp updated gtk in r99655. These results are wrong, and will need another update now (revert to what it was before). 114222 2011-11-09 01:14:10 -0800 2011-11-09 01:15:10 -0800 Patch A-FixSVGLengthRegression.diff text/plain 2843 zimmermann SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5NjY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTEtMDkgIE5pa29sYXMg WmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CisKKyAgICAgICAgc3ZnIGZhaWx1cmVz IGFmdGVyIHI5OTU2MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzE4MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggcmVncmVzc2lvbnMgaW4gc3ZnL3pvb20vcGFnZS9yZWxhdGl2ZS1zaXplZC1kb2N1 bWVudC1zY3JvbGxiYXJzLnN2ZyBhbmQgc3ZnL3pvb20vcGFnZS96b29tLXN2Zy1hcy1yZWxhdGl2 ZS1pbWFnZS5odG1sLgorICAgICAgICBGaXggbWVyZ2luZyBwcm9ibGVtIGluIHI5OTU2MSwgYnVn IDcxNzgwLiBJdCBtb3ZlZCBzZXZlcmFsIG1ldGhvZHMgZnJvbSBTVkdMZW5ndGggdG8gU1ZHTGVu Z3RoQ29udGV4dCwgYW5kIHVuZm9ydHVuYXRlbHkKKyAgICAgICAgdGhlIFNWR0xlbmd0aCBjaGFu Z2VzIHBhcnQgb2Ygcjk4ODUyLCBidWcgNDcxNTYsIGdvdCByZXZlcnRlZCBhZ2FpbiwgbWFraW5n IHRoZXNlIHR3byB0ZXN0cyBmYWlsLgorCisgICAgICAgICogc3ZnL1NWR0xlbmd0aENvbnRleHQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHTGVuZ3RoQ29udGV4dDo6ZGV0ZXJtaW5lVmlld3Bv cnQpOgorCiAyMDExLTExLTA5ICBSYWtlc2ggS04gIDxyYWtlc2gua25AbW90b3JvbGEuY29tPgog CiAgICAgICAgIFNlbGVjdCBtdWx0aXBsZSBvcHRpb25zIHdpdGggbW91c2UgZHJhZyBpbiBTZWxl Y3QgZWxlbWVudC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdMZW5ndGhDb250ZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHTGVuZ3RoQ29udGV4dC5jcHAJ KHJldmlzaW9uIDk5NTc0KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR0xlbmd0aENvbnRleHQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODEsNiArMjgxLDcgQEAgYm9vbCBTVkdMZW5ndGhDb250 ZXh0OjpkZXRlcm1pbmVWaWV3cG9ydAogICAgICAgICAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICAgICAgICAgIC8vIFNWR3MgZW1iZWRkZWQgdGhy b3VnaCA8b2JqZWN0PiByZXNvbHZlIHBlcmNlbnRhZ2UgdmFsdWVzIGFnYWluc3QgdGhlIG93bmVy IHJlbmRlcmVyIGluIHRoZSBob3N0IGRvY3VtZW50LgogICAgICAgICAgICAgaWYgKFJlbmRlclBh cnQqIG93bmVyUmVuZGVyZXIgPSBmcmFtZS0+b3duZXJSZW5kZXJlcigpKSB7CiAgICAgICAgICAg ICAgICAgd2lkdGggPSBvd25lclJlbmRlcmVyLT53aWR0aCgpOwogICAgICAgICAgICAgICAgIGhl aWdodCA9IG93bmVyUmVuZGVyZXItPmhlaWdodCgpOwpAQCAtMjkyLDggKzI5MywxNCBAQCBib29s IFNWR0xlbmd0aENvbnRleHQ6OmRldGVybWluZVZpZXdwb3J0CiAgICAgICAgIGlmICghdmlldykK ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgICAgICAvLyBBbHdheXMgcmVzb2x2ZSBw ZXJjZW50YWdlcyBhZ2FpbnN0IHRoZSB1bnNjYWxlZCB2aWV3cG9ydCwgYXMgYWdyZWVkIGFjcm9z cyBicm93c2Vycy4KKyAgICAgICAgZmxvYXQgem9vbSA9IHZpZXctPnN0eWxlKCktPmVmZmVjdGl2 ZVpvb20oKTsKICAgICAgICAgd2lkdGggPSB2aWV3LT52aWV3V2lkdGgoKTsKICAgICAgICAgaGVp Z2h0ID0gdmlldy0+dmlld0hlaWdodCgpOworICAgICAgICBpZiAoem9vbSAhPSAxKSB7CisgICAg ICAgICAgICB3aWR0aCAvPSB6b29tOworICAgICAgICAgICAgaGVpZ2h0IC89IHpvb207CisgICAg ICAgIH0KICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCkBAIC0zMDEsMTIgKzMwOCwxMyBA QCBib29sIFNWR0xlbmd0aENvbnRleHQ6OmRldGVybWluZVZpZXdwb3J0CiAgICAgU1ZHRWxlbWVu dCogdmlld3BvcnRFbGVtZW50ID0gbV9jb250ZXh0LT52aWV3cG9ydEVsZW1lbnQoKTsKICAgICBp ZiAodmlld3BvcnRFbGVtZW50ICYmIHZpZXdwb3J0RWxlbWVudC0+aXNTVkcoKSkgewogICAgICAg ICBjb25zdCBTVkdTVkdFbGVtZW50KiBzdmcgPSBzdGF0aWNfY2FzdDxjb25zdCBTVkdTVkdFbGVt ZW50Kj4odmlld3BvcnRFbGVtZW50KTsKLSAgICAgICAgaWYgKHN2Zy0+aGFzQXR0cmlidXRlKFNW R05hbWVzOjp2aWV3Qm94QXR0cikpIHsKLSAgICAgICAgICAgIHdpZHRoID0gc3ZnLT52aWV3Qm94 KCkud2lkdGgoKTsKLSAgICAgICAgICAgIGhlaWdodCA9IHN2Zy0+dmlld0JveCgpLmhlaWdodCgp OwotICAgICAgICB9IGVsc2UgeworICAgICAgICBGbG9hdFJlY3Qgdmlld0JveCA9IHN2Zy0+Y3Vy cmVudFZpZXdCb3hSZWN0KCk7CisgICAgICAgIGlmICh2aWV3Qm94LmlzRW1wdHkoKSkgewogICAg ICAgICAgICAgd2lkdGggPSBzdmctPndpZHRoKCkudmFsdWUoc3ZnKTsKICAgICAgICAgICAgIGhl aWdodCA9IHN2Zy0+aGVpZ2h0KCkudmFsdWUoc3ZnKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgIHdpZHRoID0gdmlld0JveC53aWR0aCgpOworICAgICAgICAgICAgaGVpZ2h0ID0gdmll d0JveC5oZWlnaHQoKTsKICAgICAgICAgfQogCiAgICAgICAgIHJldHVybiB0cnVlOwo=