71829 2011-11-08 10:11:17 -0800 Remove get() defined in CredentialStorageQt.cpp 2011-11-08 12:33:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates andersca kenneth ossy webkit.review.bot oldest_to_newest 498195 0 dbates 2011-11-08 10:11:17 -0800 CredentialStorage::get() is defined in CredentialStorage.cpp. We shouldn't define it again in the platform-specific CredentialStorage file. CredentialStorage::get() was added to CredentialStorageQt.cpp in changeset 86172 <http://trac.webkit.org/changeset/86172>. I spoke with Anders Carlsson today on IRC about this changeset and we came to the conclusion that CredentialStorage::get() shouldn't be defined in CredentialStorageQt.cpp: [5:41pm] dydx: andersca: I am curious how did you come to the decision to add CredentialStorage::get() in <http://trac.webkit.org/changeset/86172/trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp> [5:41pm] andersca: dydx: probably to fix the build? [5:42pm] dydx: Notice, that CredentialStorage.cpp defines get(): <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/CredentialStorage.cpp?rev=86172#L103> [5:43pm] andersca: dydx: oh, "i thought it would fix the build"? [5:44pm] dydx: andersca: Unless you can think of a reason to explicitly have get() be defined in the platform-specific CredentialStorage then I think we should remove CredentialStorage::get() from CredentialStorageQt.cpp [5:45pm] andersca: dydx: please do 498211 1 114109 dbates 2011-11-08 10:19:46 -0800 Created attachment 114109 Patch 498215 2 dbates 2011-11-08 10:23:42 -0800 (In reply to comment #0) > [5:41pm] dydx: andersca: I am curious how did you come to the decision to add We had this conversation at 9:41 am PST. For some reason Colloquy Version 2.3 (4617) on Mac OS 10.7 shows the wrong time in the chat window. 498330 3 114109 kling 2011-11-08 12:17:44 -0800 Comment on attachment 114109 Patch r=me 498351 4 114109 webkit.review.bot 2011-11-08 12:33:47 -0800 Comment on attachment 114109 Patch Clearing flags on attachment: 114109 Committed r99607: <http://trac.webkit.org/changeset/99607> 498352 5 webkit.review.bot 2011-11-08 12:33:53 -0800 All reviewed patches have been landed. Closing bug. 114109 2011-11-08 10:19:46 -0800 2011-11-08 12:33:47 -0800 Patch bug-71829-20111108101945.patch text/plain 2242 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5NTg2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTEtMDggIERhbmllbCBC YXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBnZXQoKSBkZWZpbmVk IGluIENyZWRlbnRpYWxTdG9yYWdlUXQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MTgyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENyZWRlbnRpYWxTdG9yYWdlOjpnZXQoKSBpcyBpbXBsZW1lbnRl ZCBpbiBDcmVkZW50aWFsU3RvcmFnZS5jcHAuIEFuZCBDcmVkZW50aWFsU3RvcmFnZS5jcHAKKyAg ICAgICAgcHJvdmlkZXMgdGhlIGJhc2UgaW1wbGVtZW50YXRpb24gZm9yIGVhY2ggcGxhdGZvcm0u IFdlIHNob3VsZG4ndCByZS1kZWZpbmUKKyAgICAgICAgQ3JlZGVudGlhbFN0b3JhZ2U6OmdldCgp IGluIENyZWRlbnRpYWxTdG9yYWdlUXQuY3BwLgorCisgICAgICAgICogVGFyZ2V0LnByaTogQWRk IGZpbGVzIENyZWRlbnRpYWxTdG9yYWdlLntjcHAsIGh9LgorICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvcXQvQ3JlZGVudGlhbFN0b3JhZ2VRdC5jcHA6CisKIDIwMTEtMTEtMDggIEhhbnMgV2Vu bmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFN0YXJ0IHVz aW5nIHRoZSBvblN1Y2Nlc3NXaXRoQ29udGludWF0aW9uKCkgY2FsbGJhY2sKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL1RhcmdldC5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvVGFyZ2V0 LnByaQkocmV2aXNpb24gOTk1ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9UYXJnZXQucHJpCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTAzLDYgKzExMDMsNyBAQCBTT1VSQ0VTICs9IFwKICAgICBwbGF0Zm9y bS9uZXR3b3JrL0Jsb2JSZWdpc3RyeUltcGwuY3BwIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL0Js b2JSZXNvdXJjZUhhbmRsZS5jcHAgXAogICAgIHBsYXRmb3JtL25ldHdvcmsvQ3JlZGVudGlhbC5j cHAgXAorICAgIHBsYXRmb3JtL25ldHdvcmsvQ3JlZGVudGlhbFN0b3JhZ2UuY3BwIFwKICAgICBw bGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmNwcCBcCiAgICAgcGxhdGZvcm0vbmV0d29yay9Gb3Jt RGF0YUJ1aWxkZXIuY3BwIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBIZWFkZXJNYXAuY3Bw IFwKQEAgLTIxNzgsNiArMjE3OSw3IEBAIEhFQURFUlMgKz0gXAogICAgIHBsYXRmb3JtL25ldHdv cmsvQmxvYlN0b3JhZ2VEYXRhLmggXAogICAgIHBsYXRmb3JtL25ldHdvcmsvQ29va2llU3RvcmFn ZS5oIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL0NyZWRlbnRpYWwuaCBcCisgICAgcGxhdGZvcm0v bmV0d29yay9DcmVkZW50aWFsU3RvcmFnZS5oIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL0Zvcm1E YXRhQnVpbGRlci5oIFwKICAgICBwbGF0Zm9ybS9uZXR3b3JrL0Zvcm1EYXRhLmggXAogICAgIHBs YXRmb3JtL25ldHdvcmsvSFRUUEhlYWRlck1hcC5oIFwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvcXQvQ3JlZGVudGlhbFN0b3JhZ2VRdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9DcmVkZW50aWFsU3RvcmFnZVF0LmNw cAkocmV2aXNpb24gOTk1ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0 L0NyZWRlbnRpYWxTdG9yYWdlUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw5ICszNSw0IEBA IENyZWRlbnRpYWwgQ3JlZGVudGlhbFN0b3JhZ2U6OmdldEZyb21QZXIKICAgICByZXR1cm4gQ3Jl ZGVudGlhbCgpOwogfQogCi1DcmVkZW50aWFsIENyZWRlbnRpYWxTdG9yYWdlOjpnZXQoY29uc3Qg UHJvdGVjdGlvblNwYWNlJikKLXsKLSAgICByZXR1cm4gQ3JlZGVudGlhbCgpOwotfQotCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCg==