71825 2011-11-08 09:55:57 -0800 Remove get() defined in CredentialStorageSoup.cpp 2011-11-08 11:13:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Soup P2 Normal --- 1 dbates dbates mrobinson rakuco webkit.review.bot oldest_to_newest 498172 0 dbates 2011-11-08 09:55:57 -0800 CredentialStorage::get() is defined in CredentialStorage.cpp. We shouldn't define it again in the platform-specific CredentialStorage file. 498192 1 114105 dbates 2011-11-08 10:08:52 -0800 Created attachment 114105 Patch 498271 2 114105 webkit.review.bot 2011-11-08 11:13:38 -0800 Comment on attachment 114105 Patch Clearing flags on attachment: 114105 Committed r99596: <http://trac.webkit.org/changeset/99596> 498272 3 webkit.review.bot 2011-11-08 11:13:43 -0800 All reviewed patches have been landed. Closing bug. 114105 2011-11-08 10:08:52 -0800 2011-11-08 11:13:38 -0800 Patch bug-71825-20111108100851.patch text/plain 2177 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5NTgyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTEtMDggIERhbmllbCBC YXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBnZXQoKSBkZWZpbmVk IGluIENyZWRlbnRpYWxTdG9yYWdlU291cC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcxODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ3JlZGVudGlhbFN0b3JhZ2U6OmdldCgpIGlzIGltcGxlbWVu dGVkIGluIENyZWRlbnRpYWxTdG9yYWdlLmNwcC4gQW5kIENyZWRlbnRpYWxTdG9yYWdlLmNwcAor ICAgICAgICBwcm92aWRlcyB0aGUgYmFzZSBpbXBsZW1lbnRhdGlvbiBmb3IgZWFjaCBwbGF0Zm9y bS4gV2Ugc2hvdWxkbid0IHJlLWRlZmluZQorICAgICAgICBDcmVkZW50aWFsU3RvcmFnZTo6Z2V0 KCkgaW4gQ3JlZGVudGlhbFN0b3JhZ2VTb3VwLmNwcC4KKworICAgICAgICAqIEdOVW1ha2VmaWxl Lmxpc3QuYW06IEFkZCBzb3VyY2UgZmlsZSBDcmVkZW50aWFsU3RvcmFnZS5jcHAuCisgICAgICAg ICogcGxhdGZvcm0vbmV0d29yay9zb3VwL0NyZWRlbnRpYWxTdG9yYWdlU291cC5jcHA6IFJlbW92 ZSByZS1kZWZpbml0aW9uIG9mIENyZWRlbnRpYWxTdG9yYWdlOjpnZXQoKS4KKyAgICAgICAgQ3Jl ZGVudGlhbFN0b3JhZ2U6OmdldCgpIGlzIGRlZmluZWQgaW4gQ3JlZGVudGlhbFN0b3JhZ2UuY3Bw LgorCiAyMDExLTExLTA4ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgSW5kZXhlZERCOiBTdGFydCB1c2luZyB0aGUgb25TdWNjZXNzV2l0aENvbnRpbnVhdGlv bigpIGNhbGxiYWNrCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0JKHJldmlzaW9u IDk5NTgyKQorKysgU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQkod29ya2luZyBj b3B5KQpAQCAtMjc4OSw2ICsyNzg5LDcgQEAgd2ViY29yZV9zb3VyY2VzICs9IFwKIAlTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Nvb2tpZVN0b3JhZ2UuaCBcCiAJU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9DcmVkZW50aWFsLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9DcmVkZW50aWFsLmggXAorCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvQ3JlZGVudGlhbFN0b3JhZ2UuY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0NyZWRlbnRpYWxTdG9yYWdlLmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvRE5TLmggXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFC dWlsZGVyLmNwcCBcCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv Q3JlZGVudGlhbFN0b3JhZ2VTb3VwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ3JlZGVudGlhbFN0b3JhZ2VTb3VwLmNwcAkocmV2aXNpb24g OTk1ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ3JlZGVudGlh bFN0b3JhZ2VTb3VwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUsOSArMzUsNCBAQCBDcmVkZW50 aWFsIENyZWRlbnRpYWxTdG9yYWdlOjpnZXRGcm9tUGVyCiAgICAgcmV0dXJuIENyZWRlbnRpYWwo KTsKIH0KIAotQ3JlZGVudGlhbCBDcmVkZW50aWFsU3RvcmFnZTo6Z2V0KGNvbnN0IFByb3RlY3Rp b25TcGFjZSYpCi17Ci0gICAgcmV0dXJuIENyZWRlbnRpYWwoKTsKLX0KLQogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQo=